CurseForge and Overwolf are joining forces!
Awesome More Information
  • 0

    posted a message on [Old] PitBull - official topic
    Quote from uaxli »

    is evil but with target frame not beig drawn proprly or at all fixed? im afraid of updating pitbull :)


    It's not that the target frame is improperly drawn. It looks fantastic, as does the rest of the add-on. All I was saying is that the draw method is not set up for applying the Dragon-style borders to the target frame. Trust me, there's nothing at all wrong with the appearance of the add-on. It's sleek and attractive.

    ~Llyrwech
    Posted in: Unit Frames
  • 0

    posted a message on [Old] PitBull - official topic
    Quote from NavyFC »

    Could this be used to put in a custom texture to show on elites/rares, such as the original gold/gray dragons? Would I just store the texture in the SharedMedia folder and call it in the PitBull lua?


    Not easily. Yes, it would be possible to add the dragon borders to the border selection list. In SharedMedia-1.0.lua, you'd find the code:

    			border = {
    				["None"] = "Interface\\None",
    				["Blizzard Dialog"] = "Interface\\DialogFrame\\UI-DialogBox-Border",
    				["Blizzard Tooltip"] = "Interface\\Tooltips\\UI-Tooltip-Border",
    			},

    and change it to:

    			border = {
    				["None"] = "Interface\\None",
    				["Blizzard Dialog"] = "Interface\\DialogFrame\\UI-DialogBox-Border",
    				["Blizzard Tooltip"] = "Interface\\Tooltips\\UI-Tooltip-Border",
    				["Dragon Elite"] = "Interface\\TargetingFrame\\UI-TargetingFrame-Elite",
    				["Dragon Rare"] = "Interface\\TargetingFrame\\UI-TargetingFrame-Rare",
    			},


    Unfortunately, the method for drawing the border around the unit frames produces a less -than-desirable outcome. A new drawing method would have to be written into the code of PitBull.lua. However, since I typically use WowAceUpdater, I'd rather not have to make all these adjustments every time I update. Best would be to make this a feature request on the bugtracker and hope CK decides to add it to the official releases. ^_~

    Safe journeys,
    Llyrwech
    Posted in: Unit Frames
  • 0

    posted a message on [Old] PitBull - official topic
    Quote from imarkon »

    have we to replace and fix that code? in previous releases was it correct ?


    Yes, this code was once correct, as the object reference to the border types was originally simply "Dialogue" or "Tooltip." That was recently changed for clarity, but this call to that reference wasn't changed. A very easy thing to miss. I know I've done the same kind of thing many times and had to pore over stacks of interlaced files to find the one which called to the depreciated terms.

    The entirety of the code need not be replaced. All that must change is the variable call in the function

    SharedMedia:Fetch('border', "Tooltip")


    changed to

    SharedMedia:Fetch('border', "Blizzard Tooltip")


    in both instances. If preferred, you could, instead, change it to read

    SharedMedia:Fetch('border', self.db.profile.groups[frame.group].border)


    This would show the elite/rare-coloured borders in the style you choose in the Target frame options, also allowing you to turn it off for certain target types, (Target, Target's Target, Focus, Focus' Target,) individually.

    Of course, if you don't feel completely comfortable messing around in the file, hopefully the fix will be noticed on the bugtracker soon, and become part of a new release in short order.

    Safe journeys,
    Llyrwech
    Posted in: Unit Frames
  • 0

    posted a message on [Old] PitBull - official topic
    I submitted a bug report on this to the tracker to ensure that you receive the information, but I wanted to post this quick fix to the player base in general so that the code-savvy can enjoy it.

    There has been a problem of late with Elite and Rare monster borders not showing up. I've tracked down and fixed the problem. In the current release, (r37501.1008,) beginning at line 2101, we have the following:
    	if classification == "worldboss" or classification == "elite" then
    		border = SharedMedia:Fetch('border', "Tooltip") or SharedMedia_border_None
    		r, g, b = unpack(self.colorConstants.elite)
    		a = self.colorConstants.frameBorder[4]
    	elseif classification == "rare" or classification == "rareelite" then
    		border = SharedMedia:Fetch('border', "Tooltip") or SharedMedia_border_None
    		r, g, b = unpack(self.colorConstants.rare)
    		a = self.colorConstants.frameBorder[4]


    It should read as follows:
    	if classification == "worldboss" or classification == "elite" then
    		border = SharedMedia:Fetch('border', "Blizzard Tooltip") or SharedMedia_border_None
    		r, g, b = unpack(self.colorConstants.elite)
    		a = self.colorConstants.frameBorder[4]
    	elseif classification == "rare" or classification == "rareelite" then
    		border = SharedMedia:Fetch('border', "Blizzard Tooltip") or SharedMedia_border_None
    		r, g, b = unpack(self.colorConstants.rare)
    		a = self.colorConstants.frameBorder[4]


    Simple fix, but it works perfectly.

    Thanks, CK, for a fantastic addon, and for your commitment to continual development. Since I swapped to PitBull, I have never looked back.

    Safe journeys,
    Llyrwech
    Posted in: Unit Frames
  • To post a comment, please or register a new account.