• 0

    posted a message on Official Threat-1.0 error reporting and discussion thread
    Quote from SentinelBorg »

    Quote from Menelgor »

    Prism of Inner Calm...

    Just got this thing and read that it's supposedly -1000 threat on spell crits, but it doesn't seem to have any effect on the the threat Threat-1.0 is reporting.

    Any idea how I might get this thing working with Threat-1.0?

    edit: here's the mechanic for the spell crit reduction: http://www.wowhead.com/?spell=38328
    and here's the melee one: http://www.wowhead.com/?spell=38329

    edit II: After looking up the libraries again I noticed this thing in the ThreatClassModuleCore.lua:

    -- Prism of Inner Calm, see http://www.wowhead.com/?item=30621

    self.meleeCritReduction = 0
    self.spellCritReduction = 0

    if trinket1ID == 30621 or trinket2ID == 30621 then
    self.meleeCritReduction = 150
    self.spellCritReduction = 1000
    end


    But the thing is that it just doesn't work.

    It doesnt work, because the function to detect it doesnt work:

    	if trinket1ID == 30621 or trinket2ID == 30621 then
    		DEFAULT_CHAT_FRAME:AddMessage("Prism of Inner Calm active");
    		self.meleeCritReduction = 150
    		self.spellCritReduction = 1000
    	end


    It never gets to my added Print statement, but if I change it to:
    	if trinket1ID == "30621" or trinket2ID == "30621" then
    		DEFAULT_CHAT_FRAME:AddMessage("Prism of Inner Calm active");
    		self.meleeCritReduction = 150
    		self.spellCritReduction = 1000
    	end

    It works, so thats the problem, the item id is a string, not a number.




    Thanks a lot it works now. And this trinket btw... oh their god! Went from mere 10% threat reduction up to 26% threat reduction! I know I have to sacrifice a lot when I'm not using a dps-trinket in the other slot, but in aggro capped fights there's no way any dps trinket can give me up to 16% more dps!

    ...sorry went a bit off-topic there, but thanks again.
    Posted in: Libraries
  • 0

    posted a message on Official Threat-1.0 error reporting and discussion thread
    Well I'm not seeing any sort of reduced threat when I crit. It's just [damage done] * 0.9 according to what Threat is showing up.
    Posted in: Libraries
  • 0

    posted a message on Official Threat-1.0 error reporting and discussion thread
    Prism of Inner Calm...

    Just got this thing and read that it's supposedly -1000 threat on spell crits, but it doesn't seem to have any effect on the the threat Threat-1.0 is reporting.

    Any idea how I might get this thing working with Threat-1.0?

    edit: here's the mechanic for the spell crit reduction: http://www.wowhead.com/?spell=38328
    and here's the melee one: http://www.wowhead.com/?spell=38329

    edit II: After looking up the libraries again I noticed this thing in the ThreatClassModuleCore.lua:

    -- Prism of Inner Calm, see http://www.wowhead.com/?item=30621

    self.meleeCritReduction = 0
    self.spellCritReduction = 0

    if trinket1ID == 30621 or trinket2ID == 30621 then
    self.meleeCritReduction = 150
    self.spellCritReduction = 1000
    end


    But the thing is that it just doesn't work.
    Posted in: Libraries
  • 0

    posted a message on Official Threat-1.0 error reporting and discussion thread
    I don't know if this has been up yet, but the shaman talent Elemental Precision, which reduces your threat by 10% doesn't seem to be counted in Threat-1.0. I see that it has been scripted into /ClassModules/Shaman.lua, but my threat is still exactly the same as my damage and I'm pulling aggro at 144% ranged.

    I changed one 1.0 into 0.9 in the Shaman module and I seem to be doing 0.9 x damage threat and properly pulling aggro at 130% ranged. I doubt my fix was very clean (I know next to nothing about lua) and I'm not going to paste it so I can avoid getting flamed for raping your script :P
    I was just wondering that were you aware of the issue.
    Posted in: Libraries
  • To post a comment, please or register a new account.