CurseForge and Overwolf are joining forces!
Awesome More Information
  • 0

    posted a message on [BUG] TipHookerLib
    Quote from Xinhuan »

    As far as I can tell, the paperdoll (for your own character) doesn't use an OnUpdate at all. Only OnEnter and OnLeave.

    However, the Blizzard_InspectUI (for inspecting other people) does indeed use an OnUpdate to generate a new tooltip every frame.


    Is there any way to fix it causing such a fps hit? It's actually worse on a high spec machine because more OnUpdates would be fired. I generally get knocked down from 90-100 fps to about 30-40 fps.
    Posted in: Libraries
  • 0

    posted a message on [BUG] TipHookerLib
    Quote from Xinhuan »

    That's because certain parts of the UI (notably the AH, mailbox and some bag addons) use OnUpdates to refresh (and generate a new tooltip) on every frame, since RatingBuster modifies tooltips, it has to regenerate the tooltip each time, which causes said CPU load, even with tooltip caching. Most parts of the default UI were changed (bags and action bars mainly) to only update once every 0.2 seconds but not the mailbox/AH, which still update every frame.


    Did the inspect frame get changed to update every 0.2 seconds or is it still using OnUpdate? The inspect frame is the main place I see the problem, but oddly only if I have the stat summaries enabled.
    Posted in: Libraries
  • 0

    posted a message on [BUG] TipHookerLib
    I've noticed that RatingBuster also lowers framerates a lot when mousing over certain items, I'm guessing it's the same bug since it uses TipHookerLib.
    Posted in: Libraries
  • 0

    posted a message on Change Buff timer format
    I used to use the following code to change the buff timer format

    function SecondsToTimeAbbrev(time)
    	local hr, m, s, text
    	if time <= 0 then text = ""
    	elseif time < 3600 then
    		m = floor(time / 60)
    		s = mod(time, 60)
    		text = (m == 0 and format("%d", s)) or format("%d:%02d", m, s)
    	else
    		hr = floor(time / 3600)
    		m = floor(mod(time, 3600) / 60)
    		text = format("%d:%02d", hr, m)
    	end
    	return text
    end


    The problem is this code taints in the latest build of WotLK due to the new buff frame code. Telo's Bufftimers on WoWinterface seems to work fine in beta without causing action blocked problems, the only thing is the time formatting isn't to my liking, how would I change this code to have the same time format?

    local function SetTimeText(button, time)
    	if( time <= 0 ) then
    		button:SetText("");
    	elseif( time < 3600 ) then
    		local d, h, m, s = ChatFrame_TimeBreakDown(time);
    		button:SetFormattedText("%d:%02d", m, s);
    	else
    		button:SetText("1 hr+");
    	end
    end


    This is basically the format I want.



    so hh:mm mm:ss ss
    Posted in: Lua Code Discussion
  • 0

    posted a message on WotLK Build 8820 taint issues
    Just semi bumping this, does anyone know of a way to change the buff time format without causing the blocked action issues?
    Posted in: Lua Code Discussion
  • 0

    posted a message on WotLK CancelPlayerBuff removed?
    Never worked with secure templates, how exactly would I get the following code working again?

    local f = CreateFrame("Frame")
    f:RegisterEvent("UNIT_AURA")
    f:SetScript("OnEvent", function(self, event, unit)
    	local aspect = UnitBuff("player", "Aspect of the Cheetah") or UnitBuff("player", "Aspect of the Pack")
    	if aspect and UnitDebuff("player", "Dazed") then CancelUnitBuff(aspect) end
    end)
    Posted in: Lua Code Discussion
  • 0

    posted a message on WotLK CancelPlayerBuff removed?
    CancelPlayerBuff no longer seems to work in the latest build in fact it errors, does anyone know what it got changed to?
    Posted in: Lua Code Discussion
  • 0

    posted a message on WotLK Build 8820 taint issues
    Quote from Nevcairiel »

    That piece of code always caused taint, but until now it didn't matter. Now Blizzard re-wrote their Buff Code, and it does matter. I didn't look at the new code yet, but i would assume for now, its not possible to change the timer like that anymore.


    Yeah I saw they made a lot of changes to their buff code, I hope it's still possible to override their timer code though.
    Posted in: Lua Code Discussion
  • 0

    posted a message on WotLK Build 8820 taint issues
    Before yesterdays patch I had no problems, but since then the following code is tainting and causing action blocked errors in combat.

    SecondsToTimeAbbrev = function(time)
    	local hr, m, s, text
    	if time <= 0 then text = ""
    	elseif time < 3600 then
    		m = floor(time / 60)
    		s = mod(time, 60)
    		text = (m == 0 and format("%d", s)) or format("%d:%02d", m, s)
    	else
    		hr = floor(time / 3600)
    		m = floor(mod(time, 3600) / 60)
    		text = format("%d:%02d", hr, m)
    	end
    	return text
    end


    It changes the format of the buff timer text, is this a Blizzard bug or is there something I have to change to stop it tainting?

    Is from the taintlog

    8/22 16:29:03.187 Global variable SecondsToTimeAbbrev tainted by UITweaks - Interface\AddOns\UITweaks\UITweaks.lua:39
    8/22 16:29:03.187 Execution tainted by UITweaks while reading SecondsToTimeAbbrev - Interface\FrameXML\BuffFrame.lua:352 BuffFrame_UpdateDuration()
    8/22 16:29:03.187   Interface\FrameXML\BuffFrame.lua:196
    8/22 16:29:03.187 An action was blocked in combat because of taint from UITweaks - BuffButton3:SetID()
    8/22 16:29:03.187   Interface\FrameXML\BuffFrame.lua:86 AuraButton_Update()
    8/22 16:29:03.187   Interface\FrameXML\BuffFrame.lua:42 BuffFrame_Update()
    8/22 16:29:03.187   Interface\FrameXML\BuffFrame.lua:33 BuffFrame_OnEvent()
    8/22 16:29:03.187   BuffFrame:OnEvent()


    Also changing combatlog variables such as

    TEXT_MODE_A_STRING_SPELL = TEXT_MODE_A_STRING_SPELL_LINK


    Is tainting now also.
    Posted in: Lua Code Discussion
  • 0

    posted a message on Anyone ever experianced this WoW bug?
    Sometimes when going into my Interface options when I exit it will turn on show cloak/helm by itself, it's kind of annoying. It happens in the WotLK beta also. I've submitted a bug report but can't exactly find a way to reproduce it 100% of the time. I wonder if Blizzard know about it.
    Posted in: General Chat
  • 0

    posted a message on [WotLK] UnitBuff
    Okay, changed it to the following

    local frame = CreateFrame("Frame")
    frame:RegisterEvent("UNIT_AURA")
    frame:SetScript("OnEvent", function(self, event, unit)
    	local aspect = UnitBuff("player", "Aspect of the Cheetah") or UnitBuff("player", "Aspect of the Pack")
    	if aspect and UnitDebuff("player", "Dazed") then CancelPlayerBuff(aspect) end
    end)


    Still isn't cancelling Aspect of the Cheetah when I get Dazed.

    [edit]

    Nevermind, it works I'm an idiot.
    Posted in: Lua Code Discussion
  • 0

    posted a message on [WotLK] UnitBuff
    I'm trying to convert a mod over to using the new UnitBuff API without much luck, I'm not getting any errors but it's not working.

    Here's the code

    local frame = CreateFrame("Frame")
    frame:RegisterEvent("UNIT_AURA")
    frame:SetScript("OnEvent", function(self, event)
    	local aspect = UnitBuff("Player", "Aspect of the Cheetah") or UnitBuff("Player", "Aspect of the Pack")
    	if aspect and UnitBuff("Player", "Dazed") then CancelPlayerBuff(aspect) end
    end)
    Posted in: Lua Code Discussion
  • 0

    posted a message on Anyone else like the new July 31 hotfix changes? (tooltips, frames)
    Glad you found the cause, just so you know hotfixes are server side, they don't change the client at all so a hotfix can't do what you describe in the first post.
    Posted in: General Chat
  • 0

    posted a message on RatingBuster
    I noticed a problem which I believe to be related to RatingBuster, I believe this because I disabled any other addons that modify the tooltip and the problem continued to occur.

    The problem is when I mouseover armor slots when I inspect people it has a dramatic effect on my framerate. I'm not sure if it's a problem with how RatingBuster is programmed or just a flaw of hooking and placing information into the tooltip.

    Here's the effect though.

    Note my FPS as listed on Titan Panel

    Before

    http://img170.imageshack.us/img170/8727/beforenz0.png

    After

    http://img385.imageshack.us/img385/4167/aftervp0.png

    Yes the resulting FPS is still playable but for someone on a lesser machine it may drop very low. What's odd is it doesn't happen for all items on that person, it seems pretty random which items will lower the framerate.
    Posted in: General AddOns
  • 0

    posted a message on Files.wowace.com
    Quote from Xinhuan »

    It takes up to an hour for new commits to appear, as the zip-script needs that amount of time to work with a few thousand addons.


    Yeah I know it takes up to an hour for new commits to be packaged, but this was a problem that lasted 4-5 hours as it was happening before I went to bed on Sunday and was still broken on Monday morning but it got fixed later on, on Monday.
    Posted in: General Chat
  • To post a comment, please or register a new account.