• 0

    posted a message on Squishy 0.10 [2006/08/22]
    also the hooks for sRA are not working

    sRA hooks Squishy, not the other way around.

    about 20 people bugged me to make Squishy hide when on standby, so I did it. I know if I'd change it back, other people might start bugging me.

    I can only say that out of all the Ace / Ace2 / FuBar addons I use, Squishy and Detox are the only ones that exhibit this behavior. With the "Hide FuBar plugin" option for FuBar, it makes no sense to me whatsoever to remove (which resets all the FuBar stuff too btw) the icon when it's merely in standby mode. Seems to be totally non-standard compared to everything else.

    Oh, and yes setting the alpha helped with the titlebar, thanks! :)
    Posted in: General AddOns
  • 0

    posted a message on Squishy 0.10 [2006/08/22]
    Quote from maia »

    Fix the 'standby = complete removal from FuBar' issue (not sure, but I think Detox has this behavior as well). The whole point of having the FuBar buttons is to quickly set options and enable/disable the addons without needing to totally reset them from inside FuBar each time.

    I'm not really sure if I understand the real issue here. If an addon is on standby, you can't change any settings, right? And if you want to reenable it, just type /squishy standby to turn it back on. I added that option as several people asked me to do so, they didnt want to have an icon on their FuBar for addons they are currently not using.

    My point is that every other FuBar plugin allows us to set standby while still keeping the FuBar icon so that we can easily re-enable it. "Hide FuBar plugin" is a totally separate FuBar option, and it's enabled already in Squishy and Detox, so that should be used. By totally removing the icon, if I want to later change anything with Squishy (and Detox) from FuBar (ie. not slash commands) I have to first replace (and reposition since that doesn't get saved either) the icon, which is just silly.
    Posted in: General AddOns
  • 0

    posted a message on Detox
    maia: I know you said Detox is checking for a successful cast, but I can say flat-out that the "Cleaned [name]" text appears even when I am totally unable to have cast any spell whatsoever. It seems to be printing the text prior to even attempting to cast.
    Posted in: General AddOns
  • 0

    posted a message on Squishy 0.10 [2006/08/22]
    I suggest the code in the OnClick handler is changed to:
    function Squishy:OnClick()
     local unit = this.unit
     if not unit then return end
     if UnitIsUnit(unit, "player") then unit = "player" end
     local button = arg1
    
     if SquishyCustomClick and SquishyCustomClick(arg1, unit) then
    return
    end
    
     if not UnitExists(unit) then return end
     if SpellIsTargeting() then
     if button == "LeftButton" then SpellTargetUnit(unit)
     elseif button == "RightButton" then SpellStopTargeting() end
     return
     end
     if CursorHasItem() then
     if button == "LeftButton" then
      if unit=="player" then AutoEquipCursorItem()
      else DropItemOnUnit(unit) end
     else PutItemInBackpack() end
     return
     end
     TargetUnit(unit)
     end


    That is, it must check the return value from the custom click handler. A
    value of true signals that the custom click handler caught the click and did some processing, while a value of false signals that it did not catch the click in which case Squishy should execute its default behaviour.

    This is how CTRA, Perl Classic, X-Perl, sRaidFrames, PerfectRaid and others behave, and it carries the great advantage that the addon that carries the custom click handler does not have to take over the whole processing, thereby avoiding replication of the default behaviour.

    I suggest this, because i have received requests for QuickHeal to support
    Squishy. I could avoid the problems caused by the current implementation of Squishy by hooking the entire click-handler of Squishy whereby i still have the possiblity of calling the original function to get the default
    behaviour. Such a solution is not as clean and requires more functions and
    memory, so i believe it will benefit all if this small change of 3 lines of code is carried through.
    Posted in: General AddOns
  • 0

    posted a message on Squishy 0.10 [2006/08/22]
    Couple of requests (I hope this is the place for it?):

    1) Additional option to display the livelist in Raid only

    2) Option to remove the 'title' from the live list frame? I really like the way Decursive works now where I can totally remove that annoying 'header' with the buttons, but the list just *poof* appears when people begin taking damage. I don't like having unnecessary 'stuff' on my screen and just running around in a group the whole Squishy title bar part of the frame is just in the way.

    3) Fix the 'standby = complete removal from FuBar' issue (not sure, but I think Detox has this behavior as well). The whole point of having the FuBar buttons is to quickly set options and enable/disable the addons without needing to totally reset them from inside FuBar each time.
    Posted in: General AddOns
  • 0

    posted a message on Squishy 0.10 [2006/08/22]
    I apologize if this has been reported, I only scrolled back two pages to check.

    Anyway, using the 12272 build, I keep getting the following error:
    Squishy/libs/Banzai-1.0/Banzai-1.0.lua:40: A table in the compost heap has been modified!


    The error kept popping up repeatedly, even after putting Squishy in standby mode. (Oh speaking of which, it's really agravating that Squishy in standby completely removes itself from FuBar)
    Posted in: General AddOns
  • 0

    posted a message on oRA2
    On that note, since this is a whole new oRA can't we make all the frames standard and just use a normal click to drag them? It's inconvenient for every other frames that oRA2 displays to be click-draggable, but the MT frames are the only ones using alt+click.
    Posted in: Raid AddOns
  • 0

    posted a message on oRA2
    One thing I'm missing is /rs. Regardless of anyone's opinion of /rs vs. Blizzard's /rw, CTRA still uses /rs. If oRA2 is going to display RaidSay's then oRA2 should let us send them too. I brought up the whole RaidSay vs. RaidWarning to the raid group I'm in, and everyone else voted RaidSay, so for me it's unfortunately going to be a make-or-break issue with oRA2. If you're shooting for compatibility, may as well let us do what CTRA does. I much prefer oRA(2)'s ways of doing everything else...
    Posted in: Raid AddOns
  • 0

    posted a message on Detox
    Only issue I really notice is that the message "Cleaned [name]" appears regardless of whether the cast was successful (out of range, or whatever). Any way to check that the decurse/depoison did in fact cast before announcing so?
    Posted in: General AddOns
  • To post a comment, please or register a new account.