• 0

    posted a message on Official Threat-1.0 error reporting and discussion thread
    Well i guarantee that on the boss Bloodboil (The only boss that gives that agro debuf) there is absolutely no agro gain in second fase (unless you resist the debuff.. never happened sofar)..

    the thing why it was noticed at some point was because shadow priest became nr1 on agro meters.. but still the boss does not go for them..
    Posted in: Libraries
  • 0

    posted a message on Official Threat-1.0 error reporting and discussion thread
    cut'n paste from the omen threat.
    there is a bug that the healing threat still continue's while having the insignifigant debuf at bloodboil (Black temple boss)

    Quote from ThePopeRope »

    Quote from Lurr »

    As for bloodboil there is something funny about threat for shadow priests.

    If i just keeps sw:p+ve up in normal fase and then allout in enrage fase, then i have often aggro get aggro when the fase ends.

    I am below all tanks when enrage starts, and have aggro when it ends.

    It might be VE healing, but its quite hard to any real tests.


    also think the knockback pushes away to much threat..
    shadowpriests threat continue's to rise during phase 2...

    seems no one is picking this up.. going to browse trough the code myself for a bit.. if i can find anything i'll post it here


    Found something
    ThreatBuffsData.lua contains
    		-- Uncomment this once Insignifigance is in Babble-Spell
    		-- See [url]http://www.wowhead.com/?spell=40618[/url]
    		[BS["Insignifigance"]] = function(self)
    			self:AddDebuffThreatMultiplier(0)
    		end,

    Everything seems fine but it isn't :(

    i've made a fraps pointing it out.. so you can see whats going on.
    http://files.filefront.com/bloodboil+omen+bugg/;8195250;;/fileinfo.html
    It's not a shadowpriest specific error. as you can see my "Soul leech" and "death coil" also generate threat.

    so it must lie in the healing threat handling / global threat

    i see this in code in parseHeal30
    	if not self.ExemptGains[skill] then
    		local handler = self.abilityThreatMods[skill]
    		if handler then
    			threat = handler(self, threat, false, info.isCrit)
    		end
    		threat = threat * ThreatLib.ThreatConstants.healing * self:threatMods()
    		self:_addThreat(threat)
    	end


    The self.threadMods contains the modifier of the debuf.. which is 0.. so the result is 0..
    Death Coil however is an ExemptGains.. so it does not follow this line of code..
    i cant find where the exemptgains are handled.

    will look into it some more tomorrow if i find the time


    Posted in: Libraries
  • 0

    posted a message on Omen - Bug Reports and Suggestions
    Quote from ThePopeRope »

    Quote from Lurr »

    As for bloodboil there is something funny about threat for shadow priests.

    If i just keeps sw:p+ve up in normal fase and then allout in enrage fase, then i have often aggro get aggro when the fase ends.

    I am below all tanks when enrage starts, and have aggro when it ends.

    It might be VE healing, but its quite hard to any real tests.


    also think the knockback pushes away to much threat..
    shadowpriests threat continue's to rise during phase 2...

    seems no one is picking this up.. going to browse trough the code myself for a bit.. if i can find anything i'll post it here


    Found something
    ThreatBuffsData.lua contains
    		-- Uncomment this once Insignifigance is in Babble-Spell
    		-- See [url]http://www.wowhead.com/?spell=40618[/url]
    		[BS["Insignifigance"]] = function(self)
    			self:AddDebuffThreatMultiplier(0)
    		end,

    Everything seems fine but it isn't :(

    i've made a fraps pointing it out.. so you can see whats going on.
    http://files.filefront.com/bloodboil+omen+bugg/;8195250;;/fileinfo.html
    It's not a shadowpriest specific error. as you can see my "Soul leech" and "death coil" also generate threat.

    so it must lie in the healing threat handling / global threat

    i see this in code in parseHeal30
    	if not self.ExemptGains[skill] then
    		local handler = self.abilityThreatMods[skill]
    		if handler then
    			threat = handler(self, threat, false, info.isCrit)
    		end
    		threat = threat * ThreatLib.ThreatConstants.healing * self:threatMods()
    		self:_addThreat(threat)
    	end


    The self.threadMods contains the modifier of the debuf.. which is 0.. so the result is 0..
    Death Coil however is an ExemptGains.. so it does not follow this line of code..
    i cant find where the exemptgains are handled.

    will look into it some more tomorrow if i find the time


    Posted in: Raid AddOns
  • 0

    posted a message on Omen - Bug Reports and Suggestions
    Quote from Lurr »

    As for bloodboil there is something funny about threat for shadow priests.

    If i just keeps sw:p+ve up in normal fase and then allout in enrage fase, then i have often aggro get aggro when the fase ends.

    I am below all tanks when enrage starts, and have aggro when it ends.

    It might be VE healing, but its quite hard to any real tests.


    also think the knockback pushes away to much threat..
    shadowpriests threat continue's to rise during phase 2...

    seems no one is picking this up.. going to browse trough the code myself for a bit.. if i can find anything i'll post it here
    Posted in: Raid AddOns
  • 0

    posted a message on Omen - Bug Reports and Suggestions
    Bugreport for threat on the bossfight "Bloodboil" in Black Temple

    In fase 2 you get a debuf called "Insignifigance" that totally eliminates your threat generation.
    Omen does that for most classes.. but shadowpriest still gain on agro during this fase when they are VE healing.

    making shadowpriest be on top of omen all the time and making the fight actually pritty hard to see who's actually agro leader.


    Can you please have a look into this.

    Regards,
    Thepoperope
    Posted in: Raid AddOns
  • 0

    posted a message on Omen - Bug Reports and Suggestions
    Quote from OrionShock »

    Quote from ThePopeRope »

    atm we're close to going back to ktm because of this global threat thingy making it almost useless for us to use. and i hate ktm..:)


    >.>

    i hate to say it but if a ThreatMeeter is making or braking the raid ...
    then i would believe you have "Bigger Fish to Fry"


    Then you don't know some of those bosses out there
    Critting on keal'thas for 9k has a high chance of overagro..so agro meters must be absolutely correct to "Ride the line"

    we cleared ssc and tempestkeep.. so its going fine i'd say...
    Posted in: Raid AddOns
  • 0

    posted a message on Omen - Bug Reports and Suggestions
    Quote from Antiarc »

    There's a Kael'thas module that explicitly handles the things like the phase transitions; upon each transition, each relevant mob gets a threat wipe as appropriate, so when they are targeted, you will see the appropriate threat level on them.

    but that one doesn't wipe the global threat.

    so adds die.. and are resurrected again in fase 4.. and there is the global threat again on the weapons.

    atm we're close to going back to ktm because of this global threat thingy making it almost useless for us to use. and i hate ktm..:)
    Posted in: Raid AddOns
  • 0

    posted a message on Omen - Bug Reports and Suggestions
    Quote from Antiarc »

    Quote from ThePopeRope »

    Please make a option to not record global threat.

    in many boss fights this global threat is not correct. because you will only build threat on mobs in range.. and most boss fights the mobs are pulled far far apart.

    As far as I'm aware, global threat is accumulated on all mobs that you're in combat with. I've never seen anything to indicate that it's range-limited - it's generally split among all mobs on the hate list.

    What revisions were you and your raid using? I made a large number of corrections to global threat handling relatively recently, which would have been important to have. If you were up to date, can you describe the problem more in-depth? I watched the video, but it's too small for me to make out the relevant details.

    Thanks! :)


    In for example Kael'thas fight the adds come out one by one. we stay in combat the whole fight and the mobs are pulled apart more then 100 yards.
    there are four adds and the boss is "banished" while the adds are not down..
    so we're actually not building any global threat in that fight.

    and there are more fights like that.. so an option to disable global threat would be really really nice.
    Posted in: Raid AddOns
  • 0

    posted a message on Omen - Bug Reports and Suggestions
    Please make a option to not record global threat.

    in many boss fights this global threat is not correct. because you will only build threat on mobs in range.. and most boss fights the mobs are pulled far far apart.

    an good example of global threat not being dealt with correctly you can see in the movie i made of our first kill of keal'thas where we use Omen as threat meter.
    http://files.filefront.com/EG+vs+KaelThas+Sunstrideravi/;7888433;;/fileinfo.html

    Keep up the good work..

    Regards,
    Remco
    Posted in: Raid AddOns
  • 0

    posted a message on Omen - Bug Reports and Suggestions
    First of all.. very very nice job on Omen and threatlib .. its amassing!
    Little bug report on a boss fight with taunt ability

    The Warrior.lua has the following

    function Warrior:Taunt()
      if UnitExists("targettarget") then
       local myThreat = ThreatLib:GetThreat(UnitName("player"), UnitName("target"))
       local theirThreat = ThreatLib:GetThreat(UnitName("targettarget"), UnitName("target"))
       if myThreat >= theirThreat then
         return
       end
       local globalThreat = ThreatLib:GetThreat(UnitName("player"), "_GLOBAL_")
       self:SetTargetThreat(theirThreat - globalThreat)
      else
       -- Assume we get max threat? This seems dangerous, but we need it to apply taunt in situations where the mob is sheeped/stunned/shackled/anything else that prevents a target
       local maxThreat = ThreatLib:GetMaxThreatOnTarget(UnitName("target"))
       local globalThreat = ThreatLib:GetThreat(UnitName("player"), "_GLOBAL_")
       self:SetTargetThreat(maxThreat - globalThreat)
      end  
    end



    But on the boss fight "High Astromancer Solarian" in "The Eye" of tempest keep it doesn't really work.
    There is someone top agro that will get melee'ed every once in a while.
    But the Astromancer targets the one who gets the random "arcane missles" and that ability is not by threat
    Doing a taunt while he's casting arcane missles (something he does 90% of the fight) will result in the warrior getting the agro amount of the current person targeted
    So a temperary fix i made was this.

    function Warrior:Taunt()
      if (UnitExists("targettarget")) and (UnitName("target")<>"High Astromancer Solarian" ) then
       local myThreat = ThreatLib:GetThreat(UnitName("player"), UnitName("target"))
       local theirThreat = ThreatLib:GetThreat(UnitName("targettarget"), UnitName("target"))
       if myThreat >= theirThreat then
         return
       end
       local globalThreat = ThreatLib:GetThreat(UnitName("player"), "_GLOBAL_")
       self:SetTargetThreat(theirThreat - globalThreat)
      else
       -- Assume we get max threat? This seems dangerous, but we need it to apply taunt in situations where the mob is sheeped/stunned/shackled/anything else that prevents a target
       local maxThreat = ThreatLib:GetMaxThreatOnTarget(UnitName("target"))
       local globalThreat = ThreatLib:GetThreat(UnitName("player"), "_GLOBAL_")
       self:SetTargetThreat(maxThreat - globalThreat)
      end  
    end


    But this does not work with other languages.

    anyways maybe you guys can take a look into this?

    Regards,
    ThePopeRope
    Eternal Gathering ( www.eg-guild.com )
    Posted in: Raid AddOns
  • To post a comment, please or register a new account.