• 0

    posted a message on Skillet - the lilsparky branch
    I've queued some poisons and went to the Vendor to buy the reagents using Skillet's Buy Reagents button. All the reagents were bought, but this error came up:
    Message: ..\AddOns\Skillet\UI\MerchantWindow.lua line 242:
      attempt to call method 'ScanInventory' (a nil value)
    Debug:
      [C]: ScanInventory()
      Skillet\UI\MerchantWindow.lua:242: BuyRequiredReagents()
      [string "*:OnClick"]:1:
       [string "*:OnClick"]:1

    And the Buy Reagents button didn't go away...

    I'm using latest Skillet (r72910).
    Posted in: General AddOns
  • 0

    posted a message on Adding your project to SVN - A better process
    Quote from HunterZ »

    No, that will cause WAU to overwrite my branch version checkout with the latest trunk version.

    Have you tested it? I haven't been using WAU for months now but I just tested it and it worked fine on lilsparky's branch of Skillet :-)

    Steps during my test:
    1) Remove all addons
    2) Install one test addon using WAU and exit WAU
    3) Checkout Skillet using TortoiseSVN from: http://svn.wowace.com/wowace/branches/Skillet/lilsparky/ to Addons/Skillet
    4) Run WAU - Skillet is shown in special category "SVN" on the bottom of the list
    5) Having Skip SVN Working Copies checked Skillet is ignored
    6) Having Skip SVN Working Copies UNchecked Skillet is successfully checked for the latest version using external SVN.exe (hasn't been updated because it was the latest version)
    Posted in: Lua Code Discussion
  • 0

    posted a message on GatherMate: Offical Thread
    Quote from Kagaro »

    You using some tooltip mod?


    I'm using TipTac (08.04.06), but I have TipTac Options > Special > Instantly Hide World Frame Tips UNchecked
    Posted in: General AddOns
  • 0

    posted a message on Adding your project to SVN - A better process
    Quote from HunterZ »

    Wait, WAU can auto-update stuff that I have checked out from branches using TortoiseSVN? How does one set it up to do that?


    Uncheck: Edit > Preferences: Update Behavior > Skip SVN Working Copies
    Posted in: Lua Code Discussion
  • 0

    posted a message on Skillet - the lilsparky branch
    Quote from lilsparky »

    yeah, i have fixed the desync thing. in "flat" i think it will work with the current version.

    ok. Waiting for an update :)

    Quote from lilsparky »

    how are you sorting when it jumps? there's a problem that when you first open a trade it's not always sorting the way it says until you click on something, then it seems to wake up and do the right sort...

    yes, this is the issue - I hadn't thought about it as connected to Opening the window, because I close and open Skillet all the time to resolve the "Gray(disabled?) Pause button" and "Stopping after two runs" problem
    Posted in: General AddOns
  • 0

    posted a message on Skillet - the lilsparky branch
    The Skillet cannot cope with newly learned recipes very well. Shift-Rescan is the only workaround for this problem in the game. After learning a new Engineering recipe my recipe list becomes desynced with the main view as seen on the attached screenshots.
    First screenshot shows Sniper Scope (the new recipe learned) selected, but Deadly Scope displayed...
    The second screenshot shows Inlaid Mithril Cylinder Plans selected, but nothing is displayed...

    Also to note: the recipe sorting is still behaving wierdly: the "Miscellaneous 2" category in Engineering is jumping around the recipe list - sometimes it is in the middle of the list, sometimes it is the first group displayed.
    Posted in: General AddOns
  • 0

    posted a message on GatherMate: Offical Thread
    I have small issue with GatherMate - it doesn't record new Giant Clams in Stranglethorn Vale

    BTW: I have all Lock Database checkboxes unchecked...
    Posted in: General AddOns
  • 0

    posted a message on EavesDrop 2.0 (a SCT style combat log)
    D'oh! I've always understood the Target column to contain damage done to the Target and Player column to contain damage done to the Player.

    If I understand you correctly the columns are not based by the target of damage but the source of damage, which is illogical from my (as a user) point of view :( IMO all damage done to me should be in the player column independently of the source.

    Take a look at player healing - it all goes to the player column even if it's cast by me or it is cast by any other healer.
    Posted in: General AddOns
  • 0

    posted a message on EavesDrop 2.0 (a SCT style combat log)
    BUG: The [Gnomish Death Ray] damage displays incorrectly in EavesDrop - both the damage to me and my target is displayed in the Target column and is counted as damage to target in the after-battle summary :(
    Posted in: General AddOns
  • 0

    posted a message on Skillet - the lilsparky branch
    Yeah! New Skillet version :)

    Just a few remarks about the new version:
    1) The shopping list window throws an error when trying to open it manually with bank windows opened. (The bank was opened for the first time after deleting Skillet's SV)
    Message: ..\AddOns\Skillet\UI\ShoppingList.lua line 168:
      attempt to perform arithmetic on field 'numInBags' (a nil value)
    Debug:
      [C]: ?
      Skillet\UI\ShoppingList.lua:168: GetShoppingList()
      Skillet\UI\ShoppingList.lua:191:
       Skillet\UI\ShoppingList.lua:186
      Skillet\UI\ShoppingList.lua:498:
       Skillet\UI\ShoppingList.lua:485
      (tail call): ?
      [string "*:OnClick"]:1:
       [string "*:OnClick"]:1

    2) The new Skillet version still suffers from stopping multi run after two runs are done.
    3) The new Skillet version still suffers from swapped Open at bank and Open at guildbank checkboxes in options for Shopping list.
    4) On my engineer and with By difficulty softing with Blizzard grouping the list of recipes is resorted after each click in the recipe list??

    Thank you for the update and your continuing support :)
    Posted in: General AddOns
  • 0

    posted a message on TradeskillInfo Official Thread
    Quote from Evenue »

    Quote from Evenue »

    Also, zarevak. Try uncommenting lines 387-389 in TradeskillInfo.lua, and see if that fixes the auction frame update problem.

    Did you get a chance to try this? :)

    Hi Evenue, I've tried it and after fixing few syntax errors and a few logic errors with AceHook I've given up :( The ListUpdate method is also called more then once each AH page view...

    My last testing version:
      if AucAdvanced and not self:IsHooked(AucAdvanced.API, "ListUpdate") then
       self:SecureHook(AucAdvanced.API, "ListUpdate", function() 
          self:Print("ListUpdate Hook")
          --return AuctionFrameBrowse_Update() 
       end)
      end


    Can you please take a look at ProfessionsBook addon? It handles Auc-Advanced (and also AHExtend and AuctionFilterPlus) correctly even without hooking the ListUpdate method.
    Posted in: General AddOns
  • 0

    posted a message on TradeskillInfo Official Thread
    Quote from thegriffgeeks »

    Can I ask the dumb question....where in LibRock-1.0.lua would one put the code you posted?

    It's diff - the code is list of changes for automatic patching tool that would change the LibRock-1.0.lua for you.

    You can patch it manually:
    Remove lines 2698-2700 that are responsible for GC after each addon loaded after the login.
    	if IsLoggedIn() then
    		collectgarbage('collect')
    	end

    Remove lines 2707 and 2731 that are responsible for GC after the initial world entry...
    	collectgarbage('collect')


    Other changes are imho unnecessary and the lines 1549-1551 can be helpful in long run because it slowly collects the old garbage. If you want to get a few more FPS out of WoW, you can try to remove these lines as well...
    	if a < 1/30 then
    		collectgarbage('step')
    	end


    Other collectgarbage('collect') occurrences in LibRock-1.0.lua are run in just special cases and are almost harmless.

    BTW: Some database addons (LightHeaded, MobMap, ...) are already calling collectgarbage('collect') themselves and thus disabling GC from LibRock shouldn't hurt you.
    Posted in: General AddOns
  • 0

    posted a message on TradeskillInfo Official Thread
    Quote from Zidomo »

    Does Rock really interact with non-Rock mods loading with AddonLoader at logon in this way?

    Yes, Rock does this for every delayed addon - even for tekkub's ones. It took me 2 months to find out why I have freezes after login and why sometimes my logins were unsuccessful (the game hang for too long and I was disconnected). For now I'm using my personal addon which disables complete GarbageCollection until I enable it manually, which I don't because Rock is also permanently calling collectgarbage('step') that does one GC step at a time - with this enabled I haven't find any need to perform complete GC during my gameplay.

    Quote from Xinhuan »

    This is most noticable with Quartz. You disconnect, and relogin mid-encounter, you want to cast a spell immediately on login (hey you logged in 1 second earlier so you can cast that spell faster!), but the process of casting that spell freezes your UI for half a second to load Quartz. For a healer, you now lose the opportunity to cancel-cast that particular healing spell if your target is at full health. Now add another half sec freeze for every "delayed" addon. Now that's annoying.

    The problem with Quartz is much bigger because the whole suite of 15 addons is loaded after first spellcast and Rock calls GC after each of the 15 addons! If your GC takes just 0.5sec the game freezes for 8seconds to load just "one" addon! This can be difference between life and death if you reloaded UI or logged in in the wild (I have died a few times because of this)
    Posted in: General AddOns
  • 0

    posted a message on Quartz: Modular Casting Bar
    Any player's UNIT_SPELLCAST_STOP cancels the Quartz cast bar and any player's UNIT_SPELLCAST_CHANNEL_STOP cancels the Quartz channeling cast bar.

    This is also the problem with Quartz_Flight and receiving UNIT_SPELLCAST_STOP just before takeoff, which we tried to fix with Pusikas a few posts back...
    Posted in: General AddOns
  • 0

    posted a message on TradeskillInfo Official Thread
    Quote from Zidomo »

    A feature request that unlike most features, will cause this mod to become more efficient: add AddonLoader support.

    With Warmup testing, due to this being a database mod, it adds a fairly large bit of time to your logon, especially on older PCs. I replaced
    ## LoadOnDemand: 0
    with
    ## LoadManagers: AddonLoader
    ## X-LoadOn-Always: delayed
    in the TOC. Two full weeks of testing and there are no problems at all. TradeskillInfo loads correctly and functions without issues after logon using AddonLoader.

    Please don't do this! The difference is that instead of waiting 0.3sec for TSI to load during load screen you have to wait 0.3sec + 0.5-2sec of garbage collection (if you use at least one Rock based addon) after the game loads. If you have more LOD-delayed addons and you are using Rock libraries the garbage collection is done after each addon is loaded and the game loading takes much longer then without using AddonLoader

    Only reason to do LOD version would be if the addon load could be delayed until some action is made...
    Posted in: General AddOns
  • To post a comment, please or register a new account.