CurseForge and Overwolf are joining forces!
Awesome More Information
  • 0

    posted a message on Taint and you - eh?
    I have reported the following issues :

    FrameXML/BNet.lua:333 missing local declaration for "givenName" in BNet_InitiateReport
    FrameXML/BNet.lua:333 missing local declaration for "surname" in BNet_InitiateReport
    FrameXML/BuffFrame.lua:300 missing local declaration for "index" in BuffFrame_UpdateAllBuffAnchors
    FrameXML/ChatFrame.lua:1863 missing local declaration for "name" in *function:1853-1880*
    FrameXML/ChatFrame.lua:1863 missing local declaration for "rank" in *function:1853-1880*
    FrameXML/ContainerFrame.lua:680 GLOBAL "_" is set in ContainerFrame_GetExtendedPriceString
    FrameXML/FriendsFrame.lua:647 GLOBAL "days" is set in PendingList_Scroll
    FrameXML/FriendsFrame.lua:647 missing local declaration for "timeSent" in PendingList_Scroll
    FrameXML/FriendsFrame.lua:647 missing local declaration for "givenName" in PendingList_Scroll
    FrameXML/FriendsFrame.lua:647 missing local declaration for "inviteID" in PendingList_Scroll
    FrameXML/FriendsFrame.lua:1274 missing local declaration for "button" in FriendsFrame_UpdateFriends
    FrameXML/FriendsFrame.lua:1275 missing local declaration for "index" in FriendsFrame_UpdateFriends
    FrameXML/LootFrame.lua:112 missing local declaration for "questTexture" in LootFrame_UpdateButton
    FrameXML/MailFrame.lua:92 GLOBAL "itemSubType" is set in MailFrame_OnEvent
    FrameXML/MailFrame.lua:92 GLOBAL "itemType" is set in MailFrame_OnEvent
    FrameXML/MailFrame.lua:92 missing local declaration for "itemTexture" in MailFrame_OnEvent
    FrameXML/MailFrame.lua:92 missing local declaration for "itemName" in MailFrame_OnEvent
    FrameXML/MailFrame.lua:92 GLOBAL "itemEquipLoc" is set in MailFrame_OnEvent
    FrameXML/MailFrame.lua:92 GLOBAL "itemStackCount" is set in MailFrame_OnEvent
    FrameXML/MailFrame.lua:92 GLOBAL "itemMinLevel" is set in MailFrame_OnEvent
    FrameXML/MailFrame.lua:92 GLOBAL "itemLevel" is set in MailFrame_OnEvent
    FrameXML/MailFrame.lua:92 missing local declaration for "itemRarity" in MailFrame_OnEvent
    FrameXML/MerchantFrame.lua:467 missing local declaration for "currencyName" in MerchantFrame_ConfirmExtendedItemCost
    FrameXML/MovieFrame.lua:18 GLOBAL "volume" is set in MovieFrame_PlayMovie
    FrameXML/PaperDollFrame.lua:504 GLOBAL "_" is set in PaperDollFrame_SetLevel
    FrameXML/PaperDollFrame.lua:3513 GLOBAL "_" is set in RecalculateGearManagerDialogPopup
    FrameXML/PaperDollFrame.lua:3597 GLOBAL "_" is set in GearManagerDialogPopup_Update
    FrameXML/PVPFrame.lua:309 GLOBAL "_" is set in PVPFrame_UpdateCurrency
    FrameXML/PVPFrame.lua:387 GLOBAL "_" is set in PVPFrame_TabClicked
    FrameXML/PVPFrame.lua:475 GLOBAL "_" is set in PVPHonor_UpdateBattlegrounds
    FrameXML/PVPFrame.lua:807 GLOBAL "_" is set in PVPConquestFrame_Update
    FrameXML/PVPFrame.lua:807 missing local declaration for "ratedArenaReward" in PVPConquestFrame_Update
    FrameXML/PVPFrame.lua:1000 missing local declaration for "played" in PVPTeamManagementFrame_UpdateTeamInfo
    FrameXML/PVPFrame.lua:1001 missing local declaration for "wins" in PVPTeamManagementFrame_UpdateTeamInfo
    FrameXML/PVPFrame.lua:1012 missing local declaration for "loss" in PVPTeamManagementFrame_UpdateTeamInfo
    FrameXML/PVPFrame.lua:1046 missing local declaration for "button" in PVPTeamManagementFrame_UpdateTeamInfo
    FrameXML/PVPFrame.lua:1069 missing local declaration for "seasonLoss" in PVPTeamManagementFrame_UpdateTeamInfo
    FrameXML/PVPFrame.lua:1087 missing local declaration for "winLossText" in PVPTeamManagementFrame_UpdateTeamInfo
    FrameXML/PVPFrame.lua:1186 GLOBAL "_" is set in PVPTeamManagementFrame_UpdateTeams
    FrameXML/QuestInfo.lua:61 missing local declaration for "bottomShownFrame" in QuestInfo_Display
    FrameXML/QuestInfo.lua:198 GLOBAL "_" is set in QuestInfo_DoReputations
    FrameXML/QuestInfo.lua:198 missing local declaration for "hasRep" in QuestInfo_DoReputations
    FrameXML/QuestInfo.lua:287 GLOBAL "_" is set in QuestInfo_ShowObjectivesText
    FrameXML/SpellBookFrame.lua:1012 missing local declaration for "offset" in SpellBookCompanionButton_OnClick
    FrameXML/StaticPopup.lua:3142 missing local declaration for "moneyInputFrame" in StaticPopup_Show
    FrameXML/UIDropDownMenu.lua:500 missing local declaration for "uncheckImage" in UIDropDownMenu_Refresh
    FrameXML/UIDropDownMenu.lua:937 missing local declaration for "uncheckImage" in UIDropDownMenu_ClearAll
    FrameXML/UIParent.lua:3667 missing local declaration for "xCoord" in SetGuildTabardTextures
    FrameXML/UIParent.lua:3668 missing local declaration for "yCoord" in SetGuildTabardTextures
    FrameXML/WatchFrame.lua:893 missing local declaration for "objectiveType" in WatchFrame_DisplayTrackedQuests
    FrameXML/WorldMapFrame.lua:2008 missing local declaration for "questFrame" in WorldMapQuestFrame_UpdateMouseOver
    FrameXML/WorldMapFrame.lua:2062 GLOBAL "_" is set in WorldMapQuestPOI_SetTooltip
    FrameXML/WorldStateFrame.lua:843 GLOBAL "_" is set in WorldStateScoreFrame_Update

    AddOns/Blizzard_ArchaeologyUI/Blizzard_ArchaeologyUI.lua:329 GLOBAL "firstComletionTime" is set in ArchaeologyFrame_UpdateComplete
    AddOns/Blizzard_ArchaeologyUI/Blizzard_ArchaeologyUI.lua:329 missing local declaration for "description" in ArchaeologyFrame_UpdateComplete
    AddOns/Blizzard_ArchaeologyUI/Blizzard_ArchaeologyUI.lua:329 GLOBAL "_" is set in ArchaeologyFrame_UpdateComplete
    AddOns/Blizzard_ArchaeologyUI/Blizzard_ArchaeologyUI.lua:329 missing local declaration for "spellDescription" in ArchaeologyFrame_UpdateComplete
    AddOns/Blizzard_GuildUI/Blizzard_GuildUI.lua:163 GLOBAL "_" is set in GuildFrame_LinkItem
    AddOns/Blizzard_InspectUI/InspectPaperDollFrame.lua:32 GLOBAL "_" is set in InspectPaperDollFrame_SetLevel
    AddOns/Blizzard_TalentUI/Blizzard_TalentUI.lua:1454 missing local declaration for "tab" in PlayerTalentFrame_UpdateTabs
    AddOns/Blizzard_TokenUI/Blizzard_TokenUI.lua:177 missing local declaration for "itemID" in BackpackTokenFrame_Update
    AddOns/Blizzard_TradeSkillUI/Blizzard_TradeSkillUI.lua:171 missing local declaration for "numSkillUps" in TradeSkillFrame_Update
    AddOns/Blizzard_TradeSkillUI/Blizzard_TradeSkillUI.lua:181 missing local declaration for "skillButtonNumSkillUps" in TradeSkillFrame_Update
    AddOns/Blizzard_TradeSkillUI/Blizzard_TradeSkillUI.lua:182 missing local declaration for "skillButtonNumSkillUpsIcon" in TradeSkillFrame_Update
    AddOns/Blizzard_TrainerUI/Blizzard_TrainerUI.lua:191 missing local declaration for "hasReq" in ClassTrainerFrame_SetServiceButton
    Posted in: Lua Code Discussion
  • 0

    posted a message on Taint and you - eh?
    I used to check and report (via Cairenn) a lot of issues related to tainting and missing local declaration. I've been unable to do so for wow4. It's probably not too late for fixes to be inserted in 4.0.3, though.
    Posted in: Lua Code Discussion
  • 0

    posted a message on Curse reward gifts and taxes in France
    Okay, got a response:
    He said: "I don't know"
    I'm sorry :-) we're back to square one.
    Posted in: General Chat
  • 0

    posted a message on Grid2 - What it is, and what it's not
    Found it and committed the changes.

    Thanks a lot.
    Posted in: Grid & Grid2
  • 0

    posted a message on Help with setting in my addon
    You need to fix your XML. The correct syntax is :
    <OnEvent function="LvlWizRev_OnEvent" />


    It is a global variable name, not a function call. Using this method will ensure that your function are indeed called with the correct arguments.

    Alternatively, you may fix it like this :
    <OnEvent>LvlWizRev_OnEvent(self, event, ...)</OnEvent>


    But this syntax introduces an unnecessary global lookup and function call.

    You also need to fix you Lua. You have to properly declare the arguments of you event handlers, like this:
    function LvlWizRev_OnEvent(self, event, ...)
    end


    The name and order of the arguments are dependant on the event being handled. Look at wowwiki or wowprogramming for the correct one.
    Posted in: Lua Code Discussion
  • 0

    posted a message on Grid2 - What it is, and what it's not
    Quote from abuelitowow
    i you have a strong knowlege of grid2, lua and wow api, an hour i think. You have to:

    -Fix initialConfigFunction in gridlayout.lua and gridframes.lua
    -Recode healstatus.lua (remove healcomm stuff and use new heal-incoming api)
    -Fix GridDefaults.lua for every wow class (remove or change spell ids)

    I spent 5 hours to understand a bit and fix that stuff and it works at least for druids an its easy to fix for the rest of clases.


    Please PM me your modifications, having a look at them would be a huge time savior.
    Posted in: Grid & Grid2
  • 0

    posted a message on Grid2 - What it is, and what it's not
    I'm not going to work on Grid2 for the forseable future.

    I'm still convinced that it is, at its core, a lot better than Grid was when I wrote Grid2. It probably still is, although I haven't check on the changes in Grid. But I can't force anyone to look at it, and old habits die hard.

    Anyone wants to work on it, I accept patches and will merge them.

    Today is the first day that I'm gonna start wow in a very long time. I'm just installing patch 4.0.1. Talented is my priority.
    Posted in: Grid & Grid2
  • 0

    posted a message on Talented, a Talent template editor !
    Sadly, Talented 3 won't be ready for 4.0.1.

    I didn't had time (and honestly, not a lot of will) to do it. But I still plan on doing it. It requires a lot of work, though, and most of it isn't very interesting.
    Hopefully it will be usable some time next week or the week after, depending on how many issues I have during the weekend.
    Posted in: General AddOns
  • 0

    posted a message on Curse reward gifts and taxes in France
    None yet, sorry
    Posted in: General Chat
  • 0

    posted a message on Curse reward gifts and taxes in France
    Switching back to english... I've asked a friend who knows a french tax controller, so I should get a definitive answer on this.
    Posted in: General Chat
  • 0

    posted a message on Curse reward gifts and taxes in France
    I filled the form a few month ago, exactly as you did. I have yet to send it, though. I was unsure about how to do so.


    Pour la déclaration aux impôts, La catégorie est "REVENUS NON COMMERCIAUX NON PROFESSIONNELS", plus d'informations ici : http://doc.impots.gouv.fr/aida/brochures_ir2010/
    Posted in: General Chat
  • 0

    posted a message on How is taint represented?
    The execution taint is attached to lua's state and initialised based on how the lua engine has been entered. The lua engine is entered on two occasions: when a frame reacts to an event or when some addon code (FrameXML included) is loaded. Whenever a new object is created, the current execution taint is attached to this object.

    When addon code is loaded, any frame created records the addon that created it. When that frame reacts to an event, the execution taint will be set to the addon that created the frame. If that execution creates new frames, they will also be recorded as belonging to the addon. This information is important for CPU and Memory tracking that the engine can record.

    The current taint is already set when your frame's "OnEvent" handler is called.
    Posted in: Lua Code Discussion
  • 0

    posted a message on Checking if an element exists in an unknown-dimensioned table
    At first, I wrote a version using upvalues, but get_deep is generic enough that it can be used for more than one type of "deep", hence another parameter.

    You can still use upvalues at a higher level (i.e. the function calling get_deep), there's no need to create tables each time you call it.

    Varargs are another possibility, indeed. I lean towards data driven code, these days, and I prefer declaring a table than writing a function call.
    Posted in: Lua Code Discussion
  • 0

    posted a message on Checking if an element exists in an unknown-dimensioned table
    local levels = {"children", 1, "children", 1, "width"}
    
    local function get_deep(node, levels)
      for _, key in next, levels do
        node = node[key]
        if not node then return end
      end
      return node
    end
    Posted in: Lua Code Discussion
  • 0

    posted a message on Player GUID ID + Sort Array Question
    That might just be an artefact of the implementation of the database. i.e. "SELECT guid FROM user_channels WHERE channel_id = ? LIMIT 1".
    Posted in: Lua Code Discussion
  • To post a comment, please or register a new account.