• 0

    posted a message on tomQuest2
    Quote from Morgalm
    Thanks:)


    you're welcome :) and it's now part of r294 and work for quests tooltip, quests tracker, achievements tracker and quest information module fonts
    Posted in: General AddOns
  • 0

    posted a message on tomQuest2
    Quote from Morgalm
    Any chance of adding a global font that applies that font to all possible font choices?


    That should not be hard to implement, I'll look at it for next alpha
    Posted in: General AddOns
  • 0

    posted a message on Skinner
    Just to inform you that since a few alpha tomQuest2 is no more using LibQTip for ldb tooltips and trackers. I've replaced it with three frames of my own named:
    • tomQuest2QuestsTooltip
    • tomQuest2QuestsTracker
    • tomQuest2AchievementsTracker
    Posted in: General AddOns
  • 0

    posted a message on tomQuest2
    new alpha up, should fix lots of errors
    Posted in: General AddOns
  • 0

    posted a message on tomQuest2
    you're welcome to open tickets :) I commit it as alpha to get as much report as possible and make it stable as fast as possible.
    Posted in: General AddOns
  • 0

    posted a message on tomQuest2
    I just commited a new alpha, options are back in and should work :)
    frame anchor for tracker are no more, you now directly lock / unlock the trackers in the option panel (you can add a mouse action on both ldb tracker to lock - unlock each trackers), once unlocked you move the tracker directly instead of the anchor frame.
    Posted in: General AddOns
  • 0

    posted a message on tomQuest2
    yes current alpha does not have it's option enabled, it's still the old option that need to be changed. it'll be in next alpha
    Posted in: General AddOns
  • 0

    posted a message on tomQuest2
    When I released tomQuest2 for the first time the tracker was quite simple and there was no achievements tracker at this time. But with each release the complexity increased so now you have clickable items, statusbar for achievemnts...

    before this release the design principle was like this:

    when an event occur all necessary computation are made to update the relevant quest, questobjective and achievements status, and everything was stored in a big table, then the trackers were updated which means every frames of the trackers were first recycled (including statusbar, item icons, collapse icons...) then redrawn which can take time if you for example set your achievement tracker to be part of the quest tracker. same thing if you display by category, when you collapse or expand a category everything is recycled or collapsed. I made this design choice because at this time I was not very fond of frame drawing, positioning so I go the LibQTip way to draw everything. LibQTip is a very good and efficient library which allows me to do some very interesting things with custom cells providers. I made some improvements, like for example at the very begining when I implemented quest timers in the tracker it was redrawn every second which was very bad so I replaced this by a OnUpate script that only redrawn the quest cell every second :)
    But it was more and more difficult to improve things and some people complained about performance in some situation so I decided to get back to the drawing board and change the design and now that I'm more familiar with frame manipulation I decided to make my own :)
    So the new design is:
    When you receive a new quest in your questlog or when you track a new achievements tomQuest2 automatically assign widgets to those for quests trackers, quests tooltip, achievements tracker. those widgets are for quest title and status, quest objectives and quest objectives status, quests items... Those widgets will only be recycled when the quest is no more in your quest log or if you untrack the achievement.
    So now when some quest or achievement is updated instead of storing the result in a big table I only update the necessary widget and if needed I'll reposition the widgets in the tracker.

    My first impression after testing is that trackers are updated more smoothly and it's using less memory. when playing with the old release I was around 900kb or even above 1mb. with the current alpha I'm arround 550 to 600 kb used.


    I still have lots of things to improve but it's on the good way :)


    edit: well I forgot I also replaced the module system, it's now back to one file this make this a lot easier as module had too much to exchange so it was an un-needed complexity. (except for option which are still in a separated folder) But I've still some sort of module system so you'll be able to enable / disable part of tomQuest2 as well as automatically disable them in Raid
    Posted in: General AddOns
  • 0

    posted a message on tomQuest2
    I've just posted the first alpha of a complete rewrite of tomQuest2, it will certainly have bugs and currently options are disabled so if you want to try it you'll have to edit the default profile in tomQuest2.lua to change the settings.

    edit: this rewrite of tq2 imply a reset of tq2 savedvariables
    Posted in: General AddOns
  • 0

    posted a message on LibQTip
    I just looked at LibQTip internals today and found this:
    function AcquireTooltip()
    	local tooltip = tremove(tooltipHeap)
    	if not tooltip then
    		tooltip = CreateFrame("Frame", nil, UIParent)
    		local scrollFrame = CreateFrame("ScrollFrame", nil, tooltip)
    		scrollFrame:SetPoint("TOP", tooltip, "TOP", 0, -TOOLTIP_PADDING)
    		scrollFrame:SetPoint("BOTTOM", tooltip, "BOTTOM", 0, TOOLTIP_PADDING)
    		scrollFrame:SetPoint("LEFT", tooltip, "LEFT", TOOLTIP_PADDING, 0)
    		scrollFrame:SetPoint("RIGHT", tooltip, "RIGHT", -TOOLTIP_PADDING, 0)
    		[COLOR="Red"]tooltip.scrollFrame[/COLOR] = scrollFrame
    		local scrollChild = CreateFrame("Frame", nil, [COLOR="Red"]tooltip.scrollframe[/COLOR])
    		scrollFrame:SetScrollChild(scrollChild)
    		tooltip.scrollChild = scrollChild
    		setmetatable(tooltip, tipMetatable)
    	end
    	--[===[@debug@
    	usedTooltips = usedTooltips + 1
    	--@end-debug@]===]
    	return tooltip
    end


    As you can see when ScrollChild is created it's parented to tooltip.scrollframe instead of tooltip.scrollFrame
    Posted in: Libraries
  • 0

    posted a message on LibQTip
    Quote from Torhal
    As for the secure frames: I see no reason this wouldn't work, though I haven't used them myself. tomQuest2 uses a custom CellProvider, and also supports quest items in the tooltip - your answer may lie there.


    Just to clarify things, in tomQuest2 I'm not using secure frames for quests items in tooltip. I use the "WatchFrameItemButtonTemplate" template introduced in WOW 3.1, this template is not secured but can only be used for quests items as you just do a SetID(id) on your button where id is the quest id. (the OnClick is directly handled in the template).
    Posted in: Libraries
  • 0

    posted a message on Inline Aura - display aura information inside action buttons
    Quote from Adirelle
    Let alone the fact it should be checked periodically (instead of checking in response to events).

    You can catch weapon enchant change by registering to event UNIT_INVENTORY_CHANGED, this is working but time until expiration is not yet available at this time so if you need it you have to add a small delay between UNIT_INVENTORY_CHANGED fire and call to GetWeaponEnchantInfo()
    Posted in: General AddOns
  • 0

    posted a message on tomQuest2
    Quote from gagou
    thanks X-buZZ for confirming the issue is solved, I'll check the color issue


    I've replied in Skinner thread
    To summarize when tomQuest2 skin is active in Skinner it'll overwrite tomQuest2 color :(
    Posted in: General AddOns
  • 0

    posted a message on Skinner
    Quote from Kerecha
    That would be tomquest fault unf.


    Nothing have change on tomQuest2 side concerning this problem.
    Looking at the tomQuest2 skining file I can see the following problem in code:
    	local tq2 = LibStub("AceAddon-3.0"):GetAddon("tomQuest2", true)
    ...
    	local qTrkr = tq2:GetModule("questsTracker", true)
    	local aTrkr = tq2:GetModule("achievementTracker", true)
    ...
    -->>-- Colour the Quest Tracker & Achievement Tracker if required
    	if qTrkr then
    		qTrkr.db.profile.backDropColor = CopyTable(self.bColour)
    		qTrkr.db.profile.borderColor = CopyTable(self.bbColour)
    	end
    	if aTrkr then
    		aTrkr.db.profile.backDropColor = CopyTable(self.bColour)
    		aTrkr.db.profile.borderColor = CopyTable(self.bbColour)
    		aTrkr.db.profile.statusBarTexture = self.db.profile.StatusBar.texture
    		aTrkr:updateAchievementTracker() -- force update
    	end
    

    What I understand is that when tomQuest2 skin is active it's overwriting tomQuest2 coulour stored in the profile with skinner own colour.
    Posted in: General AddOns
  • 0

    posted a message on tomQuest2
    thanks X-buZZ for confirming the issue is solved, I'll check the color issue
    Posted in: General AddOns
  • To post a comment, please or register a new account.