We're fixing this. We'll stop modding the library at runtime. We'll move those functions off the addon itself in the short term but longer term I want to figure out the right design for what we're trying to achieve.
I prototyped and designed this but I didn't implement it myself. I'll go thru what I wanted and how I though LDB could support that. I'd appriciate any input you have about how it was done and how we should do it. I'm happy to admit that I'm not an expert Lua programmer. I spend most of my time in C# and .Net where I consider myself an expert.
The idea was that addons that want to autotweet can simple fire the tweets off using LibTweetCraft and the actual TweetCraft addon (or some other addon that knew about our data spec) could grab them and either 1) display them in game or 2) get them saved as SavedVariables for some client app to pick up. I can see the value of having other addons that do #1 but the chances of #2 are probably pretty remote.
Originally, I had thought that we could create two data objects "IncomingTweets" and "OutgoingTweets" that contained as one of their fields a list of tweets. If you want to display tweets, grab one or both of these and go nuts. If you want to send tweets, either use LibTweetCraft as a easy API around the OutgoingTweets collection or add them yourself. Either way an addon like DBM or BigWigs that wants to add support for tweeting boss kills could just embed LibTweetCraft and fire away even if TweetCraft itself wasn't there to get the message and actually send them.
I decided not to go with the list object plan and went with the "data object per tweet" plan. In retrospect, this was probably not the right move but we can make it better in the next release.
I thought that LDB would be the right way to allow other addons to get a hold of our information about tweets that have been brought into the game and figured that we could just build the TweetCraft front end to run off the same data in the same way I envisioned a 3rd party addon would.
We have a bunch of fixes we want to do around other things and I'll make sure we stop modding LDB as a part of that release.