["Show Pets for Party"] = "Zeige Begleiter in der Gruppe",
["Show the pets for the party below the party itself."] = "Zeigt die Begleiter der Gruppe unterhalb der Gruppe",
["Pet color"] = "Begleiterfarbe",
["Set the color of pet units."] = "Legt die Begleiterfarbe fest.",
["Pet coloring"] = "Begleiterf\195\164rbung",
["Set the coloring strategy of pet units."] = "Legt fest, wie die Begleiter eingef\195\164rbt werden.",
["Owner Class"] = "Nach Besitzerklasse",
["Creature Type"] = "Nach Kreaturtyp",
["Beast"] = "Tier",
["Demon"] = "D\195\164mon",
["Humanoid"] = "Humanoid",
Pet support is great, but since i have grid on right part of screen, next to the edge and some icons are on left of grid it would be great if pets could appear in another row (max 5 units, if more, then yet another row), not left or right cus i cant see mentioned icons after Grid have changed its width. Same goes for pets in raid (10/25 ppl).
edit:
One more, if there is 6 pets Grid will add one more row for 6th? i haven't noticed this yet.
Pet support is great, but since i have grid on right part of screen, next to the edge and some icons are on left of grid it would be great if pets could appear in another row (max 5 units, if more, then yet another row), not left or right cus i cant see mentioned icons after Grid have changed its width. Same goes for pets in raid (10/25 ppl).
This is a much more important change than what I did. What you can do is set the Grid to "Horizontal". This should allow something like what you're asking for. Another option would be to set the anchoring to right, so that new columns are added toward the center of the screen.
Quote from czokalapik »
edit:
One more, if there is 6 pets Grid will add one more row for 6th? i haven't noticed this yet.
A new column will be created, up to the limit set in the Layout.
I added the pets for class part to my layoutlayout file and it works save for 1 issue. There were 4 locks & 2 hunters in my raid and grid only allowed me 5 petboxes, so 2 petboxes were standing on top of eachother meaning it was impossible to target 1 of the pets.
Isn't it possible for a new row for pets? what if i'm in a 40 man raid with 5 hunters and 6 locks? That would result to 11 pets wich would be a very long row.
The Secure Header attributes that control columns creation are the following :
unitsPerColumn, if set, will limit the number of units shown by each column. So if you set it to 5, then you won't have more than 5 units in each column, even if the filtering is for more than 5 units. In that case, the header will try to create new columns, up to maxColumns (which default to 1!).
So if you want an unlimited number of pets in one row, then you must not set the attributes unitsPerColumn and maxColumns. If you want to limit the column size to 5, then you must set unitsPerColumn to 5 and maxColumns to a meaningfull value (3 when you know you won't have more than 15 pets, for instance).
These attributes are also working for normal groups. For instance, this is a layout you can try :
With the latest fix, I feel that this version is quite solid. Please report any issue you're having using it, I'll try to have it included in the official Grid soon.
I'd love contributed colors for pet creature types (Beast, Demon and Humanoid). Thoses colors should be easy to differenciate and, if possible, should not be like class colors either.
This is a much more important change than what I did. What you can do is set the Grid to "Horizontal". This should allow something like what you're asking for. Another option would be to set the anchoring to right, so that new columns are added toward the center of the screen.
Anchoring is not important here - anchoring to left also works cus grid cant go offscreen.
And i hate Horizontal lay :D So i will play hoping that there will be no more that 2 pets in party ;]
Grid-42967\GridLayout.lua:1116: attempt to index local 'u' (a nil value)
<in C code>: ?
AceEvent-2.0-40601 (AceEvent-2.0):269: in function `TriggerEvent'
Roster-2.1-39966 (RosterLib):386: in function `CreateOrUpdateUnit'
Roster-2.1-39966 (RosterLib):276: in function <Interface\AddOns\RosterLib\Roster-2.1\Roster-2.1.lua:271>
<in C code>: ?
AceEvent-2.0-40601 (AceEvent-2.0):329: in function <Interface\AddOns\AceEvent-2.0\AceEvent-2.0.lua:310>
How do you create a layout for 40 people and let say 3 pet columns, where this 3 columns are also always visible. Perhaps this helps
to reduce some of the lags, when hunters and warlocks call their pets in battleground combat?
What about, instead of turning them black, treat them like an offline player: turn them gray and semi-transparent?
I changed the logic of that piece of code to always set a color. The default for pets is the "pet color", as defined in the options. The default for players is gray (same as when they are dead).
In GridLayout.lua, line 1117 you missed a bracket at eol:
local class = u and u.class or select(2, UnitClass(unitid)
I see no difference in coloring between "Creature Type" and "Pet color". Perhaps the reason for this is that you use the lable "Pet color"
for choosing the petcolor and for choosing how to color (in the submenu)?
Elbereth.
Rollback Post to RevisionRollBack
To post a comment, please login or register a new account.
-
View User Profile
-
View Posts
-
Send Message
Curse PremiumThis is most probably a locale issue. Add the german translation of "Beast", "Demon" and "Humanoid".
With this, all three color-schemes are working.
Elbereth.
edit:
One more, if there is 6 pets Grid will add one more row for 6th? i haven't noticed this yet.
-
View User Profile
-
View Posts
-
Send Message
Curse PremiumThis is a much more important change than what I did. What you can do is set the Grid to "Horizontal". This should allow something like what you're asking for. Another option would be to set the anchoring to right, so that new columns are added toward the center of the screen.
A new column will be created, up to the limit set in the Layout.
Atm i solved it by changing that part to:
[10] = { isPetGroup = true, groupFilter = "WARLOCK,HUNTER", unitsPerColumn = 6, maxColumns = 5, filterOnPet = true, },Isn't it possible for a new row for pets? what if i'm in a 40 man raid with 5 hunters and 6 locks? That would result to 11 pets wich would be a very long row.
-
View User Profile
-
View Posts
-
Send Message
Curse PremiumThis is the purpose of the maxColumns attribute.
The Secure Header attributes that control columns creation are the following :
unitsPerColumn, if set, will limit the number of units shown by each column. So if you set it to 5, then you won't have more than 5 units in each column, even if the filtering is for more than 5 units. In that case, the header will try to create new columns, up to maxColumns (which default to 1!).
So if you want an unlimited number of pets in one row, then you must not set the attributes unitsPerColumn and maxColumns. If you want to limit the column size to 5, then you must set unitsPerColumn to 5 and maxColumns to a meaningfull value (3 when you know you won't have more than 15 pets, for instance).
These attributes are also working for normal groups. For instance, this is a layout you can try :
GridLayout:RegisterLayout("Class groups", [ [1] = { groupBy = "CLASS", unitsPerColumn = 5, maxColumn = 5, }, [2] = { groupBy = "CLASS", isPetGroup = true, unitsPerColumn = 5, maxColumn = 5, }, })This layout is an interesting replacement for "By class w/Pets".
-
View User Profile
-
View Posts
-
Send Message
Curse PremiumI'd love contributed colors for pet creature types (Beast, Demon and Humanoid). Thoses colors should be easy to differenciate and, if possible, should not be like class colors either.
Anchoring is not important here - anchoring to left also works cus grid cant go offscreen.
And i hate Horizontal lay :D So i will play hoping that there will be no more that 2 pets in party ;]
Elbereth.
Also any chance of gettin it onto File so i can get and keep it updated with WAU
Looks exactly like Grid without pets. There are only a few rows/columns more sometimes.
Elbereth.
-
View User Profile
-
View Posts
-
Send Message
Curse PremiumIt'll be added to the official Grid zips when it is ready.
If you want to test it before then, grab it from svn.
-
View User Profile
-
View Posts
-
Send Message
Curse PremiumI'm not quite sure how this can happen, but I now check this and provide a workaround.
This is a view of a raid with pets :
Another view from the same raid :
The corresponding layout :
GridLayout:AddLayout("Class groups", { [1] = { groupFilter = "1,2,3,4,5,6,7,8", groupBy = "CLASS", groupingOrder = "WARRIOR,PALADIN,PRIEST,DRUID,SHAMAN,ROGUE,HUNTER,MAGE,WARLOCK", unitsPerColumn = 5, maxColumns = 5, }, [2] = { isPetGroup = true, groupFilter = "1,2,3,4,5,6,7,8", groupBy = "CLASS", groupingOrder = "WARRIOR,PALADIN,PRIEST,DRUID,SHAMAN,ROGUE,HUNTER,MAGE,WARLOCK", unitsPerColumn = 5, maxColumns = 5, }, })to reduce some of the lags, when hunters and warlocks call their pets in battleground combat?
Elbereth.
-
View User Profile
-
View Posts
-
Send Message
Curse PremiumGridLayout:AddLayout("Test", { -- Add you group as you want here. [4] = { isPetGroup = true, groupFilter = "WARLOCK,HUNTER", unitsPerColumn = 5, }, [5] = { isPetGroup = true, groupFilter = "WARLOCK,HUNTER", unitsPerColumn = 5, startingIndex = 6, }, [6] = { isPetGroup = true, groupFilter = "WARLOCK,HUNTER", unitsPerColumn = 5, startingIndex = 11, }, })Untested.
GridLayout:AddLayout("By Group 40 with pets", { defaults = { -- nameList = "", -- groupFilter = "", -- sortMethod = "INDEX", -- or "NAME" -- sortDir = "ASC", -- or "DESC" -- strictFiltering = false, -- unitsPerColumn = 5, -- treated specifically to do the right thing when available -- maxColumns = 5, -- mandatory if unitsPerColumn is set, or defaults to 1 -- isPetGroup = true, -- special case, not part of the Header API }, [1] = { groupFilter = "1", }, [2] = { groupFilter = "2", }, [3] = { groupFilter = "3", }, [4] = { groupFilter = "4", }, [5] = { groupFilter = "5", }, [6] = { groupFilter = "6", }, [7] = { groupFilter = "7", }, [8] = { groupFilter = "8", }, [9] = { isPetGroup = true, groupFilter = "WARLOCK,HUNTER", unitsPerColumn = 5, }, [10] = { isPetGroup = true, groupFilter = "WARLOCK,HUNTER", unitsPerColumn = 5, startingIndex = 6, }, [11] = { isPetGroup = true, groupFilter = "WARLOCK,HUNTER", unitsPerColumn = 5, startingIndex = 11, }, })Is there a way, to remove warlock pets faster after they were sacrificed. There remains a black squaere for some time.
Thanks,
Elbereth.
-
View User Profile
-
View Posts
-
Send Message
Curse PremiumNo. This is under the control of the Secure Header.
What about, instead of turning them black, treat them like an offline player: turn them gray and semi-transparent?
-
View User Profile
-
View Posts
-
Send Message
Curse PremiumI changed the logic of that piece of code to always set a color. The default for pets is the "pet color", as defined in the options. The default for players is gray (same as when they are dead).
I see no difference in coloring between "Creature Type" and "Pet color". Perhaps the reason for this is that you use the lable "Pet color"
for choosing the petcolor and for choosing how to color (in the submenu)?
Elbereth.