I am looking for a way to disable suf during MoP's new pet battles.
In the default UI, Blizzard's standard unit frames disappears during pet battles to reveal an unobstructed view of the pet battle ui. With suf enabled, the unit frames stay on the screen during pet battles. As a result, some elements of the pet battle ui may be obstructed by suf.
I am looking for a way to disable suf during MoP's new pet battles.
In the default UI, Blizzard's standard unit frames disappears during pet battles to reveal an unobstructed view of the pet battle ui. With suf enabled, the unit frames stay on the screen during pet battles. As a result, some elements of the pet battle ui may be obstructed by suf.
Pet Battles always occur out of combat, so anything should be possible. Would be even cooler if there was a macro condition for being in a pet battle to drive a secure visibility thing, but havent found one yet.
Due to Blizzard issues I can't actually test pet battles so I can't figure out what method they use to hide things off of. So until they fix their problem, there won't be a pet hiding feature unless someone figures out if it's event based or some general system that can be hooked into.
Switched to an alternative that will work securely and not break if you somehow enter combat while in a pet battle. Requires a macro conditional that should go live with the next beta patch, until then pet battle hiding is broken.
While this shouldn't break anything, if you notice any weird positioning issues because of this, let me know.
[petbattle] is live on PTR so that change is now actually live in SUF.
At this point, SUF seems to be stable, as does Aura Indicators. Unless people find some missing features from the new expansion, SUF isn't going to be changed between now and 5.0.
Party frames don't go back to normal after dismounting from the drakes-on-rails during Grim Batol. (The "Disable vehicle swap" unit option is cleared, obviously.)
Are there any more details, such as does this happen on other vehicle based fights, or does it even happen every time? It's generally hard for me to test vehicle stuff, let alone vehicles in a party.
That's probably going to stay broken unless it happens in something new related to MoP or there ends up being some easy way of testing it.
It wouldn't surprise me if it's some sort of crazy event timing issue specific to that, and I don't have a live account so that kind of thing is a pain to test.
Hello, using ShadowedUnitFrames-v3.4.4-29-g43675c7 on a fresh lvl 90 warlock (not a single other addon except ACP/BugGrabber/BugSack), i got the following error on combopoints.lua, line 136.
I was affliction with glyph providing a 4th shard.
Inserting at line 132
print(max,pointsFrame.config.powerType)
I got
- when unchecking the "lock" checkbox : max=50000 and powerType=7
- when checking "lock" back : max=4 and powerType=7.
I fixed it temporarily by inserting this on line 136 of combopoints.lua
Figured out a way of adapting RegisterUnitEvent into SUF for (probable) performance improvements. At a glance it seems to work fine, but could use more testing to make sure it didn't break.
Rollback Post to RevisionRollBack
To post a comment, please login or register a new account.
-
View User Profile
-
View Posts
-
Send Message
Curse PremiumIn the default UI, Blizzard's standard unit frames disappears during pet battles to reveal an unobstructed view of the pet battle ui. With suf enabled, the unit frames stay on the screen during pet battles. As a result, some elements of the pet battle ui may be obstructed by suf.
-
View User Profile
-
View Posts
-
Send Message
Curse PremiumYou can't, I'll add something to do it.
-
View User Profile
-
View Posts
-
Send Message
Forum Moderator-
View User Profile
-
View Posts
-
Send Message
Curse Premium-
View User Profile
-
View Posts
-
Send Message
Forum ModeratorPET_BATTLE_OPENING_START
PET_BATTLE_OPENING_DONE
PET_BATTLE_OVER
PET_BATTLE_CLOSE
Me personally, i rather hooked into the APIs:
PetBattleFrame_Display
PetBattleFrame_Remove
Display is called on the OPENING_START event, and Remove on the _CLOSE event.
-
View User Profile
-
View Posts
-
Send Message
Curse Premium-
View User Profile
-
View Posts
-
Send Message
Curse Premium-
View User Profile
-
View Posts
-
Send Message
Curse PremiumWhile this shouldn't break anything, if you notice any weird positioning issues because of this, let me know.
-
View User Profile
-
View Posts
-
Send Message
Curse PremiumAt this point, SUF seems to be stable, as does Aura Indicators. Unless people find some missing features from the new expansion, SUF isn't going to be changed between now and 5.0.
-
View User Profile
-
View Posts
-
Send Message
Curse Premium-
View User Profile
-
View Posts
-
Send Message
Curse Premium-
View User Profile
-
View Posts
-
Send Message
Curse Premium-
View User Profile
-
View Posts
-
Send Message
Curse Premium-
View User Profile
-
View Posts
-
Send Message
Curse Premiumedit: although I don't recall exactly when I first noticed it.
-
View User Profile
-
View Posts
-
Send Message
Curse PremiumIt wouldn't surprise me if it's some sort of crazy event timing issue specific to that, and I don't have a live account so that kind of thing is a pain to test.
I was affliction with glyph providing a 4th shard.
Inserting at line 132
I got
- when unchecking the "lock" checkbox : max=50000 and powerType=7
- when checking "lock" back : max=4 and powerType=7.
I fixed it temporarily by inserting this on line 136 of combopoints.lua
-
View User Profile
-
View Posts
-
Send Message
Curse Premium-
View User Profile
-
View Posts
-
Send Message
Curse PremiumFigured out a way of adapting RegisterUnitEvent into SUF for (probable) performance improvements. At a glance it seems to work fine, but could use more testing to make sure it didn't break.