Ok, I've commited a new version that I would consider a major change. It seems to work well for me so far.
It SHOULD always change withing 5 seconds after the raid changes, although there is a small bug where the layout doesn't change always when it should. I will be tracking down this problem within the next couple of days and commit a fix.
Please test out this version and let me know how it works for you. Remember that this is the first commit of a total rewrite so it could potentially be buggy. Although I think it's still working better then the last version.
Put this in the gird thread to but think it would be better here
2008/02/12 20:51:30-213-x1]: GridLayoutPlus-59926\GridLayoutPlus.lua:334: bad argument #1 to 'concat' (table contains non-strings)
<in C code>: ?
AceEvent-2.0-56171 (Ace2):300: in function `TriggerEvent'
oRA2\Core.lua:196: in function <Interface\AddOns\oRA2\Core.lua:193>
oRA2\Core.lua:204: in function <Interface\AddOns\oRA2\Core.lua:201>
oRA2\Core.lua:211: in function <Interface\AddOns\oRA2\Core.lua:208>
<in C code>: ?
AceEvent-2.0-56171 (Ace2):300: in function `TriggerEvent'
AceEvent-2.0-56171 (Ace2):914: in function <Interface\AddOns\Ace2\AceEvent-2.0\AceEvent-2.0.lua:907>
Upgrade to the latest version (currently) which is currently 60121. And delete the entire directory "GridLayoutPlus-59926" and use WowAceUpdater to install. The path should be /interface/addons/GridLayoutPlus/GridLayoutPlus.lua.
New features:
- Added unitsPerColumn option allowing you to create a long columns of units, instead of being stuck at 5 units per column.
- Added class sorting so you can change the order in which the columns are populated. Also affects filtering on some columns (Ex: Hide warlock pets, or hide blizzard MainAssist).
- Added tank and pet specer toggles. If you want a space between your tanks and your player groups, you can now toggle it on.
- Fixed a bug where changing the layoutSorting or showPets would not update the layout immediately.
Features are almost complete. Last thing I plan to add is the ability to add different layout settings per instance type. You will be able to have 3 addition settings for the following instance types: Raid, Battlegrounds, Arena.
I will look into this. My only concern will be how to display it. Do I make 1 group with both tanks & playertargets? Do I seperate them into 2 different columns. Do I put tanks first and ptargets second, or the opposite? I never use playertargets myself so I don't know how most people would like them to be displayed.
Let me know what you think...
In our guild we don't use any MT Targets. Healers sets their own player targets on their assigned targets. However it would be nice when it would be all in one column (MT and Player Targets). In this column first the MT, then the PT.
Since i updated today i get this error did a clean install also
[2008/02/14 19:36:23-229-x1]: GridLayoutPlus-59926\GridLayoutPlus.lua:338: bad argument #1 to 'concat' (table contains non-strings)
oRA2_Participant\MainTank.lua:116: in function `func'
Dewdrop-2.0-56529 (DewdropLib):721: in function <...erface\AddOns\DewdropLib\Dewdrop-2.0\Dewdrop-2.0.lua:660>
GridLayoutPlus-59926 is a very old version. if you got it from WowI or CurseI haven't had time to update those yet. Make sure you are installing using WowAceUpdater or from http://files.wowace.com/GridLayoutPlus/
Always get this error with v61269 (and any other I have used):
[2008/02/17 18:50:02-2855-x7]: GridLayoutPlus-59926\GridLayoutPlus.lua:338: bad argument #1 to 'concat' (table contains non-strings)
<in C code>: ?
AceEvent-2.0-56171 (Aurora):300: in function `TriggerEvent'
oRA2\Core.lua:196: in function <Interface\AddOns\oRA2\Core.lua:193>
oRA2\Core.lua:204: in function <Interface\AddOns\oRA2\Core.lua:201>
oRA2\Core.lua:211: in function <Interface\AddOns\oRA2\Core.lua:208>
<in C code>: ?
AceEvent-2.0-56171 (Aurora):300: in function `TriggerEvent'
AceEvent-2.0-56171 (Aurora):914: in function <...ace\AddOns\Aurora\libs\AceEvent-2.0\AceEvent-2.0.lua:907>
---
Dont know why the error says 59926 cause the changelog shows newest version as does aceupdater.
I can not replicate this error. Can you tell me a little about your environment. Non-english client, version of oRA, version of Grid, version of GridLayoutPlus, do you update with WAU or manual, is this the only error you are getting? etc. Anything you can share with me to pinpoint the error would be appreciated.
Also, does it work at all, or is it totally not working?
Hmm well I think I fixed it by downloading the file directly from files.wowace instead of using updater. Sorry. I will let you know if it occurs again:)
[2008/02/23 20:31:08-2903-x1]: GridLayoutPlus-61970\GridLayoutPlus.lua:321: bad argument #1 to 'concat' (table contains non-strings)
<in C code>: ?
AceEvent-2.0-56171 (Aurora):300: in function `TriggerEvent'
oRA2\Core.lua:196: in function <Interface\AddOns\oRA2\Core.lua:193>
oRA2\Core.lua:204: in function <Interface\AddOns\oRA2\Core.lua:201>
oRA2\Core.lua:211: in function <Interface\AddOns\oRA2\Core.lua:208>
<in C code>: ?
AceEvent-2.0-56171 (Aurora):300: in function `TriggerEvent'
AceEvent-2.0-56171 (Aurora):914: in function <...ace\AddOns\Aurora\libs\AceEvent-2.0\AceEvent-2.0.lua:907>
---
Just joined a raidgroup for testing a mod and ora2 had leftover tanks from previous raid (they werent in the new raid at all) and getting this error repeating every couple seconds:
[2008/02/27 15:35:16-2960-x1]: GridLayoutPlus-61970\GridLayoutPlus.lua:343: bad argument #2 to 'find' (string expected, got nil)
<in C code>: ?
AceEvent-2.0-56171 (Aurora):300: in function `TriggerEvent'
Roster-2.1-55419 (BigBrother):221: in function `?'
AceEvent-2.0-56171 (Aurora):689: in function <...ace\AddOns\Aurora\libs\AceEvent-2.0\AceEvent-2.0.lua:676>
<in C code>: ?
AceEvent-2.0-56171 (Aurora):364: in function <...ace\AddOns\Aurora\libs\AceEvent-2.0\AceEvent-2.0.lua:342>
---
Also I have tried updating through wowaceupdater and choosing reinstall mod as well as downloading manually off the files site and unzipping to addons directory and I am still getting version 61970.
Yeah addon works fine just this error pops up sometimes:) As far as I know ora2 always keeps the same tanks although I usually stay raided for mod debugging so I could be wrong there. And no I always set tans using ora2.
I have the fix for this in the branch version of Grid (GridLayoutPlus merge temporarily called "AutoLayout"). If you want to try out that version, you are welcome to, but just remember it's an alpha version and will be changing a great deal before moving into trunk. If you do decide to try it out, please disable GridLayoutPlus.
I added an option to sort "By Role". There are 5 roles:
Tanks = Warriors & Paladins with 31 in Protection, Druids with 31 points in Feral
Melee = Rogues, Warriors who are not tanks, Paladin with 31 points in Retribution, Shaman with 31 points in Enhancment
Healer = Priests who are not Shadow, Paladin with 31 points in Holy, Druids & Shaman with 31 points in Resto
Hybrid = Paladin, Druids, and Shaman who do not have 31 points in any 1 tree (usually low levels)
Ranged = Mage, Warlocks, Hunters, Priests with 31 points in Shadow, Druids with 31 in Balance, Shaman with 31 points in Elemental
The 5 buckets are just for sorting, there are no hard groups defined. So if you have 3 tanks, and are set to 5 units per column, then 2 melee will be in the same column as the tanks. I could easily change this to 4 hard defined groupings (I would merge healer and hybrids) but I'm not sure it's necessary yet.
It also adheres to the classOrder that you define in the options menu. The sorting logic is (roleorder)(classorder)(level [DESC])(unitid)
Also note that it takes about 1 second per unit to get their talents. It only queries talents for hybrids, Warriors, and Priests. So usually 30 seconds after joining a new AV (for example), the roles are finished being sorted out. If a unit is out of visibile range then the unit will stay on a queue until you are in range of the unit. No units are lost, they just will be sorted in a default location until the talent can be queried.
WARNING: You may find that DogTag addons (PitBull, CowTip) behave strangely when using "By Role". This is not a fault of mine, but a fault of the way DogTag handles talent queries. It assumes it's the only addon that has the right to query talents and doesn't take any precaution to prevent it's queries from being "hijacked". Blame Blizzard really, they could have made querying talents a little easier.
I also took the luxury to redo the entire Layout option menu. I always hated how the options weren't grouped together properly. Please give me feedback on this as I'm planning for these options changes to be merged into the core.
Edit: Tried it out briefly and one problem I see is that offline units totally disappear. I was in a raid with me and 2 offline members and the only raid frame that appeared was mine. Not sure if this was intended but would really like to see offline members:)
OK tried for a full raid. Getting a few problems. Everytime the roster has an event I was getting huge lag spikes while the party reorganised. After every combat it changed form from class layout with 1 class per row to new roles layout (or class layout bunched up like usual when i took it off new roles layout) It made this switch back and forth every end of combat always going to a different one. Also when building the raid it seemed to lose people sometimes. Had 4 mages in raid but only 3 were showing unless I switched to class view. Thats all I can think of right now but the lag spikes were really bad. Also seemed to sometimes show raid frames bunched up but huge black grid unfilled. Thanks:)
Rollback Post to RevisionRollBack
To post a comment, please login or register a new account.
It SHOULD always change withing 5 seconds after the raid changes, although there is a small bug where the layout doesn't change always when it should. I will be tracking down this problem within the next couple of days and commit a fix.
Please test out this version and let me know how it works for you. Remember that this is the first commit of a total rewrite so it could potentially be buggy. Although I think it's still working better then the last version.
Thanks!
2008/02/12 20:51:30-213-x1]: GridLayoutPlus-59926\GridLayoutPlus.lua:334: bad argument #1 to 'concat' (table contains non-strings)
<in C code>: ?
AceEvent-2.0-56171 (Ace2):300: in function `TriggerEvent'
oRA2\Core.lua:196: in function <Interface\AddOns\oRA2\Core.lua:193>
oRA2\Core.lua:204: in function <Interface\AddOns\oRA2\Core.lua:201>
oRA2\Core.lua:211: in function <Interface\AddOns\oRA2\Core.lua:208>
<in C code>: ?
AceEvent-2.0-56171 (Ace2):300: in function `TriggerEvent'
AceEvent-2.0-56171 (Ace2):914: in function <Interface\AddOns\Ace2\AceEvent-2.0\AceEvent-2.0.lua:907>
---
Get this random error every now and again
Try that and get back to me.
- Added unitsPerColumn option allowing you to create a long columns of units, instead of being stuck at 5 units per column.
- Added class sorting so you can change the order in which the columns are populated. Also affects filtering on some columns (Ex: Hide warlock pets, or hide blizzard MainAssist).
- Added tank and pet specer toggles. If you want a space between your tanks and your player groups, you can now toggle it on.
- Fixed a bug where changing the layoutSorting or showPets would not update the layout immediately.
Features are almost complete. Last thing I plan to add is the ability to add different layout settings per instance type. You will be able to have 3 addition settings for the following instance types: Raid, Battlegrounds, Arena.
In our guild we don't use any MT Targets. Healers sets their own player targets on their assigned targets. However it would be nice when it would be all in one column (MT and Player Targets). In this column first the MT, then the PT.
[2008/02/14 19:36:23-229-x1]: GridLayoutPlus-59926\GridLayoutPlus.lua:338: bad argument #1 to 'concat' (table contains non-strings)
oRA2_Participant\MainTank.lua:116: in function `func'
Dewdrop-2.0-56529 (DewdropLib):721: in function <...erface\AddOns\DewdropLib\Dewdrop-2.0\Dewdrop-2.0.lua:660>
---
Dont know why the error says 59926 cause the changelog shows newest version as does aceupdater.
Also, does it work at all, or is it totally not working?
Also I have tried updating through wowaceupdater and choosing reinstall mod as well as downloading manually off the files site and unzipping to addons directory and I am still getting version 61970.
1) Is the addon working fine in a normal scenario? You haven't told me yet.
2) If you leave a raid and then join a new one, why would oRA2 keep the main tanks from the previous raid? That is not normal afaik.
3) Was there a mix of Blizzard and oRA2 tanks being set by different people?
Tanks = Warriors & Paladins with 31 in Protection, Druids with 31 points in Feral
Melee = Rogues, Warriors who are not tanks, Paladin with 31 points in Retribution, Shaman with 31 points in Enhancment
Healer = Priests who are not Shadow, Paladin with 31 points in Holy, Druids & Shaman with 31 points in Resto
Hybrid = Paladin, Druids, and Shaman who do not have 31 points in any 1 tree (usually low levels)
Ranged = Mage, Warlocks, Hunters, Priests with 31 points in Shadow, Druids with 31 in Balance, Shaman with 31 points in Elemental
The 5 buckets are just for sorting, there are no hard groups defined. So if you have 3 tanks, and are set to 5 units per column, then 2 melee will be in the same column as the tanks. I could easily change this to 4 hard defined groupings (I would merge healer and hybrids) but I'm not sure it's necessary yet.
It also adheres to the classOrder that you define in the options menu. The sorting logic is (roleorder)(classorder)(level [DESC])(unitid)
Also note that it takes about 1 second per unit to get their talents. It only queries talents for hybrids, Warriors, and Priests. So usually 30 seconds after joining a new AV (for example), the roles are finished being sorted out. If a unit is out of visibile range then the unit will stay on a queue until you are in range of the unit. No units are lost, they just will be sorted in a default location until the talent can be queried.
WARNING: You may find that DogTag addons (PitBull, CowTip) behave strangely when using "By Role". This is not a fault of mine, but a fault of the way DogTag handles talent queries. It assumes it's the only addon that has the right to query talents and doesn't take any precaution to prevent it's queries from being "hijacked". Blame Blizzard really, they could have made querying talents a little easier.
I also took the luxury to redo the entire Layout option menu. I always hated how the options weren't grouped together properly. Please give me feedback on this as I'm planning for these options changes to be merged into the core.
Edit: Tried it out briefly and one problem I see is that offline units totally disappear. I was in a raid with me and 2 offline members and the only raid frame that appeared was mine. Not sure if this was intended but would really like to see offline members:)