just updated it and my minimap button has disappeared. how do i get it back?
Please check these in this order:
1. Have you installed SavedInstances v3-beta4
2. Is SavedInstances enabled in the Addons section of the login screen?
3. Can you find SavedInstances' settings in the Addons section of the Interface options (in-game)?
4. Does deleting the SavedInstances.lua file from your WTF/.../SavedVariables folders help?
5. Does completely deleting SavedInstances and installing it fresh help?
6. Does enabling/installing only SavedInstances and nothing else help?
I have double-checked that SavedInstances' minimap icon is appearing (and can be shown/hidden) properly when it is the only addon enabled and when the SavedVariables file has been removed. It's working perfectly with my other addons too. This is with v3-beta4, beta3 did have a bug.
I have never tested my addon in disembedded (libraries separately installed) setups so I can't be sure that isn't a problem. However, that sort of configuration is an advanced Curse Client and World of Warcraft setup, so I assume that those users possess a certain technical finesse.
Any chance of adding a way to keep track of whether or not you have done the random heroic dungeon each day? I use this mod to keep track of my 8 80's and what instances/raids I have done, but the biggest thing I am missing now is a way to keep track of which ones I have done the random daily heroic (for my 2 frost emblems) on. This would be handy, as right now when I login each day I queue up for specific instances first, and than after that I go to the randoms, but I sometimes forget to do the random, and hence why if I had a way to see it, it would be awesome. :-)
...Switch the LFD tool back to random in the drop down and see if it says Frost or Triumph as the reward..? :P
I have 8 80's, that requires me to login to each and everyone of them and see. That's kind of the whole purpose of this mod, and what I use it for already is to keep track of who I've done what on. Seems like the perfect thing to add as well, I even found the API's to check it, just my attempts at hacking it in didn't go so well.
@zaphon:
It's a good idea. I personally do random dungeons before specific ones, so the addon already serves this purpose for me. However, I've been looking into your request and there are a few things I might be able to use to recognise this. I've been digging through Blizzard's new code, which is why work on Savedinstances has been quite slow lately.
I need to test it out a bit, bit I think I can reliably wait for the new LFG_COMPLETION_REWARD event (triggers when you see that new achievement-like reward panel pop up) and just check to see if you currently have the Luck of the Draw aura. I can double-check that you are doing the highest difficulty you can (normal or heroic).
It's a good idea. Any suggestions on how you'd like to have this status displayed? How about a new row displayed with your dungeons titled "Random Dungeon" with a Normal/Heroic indicator for each of your characters?
@zvifflemeyer and co:
Can anyone please confirm that I wasn't able to fix the minimap button issues in beta4? Zaphon's suggestion and this bug report are the only things holding back a stable release at this point.
@zaphon:
It's a good idea. I personally do random dungeons before specific ones, so the addon already serves this purpose for me. However, I've been looking into your request and there are a few things I might be able to use to recognise this. I've been digging through Blizzard's new code, which is why work on Savedinstances has been quite slow lately.
I need to test it out a bit, bit I think I can reliably wait for the new LFG_COMPLETION_REWARD event (triggers when you see that new achievement-like reward panel pop up) and just check to see if you currently have the Luck of the Draw aura. I can double-check that you are doing the highest difficulty you can (normal or heroic).
It's a good idea. Any suggestions on how you'd like to have this status displayed? How about a new row displayed with your dungeons titled "Random Dungeon" with a Normal/Heroic indicator for each of your characters?
@zvifflemeyer and co:
Can anyone please confirm that I wasn't able to fix the minimap button issues in beta4? Zaphon's suggestion and this bug report are the only things holding back a stable release at this point.
Maybe just a column with "random daily" (and maybe a short version "R") and just a green "mark" if u have done random dail.
@zaphon:
It's a good idea. I personally do random dungeons before specific ones, so the addon already serves this purpose for me. However, I've been looking into your request and there are a few things I might be able to use to recognise this. I've been digging through Blizzard's new code, which is why work on Savedinstances has been quite slow lately.
I need to test it out a bit, bit I think I can reliably wait for the new LFG_COMPLETION_REWARD event (triggers when you see that new achievement-like reward panel pop up) and just check to see if you currently have the Luck of the Draw aura. I can double-check that you are doing the highest difficulty you can (normal or heroic).
It's a good idea. Any suggestions on how you'd like to have this status displayed? How about a new row displayed with your dungeons titled "Random Dungeon" with a Normal/Heroic indicator for each of your characters?
@zvifflemeyer and co:
Can anyone please confirm that I wasn't able to fix the minimap button issues in beta4? Zaphon's suggestion and this bug report are the only things holding back a stable release at this point.
Yeah, I was actually looking at basically querying the LFD tool just like they do to see whether to display the better rewards or not (it's around line 783 of LFDFrame.lua) which I believe let's you know whether or not they have done the random (based on the dungeonID which is queried earlier). *shrugs*, these are all undocumented API's, so guessing. BTW don't you get the luck of the draw aura on every random?
But yes I would like just an extra row that shows if you have done it on which characters. :-)
I plan on linking the last random daily dungeon that was completed (separately for both difficulty levels) to each character, via the lockout ID. That way when the lockout expires, I'll know to reset the status of each character. Might be slightly computationally wasteful for each additional random daily, but it should mean I can track the reset time using Blizzard's data and not have to hardcode anything myself.
Can everyone confirm that the minimap button is working in beta4? Anyone currently having issues with it? Please let me know as soon as possible. I've started tinkering with the daily tracker code now, and when it's done I'll be very tempted to make a full release.
I plan on linking the last random daily dungeon that was completed (separately for both difficulty levels) to each character, via the lockout ID. That way when the lockout expires, I'll know to reset the status of each character. Might be slightly computationally wasteful for each additional random daily, but it should mean I can track the reset time using Blizzard's data and not have to hardcode anything myself.
Can everyone confirm that the minimap button is working in beta4? Anyone currently having issues with it? Please let me know as soon as possible. I've started tinkering with the daily tracker code now, and when it's done I'll be very tempted to make a full release.
Only thing about that is the Random Daily resets at 3am Server Time and the Heroics reset at 8am Server Time (at least on my PST server), so their not tied together (one resets with the dailies, the other with the heroics). If that's what you mean.
No idea about the minimap button, I use a LDB display.
Considering you can only do one instance per toon that gets you your frost badges. Link in for the LFG event you mentioned, then test the rewards for the frost badge. If it's there then flag the toon an attach the GetQuestResetTime() on to it. In SOCD I setup a simple check.
local resetTime = time()+GetQuestResetTime()
if time() > resetTime then
--Clear Data
end
It has a 1 or 2 second real offset, but it's not that bad considering that most players are not awake when dailies reset.
I'm currently gonna test the contents of the Dungeon Finder window, since the text changes once you've done a daily random. This should mean I have a future-proof way of detecting the daily since I don't need to hard code in specific rewards or numbers of rewards.
That GetQuestResetTime() is genius though. Trying to work it in now.
From what I saw as well, you should be able to get the right dungeonID by calling GetRandomDungeonBestChoice() which should return the highest one the current character is capable of. But of course than you'll start storing this information for every character, so maybe limit it to 80's.
considering that the SavedInstances works mostly with instances that have RaidID's, and only 3 classes of instances available that work with the LFD tool are available. So really only those 3 are important, as the LFD tool dosn't work the same way with raids.
I was using those calls you mentioned (OrionShock) for a while, and then it hit me: why not just save the quest time remaining after the first random daily completion? I've stopped checking altogether to see if it's actually been done according to Blizzard. :) I literally wait for the LFG_COMPLETION_REWARD event, and check to see if we have the Luck of the Draw buff, that's all. I'm testing it now.
Had a weird thing happen yesterday, got Azjol-Nerub as my daily random heroic, but when I was looking at it under SavedInstances it showed up under the Classic category versus under Wrath of the Lich King (not sure if it didn't match or what, but it even shows an Expansion of 0 in my SavedVariables file).
Yeah, it's a glitch. I don't know why, but the database of instances in the Dungeon Finder sometimes uses different names when compared to the instance zones (used for the lockouts). Even when this isn't the case, sometimes certain instances just don't get paired up with their Dungeon Finder information.
Note that there isn't really a great way for me to tell which expansion introduces which instance. I could define a whole database for it, but since there isn't really such thing as a universal Dungeon ID, I'd have to localise it which is where it gets crazy. So for the time being, you may need to manually correct a few.
Yeah, it's a glitch. I don't know why, but the database of instances in the Dungeon Finder sometimes uses different names when compared to the instance zones (used for the lockouts). Even when this isn't the case, sometimes certain instances just don't get paired up with their Dungeon Finder information.
Note that there isn't really a great way for me to tell which expansion introduces which instance. I could define a whole database for it, but since there isn't really such thing as a universal Dungeon ID, I'd have to localise it which is where it gets crazy. So for the time being, you may need to manually correct a few.
I'm trying to iron this out.
Yeah, but it's weird. I actually put some debugging code in there and I swear there's a match, but the two strfind's you do didn't get a match. It's really odd (maybe it was a case problem, I will have to look again), I will look a bit further.
I found the problem. In GetLFDID you call strfind twice in order to do a match for the name (and I was doing a direct compare and getting a match). The problem is that strfind does regular expression matching, and any name that has a regular expression operator will possibly trigger a non-match. I fixed it by adding in the optional fourth parameter which specify's PLAIN matching versus regular expressions. Now Azjol-Nerub shows up properly. It looks like this.
if (strfind(details[1], name, 1, true) or strfind(name, details[1], 1, true))
and (vars.db.Instances[name].Raid == (details[2] == 2)) then
-
View User Profile
-
View Posts
-
Send Message
Curse PremiumPlease check these in this order:
1. Have you installed SavedInstances v3-beta4
2. Is SavedInstances enabled in the Addons section of the login screen?
3. Can you find SavedInstances' settings in the Addons section of the Interface options (in-game)?
4. Does deleting the SavedInstances.lua file from your WTF/.../SavedVariables folders help?
5. Does completely deleting SavedInstances and installing it fresh help?
6. Does enabling/installing only SavedInstances and nothing else help?
I have double-checked that SavedInstances' minimap icon is appearing (and can be shown/hidden) properly when it is the only addon enabled and when the SavedVariables file has been removed. It's working perfectly with my other addons too. This is with v3-beta4, beta3 did have a bug.
I have never tested my addon in disembedded (libraries separately installed) setups so I can't be sure that isn't a problem. However, that sort of configuration is an advanced Curse Client and World of Warcraft setup, so I assume that those users possess a certain technical finesse.
I have 8 80's, that requires me to login to each and everyone of them and see. That's kind of the whole purpose of this mod, and what I use it for already is to keep track of who I've done what on. Seems like the perfect thing to add as well, I even found the API's to check it, just my attempts at hacking it in didn't go so well.
-
View User Profile
-
View Posts
-
Send Message
Curse PremiumIt's a good idea. I personally do random dungeons before specific ones, so the addon already serves this purpose for me. However, I've been looking into your request and there are a few things I might be able to use to recognise this. I've been digging through Blizzard's new code, which is why work on Savedinstances has been quite slow lately.
I need to test it out a bit, bit I think I can reliably wait for the new LFG_COMPLETION_REWARD event (triggers when you see that new achievement-like reward panel pop up) and just check to see if you currently have the Luck of the Draw aura. I can double-check that you are doing the highest difficulty you can (normal or heroic).
It's a good idea. Any suggestions on how you'd like to have this status displayed? How about a new row displayed with your dungeons titled "Random Dungeon" with a Normal/Heroic indicator for each of your characters?
@zvifflemeyer and co:
Can anyone please confirm that I wasn't able to fix the minimap button issues in beta4? Zaphon's suggestion and this bug report are the only things holding back a stable release at this point.
Maybe just a column with "random daily" (and maybe a short version "R") and just a green "mark" if u have done random dail.
Yeah, I was actually looking at basically querying the LFD tool just like they do to see whether to display the better rewards or not (it's around line 783 of LFDFrame.lua) which I believe let's you know whether or not they have done the random (based on the dungeonID which is queried earlier). *shrugs*, these are all undocumented API's, so guessing. BTW don't you get the luck of the draw aura on every random?
But yes I would like just an extra row that shows if you have done it on which characters. :-)
-
View User Profile
-
View Posts
-
Send Message
Curse PremiumCan everyone confirm that the minimap button is working in beta4? Anyone currently having issues with it? Please let me know as soon as possible. I've started tinkering with the daily tracker code now, and when it's done I'll be very tempted to make a full release.
Only thing about that is the Random Daily resets at 3am Server Time and the Heroics reset at 8am Server Time (at least on my PST server), so their not tied together (one resets with the dailies, the other with the heroics). If that's what you mean.
No idea about the minimap button, I use a LDB display.
-
View User Profile
-
View Posts
-
Send Message
Curse Premiumlocal resetTime = time()+GetQuestResetTime()
if time() > resetTime then
--Clear Data
end
It has a 1 or 2 second real offset, but it's not that bad considering that most players are not awake when dailies reset.
-
View User Profile
-
View Posts
-
Send Message
Curse PremiumI'm currently gonna test the contents of the Dungeon Finder window, since the text changes once you've done a daily random. This should mean I have a future-proof way of detecting the daily since I don't need to hard code in specific rewards or numbers of rewards.
That GetQuestResetTime() is genius though. Trying to work it in now.
-
View User Profile
-
View Posts
-
Send Message
Curse Premium261 --WotLK Random Non-Heroic ID
260 --BC Random Heroic
doneToday, moneyBase, moneyVar, experienceBase, experienceVar, numRewards = GetLFGDungeonRewards(dungeonID);
name, texturePath, quantity = GetLFGDungeonRewardInfo(dungeonID, rewardIndex);
Sadly i couldn't find a easy way to extract an item id for the rewards. however this did work
tooltip:SetLFGDungeonReward(id, index)
tooltip:GetItem()
returned values as one would expect.
From what I saw as well, you should be able to get the right dungeonID by calling GetRandomDungeonBestChoice() which should return the highest one the current character is capable of. But of course than you'll start storing this information for every character, so maybe limit it to 80's.
-
View User Profile
-
View Posts
-
Send Message
Curse Premium-
View User Profile
-
View Posts
-
Send Message
Curse Premium-
View User Profile
-
View Posts
-
Send Message
Curse PremiumNote that there isn't really a great way for me to tell which expansion introduces which instance. I could define a whole database for it, but since there isn't really such thing as a universal Dungeon ID, I'd have to localise it which is where it gets crazy. So for the time being, you may need to manually correct a few.
I'm trying to iron this out.
Yeah, but it's weird. I actually put some debugging code in there and I swear there's a match, but the two strfind's you do didn't get a match. It's really odd (maybe it was a case problem, I will have to look again), I will look a bit further.
I found the problem. In GetLFDID you call strfind twice in order to do a match for the name (and I was doing a direct compare and getting a match). The problem is that strfind does regular expression matching, and any name that has a regular expression operator will possibly trigger a non-match. I fixed it by adding in the optional fourth parameter which specify's PLAIN matching versus regular expressions. Now Azjol-Nerub shows up properly. It looks like this.
if (strfind(details[1], name, 1, true) or strfind(name, details[1], 1, true)) and (vars.db.Instances[name].Raid == (details[2] == 2)) then-
View User Profile
-
View Posts
-
Send Message
Curse PremiumActually there is, just a pain to get to