Yeah, I've put a thing in the "Known Issues" section of the addon description, but I should probably mention it here too.
My "Alpha" files should not actually be treated as such. The WowAce packager goes and automatically makes Alpha files out of anything I submit. This is unfortunate when I just want to go to bed and not lie awake at night wondering what would happen to my code if my laptop caught fire. :) So Alpha really just means "back-up" for me. I'll be the first to admit that this is probably not in the spirit of how a source repository is supposed to be used, but this is just how it works for me at the moment.
So I thank you for taking the time to let me know there's a bug in my Alpha. It's terrific that you care. For future reference, my Alpha files are basically guaranteed to fail. My Beta and Releases are the ones that are intended for testing (the former) and regular use (the latter). Thanks!
You might have noticed that both my addons have seen some activity lately. I hope to get some releases happening this coming week.
I know that open source projects with multiple maintainers often have a rule that all commits have to include working code or no compiler errors or whatever. As far as I know, the packager does do a basic Lua compliance check, but I often do these commits right before going to bed or otherwise leaving my desk for a while.
Besides, I'm currently the only maintainer. I appreciate that my users might want a sneak peek at the cutting edge of my process or whatever, but that's what Beta is for. :P
Just my own $.02 and personal opinion here: The UI to classify & reorder instances is, imo, overkill and .. well.. "unnecessary bloat". Separating them by raid/5man and then alphabetical sorting is going to cover anyone's needs, really.
Something entirely different I think would rock though, is being able to request saves from group members and displaying them in the same tooltip. With heroic farming being the current rage, it would be really nice to quickly check what people are saved to (assuming they're running SavedInstances or something else supporting the same protocol).
Something else it might support would be to manually tick if someone's saved to an instance after querying people and realizing that group members A, B and D don't speak the savedinstances protocol.
For a protocol, I'd suggest something Real Damn Simple so that other addons can easily speak it. Something like:
prefix="SAVED", and a single message with lines on the format:
Halls of Lightning: 5h
Trial of the Champion: 10, 10h, 25
Obviously there's going to be a translation issue here, and we can't even assume that clients on the same realm are using the same language. (No, really, ask anyone playing on an english european server). So you'd need to use something useful like LibBabble-Instance and always transmit the instance names as English (or untranslated if no translation exists and hope that the receiving end checks for untranslated also and is the same locale).
There are already tickets up for most of what you've suggested. I've been thinking about how to do synchronisation for a while now. I dislike the idea of relying on a heavy translation library for something as simple as instance names, but it does seem like a necessary evil.
I've been thinking about ways to support instance farming groups, and the low-hanging fruit seems to be simply storing the name/realm of group members whenever we are saved.
It's a whole big can of worms and I do plan on opening it eventually.
Regarding the categories and re-ordering, they were items that I wanted in there personally, but there are provisions in place for those who aren't interested. The only piece of information I can't easily figure out about any particular instance is which expansion it belongs to (it defaults to "Classic"). Instances are otherwise automatically categorised into dungeons (5-man) and raids (everything else). You don't have to spend any time classifying them yourself, and you can hide the category names if you don't like seeing "Classic" in the tooltip.
Thanks heaps for the comments. I plan to continue improving this for the foreseeable future.
Okay, well, my first session of coding for quite a while. I'm really happy with what I've done to SavedInstances. v2.5-beta should be syndicating as I type this. If all goes well it should be a full release in a few days of testing.
My major concern with the setup interface was the "world of dropdowns" that I inflicted upon the user. All unnecessary dropdowns have been removed in favour of lists that are much friendly.
There is a new feature in this release: encounters! You can define encounters for each instance in the Instance tab. Then, you can tick them off in the Lockouts tab as you go along. Make sure you enable "Show encounters" in the general tab if you want to see this in the tooltip. I know this isn't automatic yet, but I think it will still be useful. Making it work without user intervention is a really really big task. If anyone has any suggestions, I'd love to hear them.
So go go, download and test. And praise or complain. :)
You could parse the combat log, but that is a lot of overhead for something so small. Perhaps you could track the statistics portion of the achievement stuff and mark it as complete if it +1's to a boss in the corresponding instance.
I was thinking about it today and I remembered seeing a LibBossID library (or something similarly named) floating past the WowAce home page recently. The problem is there are several encounters where the boss doesn't actually die (like The Keepers). And there are other weird encounters where the bosses can die in variable orders (Assembly of Iron), but that wouldn't be too difficult to manage.
If only there was a LibBossEncounter or something, that would instantly identify the encounter that was started, and determine a successful outcome. It would be terrific if it also tracked the encounter hierarchy, such as being able to group Thorim, Freya, Hodir and Mimiron as "The Keepers" and not expect General Vezax until The Keepers was checked off.
I dunno. It's just getting yuckier and yuckier. /sigh
Note also that it's possible to kill certain bosses without getting saved in 3.3, via the LFG random-dungeon system. Yet another whacky case for SavedInstances to figure out.
Okay, just thought I'd drop a status report. I'm working on overhauling a few parts of SavedInstances.
Things in the addon currently:
- categories can be manually reordered
- instances can be manually reordered
- instances can be manually categorised
- completed encounters can be manually recorded
Things I'm working on:
- instances will be 100% automatically categorised, no more manual control
- completed encounters are 100% automatically categories, no more manual control
- instances are automatically sorted by either level or name, descending or ascending, no more manual control
- categories are automatically sorted, no more manual control (raids first, dungeons first, or by expansion)
The new Dungeon Finder and Raid Finder tools have opened some API doors for me and I'm currently figuring out how best to exploit them. I won't be releasing a 3.3 TOC for a week or so, but as far as I can tell SavedInstances is working fine already anyhow.
So basically, I'm still alive, SavedInstances is fine, and I'm working on making it a super streamlined and easy to use addon moving forward. Stay tuned. :)
Okay, I finally got a chance to sit down and look at SavedInstances today.
- Categories section is gone, sorting options are found in the General section
- category sorting options seem to work perfectly
- Dungeon Finder information is used where possible to automatically fill in instance information (specifically expansion pack)
- I'll need more time to improve the matching between the Dungeon Finder DB and the internal instance names
- Instance Order section is gone, sorting options are found in the General section
Things to look at before next stable release:
- I'd like a few days of having a beta release available for public testing
- finish overhauling Instance ordering
- look at customising Instance text coloring
- look at showing instances that party/raid members are unable to do
- tidy up and automate Encounter tracking
- tidy up Lockout links (when clicking on a particular lockout indicator)
I use BugSack and BugGrabber, so I can train myself to ignore those silly bugs while I'm developing new interface controls. Probably a bad thing. Of course, I then go and make a release and wonder why I'm still getting errors. :)
Aside from that, any comments on how it's working so far?
Boss detection is much trickier than I first thought which is why it's taking so long. I think I might leave it out for now.