The PUG detection is too picky in my opinion. How many guilds run official guild 25-man raids with more than 2-3 non-guildies? I don't know what the current logic is but I've never been in a PUG in which RBS let me broadcast, there always seems to be one guild with a bunch of members in it and then it refuses to work.
I think I already mentioned that somewhere but I can't find it anymore...
But since I saw the new localization keys for all class names, I'll write it again:
Wouldn't it be easier to use LOCALIZED_CLASS_NAMES_MALE (and LOCALIZED_CLASS_NAMES_FEMALE) instead of all that custom localizations?
I agree. I looked at other addons and they seemed to have translations for the classes. I will definitely look at making this change soon so don't bother translating yet.
Edit: Why male and female? In non-English is a female druid called something different to a male druid? If so can I just use the male version? Do you have example code using these?
Edit: Will this do?
for eng, loc in next, LOCALIZED_CLASS_NAMES_MALE do
L[eng] = loc
end
for eng, loc in next, LOCALIZED_CLASS_NAMES_FEMALE do
L[eng] = loc
end
Yes non-english does change the text based on the gender. However its only really needed if you try to match the class from an ingame API that only returns the localized name, like the Friend List API.
I've used only the male class names, but in other cultures there are distinct male/female versions of certain words and considering the existence of the two tables I think it's safe to say there are class name differences.
EDIT: Bah. I really should check to see if there are other posts before replying.
RBS isn't tracking the new Thanksgiving buff "Well Fed" from Bountiful Feast correctly. It has 1 more spell power than a Fish Feast, so people with it are getting whisper spam from me.
The food will disappear on Saturday this week. It's not worth fixing RBS for one week IMO.
The solution is to turn off the option "Good food only" or disable well fed buff check and trust everyone. The well fed but slacking buff will show who has the Bountiful Feast well fed.
Thanks for the quick reply. I've been disabling the buff check, but just figured I'd mention it.
I have BugSack installed because I'm trying to figure out another error, and got this RBS error after the server booted a bunch of us while working on heroic Anub 25:
1x <event>ADDON_ACTION_BLOCKED:AddOn 'RaidBuffStatus' tried to call the protected function 'RBSFrame:Show()'.
<in C code>: in function `Show'
Interface\FrameXML\UIParent.lua:1937: in function `ShowUIPanel':
RaidBuffStatus-3.243\Core.lua:1357: in function `ShowReportFrame'
RaidBuffStatus-3.243\Core.lua:3089: in function `?'
CallbackHandler-1.0-5 (Ace3):146: in function <...Ons\Ace3\CallbackHandler-1.0\CallbackHandler-1.0.lua:146>
<string>:"safecall Dispatcher[1]":4: in function <[string "safecall Dispatcher[1]"]:4>
<in C code>: ?
<string>:"safecall Dispatcher[1]":13: in function `?'
CallbackHandler-1.0-5 (Ace3):91: in function `Fire'
AceEvent-3.0-3 (Ace3):120: in function <Ace3\AceEvent-3.0\AceEvent-3.0.lua:119>
Not sure if it's a real bug or just something funky with the server booting us.
That's just RBS trying to open the dashboard when you're in combat. Yes caused by DC and re-logging. I will add some checks to avoid that error. Nothing to worry about though.
The food will disappear on Saturday this week. It's not worth fixing RBS for one week IMO.
<snip>
It'll happen again next year, and the next...why not just fix the issue so it doesn't occur again and prompt other folks to post the same bug report next year? Saying "deal with it" is...meh.
It'll happen again next year, and the next...why not just fix the issue so it doesn't occur again and prompt other folks to post the same bug report next year? Saying "deal with it" is...meh.
Next year it WILL be slacking food because of new food from the expansion.
Rollback Post to RevisionRollBack
To post a comment, please login or register a new account.
Please nooooooo (ooooo).
Indeed.
Actually RBS already automatically detects if it is a pug and if so allows non-assists to spam.
But since I saw the new localization keys for all class names, I'll write it again:
Wouldn't it be easier to use LOCALIZED_CLASS_NAMES_MALE (and LOCALIZED_CLASS_NAMES_FEMALE) instead of all that custom localizations?
Edit: Why male and female? In non-English is a female druid called something different to a male druid? If so can I just use the male version? Do you have example code using these?
Edit: Will this do?
for eng, loc in next, LOCALIZED_CLASS_NAMES_MALE do
L[eng] = loc
end
for eng, loc in next, LOCALIZED_CLASS_NAMES_FEMALE do
L[eng] = loc
end
Still unsure why male and female.
EDIT: Bah. I really should check to see if there are other posts before replying.
The solution is to turn off the option "Good food only" or disable well fed buff check and trust everyone. The well fed but slacking buff will show who has the Bountiful Feast well fed.
I have BugSack installed because I'm trying to figure out another error, and got this RBS error after the server booted a bunch of us while working on heroic Anub 25:
1x <event>ADDON_ACTION_BLOCKED:AddOn 'RaidBuffStatus' tried to call the protected function 'RBSFrame:Show()'.
<in C code>: in function `Show'
Interface\FrameXML\UIParent.lua:1937: in function `ShowUIPanel':
RaidBuffStatus-3.243\Core.lua:1357: in function `ShowReportFrame'
RaidBuffStatus-3.243\Core.lua:3089: in function `?'
CallbackHandler-1.0-5 (Ace3):146: in function <...Ons\Ace3\CallbackHandler-1.0\CallbackHandler-1.0.lua:146>
<string>:"safecall Dispatcher[1]":4: in function <[string "safecall Dispatcher[1]"]:4>
<in C code>: ?
<string>:"safecall Dispatcher[1]":13: in function `?'
CallbackHandler-1.0-5 (Ace3):91: in function `Fire'
AceEvent-3.0-3 (Ace3):120: in function <Ace3\AceEvent-3.0\AceEvent-3.0.lua:119>
Not sure if it's a real bug or just something funky with the server booting us.
It'll happen again next year, and the next...why not just fix the issue so it doesn't occur again and prompt other folks to post the same bug report next year? Saying "deal with it" is...meh.
Next year it WILL be slacking food because of new food from the expansion.