The PUG detection is too picky in my opinion. How many guilds run official guild 25-man raids with more than 2-3 non-guildies? I don't know what the current logic is but I've never been in a PUG in which RBS let me broadcast, there always seems to be one guild with a bunch of members in it and then it refuses to work.
I think I already mentioned that somewhere but I can't find it anymore...
But since I saw the new localization keys for all class names, I'll write it again:
Wouldn't it be easier to use LOCALIZED_CLASS_NAMES_MALE (and LOCALIZED_CLASS_NAMES_FEMALE) instead of all that custom localizations?
Yes non-english does change the text based on the gender. However its only really needed if you try to match the class from an ingame API that only returns the localized name, like the Friend List API.
I've used only the male class names, but in other cultures there are distinct male/female versions of certain words and considering the existence of the two tables I think it's safe to say there are class name differences.
EDIT: Bah. I really should check to see if there are other posts before replying.
Thanks for the quick reply. I've been disabling the buff check, but just figured I'd mention it.
I have BugSack installed because I'm trying to figure out another error, and got this RBS error after the server booted a bunch of us while working on heroic Anub 25:
1x <event>ADDON_ACTION_BLOCKED:AddOn 'RaidBuffStatus' tried to call the protected function 'RBSFrame:Show()'.
<in C code>: in function `Show'
Interface\FrameXML\UIParent.lua:1937: in function `ShowUIPanel':
RaidBuffStatus-3.243\Core.lua:1357: in function `ShowReportFrame'
RaidBuffStatus-3.243\Core.lua:3089: in function `?'
CallbackHandler-1.0-5 (Ace3):146: in function <...Ons\Ace3\CallbackHandler-1.0\CallbackHandler-1.0.lua:146>
<string>:"safecall Dispatcher":4: in function <[string "safecall Dispatcher"]:4>
<in C code>: ?
<string>:"safecall Dispatcher":13: in function `?'
CallbackHandler-1.0-5 (Ace3):91: in function `Fire'
AceEvent-3.0-3 (Ace3):120: in function <Ace3\AceEvent-3.0\AceEvent-3.0.lua:119>
Not sure if it's a real bug or just something funky with the server booting us.