Authors CurseForge

Sometimes it does not switch properly to the settings I have chosen. Have not been able to nail down when it does not work properly though.

Quote from Ammo

oRA3 has it's ML settings in the options menu. And will automatically switch to those settings.

Quote from Dridzt

One difference I noticed (not sure it's a bug or not) is that oRA3 doesn't observe the masterloot and quality option (set from Blizz options) when I convert a party to raid manually. (from the "convert to raid" button of the raid frame)

Shifting the focus to the part you missed.
I know where the option is, the problem is that the addon doesn't always apply it.

I also noticed that it didn't switch to masterloot twice in the last few days. I never had the problem before, so maybe a bug introduced in one of the last few versions?

To get back to the loot settings problem.

In my case it will work every time when someone else forms the raid and promotes me to leader.

It will never work if I form the raid myself.

Yeah I have been finding the same as Dridzt. And it is fairly new behavior.

Loot setting when you're the one forming raid can be fixed by editing line 294 in oRA3.lua (r353) to

elseif oldStatus and groupStatus > oldStatus then

No other changes are needed. (tested)

With this edit oRA3 will change loot properly in 2 out of the 3 possible cases:
1. Player forms raid: OK
2. Player is invited to raid and then promoted to RL: OK
3. Player is invited to raid, promoted to Assistant THEN to RL: not working.

This last test case has to do with how :IsPromoted works.
As it only returns true/false the playerPromoted ~= self:IsPromoted() condition at line 297 (r353) doesn't evaluate true for Assistant->RL promotion so the "OnPromoted" callback doesn't fire.

Anyway that's kinda of a fringe case.
(not so rare though if the initial RL has you in the auto-promote list)

r368 when opening the window:

1x oRA3-367\modules\Tanks.lua:460: attempt to compare number with nil
<in C code>: in function `sort'
oRA3-367\modules\Tanks.lua:474: in function `UpdateBottomScroll'
oRA3-367\modules\Tanks.lua:407: in function `UpdateScrolls'
oRA3-367\modules\Tanks.lua:26: in function `show'
oRA3-367\oRA3.lua:879: in function `SelectPanel'
oRA3-367\oRA3.lua:838: in function <oRA3\oRA3.lua:836>

1x AceHook-3.0-5 (Ace3):180: Attempting to rehook already active hook UseSoulstone.
AceHook-3.0-5 (Ace3):180: in function <Ace3\AceHook-3.0\AceHook-3.0.lua:118>
AceHook-3.0-5 (Ace3):344: in function `SecureHook'
oRA3-369\modules\Cooldowns.lua:905: in function `?'
CallbackHandler-1.0-5 (Ace3):147: in function <...Ons\Ace3\CallbackHandler-1.0\CallbackHandler-1.0.lua:147>
<string>:"safecall Dispatcher[2]":4: in function <[string "safecall Dispatcher[2]"]:4>
<in C code>: ?
<string>:"safecall Dispatcher[2]":13: in function `?'
CallbackHandler-1.0-5 (Ace3):92: in function `Fire'
oRA3-369\oRA3.lua:297: in function `?'
CallbackHandler-1.0-5 (Ace3):147: in function <...Ons\Ace3\CallbackHandler-1.0\CallbackHandler-1.0.lua:147>
<string>:"safecall Dispatcher[1]":4: in function <[string "safecall Dispatcher[1]"]:4>
<in C code>: ?
<string>:"safecall Dispatcher[1]":13: in function `?'
CallbackHandler-1.0-5 (Ace3):92: in function `Fire'
AceEvent-3.0-3 (Ace3):120: in function <Ace3\AceEvent-3.0\AceEvent-3.0.lua:119>

The new solution for the oRA3 frame is nice, but sometimes it doesn't close itself when the Blizzard raid frame is closed:

* If it's closed by keybinding (default "o" if I remember correctly).
* If the user switches tabs in the Blizzard frame (away from raid).
* If the user clicks on the button to open the looking for raid interface.

edit: Thanks for the fixes, works great now.

r416 - button to set Blizz MT's does not work at all. Not clickable.