For example, I have a bar for dead players, but if there are 0 dead players, it would be nice to have an option for the Dead bar to auto hide. Once a player dies, the bar would show. Same for Offline players, or XX Class mana bar if the raid has none of those classes in it, etc etc.
Big update:
- fixed binding header
- tooltips can now be clicked for buffing and can be detached
- improved event processing
- using compost in many places now
- tooltips will now be refreshed with every update
- fixed bug with removing a buff button
- additional to predefined buffs, the user can now enter an own one
- buff icons can now be shift-clicked to print missing buffs
Just fyi ... not sure if you are following the agUF topic
Snurre and me, got strange jumps of the frames with agUF and XRS (when frame was moved and hovering the scaling option of the menu) ... some posts later in the agUF topic I found out that the different viewport I use was the problem. AndreasG changed the the WorldFRame to UIParent in the SavePosition functions - from
local worldscale = WorldFrame:GetEffectiveScale()
local x,y = self.frame:GetLeft()*scale,self.frame:GetTop()*scale - (WorldFrame:GetTop())*worldscale
to
local worldscale = UIParent:GetEffectiveScale()
local x,y = self.frame:GetLeft()*scale,self.frame:GetTop()*scale - (UIParent:GetTop())*worldscale
I just changed WorldFrame to UIParent in your XRS:SavePosition() function and the jumps are gone with XRS too.
I was using CorkFu for quite a while to manage buffs, but XRS seems to do that and more, thanks.
One question...for Group Buffs, would it be possible to cast them if at least 4 people in one group needs the buff, instead of individual buffs as it does now.
Example:
4 people in group 3 need Power Word: Fortitude
XRS casts Prayer of Fortitude on group 3
I thought about this, too. But the user should decide if he wants to cast a group buff or a normal one. I'll think about this tomorrow how to implement this in a good way.
Weird, try deleting your saved var, and create again a bar. Did you have the error before you were localizing the addon? Maybe try that before, so you (and I) know that the locale file isn't corrupt.
Would like to request a different behaviour for buff checks (toggle option)
- Check for existing buffs.
I'd like to make sure we have a soulstone up, or maybe even a Divine Intervention. Would look great with the current tooltip set up, wouldn't mind much not having timer.
I apologise as this might have been mentioned earlier in the thread but I haven't had time to read through it all yet:
I like this addon a lot but using it gives me FPS drops and Increasing Rate spikes when there is lots of data to parse in the combat log (e.g. Essence of the Red, Mass AoE). To give you an idea, with XRS my FPS drops to around 5 when this happens, and my increasing rate shoots up to as much as around 100 KiB/s. Without FPS is around 15-20, increasing rate around 30 at the worst of times.
I tried setting updaterate to 1.5 but it seemed to have no impact on the problem.
I apologise as this might have been mentioned earlier in the thread but I haven't had time to read through it all yet:
I like this addon a lot but using it gives me FPS drops and Increasing Rate spikes when there is lots of data to parse in the combat log (e.g. Essence of the Red, Mass AoE). To give you an idea, with XRS my FPS drops to around 5 when this happens, and my increasing rate shoots up to as much as around 100 KiB/s. Without FPS is around 15-20, increasing rate around 30 at the worst of times.
I tried setting updaterate to 1.5 but it seemed to have no impact on the problem.
Are you really using the latest xrs version? And how many bars and buffs are you showing? And my addon never parses the combat log. I really tried to remove all lag and memory spikes. Further, I am using compost for the tables which are being reused all the time, so there shouldn't be any increasing rate from the memory by this addon (maybe a little ...). As far as my tests are going, the addon has no impact for me with updaterate set to 1s.
Quote from Gregory »
may be include yourself in range bars count ? a bit annoying when it always 1 less then other bars.
But if you know it, why does it bother you? I mean you are always in your range, no matter what, so the bar will never be at 0%.
Quote from shadowmx »
Would like to request a different behaviour for buff checks (toggle option)
- Check for existing buffs.
I'd like to make sure we have a soulstone up, or maybe even a Divine Intervention. Would look great with the current tooltip set up, wouldn't mind much not having timer.
I think I wait till oRA2 is ready and use it then.
Are you really using the latest xrs version? And how many bars and buffs are you showing? And my addon never parses the combat log. I really tried to remove all lag and memory spikes. Further, I am using compost for the tables which are being reused all the time, so there shouldn't be any increasing rate from the memory by this addon (maybe a little ...). As far as my tests are going, the addon has no impact for me with updaterate set to 1s.
I checkedout from the SVN around noon (GMT). I'll give it another run today and will attempt to isolate the problem. I was using about 5 bars I think: Healer Mana (Druid, Priest, Shaman), DPS Mana (Hunter, Mage, Warlock), Melee Health (Rogue, Warrior), Dead Count, Offline Count. I'll delete SavedVars and do a fresh checkout.
I tested on another PC (zhCN client of course), with and without zhCN locale. Clean Addons and WTF folders. The problem has not be solved.
Tested it too with a clean wtf file. No problems at all for me...
The error of XRS.lua:line 482 "self.frame a nil value" pops up every time when I create a new bar or a buff button, and also when I click the dewdrop items of the bars. However, clicking on buff button dewdrop menu item does not trigger this error.
One thing I've noticed: In XRS.lua, the classTable is in this form:
not "DRUID", "druid" or BC"Druid".
In function CreateNewBar() and CreateNewBuffButton(), there are also two "Druid".
After I create a new bar and a buff button, the Saved Variables is like following:
Not 100% certain since I don't use or ever have used it, but I think it is
http://www.curse-gaming.com/en/wow/addons-4351-klhperformancemonitor.html
For example, I have a bar for dead players, but if there are 0 dead players, it would be nice to have an option for the Dead bar to auto hide. Once a player dies, the bar would show. Same for Offline players, or XX Class mana bar if the raid has none of those classes in it, etc etc.
- fixed binding header
- tooltips can now be clicked for buffing and can be detached
- improved event processing
- using compost in many places now
- tooltips will now be refreshed with every update
- fixed bug with removing a buff button
- additional to predefined buffs, the user can now enter an own one
- buff icons can now be shift-clicked to print missing buffs
Snurre and me, got strange jumps of the frames with agUF and XRS (when frame was moved and hovering the scaling option of the menu) ... some posts later in the agUF topic I found out that the different viewport I use was the problem. AndreasG changed the the WorldFRame to UIParent in the SavePosition functions - from
to
I just changed WorldFrame to UIParent in your XRS:SavePosition() function and the jumps are gone with XRS too.
Have to admit that I only copied the saveposition method from aguf when I started writing XRS ;)
One question...for Group Buffs, would it be possible to cast them if at least 4 people in one group needs the buff, instead of individual buffs as it does now.
Example:
4 people in group 3 need Power Word: Fortitude
XRS casts Prayer of Fortitude on group 3
Same goes for GoW, Spirit, AI, etc.
When I create a new bar, an error pop up. After that, when I click any item in the dewdrop menu of the bar, the errors pop up.
And it displays nothing no the bar. (empty bar, only with its name on it)
- Check for existing buffs.
I'd like to make sure we have a soulstone up, or maybe even a Divine Intervention. Would look great with the current tooltip set up, wouldn't mind much not having timer.
I like this addon a lot but using it gives me FPS drops and Increasing Rate spikes when there is lots of data to parse in the combat log (e.g. Essence of the Red, Mass AoE). To give you an idea, with XRS my FPS drops to around 5 when this happens, and my increasing rate shoots up to as much as around 100 KiB/s. Without FPS is around 15-20, increasing rate around 30 at the worst of times.
I tried setting updaterate to 1.5 but it seemed to have no impact on the problem.
Are you really using the latest xrs version? And how many bars and buffs are you showing? And my addon never parses the combat log. I really tried to remove all lag and memory spikes. Further, I am using compost for the tables which are being reused all the time, so there shouldn't be any increasing rate from the memory by this addon (maybe a little ...). As far as my tests are going, the addon has no impact for me with updaterate set to 1s.
But if you know it, why does it bother you? I mean you are always in your range, no matter what, so the bar will never be at 0%.
I think I wait till oRA2 is ready and use it then.
I tested on another PC (zhCN client of course), with and without zhCN locale. Clean Addons and WTF folders. The problem has not be solved.
Tested it too with a clean wtf file. No problems at all for me...
The error of XRS.lua:line 482 "self.frame a nil value" pops up every time when I create a new bar or a buff button, and also when I click the dewdrop items of the bars. However, clicking on buff button dewdrop menu item does not trigger this error.
One thing I've noticed: In XRS.lua, the classTable is in this form:
self.classTable = { "Druid", "Hunter", "Mage", "Paladin", "Priest", "Rogue", "Shaman", "Warlock", "Warrior", }not "DRUID", "druid" or BC"Druid".In function CreateNewBar() and CreateNewBuffButton(), there are also two "Druid".
After I create a new bar and a buff button, the Saved Variables is like following:
["c"] = { [1] = "Druid", [2] = "hunter", [3] = "mage", [4] = "paladin", [5] = "priest", [6] = "rogue", [7] = "warrior", [8] = "warlock",The first line is obviously different.