I didn't want to turn Acheron into some kind of healer assist addon, I just took the silence as an example when knowing about a buff/debuff is helpful to understand someone's death, even when it didn't heal/damage anybody. It might be a nice feature to let the user choose to log all buffs/debuffs or just the important ones (from debuffs.lua).
It's just confusing that when somebody resists a debuff it will show up in the death log, but not when he gets the debuff.
@Menju:
Thanks for the additional debugging data. This is a bug that I and a number of other people have seen, but it's been really hard to nail down exactly what's happening. I'll keep working on it.
Can you elaborate on what you mean by an "empty option" in the drop down menu box?
@fovilitive:
I think we're basically in agreement with each other on what we want the end result of Acheron to be, I just want to be cautious about how we get there. :)
I did some small code hacks to show what idea I was thinking of.
(all edits done in "Acheron.lua")
if eventType == "UNIT_DIED" then
self:HandleDeathEvent(timeStamp, dstGUID)
-- elseif eventType == "SPELL_AURA_APPLIED" or
-- eventType == "SPELL_AURA_REMOVED" or
-- eventType == "SPELL_AURA_APPLIED_DOSE" or
-- eventType == "SPELL_AURA_REMOVED_DOSE"
-- then
-- self:HandleBuffEvent(event, timeStamp, eventType, srcGUID, srcName, srcFlags, dstGUID, dstName, dstFlags, ...)
else
self:HandleHealthEvent(event, timeStamp, eventType, srcGUID, srcName, srcFlags, dstGUID, dstName, dstFlags, ...)
end
elseif suffix == "MISSED" or special == "MISSED" then
missType = select(4, ...)
elseif suffix == "AURA" then
local buffCount = select(5, ...) or 1
amount = 0
source = select(4, ...)
if buffCount ~= 1 then spell = spell.."("..buffCount..")" end
if special == "APPLIED" then
action = " >>> "
elseif special == "REMOVED" then
action = " <<< "
end
end
elseif suffix == "DAMAGE" then
I know it's a bit dirty since it doesn't fit in the design of the event system, but it does its job.
[2008/08/28 22:53:13-5830-x2]: Acheron-1.0\Display.lua:392: attempt to index field '?' (a nil value)
Acheron-1.0\Display.lua:369: in function `Report'
Acheron-1.0\Display.lua:309: in function <Interface\AddOns\Acheron\Display.lua:307>
Is there a command to bring up the Deathreport window like /acheron [playername]? The current way of rightclicking player portraits takes a bit too long for my taste, and i've removed players accidentally from the raid twice now because the Acheron Report is right under ''Remove player from the raid''.
Shinja, when you saw this, did you also see the funky health % numbers like what Menju posted in his screenshot earlier in this thread?
Oh, and what version are you using?
I also had the funny health % today, using latest r80961. When moving my mouse over the entries, it would show people with "0/0 (2^-31%)" health. So the wrong entry seems to be the result of a division by zero (0 div 0). I only had this kind of entries on raid members who where very far away from me (possibly > 40m, Archimonde battle). The raid mebers near me had their normal health displayed. It might be a problem with the range of the combat log.
Yes, knowing if buffs like Shield Block gains/fades are useful, and some debuffs from bosses and their stacks (some of this is already in for specific bosses).
All people who want to see aura gains/fades (including stacks) can edit Acheron with the small patches I posted here, until it's officially implemented in Acheron.
It will also display an aura break/refresh, but since it only was a quick hack, I didn't filter them out. I didn't change the code much, so it should work fine for everybody. It has been working fine for me in the last two weeks in MH/BT raids.
Checked in the following improvements:
- fixed bug with crazy health numbers being displayed when raid members are out of range for health readings (0/0 bug). If no health is available, Acheron will just display "--"
- hopefully finally fixed bug with nil entry on reporting
- added support for LibQuickHealth for more accurate health readings
- access to the main UI has changed significantly. Instead of right-clicking on a unit frame to get a report option, you can now access all reports via '/acheron show'. Any available names can be selected from a drop-down menu.
- added quick-launch support for LibDataBroker for viewing reports as well
Next up on the list of things to do
- come up with a good system for configurable, extensible buff/debuff tracking and display
- display timeline-style list of death reports, per combat rather than per player
[2008/09/05 15:24:18-800-x1]: Acheron-1.0\Acheron.lua:33: Cannot find a library instance of "LibQuickHealth-1.0".
Ace2\AceLibrary\AceLibrary.lua:49: in function `LibStub'
Acheron-1.0\Acheron.lua:33: in main chunk
---
Running disembedded, and i have LibQuickHealth installed.
Hrm, just from taking a look at the code in the repository, I can't see anything wrong that would cause that. Is anyone else having that problem? I'll test it out with a fresh install of the addon when I get home from work.
- come up with a good system for configurable, extensible buff/debuff tracking and display
I think the simplest (and most user-friendly) way to go about this would be to provide two options:
- blacklist mode would show all aura events by default, and users could blacklist specific debuffs they don't want to see.
- whitelist mode would show no aura events by default, and users could whitelist specific debuffs they do want to see.
Rollback Post to RevisionRollBack
To post a comment, please login or register a new account.
That would be just bad luck.
I didn't want to turn Acheron into some kind of healer assist addon, I just took the silence as an example when knowing about a buff/debuff is helpful to understand someone's death, even when it didn't heal/damage anybody. It might be a nice feature to let the user choose to log all buffs/debuffs or just the important ones (from debuffs.lua).
It's just confusing that when somebody resists a debuff it will show up in the death log, but not when he gets the debuff.
Thanks for the additional debugging data. This is a bug that I and a number of other people have seen, but it's been really hard to nail down exactly what's happening. I'll keep working on it.
Can you elaborate on what you mean by an "empty option" in the drop down menu box?
@fovilitive:
I think we're basically in agreement with each other on what we want the end result of Acheron to be, I just want to be cautious about how we get there. :)
(all edits done in "Acheron.lua")
I know it's a bit dirty since it doesn't fit in the design of the event system, but it does its job.
[2008/08/28 22:53:13-5830-x2]: Acheron-1.0\Display.lua:392: attempt to index field '?' (a nil value)
Acheron-1.0\Display.lua:369: in function `Report'
Acheron-1.0\Display.lua:309: in function <Interface\AddOns\Acheron\Display.lua:307>
---
Oh, and what version are you using?
Yes, i've also 2^31-1 % in report and I'm using the latest version ( r80961 )
I also had the funny health % today, using latest r80961. When moving my mouse over the entries, it would show people with "0/0 (2^-31%)" health. So the wrong entry seems to be the result of a division by zero (0 div 0). I only had this kind of entries on raid members who where very far away from me (possibly > 40m, Archimonde battle). The raid mebers near me had their normal health displayed. It might be a problem with the range of the combat log.
I think you may be on to something there. I'll see if I can't play with it some more tomorrow.
@Shinja:
That's been a common request and definitely something I'll be adding at some point.
It will also display an aura break/refresh, but since it only was a quick hack, I didn't filter them out. I didn't change the code much, so it should work fine for everybody. It has been working fine for me in the last two weeks in MH/BT raids.
- fixed bug with crazy health numbers being displayed when raid members are out of range for health readings (0/0 bug). If no health is available, Acheron will just display "--"
- hopefully finally fixed bug with nil entry on reporting
- added support for LibQuickHealth for more accurate health readings
- access to the main UI has changed significantly. Instead of right-clicking on a unit frame to get a report option, you can now access all reports via '/acheron show'. Any available names can be selected from a drop-down menu.
- added quick-launch support for LibDataBroker for viewing reports as well
Next up on the list of things to do
- come up with a good system for configurable, extensible buff/debuff tracking and display
- display timeline-style list of death reports, per combat rather than per player
Ace2\AceLibrary\AceLibrary.lua:49: in function `LibStub'
Acheron-1.0\Acheron.lua:33: in main chunk
---
Running disembedded, and i have LibQuickHealth installed.
I do not get any error messages with my LibQuickHealth with my Pitbull.
I think the simplest (and most user-friendly) way to go about this would be to provide two options:
- blacklist mode would show all aura events by default, and users could blacklist specific debuffs they don't want to see.
- whitelist mode would show no aura events by default, and users could whitelist specific debuffs they do want to see.