Forgot to add the return if not deDE line to the file b00gy gave me, my bad. I'll get a fix checked in tonight when I get home from work and have access to the SVN again.
One more conceptual question.
Between mods like Acheron and Recount, do both actually have to do the same "amount" of combatlog parsing? Or can a mod like Acheron specifically "hook" only the damage-taken/healing-taken/death messages?
I am trying to decide which mod to use for deathlogs, and I like Acheron a lot, but I'd also sometimes want a damage-mod simply because being the raidleader it's nice to see how someone casted if they ask whether they're doing well.
But OTOH, I fear the raw CPU-usage Recount would cause :s
Both use the COMBATLOG_EVENT_UNFILTERED event... but beyond that, without looking at the code, I'd say that Acheron probably only looks for certain events related to stuff it displays, and records a few things about each event. Recount does much more with each event, and stores much more in order to be able to show you all of the information it does.
If you simply want a basic "damage meter" without all the in-depth stuff Recount does, you might check out Violation.
I have the same dilemma, the only reason i use Recount over Violation is that Violation cannot have 2 separate windows showing total damage and damage done last fight. I would be forever grateful if someone wrote a plugin for Violation to have that feature.
To answer the original question, Phanx is right. Acheron has to examine every COMBATLOG_EVENT_UNFILTERED, but it filters out only those events that involve data relevant to what Acheron displays. Hopefully that renders it relatively light weight.
FWIW, I run both Acheron and Recount without any performance issues.
I didn't know Recount could do that either... I've only been using it since 2.4 rendered my beloved Assessment inoperable. :(
Recount doesn't have 2 windows, but you can switch to ''Current fight'' easily, and you can switch back to overall data. Anyway, Acheron is working great so far, got it set to keep track of the last 3 deaths of each player and it's running at around ~1.5mb. Not tried it together with Recount yet though, i guess the average increasing rate will be a bit higher with both addons running, but that's not a major issue.
I was going to post a report to our class leads channel last night and realized that it wasn't in the dropdown. It seems that the channel dropdown doesn't pick up all of the channels I'm in for some reason.
I was going to post a report to our class leads channel last night and realized that it wasn't in the dropdown. It seems that the channel dropdown doesn't pick up all of the channels I'm in for some reason.
Was it a channel with a num < 5 perchance? Acheron only grabs the channels > 4, but maybe there's a better way to do that.
Quote from Skylinee »
[2008/08/04 23:26:13-789-x6]: Acheron-1.0\Display.lua:270: attempt to index field 'entry' (a nil value)
Can't really remember what i was doing when i got this error.
I've seen this one come up for me as well, once or twice, but I can never figure out the circumstance or reproduce it. If anyone else sees this happen and can recall exactly what was going on when it happened, please let me know.
FYI, I'm on vacation atm and the internet connection where I'm at suuuuu-uuucks. So I won't be having any updates on Acheron until the end of the week.
I've seen this one come up for me as well, once or twice, but I can never figure out the circumstance or reproduce it. If anyone else sees this happen and can recall exactly what was going on when it happened, please let me know.
I was messing around in the Recount GUI seconds before the error popped, very doubtful it has anything to do with it though. It was OOC (Out of Combat) aswell.
I have the same dilemma, the only reason i use Recount over Violation is that Violation cannot have 2 separate windows showing total damage and damage done last fight. I would be forever grateful if someone wrote a plugin for Violation to have that feature.
I know this is the wrong thread, but afaik this cannot be done in Violation since it only tracks one set of data (from last reset). Thus you EITHER do a reset every fight OR just reset at the beginning of the raid.
[2008/08/15 20:54:12-154-x1]: Acheron-1.0\Display.lua:384: attempt to index field '?' (a nil value)
Acheron-1.0\Display.lua:361: in function `Report'
Acheron-1.0\Display.lua:301: in function <Interface\AddOns\Acheron\Display.lua:299>
---
with the latest version.
Between mods like Acheron and Recount, do both actually have to do the same "amount" of combatlog parsing? Or can a mod like Acheron specifically "hook" only the damage-taken/healing-taken/death messages?
I am trying to decide which mod to use for deathlogs, and I like Acheron a lot, but I'd also sometimes want a damage-mod simply because being the raidleader it's nice to see how someone casted if they ask whether they're doing well.
But OTOH, I fear the raw CPU-usage Recount would cause :s
If you simply want a basic "damage meter" without all the in-depth stuff Recount does, you might check out Violation.
FWIW, I run both Acheron and Recount without any performance issues.
Recount doesn't have 2 windows, but you can switch to ''Current fight'' easily, and you can switch back to overall data. Anyway, Acheron is working great so far, got it set to keep track of the last 3 deaths of each player and it's running at around ~1.5mb. Not tried it together with Recount yet though, i guess the average increasing rate will be a bit higher with both addons running, but that's not a major issue.
---
Can't really remember what i was doing when i got this error.
Was it a channel with a num < 5 perchance? Acheron only grabs the channels > 4, but maybe there's a better way to do that.
I've seen this one come up for me as well, once or twice, but I can never figure out the circumstance or reproduce it. If anyone else sees this happen and can recall exactly what was going on when it happened, please let me know.
FYI, I'm on vacation atm and the internet connection where I'm at suuuuu-uuucks. So I won't be having any updates on Acheron until the end of the week.
Now that you mention it, it may have been channel #4.
I was messing around in the Recount GUI seconds before the error popped, very doubtful it has anything to do with it though. It was OOC (Out of Combat) aswell.
I know this is the wrong thread, but afaik this cannot be done in Violation since it only tracks one set of data (from last reset). Thus you EITHER do a reset every fight OR just reset at the beginning of the raid.
Acheron-1.0\Display.lua:361: in function `Report'
Acheron-1.0\Display.lua:301: in function <Interface\AddOns\Acheron\Display.lua:299>
Just trying to report to raid
By the way, I'm still planning to do a revamp of the UI to make it a little more user friendly. But the beta has been... a little distracting. ;)