Does it ever start behaving (presumably after you've hit Clear All) and then start misbehaving again later? Or does Clear All fix things for the rest of your session?
I've been seeing some odd issues lately with the health display in Acheron... guessing it may be related to the "Unknown" issue. Clear All doesn't necessarily fix the issue... it seems totally random. I'll log in and it will be fine. At some point, I'll look at someone and it'll be messed up. Whether or not I clear it, if I look some time later, it might be working properly again. Here are screenshots of both relative and absolute health:
Curiouser and curiouser. Aside from seeing the 'Unknown' issue one time on the first night after 3.1, I haven't had any of these issues myself (and I've been raiding 10 or 25 man every single night) so it makes it difficult to reproduce and diagnose. But clearly something is going awry with Acheron. I will dig in to it this week and see if I can't figure out what's going on.
Does it ever start behaving (presumably after you've hit Clear All) and then start misbehaving again later? Or does Clear All fix things for the rest of your session?
I'm pretty sure that it works fine after the Clear All.
Sometimes Clear All fixes it, sometimes not. (Which I guess is different, and yet indistinguishable, from "it fixes it but sometimes it immediately breaks again".)
Here's a local change I made a couple weeks ago that might be of interest.
Currently, if you get disconnected in the middle of a raid (or just have to relog), then when you log back in, Acheron will do its 'Clear All' routine. (That's including whether the user has clear-on-join enabled, including prompting, etc.) While it makes perfect sense to do this when forming up a group, it wasn't clear to me that clearing when relogging during a raid was a good thing. If there's a weird bug where I need to clear the entries, then I'll just click Clear All, not relog. If I'm relogging or getting disconnected, then clearing the death reports is not on my mind.
Anyhow, the patch is self-explanatory, figured I'd toss it out for the search engines to munch over.
--- Acheron.lua.orig 2009-03-19 23:32:54.475875000 -0400
+++ Acheron.lua 2009-04-18 21:16:57.749625000 -0400
@@ -334,7 +334,7 @@
end
-- change grouping status
- if (GetNumPartyMembers() > 0 or GetNumRaidMembers() > 0) and self.solo == "yes" and self:GetProfileParam("clearongroup") then
+ if (GetNumPartyMembers() > 0 or GetNumRaidMembers() > 0) and self.solo == "yes" and self:GetProfileParam("clearongroup") and (not IsInInstance()) then
self.solo = "no"
if Acheron:GetProfileParam("confirmclear") then
StaticPopup_Show("ACHERON_CLEAR_ALL")
I'm seeing the Unknown issue in the raid I'm in right now. When I look at the death report and look at the tooltip for an individual line item from each one, it's all for the same guy and that guy happens to have a weird character in his name. (It's also a guy who hasn't been in our raid in a while so that could be why I wasn't seeing it before). Maybe I'm reaching, but can anyone else who's experiencing the issue corroborate a pattern there?
I'm seeing the Unknown issue in the raid I'm in right now. When I look at the death report and look at the tooltip for an individual line item from each one, it's all for the same guy and that guy happens to have a weird character in his name. (It's also a guy who hasn't been in our raid in a while so that could be why I wasn't seeing it before). Maybe I'm reaching, but can anyone else who's experiencing the issue corroborate a pattern there?
Nope, the guy whose report screenshots I posted was "Picturesque". Nothing weird in his name.
<event>ADDON_ACTION_BLOCKED:AddOn 'Acheron' tried to call the protected function 'LootSlot()'.
<in C code>: in function `LootSlot'
Interface\FrameXML\LootFrame.lua:191: in function `LootButton_OnClick':
<string>:"*:OnClick":4: in function <[string "*:OnClick"]:1>
Shadoweric, Acheron does not ever call the function LootSlot; you can verify this yourself by searching its files. This is yet another downside of embedded libraries... all taint issues caused by all addons using libraries are attributed to whichever addon's copy of the library loaded first. In this case, Acheron loads first since it comes early in the alphabet, and some other addon using one of the libraries it embeds (most likely AceAddon-3.0) is trying to call LootSlot. If you disabled Acheron, you'd still get the same "error" message, with another addon blamed. If you have something that lets you search the contents of files on your hard disk, search for "LootSlot". If you don't, look through your addon list and take a guess at which one(s) might be trying to do stuff with looting; chances are one of them is the problem.
Well that's interesting. I have no addon that uses LootSlot. And yes, I have my entire addon folder indexed by Windows for cases like this, so it should show if an addon uses this. So where is this coming from?
Sorry about not checking whether it was Acheron or not. I usually do.
Well, it's even more interesting because LootSlot is not actually a protected function. ;)
Blizzard's way of determining where taint comes from, or even what is tainted, is pretty worthless. If nothing is actually happening that interferes with your gameplay, or that you can even tell is happening (or not happening, as the case may be) I'd really just ignore the warning. If you notice the warning being triggered consistently when you perform a certain action, try to figure out which addon is involved in that action. Then, disable that addon and perform the action, and see if the warning is triggered. If it isn't, then you were right about the cause, and should report the problem to that addon's author.
Made a slight change to the way the raid is scanned in the latest beta release, hopefully that'll stop the stupid Unknown thing. Let me know if any issues persist.
Would it be possible to sort the names in the dropdown alphabetically? I have a heck of a time trying to find a specific person in the dropdown when I'm trying to isolate their individual death reports.
Would it be possible to sort the names in the dropdown alphabetically? I have a heck of a time trying to find a specific person in the dropdown when I'm trying to isolate their individual death reports.
Heh. Great minds think alike -- and so do ours! I had planned on hacking this out and then posting another "here's a local change" post with a diff.
It turns out this is remarkably hard to do without making either: (1) some code changes outside of Acheron, or (2) seriously invasive code changes within Acheron. I didn't feel I was in a position to do either.
The dropdown sorting is controlled by AceGUI, which accepts a table to populate the dropdown. The table under consideration is a mapping of GUIDs to names. AceGUI sorts by the keys and then displays the names. So the list you see when clicking on the Acheron dropdown appears unsorted, but is actually sorted by GUID... which themselves are vaguely sorted by character creation date.
Sorting by table values has some well-known approaches (link for simple starting point) but would require more functionality out of AceGUI's :SetList(). It could also be done by changing how the Acheron:GetAvailableReports() table is built, but that gets used everywhere.
Also, the report funciton is a bit off, It reports the wrong line when I alt-left-click.
Does it ever start behaving (presumably after you've hit Clear All) and then start misbehaving again later? Or does Clear All fix things for the rest of your session?
http://www.hdimage.org/viewer.php?file=7da7fj2061nsn15c11k9_acheronabsolute.jpg
http://www.hdimage.org/viewer.php?file=c478lvf9hjiz6miw40ox_acheronpercent.jpg
I'm pretty sure that it works fine after the Clear All.
-
View User Profile
-
View Posts
-
Send Message
Curse Premium-
View User Profile
-
View Posts
-
Send Message
Curse PremiumCurrently, if you get disconnected in the middle of a raid (or just have to relog), then when you log back in, Acheron will do its 'Clear All' routine. (That's including whether the user has clear-on-join enabled, including prompting, etc.) While it makes perfect sense to do this when forming up a group, it wasn't clear to me that clearing when relogging during a raid was a good thing. If there's a weird bug where I need to clear the entries, then I'll just click Clear All, not relog. If I'm relogging or getting disconnected, then clearing the death reports is not on my mind.
Anyhow, the patch is self-explanatory, figured I'd toss it out for the search engines to munch over.
--- Acheron.lua.orig 2009-03-19 23:32:54.475875000 -0400 +++ Acheron.lua 2009-04-18 21:16:57.749625000 -0400 @@ -334,7 +334,7 @@ end -- change grouping status - if (GetNumPartyMembers() > 0 or GetNumRaidMembers() > 0) and self.solo == "yes" and self:GetProfileParam("clearongroup") then + if (GetNumPartyMembers() > 0 or GetNumRaidMembers() > 0) and self.solo == "yes" and self:GetProfileParam("clearongroup") and (not IsInInstance()) then self.solo = "no" if Acheron:GetProfileParam("confirmclear") then StaticPopup_Show("ACHERON_CLEAR_ALL")Nope, the guy whose report screenshots I posted was "Picturesque". Nothing weird in his name.
Using v1.1.8.
Sorry about not checking whether it was Acheron or not. I usually do.
Blizzard's way of determining where taint comes from, or even what is tainted, is pretty worthless. If nothing is actually happening that interferes with your gameplay, or that you can even tell is happening (or not happening, as the case may be) I'd really just ignore the warning. If you notice the warning being triggered consistently when you perform a certain action, try to figure out which addon is involved in that action. Then, disable that addon and perform the action, and see if the warning is triggered. If it isn't, then you were right about the cause, and should report the problem to that addon's author.
-
View User Profile
-
View Posts
-
Send Message
Curse PremiumHeh. Great minds think alike -- and so do ours! I had planned on hacking this out and then posting another "here's a local change" post with a diff.
It turns out this is remarkably hard to do without making either: (1) some code changes outside of Acheron, or (2) seriously invasive code changes within Acheron. I didn't feel I was in a position to do either.
The dropdown sorting is controlled by AceGUI, which accepts a table to populate the dropdown. The table under consideration is a mapping of GUIDs to names. AceGUI sorts by the keys and then displays the names. So the list you see when clicking on the Acheron dropdown appears unsorted, but is actually sorted by GUID... which themselves are vaguely sorted by character creation date.
Sorting by table values has some well-known approaches (link for simple starting point) but would require more functionality out of AceGUI's :SetList(). It could also be done by changing how the Acheron:GetAvailableReports() table is built, but that gets used everywhere.
Maybe I'm misreading it, but I read that to be that it should in fact sort by the values (I realize that it's not, though).
Edit: oh, nevermind, I see what's going on there.