Authors CurseForge

oRA2 need to have Wild Thornroot switched with Wild Quillvine

It will do so when CTRA does.

Quote from sanemadman »

Is oRA2 updating the Blizzard Standard UI MainTanks/MainAssists aswell when setting Maintanks?

Nope.

-Ammo

i think CTRA is dead.

Hi !

I wanted to enhance the cooldown module of oRa2.
It wanted to achieve two things:
a) Innervate should be shown
b) The name of the spell on cooldown should be shown.

I also looked at candybar and CTRA, and tried to maintain compatibility with other/older clients.
Since I am not able to promote and test my changes, it's drycode only atm.
Nevertheless I want to post it here, perhaps the developers can implement it to the next version.
I have no SVN so I choose the forum to publish it, I know thats not very elegant.

changes in Participant.lua:
change 1: (this sends the spellname instead of a number for those cooldowns that only oRa2 uses.)
(it also adds Innervate to the list of monitored spells)

function mod:UNIT_SPELLCAST_SUCCEEDED( unit, spell, rank )
	if spell == BS["Rebirth"] then
		oRA:SendMessage("CD 1 30")
	elseif spell == BS["Soulstone Resurrection"] then
		oRA:SendMessage("CD 3 30")
	elseif spell == BS["Divine Intervention"] then
		oRA:SendMessage("CD " .. BS["Divine Intervention"] .. " 60", true) -- only oRA2 clients will react to this cooldown
	elseif spell == BS["Innervate"] then
		oRA:SendMessage("CD " .. BS["Innervate"] .. " 6", true) -- only oRA2 clients will react to this cooldown
	end
	-- call for resurrection check
	self:SpellStopped( unit )
end

changes in CoolDown.lua:
change 2: (this changes the 'CTRA-number' back to a spellname)

function mod:oRA_CoolDown(msg, author)
	local spellname, length = select(3, msg:find("^CD (%d+) (%d+)"))
	if ( spellname == 1 ) then
	  spellname = BS["Rebirth"];
	elseif ( spellname == 2 ) then
	  spellname = BS["Reincarnation"];
	elseif ( spellname == 3 ) then
	  spellname = BS["Soulstone Resurrection"];
	end
	if author and spellname and tonumber(length) then
		self.db.realm.cooldowns[author] = time() + tonumber(length)*60
		self:StartCoolDown( author .. " " .. spellname, tonumber(length)*60)
	end
end

change3: (this starts candybar with "player spellname" as text instead of "player" only)

function mod:StartCoolDown( player_spell, time )
	if not self.enabled or self.db.profile.hidden then return end
	local player, spellname = string.find(player_spell, "(%d+) (%d+)");
	local unit = roster:GetUnitObjectFromName( player )
	if not unit then return end
	local id = "oRAOCoolDown " .. player_spell

	self:RegisterCandyBarGroup("oRAOCoolDownGroup")
	self:SetCandyBarGroupPoint("oRAOCoolDownGroup", "TOP", self.frame.title, "BOTTOM", 0, -5 )
	self:SetCandyBarOnSizeGroup("oRAOCoolDownGroup", self.OnSizeGroup, self)
	self:RegisterCandyBar( id, time, player_spell, nil, unit.class)
	self:RegisterCandyBarWithGroup( id, "oRAOCoolDownGroup")
	self:SetCandyBarWidth( id, 150)
	self:SetCandyBarTexture( id, SM:Fetch('statusbar', oRA.db.profile.bartexture))
	self:SetCandyBarScale( id, self.db.profile.scale or 1)
	self:StartCandyBar( id, true)
end

All codes replaces the existing functions ;)

Please have a look at it, and implement it if possible.

Additionally, you could make a menu where users could add other spells that should be monitored :)

best regards
tayedaen

well apparently the devs of CTRA are working on CTRA2 but as there is only 1-2 people working on it, it may be some time before it comes out, so the reply of "I will do so when CTRA does." probably means never.it also sounds very childish

well as there has been no announcement of a update for CT_RA or as to the current progress of CT_RA2 i think its a good assumption that neither will be out any time soon if they even come out at all.

At risk of inciting jihad, is there any merit to an compatibility layer similar to what Threat is forced into?

Check the raid group on player enter/leave, if you need to chat CTRA, chat it, otherwise go native. Native clients see what they can, everyone else gets to use whatever functionality might be possible if ORA was developed in a vacuum without knowledge of CTRA.

I agree, CTRA compatibility should not be a limiting factor in the development and improvement of oRA. Neither should it be abandoned. Putting it in a separate module, say oRA2_compat_CTRA, would maintain CTRA compatibility (along with old versions of oRA2 for when people don't update). And what about oRA2_compat_RDX etc. to work with other raid mods? (And while I think of it, BigWigs_compat_DBM?)

More cooldowns have been asked numerous times, and while I agree that the reagent for druids should be updated. Heck I might do that. The cooldowns is just meh. The cooldown monitor is there for long important cooldowns, soulstones, combatres, ankh and divine intervention. Adding 6 second cooldowns to that (innervate) is silly.

As for CTRA compat and oRA only stuff. That is already being done for divine intervention which is an oRA only cooldown. However, I do not intend to bloat oRA. I'm still working on cleaning it up more with regards to the maintanks/playertargets. After that cleanup is done a blizzard maintank/mainassist module will be a matter of maybe 20 lines of code.

oRA development is not halted, stopped or anything. But it's my addon (for the most part), which makes me get a final say in what gets in or not. I listen to suggestions, and when I feel they're good enough they get in.

-Ammo

Quote from Funkydude »

Quote from Terefen »

BigWigs_compat_DBM

BW was never designed to spoof DBM, its a mod of its own and always will be.

..and will it cease to be a mod of it's own if it gains the ability to talk with DBM?

Since Innervate is on a 6 minutes cooldown, I often need to know if it's available if I am raid leader, because we only give them away on order ;)

But even if you do not implement Innervate please have a look at the other changes that allow to display the spellname.

I know it's your addon, and I really appreciate your work. It's a great addon!
I just think the additional display of spellnames would be really great, and the added Innervate would not be too much bloat ;)
So please reconsider the submitted patch.

best regards
tayedaen