I think Farmbuyer may be suggesting that BigBrother is currently checking for SPELL_AURA_REMOVED on both of those spells and that that may be incorrect behavior.
Yes, I know. He presented it in such a way that it sounded like he was going to modify the addon himself. So, Farmbuyer, in your next commit, I'd suggest moving repentance to BREAK and disabling REMOVED entirely.
Now I see what you mean, was confused by wording. Thanks for the pointer!
I have no commit privs to anything on wowace, I won't be doing any checkins myself. If the project's been abandoned by whoever the author(s) is/are, I'll just make local copies and distribute changed versions to the other raiders in my guild, same as with most addons. :-)
Actually, I forgot to point this out a couple weeks ago when chatting above. The pseudocode I posted:
if event == SPELL_AURA_BROKEN then
...
elseif event == SPELL_AURA_BROKEN_SPELL then
...
elseif event == SPELL_AURA_REMOVED and (it's a Hex or Repentance) then
"[effect] on [mob] removed by [shaman or paladin originally casting]"
end
uses exactly those conditionals, i.e., the two _BROKEN checks do not also check a spell ID. The special checks for Hex/Repentance are only on _REMOVED.
Also, the checks are done in the order shown. Maybe I didn't make that clear before. So, if Repentance is supposed to be triggering either of the BROKEN events, well, it ain't.
(Coming back to this now because I'm trying to add some unrelated checks to other code, and seeing this block of code reminded me.)
-
View User Profile
-
View Posts
-
Send Message
Curse PremiumI have no commit privs to anything on wowace, I won't be doing any checkins myself. If the project's been abandoned by whoever the author(s) is/are, I'll just make local copies and distribute changed versions to the other raiders in my guild, same as with most addons. :-)
-
View User Profile
-
View Posts
-
Send Message
Curse Premiumuses exactly those conditionals, i.e., the two _BROKEN checks do not also check a spell ID. The special checks for Hex/Repentance are only on _REMOVED.
Also, the checks are done in the order shown. Maybe I didn't make that clear before. So, if Repentance is supposed to be triggering either of the BROKEN events, well, it ain't.
(Coming back to this now because I'm trying to add some unrelated checks to other code, and seeing this block of code reminded me.)
Edit: Seems there's something wrong with my combat log.