Authors CurseForge

i look at the Files:

there are changes in the "Thread-2.0.lua" and "ThreadClassModuleCore.lua" now we must find the exact changes in the files.

A nice site :D

here we have our problem:

-- This catches heals/energizes from totems -> players, before the totems are friendly. Prevent them from being put into the threat table.
if eventtype == "SPELL_PERIODIC_HEAL" or eventtype == "SPELL_PERIODIC_ENERGIZE" and srcFlags == FAKE_HOSTILE then return end

its from the "ThreatClassModuleCore.lua"

I dont understand it realy but i think it "kill" all "SPELL_PERIODIC_HEAL" Events (like Health funnel) if Hostile is fake? Or so, whatever this is the problem.

Yes that was the Error.

Changed the lines in the Newest Version (73144) from

-- This catches heals/energizes from totems -> players, before the totems are friendly. Prevent them from being put into the threat table.
if eventtype == "SPELL_PERIODIC_HEAL" or eventtype == "SPELL_PERIODIC_ENERGIZE" and srcFlags == FAKE_HOSTILE then return end

to

-- This catches heals/energizes from totems -> players, before the totems are friendly. Prevent them from being put into the threat table.
-- if eventtype == "SPELL_PERIODIC_HEAL" or eventtype == "SPELL_PERIODIC_ENERGIZE" and srcFlags == FAKE_HOSTILE then return end

and now its works again :D now i simple but in our new Onyxia Module and then i can show how accurate the Thread is ^^

it work, it work!

The Thread look Accurate so at moment all Problems solved.

big thx to yoshimo

Why do you keep typing "thread" instead of "threat"? The first time I thought it was just a mistake, but you've done it in like 5 posts now... :P

hm good question... :P

I attached the Working Onyxia Module. But i can only verify Phase 1.

Also there was a change for a Problem with Totems or so, but this breaks the Threat of "Health funnel" so i simply delete/out commend the Line 532 in the "ThreatClassModuleCore.lua"

	-- This catches heals/energizes from totems -> players, before the totems are friendly. Prevent them from being put into the threat table.
	-- if eventtype == "SPELL_PERIODIC_HEAL" or eventtype == "SPELL_PERIODIC_ENERGIZE" and srcFlags == FAKE_HOSTILE then return end

The change was made here (line 531-533): http://fish.wowace.com/browse/WowAce/trunk/Threat-2.0/Threat-2.0/ThreatClassModuleCore.lua?r1=70955&r2=70991

sry 4 xposting, but just found this thread


I would like to propose a "small" new feature here.

Something like "Warn me if my next three Attacks will definitely draw Aggro if I don't stop doing damge right now"

Some will say, "well thats implemented, adjust the alertlevel", hm no, that is not what I want, the problem is. I set this to "warn me at 90%", and the Bossfight starts, I as a warlock cast a spell, it hits critical, and i see the Warning "over 90% aggro". so i stop dealing damage, soon as I am below 90% I cast again and crit again, resulting in drawing Aggro.

If I could be warned, that I will (if i crit) draw aggro, this would be much more efficient for me, because later in the Bossfight i can and will go up to 120% Aggro to maximize DPS. And beeing in the 120% Area I still have enough Aggro between myself and "130%" to cast right away.

So me as a shadowbolt spamming lock i can crit up to 10k per shadowbolt, and I want to be notified in time, so I say letzt alert me 3 bolts bevore i draw aggro, so this is 10k x 3 Bolts = 30k Aggro "reserve"

This is the reason why I would like something like, the next three casts - assumed the hit critical, we'll end up with 30k Aggro, so to test it i wanted to set it to .. "warn me if I have only 30k Aggro left bevore i will draw aggro" , I had a glimpse in the code and did this:

 if selfThreat+30000 > aggroThreat and not self.warned and aggroGUID and playerGUID ~= aggroGUID and aggroThreat > 5 then
 -- if pct > WarningThreshold and not self.warned and aggroGUID and playerGUID ~= aggroGUID and aggroThreat > 5 then

[SingleTarget.lua:814]

Going the long way here, one has to build a configurable value into the gui and has to make the test here work for both cases, and aditionally add another option to only alert with this mechanic, i the Target ha Aggro over 30k at all.


So basically
- "notify me when I will draw Aggro in 5 sec if I keep doing Damage at my current APS"

can be easier implemented, by doing:

- "notify me when i Have only 20k Aggro left to draw Aggro"

and is superior to the current implementation:

- "notify me when i reach 90% of Tank's aggro"


Maybe this is a nice Idea for the masses ?

Comments ?

and yes I know I am just looking from a warlock perspective here (first) .-)

Don't cross-post.

I'm actually going to lock this thread, and point posters to the thread entitled "Omen2" in an effort to keep discussion in one place:

http://www.wowace.com/forums/index.php?topic=12127.0