Authors CurseForge

Quote from HunterZ »

vi is horrible. We have mice, arrow keys, and Alt keys in the 21st century!

HJKL and keys > mouse + arrows, its much faster once you learn it.

Hello, again to Onyxia.

Since Thread 2.0 Omen doesn?t count the Knock away from her (and the Thread reduce with this).

Also Thread 1.0 and 2.0 coutn all knock aways with 50% hate reduce, but this isnt right for Onyxia, there it is 25% so i tryed to change in the "ThreadNPCModuleCore.lua"

local halveThreat = function(mob, target) ModifyThreat(mob, target, 0.5, 0) end
local threatHalveSpellIDs = {
	-- Wing Buffet
	18500, 23339, 29905, 37157, 37319, 41572, 32914, 38110, 31475, 38593,
	
	-- Knock Away
	21737, 40434, 37102, 32959, 31389, 25778, 23382, 19633, 18945, 18813, 18670, 10101
}

to

local halveThreat = function(mob, target) ModifyThreat(mob, target, 0.75, 0) end
local threatHalveSpellIDs = {
	-- Wing Buffet
	
	
	-- Knock Away
	19633, 18945, 18813, 18670, 10101, 11130, 20686, 36512, 21737, 40434, 37102, 32959, 31389, 25778, 23382
}

First changed the 0.5 to 0.75 special for Onyxia and deleted all "Wing Buffed" Spellid, because Onyxias one doesnt reduce hate.

Also i added all "Knock Away" Spellids i found, and Allakhazam say Onyxia?s one is 19633
http://wow.allakhazam.com/db/mob.html?wmob=10184 -> http://wow.allakhazam.com/db/spell.html?wspell=19633

but like before... nothing happen, Omen just dont count the Knock aways and so the Thread is very incorrect.

Someone an Idea WHY Omen dont count this?

Also i Use German Client, maybe there is the Problem? Says the Combatlog Omen direct wich spellid or the Name and there is somewhere an Translation to spellid or so?

/Edit: And btw, i use Felguard to Tank Onyxia, so the Threadreduce doesnt goes to me, but to my Pet in Thread1.0 this was ok, but maybe there is an Problem with the Petthread in 2.0?

Please Help me :/

Dead

Thanks ^^ i will try the Next days, but how i can Register the Module?

yea i missed it :D Thanks again :) I Hope it will work ^^

Ok i tried, dont work :(

First your "RegisterSpellHandler" dont work, so i coded a bit with the help of the "bloodboil.lua"

Bloodboil:

local MAJOR_VERSION = "Threat-2.0"
local MINOR_VERSION = tonumber(("$Revision: 68354 $"):match("%d+"))

if MINOR_VERSION > _G.ThreatLib_MINOR_VERSION then _G.ThreatLib_MINOR_VERSION = MINOR_VERSION end

ThreatLib_funcs[#ThreatLib_funcs+1] = function()

	local ThreatLib = _G.ThreatLib
	local BLOODBOIL_ID = 22948

	ThreatLib:GetModule("NPCCore"):RegisterModule(BLOODBOIL_ID, function(Bloodboil)
		function Bloodboil:Init()
			self:RegisterSpellHandler(
				40486,
				function(self, mob, target) self.ModifyThreat(mob, target, 0.75, 0) end
			)
			self:RegisterCombatant(BLOODBOIL_ID, true)
		end
	end)
end

And here the edited Onyxia.lua (maybe you see whats wrong with your function)

local MAJOR_VERSION = "Threat-2.0"
local MINOR_VERSION = tonumber(("$Revision: 70586 $"):match("%d+"))

if MINOR_VERSION > _G.ThreatLib_MINOR_VERSION then _G.ThreatLib_MINOR_VERSION = MINOR_VERSION end

ThreatLib_funcs[#ThreatLib_funcs+1] = function()
	local ThreatLib = _G.ThreatLib

	local ONYXIA_ID = 10184
	-- local KNOCK_AWAY_ID = 19633
	ThreatLib:GetModule("NPCCore"):RegisterModule(ONYXIA_ID, function(Onyxia)
		function Onyxia:Init()
			-- local func = function(self, mobGUID, targetGUID) self.ModifyThreatOnTargetGUID(mobGUID, targetGUID, 0.75, 0) end
			-- self:RegisterSpellHandler("SPELL_DAMAGE", func, KNOCK_AWAY_ID)
			self:RegisterSpellHandler(
				19633,
				function(self, mobGUID, targetGUID) self.ModifyThreatOnTargetGUID(mobGUID, targetGUID, 0.75, 0) end
			)
			self:RegisterCombatant(ONYXIA_ID, true)
		end
	end)
end

But ho i sayd i dont work... i also tried so:

local MAJOR_VERSION = "Threat-2.0"
local MINOR_VERSION = tonumber(("$Revision: 68354 $"):match("%d+"))

if MINOR_VERSION > _G.ThreatLib_MINOR_VERSION then _G.ThreatLib_MINOR_VERSION = MINOR_VERSION end

ThreatLib_funcs[#ThreatLib_funcs+1] = function()

	local ThreatLib = _G.ThreatLib
	local ONYXIA_ID = 10184

	ThreatLib:GetModule("NPCCore"):RegisterModule(ONYXIA_ID, function(Onyxia)
		function Onyxia:Init()
			self:RegisterSpellHandler(
				19633,
				function(self, mob, target) self.ModifyThreat(mob, target, 0.75, 0) end
			)
			self:RegisterCombatant(ONYXIA_ID, true)
		end
	end)
end

i think is must have something to do with the Combatlog or spellid, that omen doesnt count it...

hm maybe this work? (cant try more at moment) Its a full copy of the Voidreaver one only with other Name and Id

Onyxia:

local MAJOR_VERSION = "Threat-2.0"
local MINOR_VERSION = tonumber(("$Revision: 68354 $"):match("%d+"))

if MINOR_VERSION > _G.ThreatLib_MINOR_VERSION then _G.ThreatLib_MINOR_VERSION = MINOR_VERSION end

ThreatLib_funcs[#ThreatLib_funcs+1] = function()
	local ThreatLib = _G.ThreatLib

	local ONYXIA_ID = 10184
	local KNOCK_AWAY_ID = 19633
	ThreatLib:GetModule("NPCCore"):RegisterModule(ONYXIA_ID, function(Onyxia)
		function Onyxia:Init()
			self:RegisterSpellHandler(KNOCK_AWAY_ID, function(self, mob, target) self.ModifyThreat(mob, target, 0.75, 0) end)
			self:RegisterCombatant(ONYXIA_ID, true)
		end
	end)
end
 

here the Voidreaver original:

local MAJOR_VERSION = "Threat-2.0"
local MINOR_VERSION = tonumber(("$Revision: 68354 $"):match("%d+"))

if MINOR_VERSION > _G.ThreatLib_MINOR_VERSION then _G.ThreatLib_MINOR_VERSION = MINOR_VERSION end

ThreatLib_funcs[#ThreatLib_funcs+1] = function()
	local ThreatLib = _G.ThreatLib

	local VOID_REAVER_ID = 19516
	local KNOCK_AWAY_ID = 25778
	ThreatLib:GetModule("NPCCore"):RegisterModule(VOID_REAVER_ID, function(VoidReaver)
		function VoidReaver:Init()
			self:RegisterSpellHandler(KNOCK_AWAY_ID, function(self, mob, target) self.ModifyThreat(mob, target, 0.75, 0) end)
			self:RegisterCombatant(VOID_REAVER_ID, true)
		end
	end)
end
 

i can do that but... how?

Ah ok i readed the Sticky and its only /combatlog before fight and /Combatlog after + /rl?

okey here it is: Blizzards log and Transcriptor Log:

btw, this is the Problem Spell:

Blizz:

5/10 23:27:05.156 SPELL_CAST_SUCCESS,0xF1300027C8000006,"Onyxia",0x10a48,0xF1402CD395000002,"Thooghun",0x1111,19633,"Wegschlagen",0x1
5/10 23:27:05.171 SPELL_DAMAGE,0xF1300027C8000006,"Onyxia",0x10a48,0xF1402CD395000002,"Thooghun",0x1111,19633,"Wegschlagen",0x1,595,1,0,0,0,nil,nil,nil

Transcriptor:

"<31.6> SPELL_CAST_SUCCESS:0xF1300027C8000006:Onyxia:68168:0xF1402CD395000002:Thooghun:4369:19633:Wegschlagen:1:nil:nil -[LOG_EVENT]-", -- [39]
"<31.6> SPELL_DAMAGE:0xF1300027C8000006:Onyxia:68168:0xF1402CD395000002:Thooghun:4369:19633:Wegschlagen:1:595:1 -[LOG_EVENT]-", -- [40]

I hope we find the Problem now ^^

yea we can do this but dont they need a full fight log?