No, it's not an issue at all. It's just a needless inconsistency, being displayed in a raid and hidden in a party for no obvious reason. Is there a reason to not unconditionally put the player's own revisions in Threat.partyMemberAgents? I don't know all the ways in which that table gets used; if doing so would cause complications then it's not worth it.
Basically, those of us who don't know Threat/Omen well enough to fix major bugs would like to contribute smaller patches to smooth the minor bumps.
Since Thread 2.0 Omen doesn?t count the Knock away from her (and the Thread reduce with this).
Also Thread 1.0 and 2.0 coutn all knock aways with 50% hate reduce, but this isnt right for Onyxia, there it is 25% so i tryed to change in the "ThreadNPCModuleCore.lua"
but like before... nothing happen, Omen just dont count the Knock aways and so the Thread is very incorrect.
Someone an Idea WHY Omen dont count this?
Also i Use German Client, maybe there is the Problem? Says the Combatlog Omen direct wich spellid or the Name and there is somewhere an Translation to spellid or so?
/Edit: And btw, i use Felguard to Tank Onyxia, so the Threadreduce doesnt goes to me, but to my Pet in Thread1.0 this was ok, but maybe there is an Problem with the Petthread in 2.0?
I tried to get ony working myself but i choose the way to create a new npc-module myself.
not the npc-core.
Like Interface\Addons\Threat-2.0\Threat-2.0\NPCModules\Azeroth\Onyxia.lua
I copied a few bits from other BossModules like Zuljin and especially Voidreaver, because he looks similar. Just exchanged the ids and renamed a few things.
But noone wants to kill ony on my server, so no idea if it works or not.
I attached it, maybe it helps you.
dont forget to register it with the core,so it will be loaded
My lib.xml contains the additional line
<Script file="NPCModules\Azeroth\Onyxia.lua" />
Next thing i try to finish is a KelThuzad-Module , changing threat properly when he casts his chains.
If someone has a few ideas where to start , im thankful :)
There are some fights where someone looses aggro just for a small amount of time.
Is there a way to make this visible in an npcmodule? or do i have to remember it and look at the second in the list ? ;)
Something like " reduce aggro of X while affected by spell Y " or " reduce aggro shown for Z seconds when F happens" ?
First your "RegisterSpellHandler" dont work, so i coded a bit with the help of the "bloodboil.lua"
Bloodboil:
local MAJOR_VERSION = "Threat-2.0"
local MINOR_VERSION = tonumber(("$Revision: 68354 $"):match("%d+"))
if MINOR_VERSION > _G.ThreatLib_MINOR_VERSION then _G.ThreatLib_MINOR_VERSION = MINOR_VERSION end
ThreatLib_funcs[#ThreatLib_funcs+1] = function()
local ThreatLib = _G.ThreatLib
local BLOODBOIL_ID = 22948
ThreatLib:GetModule("NPCCore"):RegisterModule(BLOODBOIL_ID, function(Bloodboil)
function Bloodboil:Init()
self:RegisterSpellHandler(
40486,
function(self, mob, target) self.ModifyThreat(mob, target, 0.75, 0) end
)
self:RegisterCombatant(BLOODBOIL_ID, true)
end
end)
end
And here the edited Onyxia.lua (maybe you see whats wrong with your function)
local MAJOR_VERSION = "Threat-2.0"
local MINOR_VERSION = tonumber(("$Revision: 70586 $"):match("%d+"))
if MINOR_VERSION > _G.ThreatLib_MINOR_VERSION then _G.ThreatLib_MINOR_VERSION = MINOR_VERSION end
ThreatLib_funcs[#ThreatLib_funcs+1] = function()
local ThreatLib = _G.ThreatLib
local ONYXIA_ID = 10184
-- local KNOCK_AWAY_ID = 19633
ThreatLib:GetModule("NPCCore"):RegisterModule(ONYXIA_ID, function(Onyxia)
function Onyxia:Init()
-- local func = function(self, mobGUID, targetGUID) self.ModifyThreatOnTargetGUID(mobGUID, targetGUID, 0.75, 0) end
-- self:RegisterSpellHandler("SPELL_DAMAGE", func, KNOCK_AWAY_ID)
self:RegisterSpellHandler(
19633,
function(self, mobGUID, targetGUID) self.ModifyThreatOnTargetGUID(mobGUID, targetGUID, 0.75, 0) end
)
self:RegisterCombatant(ONYXIA_ID, true)
end
end)
end
But ho i sayd i dont work... i also tried so:
local MAJOR_VERSION = "Threat-2.0"
local MINOR_VERSION = tonumber(("$Revision: 68354 $"):match("%d+"))
if MINOR_VERSION > _G.ThreatLib_MINOR_VERSION then _G.ThreatLib_MINOR_VERSION = MINOR_VERSION end
ThreatLib_funcs[#ThreatLib_funcs+1] = function()
local ThreatLib = _G.ThreatLib
local ONYXIA_ID = 10184
ThreatLib:GetModule("NPCCore"):RegisterModule(ONYXIA_ID, function(Onyxia)
function Onyxia:Init()
self:RegisterSpellHandler(
19633,
function(self, mob, target) self.ModifyThreat(mob, target, 0.75, 0) end
)
self:RegisterCombatant(ONYXIA_ID, true)
end
end)
end
i think is must have something to do with the Combatlog or spellid, that omen doesnt count it...
hm maybe this work? (cant try more at moment) Its a full copy of the Voidreaver one only with other Name and Id
Onyxia:
local MAJOR_VERSION = "Threat-2.0"
local MINOR_VERSION = tonumber(("$Revision: 68354 $"):match("%d+"))
if MINOR_VERSION > _G.ThreatLib_MINOR_VERSION then _G.ThreatLib_MINOR_VERSION = MINOR_VERSION end
ThreatLib_funcs[#ThreatLib_funcs+1] = function()
local ThreatLib = _G.ThreatLib
local ONYXIA_ID = 10184
local KNOCK_AWAY_ID = 19633
ThreatLib:GetModule("NPCCore"):RegisterModule(ONYXIA_ID, function(Onyxia)
function Onyxia:Init()
self:RegisterSpellHandler(KNOCK_AWAY_ID, function(self, mob, target) self.ModifyThreat(mob, target, 0.75, 0) end)
self:RegisterCombatant(ONYXIA_ID, true)
end
end)
end
here the Voidreaver original:
local MAJOR_VERSION = "Threat-2.0"
local MINOR_VERSION = tonumber(("$Revision: 68354 $"):match("%d+"))
if MINOR_VERSION > _G.ThreatLib_MINOR_VERSION then _G.ThreatLib_MINOR_VERSION = MINOR_VERSION end
ThreatLib_funcs[#ThreatLib_funcs+1] = function()
local ThreatLib = _G.ThreatLib
local VOID_REAVER_ID = 19516
local KNOCK_AWAY_ID = 25778
ThreatLib:GetModule("NPCCore"):RegisterModule(VOID_REAVER_ID, function(VoidReaver)
function VoidReaver:Init()
self:RegisterSpellHandler(KNOCK_AWAY_ID, function(self, mob, target) self.ModifyThreat(mob, target, 0.75, 0) end)
self:RegisterCombatant(VOID_REAVER_ID, true)
end
end)
end
im not sure where your "voidreaver " differs from mine, but ill have a look later tonight .
maybe you can get us a transcriptor-logfile next time you run onyxia?
so we get all correct combatlog events, and funky rabbit or ammon can update the bigwigs module as well
either that, or you install the transcriptor-addon ; this is more easier to understand.
Grab it from files.wowace.com or your favorite update and attach the SavedVariables\Transcriptor.lua ;)
Maybe we should post this in the bigwigs-thread for 2.4-logfiles as well , so they can update the onyxiamodule. ill do it for deadlybossmods if you dont mind
ok , you're right , i thought it was a complete log..
There is no documentation yet, so we have to do trial&error and a bit of blind guess-work.
You did remove the onyxia-spellids from ThreatNPCModuleCore as well, didnt you?
The function halveThreat is called for all registered spellids, maybe we got a conflict here...
local halveThreat = function(mob, target) ModifyThreat(mob, target, 0.5, 0) end
local threatHalveSpellIDs = {
-- Wing Buffet
18500, 23339, 29905, 37157, 37319, 41572, 32914, 38110, 31475, 38593,
-- Knock Away
21737, 40434, 37102, 32959, 31389, 23382, 19633, 18945, 18813, 18670, 10101
}
function ThreatLibNPCModuleCore:OnInitialize()
self.activeModule = nil
self.activeModuleID = nil
self.ModifyThreatSpells = {}
for i = 1, #threatHalveSpellIDs do
self.ModifyThreatSpells[threatHalveSpellIDs[i]] = halveThreat
end
end
Rollback Post to RevisionRollBack
To post a comment, please login or register a new account.
Basically, those of us who don't know Threat/Omen well enough to fix major bugs would like to contribute smaller patches to smooth the minor bumps.
HJKL and keys > mouse + arrows, its much faster once you learn it.
Since Thread 2.0 Omen doesn?t count the Knock away from her (and the Thread reduce with this).
Also Thread 1.0 and 2.0 coutn all knock aways with 50% hate reduce, but this isnt right for Onyxia, there it is 25% so i tryed to change in the "ThreadNPCModuleCore.lua"
to
First changed the 0.5 to 0.75 special for Onyxia and deleted all "Wing Buffed" Spellid, because Onyxias one doesnt reduce hate.
Also i added all "Knock Away" Spellids i found, and Allakhazam say Onyxia?s one is 19633
http://wow.allakhazam.com/db/mob.html?wmob=10184 -> http://wow.allakhazam.com/db/spell.html?wspell=19633
but like before... nothing happen, Omen just dont count the Knock aways and so the Thread is very incorrect.
Someone an Idea WHY Omen dont count this?
Also i Use German Client, maybe there is the Problem? Says the Combatlog Omen direct wich spellid or the Name and there is somewhere an Translation to spellid or so?
/Edit: And btw, i use Felguard to Tank Onyxia, so the Threadreduce doesnt goes to me, but to my Pet in Thread1.0 this was ok, but maybe there is an Problem with the Petthread in 2.0?
Please Help me :/
Dead
not the npc-core.
Like Interface\Addons\Threat-2.0\Threat-2.0\NPCModules\Azeroth\Onyxia.lua
I copied a few bits from other BossModules like Zuljin and especially Voidreaver, because he looks similar. Just exchanged the ids and renamed a few things.
But noone wants to kill ony on my server, so no idea if it works or not.
I attached it, maybe it helps you.
dont forget to register it with the core,so it will be loaded
My lib.xml contains the additional line
Next thing i try to finish is a KelThuzad-Module , changing threat properly when he casts his chains.
If someone has a few ideas where to start , im thankful :)
EDIT: wrong file^^
maybe you just missed my edit ;)
I hope i find a decent geared tank tonight :D
Is there a way to make this visible in an npcmodule? or do i have to remember it and look at the second in the list ? ;)
Something like " reduce aggro of X while affected by spell Y " or " reduce aggro shown for Z seconds when F happens" ?
First your "RegisterSpellHandler" dont work, so i coded a bit with the help of the "bloodboil.lua"
Bloodboil:
And here the edited Onyxia.lua (maybe you see whats wrong with your function)
But ho i sayd i dont work... i also tried so:
i think is must have something to do with the Combatlog or spellid, that omen doesnt count it...
Onyxia:
here the Voidreaver original:
maybe you can get us a transcriptor-logfile next time you run onyxia?
so we get all correct combatlog events, and funky rabbit or ammon can update the bigwigs module as well
Grab it from files.wowace.com or your favorite update and attach the SavedVariables\Transcriptor.lua ;)
btw, this is the Problem Spell:
Blizz:
Transcriptor:
I hope we find the Problem now ^^
Maybe we should post this in the bigwigs-thread for 2.4-logfiles as well , so they can update the onyxiamodule. ill do it for deadlybossmods if you dont mind
There is no documentation yet, so we have to do trial&error and a bit of blind guess-work.
You did remove the onyxia-spellids from ThreatNPCModuleCore as well, didnt you?
The function halveThreat is called for all registered spellids, maybe we got a conflict here...