As for the paladin on healing we got it fixed simple user action which caused it. My apologies.
r40602 took away the Updating Threat per second frequency in the drop down menus. You have it by default of 0.05 where I switched it to 0.4 for the main reson I use TPS to get a quick benchmark from me and another of my class. Threat itself and threat percentage we use for the raid portion. Which does not go like a stopwatch constantly changing. How can I get my TPS frequency back to my 0.4 vs the 0.05?
maybe omen should add sw_stats as an optional dependancy .. this will probably fix the problems with sw_stats & omen.
What use would be having a DMG Meter as a dependacy of a Threat Meter, specially a DMG Meter thats not even Ace based?
Adding SW_Stats as an optional dependency would just ensure that it loads before Omen, which often fixes issues related to SW_FixLogStrings and parsing. It has nothing to do with actually using or requiring SW_Stats.
SwFixLogStrings actually modifies the Blizzard parser patterns, which breaks basically any other mod that tries to do combat log parsing. I'm not sure yet how it needs to be handled.
Quote from Ellipsis »
Adding SW_Stats as an optional dependency would just ensure that it loads before Omen, which often fixes issues related to SW_FixLogStrings and parsing. It has nothing to do with actually using or requiring SW_Stats.
If this is actually the case, then hooray. However, the parser issue affects Threat, which means that every mod that embeds Threat would need to add SW_Stats as a dependency. Ugly. :/
SW_FixLogStrings seems pretty optional; could Threat have code that detects that it's installed and warn the user? Or work around the changes it's making?
Here's the TOC entry for SW_FixLogStrings:
Adds a function to fix some log strings. If you turn this off SW Stats may parse incorrect things. If you turn it on other addons might be affected.
Here's the actual code that it applies to English locale:
function SW_FixLogStrings(str)
--problematic strings
-- %s's
--Twilight's Hammer Ambassador's Flame Shock hits you for 1234 fire damage.
-- or fictional: Twilight's Hammer Ambassador's Nature's Grasp ...
return string.gsub(str, "(%%%d?$?s)('s)", "%1% %2");
end
At a minimum, I'm likely going to add a warning to Threat that says "Hey, something's messing with the parser patterns, go disable it" so that people at least know that there's a reason that things aren't working as expected
the problem is that it's not possible to parse all messages in foreign languages if you build your parser from the globalstrings.
it's all fine when sw_stats loads first because omen will then build it's parser from the modified (better) combat log strings.
Mayhaps someone should be contacting the SWStats author(s) and telling them their addon is behaving in a hostile manner?
well you can .. but it won't change anything. in fact if sw_stats is loaded before omen, omen will work better in other languages... ktm has the same problem ...
What use would be having a DMG Meter as a dependacy of a Threat Meter, specially a DMG Meter thats not even Ace based?
because the average user will blame omen for false values. because it fixes the problem :9 no need to parent a other author .9
Ive searched through a few pages in this thread and didnt see this issue.
The bars in omen seem to have various random colors and dont seem to be colored by class necessarily. There are priests flagged as warlocks, rogues flagged as mages, tanks showing up as rogues, etc. I can post a screenie if that would help.
Are the bars supposed tobe color coded by class? Also, it would be spiffy if, like KTM, we could get a special color (red?) for the self threat bar so its a bit easier to pick out in the middle of the fight.
For addon devs: If you generate your regEx from global vars it is best just to make SW_Stats (and not this)
an optional Dep in your toc
## OptionalDeps: SW_Stats
What about FixLogStrings ("Actively fix log strings pattern to remove ambiguities (Jerry)")? Maybe have both as optional deps? Not sure but I think I read somewhere that FixLogStrings does not load if SW_Stats log string fix is loaded.
Last night in SSC Omen was sometimes noch displaying data from KTM-users. One pull it works, the next one there were only a handfull of people in Omen displayed while KTM was displaying everyone.
As for the paladin on healing we got it fixed simple user action which caused it. My apologies.
r40602 took away the Updating Threat per second frequency in the drop down menus. You have it by default of 0.05 where I switched it to 0.4 for the main reson I use TPS to get a quick benchmark from me and another of my class. Threat itself and threat percentage we use for the raid portion. Which does not go like a stopwatch constantly changing. How can I get my TPS frequency back to my 0.4 vs the 0.05?
BTW great mod. :D
All I have to do now is finding a replacement for ItemRack ;)
-
View User Profile
-
View Posts
-
Send Message
Curse Premiumitem rack? is that with 1.0(Most sites) or 2.0(Beta Version from wowinterface.com) ?
ive noticed this too, not all my healing spells showing up
You could try Outfitter. That's the addon I use.
What use would be having a DMG Meter as a dependacy of a Threat Meter, specially a DMG Meter thats not even Ace based?
Adding SW_Stats as an optional dependency would just ensure that it loads before Omen, which often fixes issues related to SW_FixLogStrings and parsing. It has nothing to do with actually using or requiring SW_Stats.
-
View User Profile
-
View Posts
-
Send Message
Curse PremiumIf this is actually the case, then hooray. However, the parser issue affects Threat, which means that every mod that embeds Threat would need to add SW_Stats as a dependency. Ugly. :/
Here's the TOC entry for SW_FixLogStrings:
Adds a function to fix some log strings. If you turn this off SW Stats may parse incorrect things. If you turn it on other addons might be affected.
Here's the actual code that it applies to English locale:
function SW_FixLogStrings(str) --problematic strings -- %s's --Twilight's Hammer Ambassador's Flame Shock hits you for 1234 fire damage. -- or fictional: Twilight's Hammer Ambassador's Nature's Grasp ... return string.gsub(str, "(%%%d?$?s)('s)", "%1% %2"); end-
View User Profile
-
View Posts
-
Send Message
Curse Premiumit's all fine when sw_stats loads first because omen will then build it's parser from the modified (better) combat log strings.
well you can .. but it won't change anything. in fact if sw_stats is loaded before omen, omen will work better in other languages... ktm has the same problem ...
because the average user will blame omen for false values. because it fixes the problem :9 no need to parent a other author .9
The bars in omen seem to have various random colors and dont seem to be colored by class necessarily. There are priests flagged as warlocks, rogues flagged as mages, tanks showing up as rogues, etc. I can post a screenie if that would help.
Are the bars supposed tobe color coded by class? Also, it would be spiffy if, like KTM, we could get a special color (red?) for the self threat bar so its a bit easier to pick out in the middle of the fight.
(using omen 40570 btw)
But if you do that how does that affect one who does not use swstats?
how to colour own bar so that it can be different from all others , and more easily findable on omen chart?