Authors CurseForge

After a fresh Skinner install...

2007/10/08 17:38:59-140-x1]: Skinner-2.1\SkinMe\JasonQuest.lua:50: AceHook-2.1: Attempt to hook method "Log_CreateSearchEditBox" failed, it does not exist in the given object "Jason's PartyQuest".
<in C code>: ?
AceEvent-2.0-49307 (Ace2):367: in function <Interface\AddOns\Ace2\AceEvent-2.0\AceEvent-2.0.lua:345>

---


[2007/10/08 17:38:59-140-x1]: Skinner-2.1\SkinMe\ProfessionsBook.lua:6: attempt to index global 'ProfessionsBookFrame' (a nil value)
<in C code>: ?
AceEvent-2.0-49307 (Ace2):367: in function <Interface\AddOns\Ace2\AceEvent-2.0\AceEvent-2.0.lua:345>

---

Quote from Jncl »

Hi Notvello,

That bug was fixed in r 51024, 05/10/07.

Have you got the Dewdrop skin in the SkinMe directory? If so what is the actual problem with Dewdrop?

heres my issue

ProfessionBook has recently been updated.

Since then, I get the following error and it's no longer skinned.

.

Thanks for this great addon. I hope this will be fixed soon.

Take care.

Quote from Jncl »

Hi,

Updated JasonQuest & ProfessionsBook skins, as reported by fred & Kamarade Molotov

r 51503

Thank you, At least I wasn't getting the earlier error :)

Quote from Jncl »

Hi Notvello,

Dewdrop is OK for me, are there any errors reported by BugSack ?

no errors that I know of, it just wont skin. Also can you add a skin for Wowequip plz?

Quote from Jncl »

Hi,

Updated JasonQuest & ProfessionsBook skins, as reported by fred & Kamarade Molotov

r 51503

Thanks.

Jncl: the developper who upgraded faster than his own shadow.

Could you update the Cartographer's skin plz ?

Request to skin - http://wowui.incgamers.com/?p=mod&m=1699

If the mod owner for skinner could PM me please, I've modified the code to allow for borders on the left/right as well.

The use case is that I use dual monitors, and I have used CT_Viewport to shove the viewport onto one of my monitors, but I'm trying to kill CT mod...so Skinner works great, other than not adjusting the side borders. So yeah, I've modified the localization.lua, options.lua and AddonFrames.lua to add that capability. I'm happy to email you the files to look over the diffs if you'd like. Just PM me your email and I'll send them along.

Thanks!

I've tested Skinner in 2.3 PTR and i found this bug (image attached). It happens when u open Talent Panel.
Love the addon, keep up the good work :)

Quote from Seerah »

Just post the diff here as an attachment...

localization.lua:

Added the following lines to L:RegisterTranslations("enUS", function()

	["VP Left"] = true,
	["Change Width of the Left Band"] = true,
	["VP Right"] = true,
	["Change Width of the Right Band"] = true,
	["VP XResolution"] = true,
	["Change X Resolution"] = true,	

Added them after
["Change Y Resolution"] = true,

to options.lua -
changed

    ViewPort    = {top = 64, bottom = 64, YResolution = 1050, scaling = 768/1050, shown = false, overlay = false, r = 0, g = 0, b = 0, a = 1},

to

    ViewPort    = {top = 64, bottom = 64, YResolution = 1050, left = 0, right = 0, XResolution = 1050, yScaling = 768/1050, xScaling = 768/1050, shown = false, overlay = false, r = 0, g = 0, b = 0, a = 1},

and under viewport's definitions, added:

          left = {
            name = L["VP Left"],
            desc = L["Change Width of the Left Band"],
            type = "range",
            step = 1,
            min = 0,
            max = 2000,
            get = function ()
              return self.db.profile.ViewPort.left
            end,
            set = function (v)
              self.db.profile.ViewPort.left = v
              self:ViewPort_left()
            end,
          },
          right = {
            name = L["VP Right"],
            desc = L["Change Width of the Right Band"],
            type = "range",
            step = 1,
            min = 0,
            max = 2000,
            get = function ()
              return self.db.profile.ViewPort.right
            end,
            set = function (v)
              self.db.profile.ViewPort.right = v
              self:ViewPort_right()
            end,
          },
          xres = {
            name = L["VP XResolution"],
            desc = L["Change X Resolution"],
            type = "range",
            step = 2,
            min = 0,
            max = 1600,
            get = function ()
              return self.db.profile.ViewPort.XResolution
            end,
            set = function (v)
              self.db.profile.ViewPort.XResolution = v
              self.db.profile.ViewPort.xScaling = 768 / self.db.profile.ViewPort.XResolution
              self.initialized.ViewPort = nil
              self:ViewPort()
            end,
          },

also changed yres' reference to self.db.profile.ViewPort.scaling to yScaling.

AddonFrames.lua -
add/changed the following block of code to:

function Skinner:ViewPort()
	if not self.db.profile.ViewPort.shown or self.initialized.ViewPort then return end
	self.initialized.ViewPort = true

	WorldFrame:SetPoint("TOPLEFT", (self.db.profile.ViewPort.left * self.db.profile.ViewPort.xScaling), -(self.db.profile.ViewPort.top * self.db.profile.ViewPort.yScaling))
	WorldFrame:SetPoint("BOTTOMRIGHT", -(self.db.profile.ViewPort.right * self.db.profile.ViewPort.xScaling), (self.db.profile.ViewPort.bottom * self.db.profile.ViewPort.yScaling))

	if self.db.profile.ViewPort.overlay then
		ViewportOverlay = WorldFrame:CreateTexture(nil, "BACKGROUND")
		ViewportOverlay:SetTexture(self.db.profile.ViewPort.r or 0, self.db.profile.ViewPort.g or 0, self.db.profile.ViewPort.b or 0, ba or self.db.profile.ViewPort.a or 1)
		ViewportOverlay:SetPoint("TOPLEFT", UIParent, "TOPLEFT", -1, 1)
		ViewportOverlay:SetPoint("BOTTOMRIGHT", UIParent, "BOTTOMRIGHT", 1, -1)
	end

end

function Skinner:ViewPort_top()
	if not self.db.profile.ViewPort.shown then return end

	WorldFrame:SetPoint("TOPLEFT", (self.db.profile.ViewPort.left * self.db.profile.ViewPort.xScaling), -(self.db.profile.ViewPort.top * self.db.profile.ViewPort.yScaling))
	WorldFrame:SetPoint("TOPRIGHT", -(self.db.profile.ViewPort.right * self.db.profile.ViewPort.xScaling), -(self.db.profile.ViewPort.top * self.db.profile.ViewPort.yScaling))

end

function Skinner:ViewPort_bottom()
	if not self.db.profile.ViewPort.shown then return end

	WorldFrame:SetPoint("BOTTOMRIGHT", -(self.db.profile.ViewPort.right * self.db.profile.ViewPort.xScaling), (self.db.profile.ViewPort.bottom * self.db.profile.ViewPort.yScaling))
	WorldFrame:SetPoint("BOTTOMLEFT", (self.db.profile.ViewPort.left * self.db.profile.ViewPort.xScaling), (self.db.profile.ViewPort.bottom * self.db.profile.ViewPort.yScaling))

end

function Skinner:ViewPort_left()
	if not self.db.profile.ViewPort.shown then return end

	WorldFrame:SetPoint("BOTTOMLEFT", (self.db.profile.ViewPort.left * self.db.profile.ViewPort.xScaling), (self.db.profile.ViewPort.bottom * self.db.profile.ViewPort.yScaling))
  WorldFrame:SetPoint("TOPLEFT", (self.db.profile.ViewPort.left * self.db.profile.ViewPort.xScaling), -(self.db.profile.ViewPort.top * self.db.profile.ViewPort.yScaling))
end

function Skinner:ViewPort_right()
	if not self.db.profile.ViewPort.shown then return end

	WorldFrame:SetPoint("BOTTOMRIGHT", (self.db.profile.ViewPort.right * self.db.profile.ViewPort.xScaling), (self.db.profile.ViewPort.bottom * self.db.profile.ViewPort.yScaling))
  WorldFrame:SetPoint("BOTTOMRIGHT", (self.db.profile.ViewPort.right * self.db.profile.ViewPort.xScaling), -(self.db.profile.ViewPort.top * self.db.profile.ViewPort.yScaling))
end

basically instead of hardcoding the x positions, did them dynamically based upon the set values for the left/right. Also added setting the sides to top/bottom basically.

Let me know if I missed anything...I didn't actually do a diff, I was going off what I remembered.

Hi Jncl, could you please update Skillet. There's a dropdown field missing. Thanks!

Quote from Jncl »

Hi,

I've noted the issues raised and will fix some of them soon as I can, I've been working on WUU and haven't had much time for Skinner fixes for a while.

I'm waiting for a character copy on the PTR so I can do some testing there but will once that is done I'll be able to fix that as well.

Hey Jncl, not to be a pest, but any way you could add in the code I wrote to get Skinner working in the x-axis as well as the y-axis too so I don't have to keep a backup out for when you update so I can re-paste in my code? :D