Is the following something that is fixable with the masterplan skin module?
I have enabled the settings in the Button settings modules and selected a custom border I use. It works great everywhere but the shipyard portion of the garrison mission (masterplan enabled)
Below is an image describing my issue. The shipyard has a button border that is not inset well. On all other buttons the border works great and I am wondering if it is a limitation in the frame or something that can be tweaked? It's super minor and doesn't break functionality but I am super anal retentive.
Or is it just from viewing the button border on a light texture it suddenly shows the concern I have in my really bad picture?
Just a heads up. The way sexy map handles minimap buttons, it prevents skinner from skinning it. Not something that I am afraid you can even do anything about and not an issue since in my case I hide minimap buttons until they trigger something.
Since sexy map handles visibility and button dragging if those options are enabled, it takes over the buttons and won't allow them to be redrawn perhaps?
Minimap button skinning works perfectly fine without a minimap addon enabled so I can confirm it's a limitation with using sexy map (and I can live with it just fine)
I'm not sure if transitbus means the same thing about sexymap . I have this issue. I open skinners options and I check 'skin minimap buttons'. Buttons are skinned but when I log out and in again they are not. I open options again , uncheck and checking again 'skin minimap buttons' , and buttons are skinned again until I relog and so on. This happens mostly with default buttons as calendar, missions table etc , some addons buttons are skinned all the time. ( I can live with it just fine too ;) )
5x Attempt to find 'this' in non-framescript object
[C]: ?
[C]: in function `CreateFrame'
Skinner\Skinner-b6.20886.2.lua:598: in function <Skinner\Skinner.lua:540>
(tail call): ?
Skinner\SkinMe\DBM-6.2.18 alpha.14768.lua:119: in function <Skinner\SkinMe\DBM.lua:118>
(tail call): ?
[C]: in function `Show'
DBM-Draenor\Kazzak.lua:60: in function `handler'
DBM-Core\DBM-Core-6.2.17-48-g1979307.lua:636: in function <DBM-Core\DBM-Core.lua:623>
(tail call): ?
DBM-Core\DBM-Core-6.2.17-48-g1979307.lua:636: in function <DBM-Core\DBM-Core.lua:623>
[C]: in function `CastSpellByName'
...
FrameXML\ChatFrame.lua:2707: in function <FrameXML\ChatFrame.lua:2700>
[C]: ?
[C]: in function `UseAction'
FrameXML\SecureTemplates.lua:348: in function `handler'
FrameXML\SecureTemplates.lua:649: in function <FrameXML\SecureTemplates.lua:597>
[C]: ?
FrameXML\SecureHandlers.lua:264: in function <FrameXML\SecureHandlers.lua:261>
[C]: ?
FrameXML\SecureHandlers.lua:294: in function <FrameXML\SecureHandlers.lua:277>
(tail call): ?
Locals:
/snip
Just a heads up. The way sexy map handles minimap buttons, it prevents skinner from skinning it.
/snip
Not quite, ;-). This happens because there is code in Skinner to NOT skin the Minimap or Minimap Buttons if SexyMap is loaded. Been in there since July 2013.
/snip
I have this issue. I open skinners options and I check 'skin minimap buttons'. Buttons are skinned but when I log out and in again they are not. I open options again , uncheck and checking again 'skin minimap buttons' , and buttons are skinned again until I relog and so on. This happens mostly with default buttons as calendar, missions table etc , some addons buttons are skinned all the time.
/snip
If you're talking about this issue happening when SexyMap is loaded, please refer to my previous reply to transitbus.
Updated DBM (as reported by transitbus) & MasterPlan skins
Bugfix for Garrison Mission UI skin
Updated BlackMarketUI skin
Remove ButtonBorders on AlertFrames
MainMenuBar skin change
Move ItemRef Tooltip close button
Move Tab & OOC code to OnEnable function
UnitFrames use a different template for skin background
Add Comments
Remove debug code
Hi, I've been having a problem for a while. I get an error every time I change my talents and have finally identified which addon may be causing it. With every single addon enabled I have this bug, and only when Skinner or Broker Garrison is disabled the bug goes away.
Do you have an AddOn called AchieveIt? The problem with taint is that Blizzard plays the blame game. Not an exact science, but something like this happens:
[QUOTE=Gershuun;/comments/2199255]Hi, I've been having a problem for a while. I get an error every time I change my talents and have finally identified which addon may be causing it. With every single addon enabled I have this bug, and only when Skinner or Broker Garrison is disabled the bug goes away.
Hi Gershuun,
Can you enable taint logging by entering the following command at the WoW chat prompt
/console taintLog 1
cause the error to happen, then turn off taint logging
/console taintLog 0
and attach the taint log, World of Warcraft\Logs\taint.log, to your post please.
17x Skinner\Skinner-b6.21355.1.lua:1981: attempt to index field 'obj' (a nil value)
Skinner\Skinner-b6.21355.1.lua:2005: in function `skinUsingBD'
Skinner\SkinMe\Rematch-4.4.1.lua:300: in function <Skinner\SkinMe\Rematch.lua:5>
(tail call): ?
[C]: in function `xpcall'
Skinner\UtilFuncs.lua:180: in function <Skinner\UtilFuncs.lua:174>
Skinner\UtilFuncs.lua:295: in function `checkAndRunAddOn'
Skinner\AddonFrames.lua:289: in function `?'
...y\Externals\curse\svn\Ace3-AceTimer\AceTimer-3.0-17.lua:53: in function <...y\Externals\curse\svn\Ace3-AceTimer\AceTimer-3.0.lua:48>
I found some skins in the Obsolete folder that are probably still valid:
MSBTOptions (Mikk's Scrolling Battle Text Options)
MobileVault (hasn't needed updating)
Postal (pretty sure the repo has newer versions)
LibSimpleOptions (I think some AddOns use this)
Prat (duh)
TomTom (still works, updated by Torhal, I believe)
In unrelated stuff, is it possible to skin SmartRes2, or would I have to alter the code in some fashion to allow skinning? You should be able to access the DB easily enough.
Added skin for SmartRes2 (as requested by myrroddin)
Updated MasterPlan & Rematch (as reported by NeoZeus) skins
Bugfix for QueueStatusMinimapButton skin (as reported by leprecaun13)
Updated version numbers
b6.21742.1
I'm happy to update obsoleted skins if they are still required
@Gershuun, not seeing any taint caused by skinner in the logs
After latest update, still have the problem of not being able to change talents. It only goes away when I disable Skinner or BrokerGarrison so I guess I will be uninstalling BrokerGarrison in Legion anyway.
Rollback Post to RevisionRollBack
To post a comment, please login or register a new account.
I have enabled the settings in the Button settings modules and selected a custom border I use. It works great everywhere but the shipyard portion of the garrison mission (masterplan enabled)
Below is an image describing my issue. The shipyard has a button border that is not inset well. On all other buttons the border works great and I am wondering if it is a limitation in the frame or something that can be tweaked? It's super minor and doesn't break functionality but I am super anal retentive.
Or is it just from viewing the button border on a light texture it suddenly shows the concern I have in my really bad picture?
b6.20886.2
Just a heads up. The way sexy map handles minimap buttons, it prevents skinner from skinning it. Not something that I am afraid you can even do anything about and not an issue since in my case I hide minimap buttons until they trigger something.
Since sexy map handles visibility and button dragging if those options are enabled, it takes over the buttons and won't allow them to be redrawn perhaps?
Minimap button skinning works perfectly fine without a minimap addon enabled so I can confirm it's a limitation with using sexy map (and I can live with it just fine)
Bugfix for Garrison Mission UI skin
Updated BlackMarketUI skin
Remove ButtonBorders on AlertFrames
MainMenuBar skin change
Move ItemRef Tooltip close button
Move Tab & OOC code to OnEnable function
UnitFrames use a different template for skin background
Add Comments
Remove debug code
b6.20886.3
Removed BNCOnversationInvite skin code
Updated GarrisonMission skin
Updated QuestMap skin
Updated version numbers
b6.21355.1
Here's the full error:
http://pastebin.com/d2fq3rF6
Hi Gershuun,
Hi Gershuun,
TIA
getting an error since Rematch updated:
17x Skinner\Skinner-b6.21355.1.lua:1981: attempt to index field 'obj' (a nil value)
Skinner\Skinner-b6.21355.1.lua:2005: in function `skinUsingBD'
Skinner\SkinMe\Rematch-4.4.1.lua:300: in function <Skinner\SkinMe\Rematch.lua:5>
(tail call): ?
[C]: in function `xpcall'
Skinner\UtilFuncs.lua:180: in function <Skinner\UtilFuncs.lua:174>
Skinner\UtilFuncs.lua:295: in function `checkAndRunAddOn'
Skinner\AddonFrames.lua:289: in function `?'
...y\Externals\curse\svn\Ace3-AceTimer\AceTimer-3.0-17.lua:53: in function <...y\Externals\curse\svn\Ace3-AceTimer\AceTimer-3.0.lua:48>
Locals:
nil
Nope - still being maintained by the original author.
Updated MasterPlan & Rematch (as reported by NeoZeus) skins
Bugfix for QueueStatusMinimapButton skin (as reported by leprecaun13)
Updated version numbers
b6.21742.1
I'm happy to update obsoleted skins if they are still required
@Gershuun, not seeing any taint caused by skinner in the logs