Skinner

#5475 Feb 2, 2016
transitbus
transitbus

View User Profile

View Posts

Send Message
Curse Premium
- Join Date: 10/27/2005
- Posts: 54
- Member Details
Is the following something that is fixable with the masterplan skin module?

I have enabled the settings in the Button settings modules and selected a custom border I use. It works great everywhere but the shipyard portion of the garrison mission (masterplan enabled)

Below is an image describing my issue. The shipyard has a button border that is not inset well. On all other buttons the border works great and I am wondering if it is a limitation in the frame or something that can be tweaked? It's super minor and doesn't break functionality but I am super anal retentive.

Or is it just from viewing the button border on a light texture it suddenly shows the concern I have in my really bad picture?

Rollback Post to Revision RollBack
#5476 Feb 2, 2016
Jncl
Jncl

View User Profile

View Posts

Send Message
Curse Premium
- Join Date: 9/30/2008
- Posts: 1,869
- Member Details
Hi,
Updated GarrisonUI skin(s) (as reported by transitbus)

b6.20886.2

Rollback Post to Revision RollBack
#5477 Feb 2, 2016
transitbus
transitbus

View User Profile

View Posts

Send Message
Curse Premium
- Join Date: 10/27/2005
- Posts: 54
- Member Details
That fixed the issue, thanks!

Just a heads up. The way sexy map handles minimap buttons, it prevents skinner from skinning it. Not something that I am afraid you can even do anything about and not an issue since in my case I hide minimap buttons until they trigger something.

Since sexy map handles visibility and button dragging if those options are enabled, it takes over the buttons and won't allow them to be redrawn perhaps?

Minimap button skinning works perfectly fine without a minimap addon enabled so I can confirm it's a limitation with using sexy map (and I can live with it just fine)

Rollback Post to Revision RollBack
#5478 Feb 2, 2016
_ForgeUser22082027
_ForgeUser22082027

View User Profile

View Posts

Send Message
- Join Date: 11/26/2015
- Posts: 3
- Member Details
I'm not sure if transitbus means the same thing about sexymap . I have this issue. I open skinners options and I check 'skin minimap buttons'. Buttons are skinned but when I log out and in again they are not. I open options again , uncheck and checking again 'skin minimap buttons' , and buttons are skinned again until I relog and so on. This happens mostly with default buttons as calendar, missions table etc , some addons buttons are skinned all the time. ( I can live with it just fine too ;) )

Rollback Post to Revision RollBack

#5479 Feb 3, 2016

transitbus

Curse Premium

Join Date: 10/27/2005
Posts: 54
Member Details

While fighting Kazzak with DBM enabled.

5x Attempt to find 'this' in non-framescript object
[C]: ?
[C]: in function `CreateFrame'
Skinner\Skinner-b6.20886.2.lua:598: in function <Skinner\Skinner.lua:540>
(tail call): ?
Skinner\SkinMe\DBM-6.2.18 alpha.14768.lua:119: in function <Skinner\SkinMe\DBM.lua:118>
(tail call): ?
[C]: in function `Show'
DBM-Draenor\Kazzak.lua:60: in function `handler'
DBM-Core\DBM-Core-6.2.17-48-g1979307.lua:636: in function <DBM-Core\DBM-Core.lua:623>
(tail call): ?
DBM-Core\DBM-Core-6.2.17-48-g1979307.lua:636: in function <DBM-Core\DBM-Core.lua:623>
[C]: in function `CastSpellByName'
...
FrameXML\ChatFrame.lua:2707: in function <FrameXML\ChatFrame.lua:2700>
[C]: ?
[C]: in function `UseAction'
FrameXML\SecureTemplates.lua:348: in function `handler'
FrameXML\SecureTemplates.lua:649: in function <FrameXML\SecureTemplates.lua:597>
[C]: ?
FrameXML\SecureHandlers.lua:264: in function <FrameXML\SecureHandlers.lua:261>
[C]: ?
FrameXML\SecureHandlers.lua:294: in function <FrameXML\SecureHandlers.lua:277>
(tail call): ?

Locals:

#5480 Feb 4, 2016
Jncl
Jncl

View User Profile

View Posts

Send Message
Curse Premium
- Join Date: 9/30/2008
- Posts: 1,869
- Member Details
Quote from transitbus
/snip
Just a heads up. The way sexy map handles minimap buttons, it prevents skinner from skinning it.
/snip

Not quite, ;-). This happens because there is code in Skinner to NOT skin the Minimap or Minimap Buttons if SexyMap is loaded. Been in there since July 2013.

Rollback Post to Revision RollBack
#5481 Feb 4, 2016
Jncl
Jncl

View User Profile

View Posts

Send Message
Curse Premium
- Join Date: 9/30/2008
- Posts: 1,869
- Member Details
Quote from Thrassivoulos
/snip
I have this issue. I open skinners options and I check 'skin minimap buttons'. Buttons are skinned but when I log out and in again they are not. I open options again , uncheck and checking again 'skin minimap buttons' , and buttons are skinned again until I relog and so on. This happens mostly with default buttons as calendar, missions table etc , some addons buttons are skinned all the time.
/snip

If you're talking about this issue happening when SexyMap is loaded, please refer to my previous reply to transitbus.

Rollback Post to Revision RollBack
#5482 Mar 6, 2016
Jncl
Jncl

View User Profile

View Posts

Send Message
Curse Premium
- Join Date: 9/30/2008
- Posts: 1,869
- Member Details
Hi,
Updated DBM (as reported by transitbus) & MasterPlan skins

Bugfix for Garrison Mission UI skin
Updated BlackMarketUI skin

Remove ButtonBorders on AlertFrames
MainMenuBar skin change
Move ItemRef Tooltip close button
Move Tab & OOC code to OnEnable function
UnitFrames use a different template for skin background
Add Comments
Remove debug code

b6.20886.3

Rollback Post to Revision RollBack
#5483 Mar 25, 2016
Jncl
Jncl

View User Profile

View Posts

Send Message
Curse Premium
- Join Date: 9/30/2008
- Posts: 1,869
- Member Details
Hi,
Updated FriendsFrame skin
Removed BNCOnversationInvite skin code
Updated GarrisonMission skin
Updated QuestMap skin

Updated version numbers

b6.21355.1

Rollback Post to Revision RollBack
#5484 Mar 27, 2016
gershuun
gershuun

View User Profile

View Posts

Send Message
Curse Premium
- Location: Omaha
- Join Date: 7/14/2008
- Posts: 12
- Member Details
Hi, I've been having a problem for a while. I get an error every time I change my talents and have finally identified which addon may be causing it. With every single addon enabled I have this bug, and only when Skinner or Broker Garrison is disabled the bug goes away.

Message: Error: AddOn AchieveIt attempted to call a forbidden function (RemoveTalent()) from a tainted execution path.
Debug:
[C]: RemoveTalent()
...rface\AddOns\Blizzard_TalentUI\Blizzard_TalentUI.lua:39: OnAccept()
..\FrameXML\StaticPopup.lua:4090: StaticPopup_OnClick()
[string "*:OnClick"]:1:
[string "*:OnClick"]:1
[C]: Click()
..\FrameXML\ChatFrame.lua:1531: ?()
..\FrameXML\ChatFrame.lua:4320:
..\FrameXML\ChatFrame.lua:4287
[C]: ChatEdit_ParseText()
..\FrameXML\ChatFrame.lua:4008: ChatEdit_SendText()
..\FrameXML\ChatFrame.lua:2639:
..\FrameXML\ChatFrame.lua:2632
[C]: RunMacroText()
..\FrameXML\SecureTemplates.lua:463: handler()
..\FrameXML\SecureTemplates.lua:649:
..\FrameXML\SecureTemplates.lua:597
[C]: Click()
..\FrameXML\ChatFrame.lua:1531: ?()
..\FrameXML\ChatFrame.lua:4320:
..\FrameXML\ChatFrame.lua:4287
[C]: ChatEdit_ParseText()
..\FrameXML\ChatFrame.lua:4008: ChatEdit_SendText()
..\FrameXML\ChatFrame.lua:2639:
..\FrameXML\ChatFrame.lua:2632
[C]: RunMacroText()
..\FrameXML\SecureTemplates.lua:463: handler()
..\FrameXML\SecureTemplates.lua:649:
..\FrameXML\SecureTemplates.lua:597
[C]: ?
..\FrameXML\SecureHandlers.lua:264:
..\FrameXML\SecureHandlers.lua:261
[C]: ?
..\FrameXML\SecureHandlers.lua:294:
..\FrameXML\SecureHandlers.lua:277
(tail call): ?

Here's the full error:

http://pastebin.com/d2fq3rF6

Rollback Post to Revision RollBack
#5485 Mar 27, 2016
Myrroddin
Myrroddin

View User Profile

View Posts

Send Message
Forum Moderator
Forum Moderator
- Location: Edmonton
- Join Date: 5/8/2006
- Posts: 1,400
- Member Details
Do you have an AddOn called AchieveIt? The problem with taint is that Blizzard plays the blame game. Not an exact science, but something like this happens:

AddOnOne causes taint
AddOnTwo uses now tainted path
Blizzard blames AddOnTwo
Rollback Post to Revision RollBack
#5486 Mar 27, 2016
Jncl
Jncl

View User Profile

View Posts

Send Message
Curse Premium
- Join Date: 9/30/2008
- Posts: 1,869
- Member Details
[QUOTE=Gershuun;/comments/2199255]Hi, I've been having a problem for a while. I get an error every time I change my talents and have finally identified which addon may be causing it. With every single addon enabled I have this bug, and only when Skinner or Broker Garrison is disabled the bug goes away.

Hi Gershuun,
Can you enable taint logging by entering the following command at the WoW chat prompt
/console taintLog 1
cause the error to happen, then turn off taint logging
/console taintLog 0
and attach the taint log, World of Warcraft\Logs\taint.log, to your post please.
Rollback Post to Revision RollBack
#5487 Apr 14, 2016
gershuun
gershuun

View User Profile

View Posts

Send Message
Curse Premium
- Location: Omaha
- Join Date: 7/14/2008
- Posts: 12
- Member Details
Sure sorry for the delay. It's still happening, here's the taint log.

ATTACHMENTS

taint.txt
Rollback Post to Revision RollBack
#5488 Apr 15, 2016
Jncl
Jncl

View User Profile

View Posts

Send Message
Curse Premium
- Join Date: 9/30/2008
- Posts: 1,869
- Member Details
Quote from Gershuun
Sure sorry for the delay. It's still happening, here's the taint log.

Hi Gershuun,
Thanks for the taint log. Unfortunately there isn't much detail in it. Can you try again but use
/console taintLog 2
which will give more info. As before use
/console taintLog 0
to turn taint capture off.

TIA
Rollback Post to Revision RollBack
#5489 Apr 15, 2016
gershuun
gershuun

View User Profile

View Posts

Send Message
Curse Premium
- Location: Omaha
- Join Date: 7/14/2008
- Posts: 12
- Member Details
Sure here is the taintLog 2

ATTACHMENTS

taint.txt
Rollback Post to Revision RollBack
#5490 May 25, 2016
Acivien
Acivien

View User Profile

View Posts

Send Message
- Join Date: 9/28/2006
- Posts: 62
- Member Details
Hi Jncl,

getting an error since Rematch updated:

17x Skinner\Skinner-b6.21355.1.lua:1981: attempt to index field 'obj' (a nil value)
Skinner\Skinner-b6.21355.1.lua:2005: in function `skinUsingBD'
Skinner\SkinMe\Rematch-4.4.1.lua:300: in function <Skinner\SkinMe\Rematch.lua:5>
(tail call): ?
[C]: in function `xpcall'
Skinner\UtilFuncs.lua:180: in function <Skinner\UtilFuncs.lua:174>
Skinner\UtilFuncs.lua:295: in function `checkAndRunAddOn'
Skinner\AddonFrames.lua:289: in function `?'
...y\Externals\curse\svn\Ace3-AceTimer\AceTimer-3.0-17.lua:53: in function <...y\Externals\curse\svn\Ace3-AceTimer\AceTimer-3.0.lua:48>

Locals:
nil

Rollback Post to Revision RollBack
#5491 May 25, 2016
Myrroddin
Myrroddin

View User Profile

View Posts

Send Message
Forum Moderator
Forum Moderator
- Location: Edmonton
- Join Date: 5/8/2006
- Posts: 1,400
- Member Details
I found some skins in the Obsolete folder that are probably still valid:

MSBTOptions (Mikk's Scrolling Battle Text Options)
MobileVault (hasn't needed updating)
Postal (pretty sure the repo has newer versions)
LibSimpleOptions (I think some AddOns use this)
Prat (duh)
TomTom (still works, updated by Torhal, I believe)
In unrelated stuff, is it possible to skin SmartRes2, or would I have to alter the code in some fashion to allow skinning? You should be able to access the DB easily enough.
Rollback Post to Revision RollBack
#5492 May 27, 2016
Torhal
Torhal

View User Profile

View Posts

Send Message
Project Author
CurseForge
- Location: Meridianville
- Join Date: 2/13/2008
- Posts: 2,860
- Member Details
Quote from myrroddin
I found some skins in the Obsolete folder that are probably still valid:

TomTom (still works, updated by Torhal, I believe)

Nope - still being maintained by the original author.
Rollback Post to Revision RollBack
#5493 May 27, 2016
Jncl
Jncl

View User Profile

View Posts

Send Message
Curse Premium
- Join Date: 9/30/2008
- Posts: 1,869
- Member Details
Hi,
Added skin for SmartRes2 (as requested by myrroddin)
Updated MasterPlan & Rematch (as reported by NeoZeus) skins
Bugfix for QueueStatusMinimapButton skin (as reported by leprecaun13)

Updated version numbers

b6.21742.1

I'm happy to update obsoleted skins if they are still required

@Gershuun, not seeing any taint caused by skinner in the logs

Rollback Post to Revision RollBack
#5494 Jun 2, 2016
gershuun
gershuun

View User Profile

View Posts

Send Message
Curse Premium
- Location: Omaha
- Join Date: 7/14/2008
- Posts: 12
- Member Details
After latest update, still have the problem of not being able to change talents. It only goes away when I disable Skinner or BrokerGarrison so I guess I will be uninstalling BrokerGarrison in Legion anyway.

Rollback Post to Revision RollBack
To post a comment, please login or register a new account.

Previous Thread

Next Thread