I have noticed that Skinner is using an absurd amount of resources lately. More than Recount and Arkinventory, which it never has in the past. It seems to always be grabbing up memory until I garbage dump, then it starts out low and builds itself back up.
I never noticed this behavior before, is this new or did I break it? I am not receiving any errors from the addon, its just my memory usage is unusually high and this is the only one that continuously increases in memory usage.
Love the update, but i was wondering if you could change your tukui skin function aObj:TukuiInit() to this.
[PHP]-- The following code handles the Initial setup of Skinner when the TukUI is loaded
function aObj:TukuiInit()
if IsAddOnLoaded("Tukui") then
local T, C, L = unpack(Tukui)
borderr, borderg, borderb = unpack(C["media"].bordercolor)
backdropr, backdropg, backdropb = unpack(C["media"].backdropcolor)
else
borderr, borderg, borderb = .6,.6,.6
backdropr, backdropg, backdropb = .1, .1, .1
end
self:RawHook(self, "OnInitialize", function(this)
-- Do these before we run the function
-- setup the default DB values and register them
self:checkAndRun("Defaults", true)
self.Defaults = nil -- only need to run this once
-- create and use a new db profile called Tukui
local dbProfile = self.db:GetCurrentProfile()
if dbProfile ~= "Tukui" then
self.db:SetProfile("Tukui") -- create new profile
self.db:CopyProfile(dbProfile) -- use settings from previous profile
-- change settings
self.db.profile.TooltipBorder = {r = borderr, g = borderg, b = borderb, a = 1}
self.db.profile.BackdropBorder = {r = borderr, g = borderg, b = borderb, a = 1}
self.db.profile.Backdrop = {r = backdropr, g = backdropg, b = backdropb, a = 1}
self.db.profile.BdDefault = false
self.db.profile.BdFile = "None"
self.db.profile.BdEdgeFile = "None"
self.db.profile.BdTexture = "Tukui Background"
self.db.profile.BdBorderTexture = "Tukui Border"
self.db.profile.BdTileSize = 0
self.db.profile.BdEdgeSize = 1
self.db.profile.BdInset = -1
self.db.profile.Gradient = {enable = false, invert = false, rotate = false, char = true, ui = true, npc = true, skinner = true, texture = "Tukui Background"}
self.db.profile.Buffs = false
self.db.profile.Nameplates = false
self.db.profile.ChatEditBox = {skin = false, style = 1}
self.db.profile.StatusBar = {texture = "Tukui StatusBar", r = 0, g = 0.5, b = 0.5, a = 0.5}
self.db.profile.WorldMap = {skin = false, size = 1}
end
....... not whole function but shows what i changed.
[/PHP]
That way if people use this skin have tukui installed, and have custom edits with custom coloring Skinner will pick up on that coloring and use the new colors instead of the default ones, like me :o.
Would it be possible to do the same (or similar for ElvUI?
Would it be possible to do the same (or similar for ElvUI?
Hi Jiminimonka,
This should already be happening for ElvUI, the skinning code is very similar to Tukui's skin.
Please let me know if it isn't working and I'll look into it
I have noticed that Skinner is using an absurd amount of resources lately.
Hi baldedp.
Thanks for raising this issue. I'm not seeing a large memory footprint for Skinner, it is usually around 1-1.5 MB when I use it.
I will have a look at the skin code related to Recount to see if there may be something in there.
In your screenshot Bugsack is getting spammed with errors so much that you have a message it has stopped capturing.
This is far from a normal situation to be having performance concerns in.
First see what is producing those errors.
This should already be happening for ElvUI, the skinning code is very similar to Tukui's skin.
Please let me know if it isn't working and I'll look into it
ElvUI has a setting to colour everything by class, when this is activated, ElvUI changes colour but none of the Skinner skins.
EDIT: There are some changes in ElvUI for the config (using ACE for config now) and since this change the skinner themes are all gone back to transparent, don't know if this is caused by ElvUI or requires an update for the ElvUI Skinner file.
1x AceHook-3.0-5 (BigWigs):180: Attempting to rehook already active hook OnInitialize.
AceHook-3.0-5 (BigWigs):180: in function <...face\AddOns\BigWigs\Libs\AceHook-3.0\AceHook-3.0.lua:118>
AceHook-3.0-5 (BigWigs):325: in function `RawHook'
Skinner-b4.13707.2\SkinMe\Tukui.lua:50: in function <Skinner\SkinMe\Tukui.lua:34>
(tail call): ?:
<in C code>: in function `xpcall'
Skinner-b4.13707.2\UtilFuncs.lua:88: in function <Skinner\UtilFuncs.lua:86>
(tail call): ?:
Skinner-b4.13707.2\SkinMe\Tukui.lua:147: in main chunk
This is because you are running both ElvUI and Tukui, the skinning code hooks the same function for each of them so they cannot be run together.
I just copy the whole AddonSkins to the SkinMe folder on each update, deleted the Tukui file and that error is gone now. Thanks.
Still using the latest Github build for ElvUI, the rest of the UI is now in invisible mode for frames and backgrounds etc., but this could just be down to the ElvUI changes, not sure.
I just copy the whole AddonSkins to the SkinMe folder on each update, deleted the Tukui file and that error is gone now.
Hi Jiminimonka,
You can disable the Tukui skin using the Skinner option panel, then you won't need to delete it. ;)
Why are you running both Tukui and ElvUI together ? I thought ElvUI was a replacement for Tukui.
I am not running them both together. There are some addons for TukUI that won't work with ElvUI without a DB converter. So Elv added it to his UI, and I am guessing that Skinner is picking it up as a TukUI.
Seems that with the latest build, Skinner is not working with ElvUI, I will keep you posted when its a release version (there have been some big changes to ElvUI recently).
Sorry, out on a small vacation this week. The buggrabber errors are from Carbonite. I am almost ready to get rid of that addon. It doesn't like a raids and dungeons.
I am not running them both together. There are some addons for TukUI that won't work with ElvUI without a DB converter. So Elv added it to his UI, and I am guessing that Skinner is picking it up as a TukUI.
Seems that with the latest build, Skinner is not working with ElvUI, I will keep you posted when its a release version (there have been some big changes to ElvUI.
Hi Jiminimonka,
Thanks for the feedback, I'll look into the DB converter issue and fix it. I will wait for the release version of ElvUI before I update the skin.
Having a small problem with Skinner atm. For some reason it does not want to skin the Talent Point, Achievment or Guild Windows. Everything else is fine. Am using b4.13707.2
Edit: I tried running skinner alone with each addon I have and it seems to only do this when RaidWatch 2 is enabled.
Skinned epgp_lootmaster (as requested by Jiminimonka)
Updated ElvUI &, Tukui (as reported by Jiminimonka), HealBot(thanks to acirac), Recount skins
PTR changes
Options changes
PVP Areana panel changes
Tab type changes
b4.13812.1
@ Greevir, RaidWatch2 isn't skinned. What errors are being produced on login or during gameplay ?
Thanks for the update Jncl - The ElvUI & Skinner are currently not working (all the non-ElvUI stuff is invisible backgrounds and borders). I am going through all the other addons one at a time to see if its something else causing the problem, I will post back and let you know.
Rollback Post to RevisionRollBack
To post a comment, please login or register a new account.
I never noticed this behavior before, is this new or did I break it? I am not receiving any errors from the addon, its just my memory usage is unusually high and this is the only one that continuously increases in memory usage.
Would it be possible to do the same (or similar for ElvUI?
It is using over 12MB of memory. Never seen that before.
Hi Jiminimonka,
Please let me know if it isn't working and I'll look into it
Hi baldedp.
I will have a look at the skin code related to Recount to see if there may be something in there.
This is far from a normal situation to be having performance concerns in.
First see what is producing those errors.
ElvUI has a setting to colour everything by class, when this is activated, ElvUI changes colour but none of the Skinner skins.
EDIT: There are some changes in ElvUI for the config (using ACE for config now) and since this change the skinner themes are all gone back to transparent, don't know if this is caused by ElvUI or requires an update for the ElvUI Skinner file.
Could I also request skinning EPGPLootMaster - http://wow.curseforge.com/addons/epgp_lootmaster/ if possible?
Thanks for all your hard work.
Hi Jiminimonka,
I just copy the whole AddonSkins to the SkinMe folder on each update, deleted the Tukui file and that error is gone now. Thanks.
Still using the latest Github build for ElvUI, the rest of the UI is now in invisible mode for frames and backgrounds etc., but this could just be down to the ElvUI changes, not sure.
Hi Jiminimonka,
Why are you running both Tukui and ElvUI together ? I thought ElvUI was a replacement for Tukui.
Seems that with the latest build, Skinner is not working with ElvUI, I will keep you posted when its a release version (there have been some big changes to ElvUI recently).
https://github.com/Elv22/Tukui
Hi Jiminimonka,
Its now a release version on wowinterface.com
Edit: I tried running skinner alone with each addon I have and it seems to only do this when RaidWatch 2 is enabled.
Updated ElvUI &, Tukui (as reported by Jiminimonka), HealBot(thanks to acirac), Recount skins
PTR changes
Options changes
PVP Areana panel changes
Tab type changes
b4.13812.1
@ Greevir, RaidWatch2 isn't skinned. What errors are being produced on login or during gameplay ?
Thanks for the update Jncl - The ElvUI & Skinner are currently not working (all the non-ElvUI stuff is invisible backgrounds and borders). I am going through all the other addons one at a time to see if its something else causing the problem, I will post back and let you know.