Corrected Addon Loading check to prevent ignored addons being skinned.
r 16242
Sorry, it was late, I was tired and didn't test it properly. :(
@ griddark - SpecialTalent is skinned
@ Anolin - you add the names of the addons that you don't want to be skinned
Your last change a few minutes before leads to this:
[2006/11/07 14:23:41-729]: Skinner\AddonFrames.lua:69: attempt to call global "checkAddOn"
Skinner\AddonFrames.lua:69: in function "event"
AceEvent-2.0\AceEvent-2.0.lua:422: in function <Interface\AddOns\Ace2\AceEvent-2.0\AceEvent-2.0.lua:402>
My only complaint about oSkin and now Skinner is that the mod is trying to skin every other mod on the face of the planet without making it modular. Hell, the only thing I really use is the top and bottomframe :P
Indeed.. I'm still using a very old bottom frame that someone made when oSkin first appeared. Tried the full package and hated it :(
Hope it gets back to basics..
Is there anyway you could zip that up somewhere so i could download it, im having problems backtracking it on the svn to find a old enough version.
My only complaint about oSkin and now Skinner is that the mod is trying to skin every other mod on the face of the planet without making it modular. Hell, the only thing I really use is the top and bottomframe :P
Indeed.. I'm still using a very old bottom frame that someone made when oSkin first appeared. Tried the full package and hated it :(
Hope it gets back to basics..
Is there anyway you could zip that up somewhere so i could download it, im having problems backtracking it on the svn to find a old enough version.
How about 2 versions of skinner. 1 version is just the bottom and top frames with options for fadeheight and gradients, and the other version is for people who want to skin everything?
How about 2 versions of skinner. 1 version is just the bottom and top frames with options for fadeheight and gradients, and the other version is for people who want to skin everything?
~Anolin
Can't you just disable every skin? they all seem to have on/off options attached to each frame....
How about 2 versions of skinner. 1 version is just the bottom and top frames with options for fadeheight and gradients, and the other version is for people who want to skin everything?
~Anolin
Can't you just disable every skin? they all seem to have on/off options attached to each frame....
Yes, I already have. But that doesn't change all the code I'm loading up that's not being used...
[2006/11/07 17:37:34-312]: Skinner\AOElements.lua:807: attempt to index field "AuctionFrame"
<in C code>: ?
Skinner\AOElements.lua:807: in function "Auctioneer"
Skinner\AddonFrames.lua:104: in function "event"
AceEvent-2.0\AceEvent-2.0.lua:422: in function <Interface\AddOns\Ace2\AceEvent-2.0\AceEvent-2.0.lua:402>
Yes, I already have. But that doesn't change all the code I'm loading up that's not being used...
Fair point. Didn't think of that. Perhaps oskin could be split up into a more modular design (perhaps using multiple folders; top/bottom frame, core skins, addon skins).
Yes, I already have. But that doesn't change all the code I'm loading up that's not being used...
Fair point. Didn't think of that. Perhaps oskin could be split up into a more modular design (perhaps using multiple folders; top/bottom frame, core skins, addon skins).
Yes, I already have. But that doesn't change all the code I'm loading up that's not being used...
Fair point. Didn't think of that. Perhaps oskin could be split up into a more modular design (perhaps using multiple folders; top/bottom frame, core skins, addon skins).
That would be the ideal solution :)
no offense or anything, but Skinner is actually already very modular. if you understand almost anything about the way Skinner works, you can very easily go into the code and only skin what you want skinned and remove everything else. i have done this and it all works wonderfully and yes it uses a lot less memory than the full version of Skinner. Props to JNCL (i hope thats right) and Haste, the code is wonderfully commented and if you take 5 minutes you will understand most of what its doing.
I get some huge announcement in the middle of the screen which takes up almost 3/4 of my screen every time my name is said in a chat frame. What option in Skinner disables this behaviour as it's very annoying and only happens when the Skinner mod is enabled.
Yes, I already have. But that doesn't change all the code I'm loading up that's not being used...
Fair point. Didn't think of that. Perhaps oskin could be split up into a more modular design (perhaps using multiple folders; top/bottom frame, core skins, addon skins).
That would be the ideal solution :)
no offense or anything, but Skinner is actually already very modular. if you understand almost anything about the way Skinner works, you can very easily go into the code and only skin what you want skinned and remove everything else. i have done this and it all works wonderfully and yes it uses a lot less memory than the full version of Skinner. Props to JNCL (i hope thats right) and Haste, the code is wonderfully commented and if you take 5 minutes you will understand most of what its doing.
No offense, but "going into the code" may or may not be easy depending on the person involved. Don't you think deleting modules from a module folder would be much better and safer for the average user?
I get some huge announcement in the middle of the screen which takes up almost 3/4 of my screen every time my name is said in a chat frame. What option in Skinner disables this behaviour as it's very annoying and only happens when the Skinner mod is enabled.
I think that's caused by the Prat addon. It's a feature that was just recently added to it.
Currently I use DiscordArt to make background frames with a custom height/width/backgroundcolor/border. I'd like to get rid of DiscordArt entirely, as that is all I use it for. I've noticed oSkin(Skinner) has this exact same feature in two premade frames called the "top and bottom frames".
My request is to impliment a feature to allow usermade custom height/width frames, with perhaps optional user-defined custom border textures (default being Interface\Buttons\UI-SliderBar-Border).
I get some huge announcement in the middle of the screen which takes up almost 3/4 of my screen every time my name is said in a chat frame. What option in Skinner disables this behaviour as it's very annoying and only happens when the Skinner mod is enabled.
I'm using the latest skinner and don't experiance this problem, you probably have a chat mod like "cleanchat or chatmod" doing it.
I get some huge announcement in the middle of the screen which takes up almost 3/4 of my screen every time my name is said in a chat frame. What option in Skinner disables this behaviour as it's very annoying and only happens when the Skinner mod is enabled.
I'm using the latest skinner and don't experiance this problem, you probably have a chat mod like "cleanchat or chatmod" doing it.
Yes, I already have. But that doesn't change all the code I'm loading up that's not being used...
Fair point. Didn't think of that. Perhaps oskin could be split up into a more modular design (perhaps using multiple folders; top/bottom frame, core skins, addon skins).
so i have started to do this, and it has become exceedingly clear to me that this is not as easily done as said. the way that Skinner decides if it is going to skin and an addon makes it a little bit hard to split it up nicely into an lua file for each addon. like prat, the toc file still has to be edited in order to not include the extra lua files on load. but i think there will need to be a second set of editing done on the persons part in the AddonFrames.lua, because they would need to comment out the check for their addon, so that that addons skinning ability isn't called. in all honesty i could make this work the way your talking about, but not without changing alot of the code and the current structure of the addon, any ideas and comments are welcome
[2006/11/07 17:37:34-312]: Skinner\AOElements.lua:807: attempt to index field "AuctionFrame"
<in C code>: ?
Skinner\AOElements.lua:807: in function "Auctioneer"
Skinner\AddonFrames.lua:104: in function "event"
AceEvent-2.0\AceEvent-2.0.lua:422: in function <Interface\AddOns\Ace2\AceEvent-2.0\AceEvent-2.0.lua:402>
Getting the same error here.
[2006/11/08 17:43:22-112]: Skinner\AOElements.lua:807: attempt to index field "AuctionFrame" (a nil value)
Skinner\AOElements.lua:807: in function "Auctioneer"
Skinner\AddonFrames.lua:104: in function "event"
AceEvent\AceEvent-2.0.lua:422: in function <...\AddOns\ag_UnitFrames\libs\AceEvent\AceEvent-2.0.lua:402>
-k
Rollback Post to RevisionRollBack
To post a comment, please login or register a new account.
Your last change a few minutes before leads to this:
[2006/11/07 14:23:41-729]: Skinner\AddonFrames.lua:69: attempt to call global "checkAddOn"
Skinner\AddonFrames.lua:69: in function "event"
AceEvent-2.0\AceEvent-2.0.lua:422: in function <Interface\AddOns\Ace2\AceEvent-2.0\AceEvent-2.0.lua:402>
-
View User Profile
-
View Posts
-
Send Message
Curse PremiumFixed bug, should test Addon name not "addonName" and call the new function correctly :(
r 16243
Is there anyway you could zip that up somewhere so i could download it, im having problems backtracking it on the svn to find a old enough version.
How about 2 versions of skinner. 1 version is just the bottom and top frames with options for fadeheight and gradients, and the other version is for people who want to skin everything?
~Anolin
Can't you just disable every skin? they all seem to have on/off options attached to each frame....
Yes, I already have. But that doesn't change all the code I'm loading up that's not being used...
Fair point. Didn't think of that. Perhaps oskin could be split up into a more modular design (perhaps using multiple folders; top/bottom frame, core skins, addon skins).
That would be the ideal solution :)
Thankyou very much. xD
no offense or anything, but Skinner is actually already very modular. if you understand almost anything about the way Skinner works, you can very easily go into the code and only skin what you want skinned and remove everything else. i have done this and it all works wonderfully and yes it uses a lot less memory than the full version of Skinner. Props to JNCL (i hope thats right) and Haste, the code is wonderfully commented and if you take 5 minutes you will understand most of what its doing.
No offense, but "going into the code" may or may not be easy depending on the person involved. Don't you think deleting modules from a module folder would be much better and safer for the average user?
I think that's caused by the Prat addon. It's a feature that was just recently added to it.
My request is to impliment a feature to allow usermade custom height/width frames, with perhaps optional user-defined custom border textures (default being Interface\Buttons\UI-SliderBar-Border).
Here's what I mean:
http://img143.imageshack.us/img143/9694/requestrw8.jpg
I'm using the latest skinner and don't experiance this problem, you probably have a chat mod like "cleanchat or chatmod" doing it.
It's prat.
so i have started to do this, and it has become exceedingly clear to me that this is not as easily done as said. the way that Skinner decides if it is going to skin and an addon makes it a little bit hard to split it up nicely into an lua file for each addon. like prat, the toc file still has to be edited in order to not include the extra lua files on load. but i think there will need to be a second set of editing done on the persons part in the AddonFrames.lua, because they would need to comment out the check for their addon, so that that addons skinning ability isn't called. in all honesty i could make this work the way your talking about, but not without changing alot of the code and the current structure of the addon, any ideas and comments are welcome
Getting the same error here.
-k