Skinner

#3267 May 6, 2009

pompachomp

Curse Premium

Join Date: 10/20/2008
Posts: 51
Member Details

getting following error with questguru 1.0.5 and skinner 1.9806.1


[2009/05/06 18:12:15-645-x1]: Skinner-b1.9806.1 \SkinMe\QuestGuru.lua:123: Usage: SecureHook([object], method, [handler]): Attempting to hook a non existing target
AceHook-3.0-5 (Ace3):200: in function <Interface\AddOns\Ace3\AceHook-3.0\AceHook-3.0.lua:107>
AceHook-3.0-5 (Ace3):276: in function `SecureHook'
Skinner-b1.9806.1 \SkinMe\QuestGuru.lua:123: in function <Interface\AddOns\Skinner\SkinMe\QuestGuru.lua:2>
(tail call): ?:
<in C code>: in function `xpcall'
Skinner-b1.9806.1 \Skinner.lua:430: in function <Interface\AddOns\Skinner\Skinner.lua:428>
Skinner-b1.9806.1 \Skinner.lua:475: in function `?'
Skinner-b1.9806.1 \AddonFrames.lua:112: in function <Interface\AddOns\Skinner\AddonFrames.lua:58>
(tail call): ?:
<in C code>: ?
<string>:"safecall Dispatcher[2]":9: in function <[string "safecall Dispatcher[2]"]:5>
(tail call): ?:
AceTimer-3.0-5 (Ace3):144: in function <Interface\AddOns\Ace3\AceTimer-3.0\AceTimer-3.0.lua:118>
  ---

#3268 May 8, 2009
Jncl
Jncl

View User Profile

View Posts

Send Message
Curse Premium
- Join Date: 9/30/2008
- Posts: 1,677
- Member Details
Hi,

Major rewrite of the core code to ease code maintenance and remove any changes to Blizzard Frames directly, they are all now 'backed' by a skin frame

This means several addon skins will now have misplaced artifacts, pleased let me know which ones and I will fix them as soon as I can.

I have already updated a number of skins to reflect these changes, they are:

Ace2, Ace3, AckisRecipeList, AucAdvanced, AutoProfit, Badapples, beql, Configator, Examiner, LightHeaded, oRA3, PerlClassic, QuestGuru, Talented & TourGuide

I have also removed several skins as they are no longer required, they are:

DoubleWide, DoubleWideTradeSkills & ExtendedQuestFrame

Skinned BetterBindingFrame (as requested by KLSmili)

Removed references to AutoProfitX skin

Added option for GMChatUI skinning

b2.9835.1

Rollback Post to Revision RollBack

#3269 May 8, 2009

_ForgeUser70972

Location:
Join Date: 2/16/2006
Posts: 2,432
Member Details

Outfitter button is to far to the right.
Volumizer LDB tooltip thing title is ofset, and partially unskinned.
Visor2 gui title is ofset.

and 2 errors:

[2009/05/08 21:02:17-3548-x1]: Skinner-b2.9835.1\SkinMe\Altoholic.lua:123: Usage: SecureHook([object], method, [handler]): Attempting to hook a non existing target
AceHook-3.0-5 (Ace3):208: in function <Interface\AddOns\Ace3\AceHook-3.0\AceHook-3.0.lua:115>
AceHook-3.0-5 (Ace3):341: in function `SecureHook'
Skinner-b2.9835.1\SkinMe\Altoholic.lua:123: in function <Interface\AddOns\Skinner\SkinMe\Altoholic.lua:2>
(tail call): ?:
<in C code>: ?
Skinner-b2.9835.1\Skinner.lua:638: in function <Interface\AddOns\Skinner\Skinner.lua:636>
Skinner-b2.9835.1\Skinner.lua:683: in function `?'
Skinner-b2.9835.1\AddonFrames.lua:114: in function <Interface\AddOns\Skinner\AddonFrames.lua:60>
(tail call): ?:
<in C code>: ?
<string>:"safecall Dispatcher[2]":9: in function <[string "safecall Dispatcher[2]"]:5>
(tail call): ?:
AceTimer-3.0-5 (Ace3):158: in function <Interface\AddOns\Ace3\AceTimer-3.0\AceTimer-3.0.lua:132>

  ---

[2009/05/08 21:02:17-3548-x1]: Skinner-b2.9835.1\Skinner.lua:1318: bad argument #1 to 'rawget' (table expected, got nil)
Skinner-b2.9835.1\Skinner.lua:1318: in function `skinEditBox'
Skinner-b2.9835.1\SkinMe\Visor2GUI.lua:7: in function <Interface\AddOns\Skinner\SkinMe\Visor2GUI.lua:2>
(tail call): ?:
<in C code>: ?
Skinner-b2.9835.1\Skinner.lua:638: in function <Interface\AddOns\Skinner\Skinner.lua:636>
Skinner-b2.9835.1\Skinner.lua:683: in function `?'
Skinner-b2.9835.1\AddonFrames.lua:114: in function <Interface\AddOns\Skinner\AddonFrames.lua:60>
(tail call): ?:
<in C code>: ?
<string>:"safecall Dispatcher[2]":9: in function <[string "safecall Dispatcher[2]"]:5>
(tail call): ?:
AceTimer-3.0-5 (Ace3):158: in function <Interface\AddOns\Ace3\AceTimer-3.0\AceTimer-3.0.lua:132>

  ---

Last edited by _ForgeUser70972: May 8, 2009

#3270 May 8, 2009

_ForgeUser902810

Join Date: 6/29/2008
Posts: 8
Member Details

With version b2.9835.1, at logon with a new install:

Date: 2009-05-08 16:35:07
ID: 1
Error occured in: Global
Count: 1
Message: ..\AddOns\Skinner\Skinner.lua line 618:
   bad argument #1 to 'rawget' (table expected, got nil)
Debug:
   (tail call): ?
   (tail call): ?
   [C]: ?
   Skinner\Skinner.lua:618: applySkin()
   Skinner\SkinMe\TipTac.lua:15:
      Skinner\SkinMe\TipTac.lua:2
   (tail call): ?
   [C]: ?
   Skinner\Skinner.lua:638:
      Skinner\Skinner.lua:636
   Skinner\Skinner.lua:683: ?()
   Skinner\AddonFrames.lua:114:
      Skinner\AddonFrames.lua:60
   (tail call): ?
   [C]: ?
   [string "safecall Dispatcher[2]"]:9:
      [string "safecall Dispatcher[2]"]:5
   (tail call): ?
   Ace3\AceTimer-3.0\AceTimer-3.0.lua:158:
      Ace3\AceTimer-3.0\AceTimer-3.0.lua:132

#3271 May 8, 2009
Jncl
Jncl

View User Profile

View Posts

Send Message
Curse Premium
- Join Date: 9/30/2008
- Posts: 1,677
- Member Details
Hi,

Bugfix for handling changed Addons

b2.9835.2

Sorry about that, put the checking code in the wrong place :-(

Rollback Post to Revision RollBack
#3272 May 8, 2009
_ForgeUser70972
_ForgeUser70972

View User Profile

View Posts

Send Message
- Location:
- Join Date: 2/16/2006
- Posts: 2,432
- Member Details
Button for auctionfilterplus is slightly ofset.

Not sure, but i think its outfitter related when looking at stuff in AH there are additional compare tooltips for different sets (apart from the 2(3 for rings) normal ones, these aren't being fully skinned. (white backdround and unskinned borders).

Rollback Post to Revision RollBack
#3273 May 8, 2009
gizmo1972
gizmo1972

View User Profile

View Posts

Send Message
Curse Premium
- Join Date: 2/12/2008
- Posts: 14
- Member Details
Im having a small issue with the quest greeting frame which can be seen in the screenshot below, the frame is fine when i click accept a quest and see the details, but when i first open it i get this.

Rollback Post to Revision RollBack
#3274 May 8, 2009
_ForgeUser11618
_ForgeUser11618

View User Profile

View Posts

Send Message
- Join Date: 4/8/2005
- Posts: 35
- Member Details
Hello,

I have a issue when changing the texture. Everytime I try to change the texture, "Error running updateSBTexture." will show up in my chat frame. I have Bugsack but for some reason it didn't catch anything... (maybe it's not a bug?)

So right now my texture is the original Blizzard texture... I really want to use something else so please help.

Thanks in advance.

Rollback Post to Revision RollBack
#3275 May 9, 2009
_ForgeUser347210
_ForgeUser347210

View User Profile

View Posts

Send Message
- Location:
- Join Date: 10/22/2007
- Posts: 71
- Member Details
Outfitter's button and windows are offset

Rollback Post to Revision RollBack
#3276 May 9, 2009
_ForgeUser108757
_ForgeUser108757

View User Profile

View Posts

Send Message
- Location:
- Join Date: 6/28/2006
- Posts: 113
- Member Details
Using Skinner b2.9835.2, I am getting the following error on login:

"Skinner: Error running MinimapButtons"
The bugsack error is as follows. (I am using Chinchilla, but recieve the same error when it is not loaded, so I do not think it is an interraction problem).

[2009/05/09 02:28:13-8741-x1]: Skinner-b2.9835.1\Skinner.lua:378: attempt to call method 'SetDrawLayer' (a nil value)
Skinner-b2.9835.1\Skinner.lua:407: in function `addSkinButton'
Skinner-b2.9835.1\UIElements1.lua:779: in function <Interface\AddOns\Skinner\UIElements1.lua:750>
Skinner-b2.9835.1\UIElements1.lua:787: in function `mmKids'
Skinner-b2.9835.1\UIElements1.lua:794: in function <Interface\AddOns\Skinner\UIElements1.lua:746>
(tail call): ?:
<in C code>: ?
Skinner-b2.9835.1\Skinner.lua:638: in function <Interface\AddOns\Skinner\Skinner.lua:636>
Skinner-b2.9835.1\Skinner.lua:650: in function <Interface\AddOns\Skinner\Skinner.lua:646>
(tail call): ?:
<in C code>: ?
<string>:"safecall Dispatcher[2]":9: in function <[string "safecall Dispatcher[2]"]:5>
(tail call): ?:
AceTimer-3.0-5 (Acheron):158: in function <...ce\AddOns\Acheron\Libs\AceTimer-3.0\AceTimer-3.0.lua:132>

---

Rollback Post to Revision RollBack
#3277 May 9, 2009
_ForgeUser23602
_ForgeUser23602

View User Profile

View Posts

Send Message
- Location:
- Join Date: 6/25/2005
- Posts: 44
- Member Details
Hi, quick report on Skinner's "strange results" on some addons:

sRaidFrames: Skinner overwrites the background coloring of raid frames. As a result you can't see the color of applied debuff (and you can't dispell 'em).

epgp: subframes are misplaced. Commenting out the line:
"if i == 1 then Skinner:moveObject(v, nil, nil, "+", 20) end"
solves the issue. However I'm not totally good with this solution, as there is a huge unused space at the top of the frame.

AdvancedTradeSkillWindow: misplaced "buy reagents" frame when you want to buy reagents from vendor with confirmation.

Not directly related to any skin, fur the "sell junk" button added from FuBar_GarbageFu is misplaced (too much high and right). Maybe it's related to the vendor window skinning.

Cheers

Rollback Post to Revision RollBack
#3279 May 9, 2009
Jncl
Jncl

View User Profile

View Posts

Send Message
Curse Premium
- Join Date: 9/30/2008
- Posts: 1,677
- Member Details
Hi,

More Bugfixes

b2.9835.3

Rollback Post to Revision RollBack
#3280 May 9, 2009
Jncl
Jncl

View User Profile

View Posts

Send Message
Curse Premium
- Join Date: 9/30/2008
- Posts: 1,677
- Member Details
Quote from Arzach
/snip
Not directly related to any skin, fur the "sell junk" button added from FuBar_GarbageFu is misplaced (too much high and right). Maybe it's related to the vendor window skinning.

Cheers

Hi Arzach,

Thanks for the bug reports.

There isn't a skin for FuBar_GarbageFu and I can't find an up to date version of the addon to test with.

Rollback Post to Revision RollBack
#3281 May 9, 2009
_ForgeUser1276854
_ForgeUser1276854

View User Profile

View Posts

Send Message
- Location:
- Join Date: 10/14/2008
- Posts: 2
- Member Details
Hi,

Great addon and thanks for the latest updates.

In line with your request I am getting the following error with Chinchilla

[2009/05/09 15:10:29-8097-x1]: Skinner-b2.9835.3\SkinMe\Chinchilla.lua:24: attempt to call method 'IsModuleActive' (a nil value)
(tail call): ?:
<in C code>: ?
Skinner-b2.9835.3\Skinner.lua:647: in function <Interface\AddOns\Skinner\Skinner.lua:645>
Skinner-b2.9835.3\Skinner.lua:692: in function `?'
Skinner-b2.9835.3\AddonFrames.lua:114: in function <Interface\AddOns\Skinner\AddonFrames.lua:60>
(tail call): ?:
<in C code>: ?
<string>:"safecall Dispatcher[2]":9: in function <[string "safecall Dispatcher[2]"]:5>
(tail call): ?:
AceTimer-3.0-5 (Chinchilla):158: in function <...AddOns\Chinchilla\libs\AceTimer-3.0\AceTimer-3.0.lua:132>

Chinchilla was recently updated by Mr knight, so I guess he changed something which stops the old skinner chinchilla lua finding it.

Also getting a weird layout when I use EnhancedStackSplit addon

Hope this helps

Last edited by _ForgeUser1276854: May 9, 2009

Rollback Post to Revision RollBack
#3282 May 9, 2009
_ForgeUser106061
_ForgeUser106061

View User Profile

View Posts

Send Message
- Location:
- Join Date: 6/23/2006
- Posts: 1
- Member Details
following the update to b2.9835.3, is there any way that the worldmap can have its border extended as it used to for a resolution of 1680 x 1050 wide

Rollback Post to Revision RollBack
#3283 May 9, 2009
pompachomp
pompachomp

View User Profile

View Posts

Send Message
Curse Premium
- Join Date: 10/20/2008
- Posts: 51
- Member Details
Error with the xperl skin in newest skinner version:

[2009/05/09 16:13:26-659-x1]: Skinner-b2.9835.3\Skinner.lua:376: attempt to call method 'GetNumRegions' (a nil value)
Skinner-b2.9835.3\Skinner.lua:416: in function `addSkinButton'
Skinner-b2.9835.3\SkinMe\XPerl.lua:88: in function <Interface\AddOns\Skinner\SkinMe\XPerl.lua:69>
(tail call): ?:
<in C code>: ?
Skinner-b2.9835.3\Skinner.lua:647: in function <Interface\AddOns\Skinner\Skinner.lua:645>
Skinner-b2.9835.3\Skinner.lua:692: in function `checkAndRunAddOn'
Skinner-b2.9835.3\SkinMe\XPerl.lua:6: in function <Interface\AddOns\Skinner\SkinMe\XPerl.lua:2>
(tail call): ?:
<in C code>: ?
Skinner-b2.9835.3\Skinner.lua:647: in function <Interface\AddOns\Skinner\Skinner.lua:645>
Skinner-b2.9835.3\Skinner.lua:692: in function `?'
Skinner-b2.9835.3\AddonFrames.lua:114: in function <Interface\AddOns\Skinner\AddonFrames.lua:60>
(tail call): ?:
<in C code>: ?
<string>:"safecall Dispatcher[2]":9: in function <[string "safecall Dispatcher[2]"]:5>
(tail call): ?:
AceTimer-3.0-5 (Ace3):144: in function <Interface\AddOns\Ace3\AceTimer-3.0\AceTimer-3.0.lua:118>

---

[2009/05/09 16:13:26-659-x1]: Skinner-b2.9835.3\Skinner.lua:376: attempt to call method 'GetNumRegions' (a nil value)
Skinner-b2.9835.3\Skinner.lua:416: in function `addSkinButton'
Skinner-b2.9835.3\SkinMe\XPerl.lua:182: in function <Interface\AddOns\Skinner\SkinMe\XPerl.lua:167>
(tail call): ?:
<in C code>: ?
Skinner-b2.9835.3\Skinner.lua:647: in function <Interface\AddOns\Skinner\Skinner.lua:645>
Skinner-b2.9835.3\Skinner.lua:692: in function `checkAndRunAddOn'
Skinner-b2.9835.3\SkinMe\XPerl.lua:8: in function <Interface\AddOns\Skinner\SkinMe\XPerl.lua:2>
(tail call): ?:
<in C code>: ?
Skinner-b2.9835.3\Skinner.lua:647: in function <Interface\AddOns\Skinner\Skinner.lua:645>
Skinner-b2.9835.3\Skinner.lua:692: in function `?'
Skinner-b2.9835.3\AddonFrames.lua:114: in function <Interface\AddOns\Skinner\AddonFrames.lua:60>
(tail call): ?:
<in C code>: ?
<string>:"safecall Dispatcher[2]":9: in function <[string "safecall Dispatcher[2]"]:5>
(tail call): ?:
AceTimer-3.0-5 (Ace3):144: in function <Interface\AddOns\Ace3\AceTimer-3.0\AceTimer-3.0.lua:118>

---

AckisRecipeList isn't fully skinned still: screenshot

Last edited by pompachomp: May 9, 2009

Rollback Post to Revision RollBack
#3285 May 10, 2009
gizmo1972
gizmo1972

View User Profile

View Posts

Send Message
Curse Premium
- Join Date: 2/12/2008
- Posts: 14
- Member Details
Using update b2.9835.3, i still have that issue on that one quest frame greeting panel i posted a page back, seems like its the only npc that give me that issue.

Edit: I got it to work by changing the following lines:

-->>-- Greeting Panel
self:skinScrollBar{obj=QuestGreetingScrollFrame}
if QuestFrameGreetingPanel:IsShown() then
GreetingText:SetTextColor(self.BTr, self.BTg, self.BTb)
CurrentQuestsText:SetTextColor(self.HTr, self.HTg, self.HTb)
AvailableQuestsText:SetTextColor(self.HTr, self.HTg, self.HTb)
QuestFrameGreetingPanel_OnShow() -- force recolour of quest lines

to this:

-->>-- Greeting Panel
self:keepFontStrings(QuestFrameGreetingPanel)
GreetingText:SetTextColor(self.BTr, self.BTg, self.BTb)
CurrentQuestsText:SetTextColor(self.HTr, self.HTg, self.HTb)
AvailableQuestsText:SetTextColor(self.HTr, self.HTg, self.HTb)
self:skinScrollBar{obj=QuestGreetingScrollFrame}

The frame properly skins now, but im not sure what else that change may affect, as I dont understand all of the addon code, but anyway I hope this gives you a starting point.

Last edited by gizmo1972: May 10, 2009

Rollback Post to Revision RollBack
#3286 May 10, 2009
Sky187
Sky187

View User Profile

View Posts

Send Message
- Join Date: 9/4/2006
- Posts: 757
- Member Details
tomQuest2 skinned looks really weird: http://bildr.no/view/407225

Also:

[2009/05/10 13:40:14-2353-x1]: Skinner-b2.9835.3\UIElements2.lua:281: attempt to call method 'GetNumChildren' (a nil value)
(tail call): ?:
<in C code>: in function `InterfaceOptionsList_DisplayPanel'
Interface\FrameXML\UIOptionsFrame.lua:46: in function `InterfaceOptionsListButton_OnClick':
<string>:"*:OnClick":2: in function <[string "*:OnClick"]:1>

---

Last edited by Sky187: May 10, 2009

Rollback Post to Revision RollBack
#3287 May 10, 2009
_ForgeUser902810
_ForgeUser902810

View User Profile

View Posts

Send Message
- Join Date: 6/29/2008
- Posts: 8
- Member Details
Skinner for AckisRecipeList may need an update (see attached zip for a JPG shot with pretty arrows, descriptive text, and such).
Summary: There's a frame that appears if you drill down the Filter options in ARL that appears with no background when skinned. [Update: This is the same issue Pompachomp mentions above in the last line of his post.]

Separately, Mapster, while I don't see a Mapster.lua in Skinner's folders, appears to want to be skinned by Skinner. I'm not sure why. I would want it supported by Skinner, if that's a viable option. Otherwise, I think what's happening is Mapster (maybe) uses Blizz resources, and so perhaps Skinner is catching those - but not the Mapster-specific bits of it's frames.

Finally, thanks for the super-quick fix relating to my prior posting.

ATTACHMENTS

SkinnerAndARL.zip
Last edited by _ForgeUser902810: May 10, 2009

Rollback Post to Revision RollBack
#3288 May 10, 2009
Sky187
Sky187

View User Profile

View Posts

Send Message
- Join Date: 9/4/2006
- Posts: 757
- Member Details
New version of Examiner is out, and this error pops up with skinner:

[2009/05/10 19:15:06-2363-x1]: Skinner-b2.9835.3\SkinMe\Examiner.lua:9: attempt to index field 'frames' (a nil value)
(tail call): ?:
<in C code>: ?
Skinner-b2.9835.3\Skinner.lua:647: in function <Interface\AddOns\Skinner\Skinner.lua:645>
Skinner-b2.9835.3\Skinner.lua:692: in function `?'
Skinner-b2.9835.3\AddonFrames.lua:114: in function <Interface\AddOns\Skinner\AddonFrames.lua:60>
(tail call): ?:
<in C code>: ?
<string>:"safecall Dispatcher[2]":9: in function <[string "safecall Dispatcher[2]"]:5>
(tail call): ?:
AceTimer-3.0-5 (Broker_Group):158: in function <...dOns\Broker_Group\libs\AceTimer-3.0\AceTimer-3.0.lua:132>

---

Rollback Post to Revision RollBack
To post a comment, please login or register a new account.

Previous Thread

Next Thread