@soltari: I've added a toggle to the config window that allows you to restict fights that are retained to those that had a boss mob (lvl -1) in it. Hope that helps for now. I'll look at a possibility for a slider later.
I've tested this thoroughly yesterday and it works perfectly. :) Thank you very much for adding it.
I have one more wish. Can you increase parameter MaxFights=5 to something larger like 30? Since older combats are already counted in Overall Data, it would be great to choose from more then last 5 combats/bosses.
no POM recorded in the last version..
or better, every pom ( 2 x holy priest in a za raid ) was signed under a "no name" bar, sometime with lock color, sometime with shaman color, sometime with priest ( looking at the current fight count ).
Looking at the overall healing pom did not show as used under any player ( looking ofc at any priest type of spell used ).
recount was synced with at least 5/6 ppl ( only one of the 2 holy priest have that )in the raid, everyone with different version but all show as compatible making a version check.
@Kerecha: Under normal conditions and setting memory accumulation should be nowhere near as bad. I use recount's default setting and in yesterday's 4 hour raid it clocked in at under 20MiB. But it really depends on your settings, if you set a lot of data accumulation you can make this worse. Make sure that you do not collect time data unless you absolutely need it. Also don't collect data for combatants that you never look at in recount (like non-trivial but non-boss npcs).
Also I did do a fair amount of memory use optimizations the last two days, so if you aren't using the latest version I'd recommend to update.
Ideally I'd suggest wiping your WTF/*/Recount.lua files and use the default filter and check if the memory usage persists.
@solari: Maybe, storing fights is very memory intensive actually, especially if they are 10 minute boss fights. I'm actually tempted to turn the default down to 3 fights because many people never ever even use that feature. But lets see if I can make this without people racking up massive memory without knowing it by setting the number of stored fights very high.
@saviorpr: I'm aware that PoM doesn't work as intended. I'll try to figure out a way to test this. Combatlog with PoM use in it would help.
Im having problems that recount is draining silly amounts of memory.
When i turn on recount performancefu logs my memory use going from the normal raid use of ~80-90MB to a whopping 150+ after just an hour of play, after 3h it became unbarable cos of lag and mem was logged at 250+, this only happends with recount on, and was the same both with and without sync.
Im fully aware that dmg meter addons drain a lot of memory for all the info, but thats just silly.
This sounds very wrong indeed, after a full night spent in Hyjal (with all it's millions of boring trash), my memory usage didn't even hit 10 mb. Make sure you do a garbage collection manually after each fight, or once every 10 mins.
Quote from soltari »
I've tested this thoroughly yesterday and it works perfectly. :) Thank you very much for adding it.
I have one more wish. Can you increase parameter MaxFights=5 to something larger like 30? Since older combats are already counted in Overall Data, it would be great to choose from more then last 5 combats/bosses.
Thank you for your time.
Please don't increase the stored fights without making it optional, since i like Recount's memory usage as it is.
@solari: Maybe, storing fights is very memory intensive actually, especially if they are 10 minute boss fights. I'm actually tempted to turn the default down to 3 fights because many people never ever even use that feature. But lets see if I can make this without people racking up massive memory without knowing it by setting the number of stored fights very high.
Since Overall Data is storing all combats regardless of MaxFights parameter, I assumed that this parameter only defines display list size for choosing combats which you prefer to analyze. I completely agree that it's inappropriate to increase memory hogging by increasing some default option.
However for people that don't have memory problems, optional increase of this number could come really handy. :)
Now Recount only syncs out of combat and then only if it knows that data got missed. Even then people can turn it off via /recount sync.
is there any possibility of adding an option to perform a manual sync or even a request clear option? this way if people think there info is incorrect or off, they can sync.
Under normal conditions and setting memory accumulation should be nowhere near as bad. I use recount's default setting and in yesterday's 4 hour raid it clocked in at under 20MiB. But it really depends on your settings, if you set a lot of data accumulation you can make this worse. Make sure that you do not collect time data unless you absolutely need it. Also don't collect data for combatants that you never look at in recount (like non-trivial but non-boss npcs).
Even 20MiB is much for a pc like mine and I'm forced to not use recount any more even though I love it. I don't know if someone asked for it already since I ,obviously, didn't read all the pages on this thread, but is it possible to bring back the standby option recount used to have? It was very helpful to be able to disable recount without relogs if you didn't need it.
Thanks for the great addon. It's extremely helpful, and the best choice for me. :)
can we please have an option the hide the values on the bars and just show the percentages? I think vice versa it is possible (only values, no percentages).
Even 20MiB is much for a pc like mine and I'm forced to not use recount any more even though I love it. I don't know if someone asked for it already since I ,obviously, didn't read all the pages on this thread, but is it possible to bring back the standby option recount used to have? It was very helpful to be able to disable recount without relogs if you didn't need it.
Thanks for the great addon. It's extremely helpful, and the best choice for me. :)
You don't need a standby option when you can just set Recount to only record data when you're in instances if you want. Or even turn off Global Data Collection. On login recount uses 800kb, which is perfectly fine when you're soloing.
@arrow: So far I have decided against manual sync simply because someone can exploit it to lag or disconnect others.
"/recount syncdesc" is not intended to be supported by recount. It appears only because of a bug in Ace3 which I have reported. Any argument with desc in it is not meant to be used and is currently causes ace3 errors. Just don't use them.
Reworked prayer of mending handling. Let me know if it now works.
Edit: Also reworked lifebloom tracking.
Now all 3 self-threat heals: PoM, lifebloom and earthshield should work heuristically at least.
Things that can make these tracking incorrect are the following:
*) Missed combat log events, specifically SPELL_CAST_SUCCESS. This will affect all three.
*) Missed AURA_APPLIED for PoM.
*) Missed _HEAL for all three.
If you see all combat log events, then ES tracking should be accurate. PoM is fairly accurate unless there is odd densely timed multiple ones going on. LB, same, unless timings are too dense it should be accurate. For PoM misattribution is unlikely, it rather gets attributed to the self-heal if in doubt. For LB every cast that will eventually get a heal will get credit, but precise attribution may in odd cases get confused. If an event got lost it's attributed as a self-heal.
Lifebloom tracking does take rolling lifeblooms into account and won't falsely attribute heals to rolling blooms.
Overall these should be as good as it gets heuristics and work well in most situations. Still there may be bugs and I'm definitely looking for loads of testing on it.
@Kerecha: Under normal conditions and setting memory accumulation should be nowhere near as bad. I use recount's default setting and in yesterday's 4 hour raid it clocked in at under 20MiB. But it really depends on your settings, if you set a lot of data accumulation you can make this worse. Make sure that you do not collect time data unless you absolutely need it. Also don't collect data for combatants that you never look at in recount (like non-trivial but non-boss npcs).
Also I did do a fair amount of memory use optimizations the last two days, so if you aren't using the latest version I'd recommend to update.
Ideally I'd suggest wiping your WTF/*/Recount.lua files and use the default filter and check if the memory usage persists.
@solari: Maybe, storing fights is very memory intensive actually, especially if they are 10 minute boss fights. I'm actually tempted to turn the default down to 3 fights because many people never ever even use that feature. But lets see if I can make this without people racking up massive memory without knowing it by setting the number of stored fights very high.
@saviorpr: I'm aware that PoM doesn't work as intended. I'll try to figure out a way to test this. Combatlog with PoM use in it would help.
Im running at default settings more or less (no time data collected) removed soem unwanted information and changed colors/textures, thats all.
Do the following: Delete data in game. Then type /script collectgarbage("collect"). Then see what kind of memory ready you get for recount. If it's still high go into your WTF/*/SavedVariables, specifically the one for your toon which has that much memory and delete Recount.lua in there.
Start again and check memory.
If recount is anywhere above 1.5 MiB something is seriously wrong. It should actually be clearly below 1MiB without data. Then just play normal. Data should not explode, in a MgT normal should be 2-3 MiB accumulation. A BT run should be 20MiB or less.
If any of this isn't true, can you make a screenie, and specifically type /script Recount:ShowNrCombatants() in game. That number should be below 100 for a typical raid clear (that's 5 hours of raiding).
Do the following: Delete data in game. Then type /script collectgarbage("collect"). Then see what kind of memory ready you get for recount. If it's still high go into your WTF/*/SavedVariables, specifically the one for your toon which has that much memory and delete Recount.lua in there.
Start again and check memory.
If recount is anywhere above 1.5 MiB something is seriously wrong. It should actually be clearly below 1MiB without data. Then just play normal. Data should not explode, in a MgT normal should be 2-3 MiB accumulation. A BT run should be 20MiB or less.
If any of this isn't true, can you make a screenie, and specifically type /script Recount:ShowNrCombatants() in game. That number should be below 100 for a typical raid clear (that's 5 hours of raiding).
Basically, when I try and and click the right click on the title so I can select a different window, the tooltip goes off the left of my screen (due to the position of Recount) and I can't actually see/click on anything. Is there an easy fix to make the tooltip go to the right, or somehow make it so it can't possibly clip off the edge of the screen? Screenshot so it's easier to see what I'm saying:
I'm using version r69336.
Also on a sidenote, I saw you talking about that you added an option to 'restrict recording fights to bosses' or something, is this an option enabled by default, or I have to check it manually? I can't find an option for it on my config. Thanks.
Rollback Post to RevisionRollBack
To post a comment, please login or register a new account.
I've tested this thoroughly yesterday and it works perfectly. :) Thank you very much for adding it.
I have one more wish. Can you increase parameter MaxFights=5 to something larger like 30? Since older combats are already counted in Overall Data, it would be great to choose from more then last 5 combats/bosses.
Thank you for your time.
or better, every pom ( 2 x holy priest in a za raid ) was signed under a "no name" bar, sometime with lock color, sometime with shaman color, sometime with priest ( looking at the current fight count ).
Looking at the overall healing pom did not show as used under any player ( looking ofc at any priest type of spell used ).
recount was synced with at least 5/6 ppl ( only one of the 2 holy priest have that )in the raid, everyone with different version but all show as compatible making a version check.
Also I did do a fair amount of memory use optimizations the last two days, so if you aren't using the latest version I'd recommend to update.
Ideally I'd suggest wiping your WTF/*/Recount.lua files and use the default filter and check if the memory usage persists.
@solari: Maybe, storing fights is very memory intensive actually, especially if they are 10 minute boss fights. I'm actually tempted to turn the default down to 3 fights because many people never ever even use that feature. But lets see if I can make this without people racking up massive memory without knowing it by setting the number of stored fights very high.
@saviorpr: I'm aware that PoM doesn't work as intended. I'll try to figure out a way to test this. Combatlog with PoM use in it would help.
This sounds very wrong indeed, after a full night spent in Hyjal (with all it's millions of boring trash), my memory usage didn't even hit 10 mb. Make sure you do a garbage collection manually after each fight, or once every 10 mins.
Please don't increase the stored fights without making it optional, since i like Recount's memory usage as it is.
Since Overall Data is storing all combats regardless of MaxFights parameter, I assumed that this parameter only defines display list size for choosing combats which you prefer to analyze. I completely agree that it's inappropriate to increase memory hogging by increasing some default option.
However for people that don't have memory problems, optional increase of this number could come really handy. :)
is there any possibility of adding an option to perform a manual sync or even a request clear option? this way if people think there info is incorrect or off, they can sync.
Even 20MiB is much for a pc like mine and I'm forced to not use recount any more even though I love it. I don't know if someone asked for it already since I ,obviously, didn't read all the pages on this thread, but is it possible to bring back the standby option recount used to have? It was very helpful to be able to disable recount without relogs if you didn't need it.
Thanks for the great addon. It's extremely helpful, and the best choice for me. :)
-
View User Profile
-
View Posts
-
Send Message
Curse Premiumcan we please have an option the hide the values on the bars and just show the percentages? I think vice versa it is possible (only values, no percentages).
Kepp up the great work!
Kind regards
X-buZZ
You don't need a standby option when you can just set Recount to only record data when you're in instances if you want. Or even turn off Global Data Collection. On login recount uses 800kb, which is perfectly fine when you're soloing.
@arrow: So far I have decided against manual sync simply because someone can exploit it to lag or disconnect others.
"/recount syncdesc" is not intended to be supported by recount. It appears only because of a bug in Ace3 which I have reported. Any argument with desc in it is not meant to be used and is currently causes ace3 errors. Just don't use them.
@frt: thanks, it's fixed with the latest commit.
Edit: Also reworked lifebloom tracking.
Now all 3 self-threat heals: PoM, lifebloom and earthshield should work heuristically at least.
Things that can make these tracking incorrect are the following:
*) Missed combat log events, specifically SPELL_CAST_SUCCESS. This will affect all three.
*) Missed AURA_APPLIED for PoM.
*) Missed _HEAL for all three.
If you see all combat log events, then ES tracking should be accurate. PoM is fairly accurate unless there is odd densely timed multiple ones going on. LB, same, unless timings are too dense it should be accurate. For PoM misattribution is unlikely, it rather gets attributed to the self-heal if in doubt. For LB every cast that will eventually get a heal will get credit, but precise attribution may in odd cases get confused. If an event got lost it's attributed as a self-heal.
Lifebloom tracking does take rolling lifeblooms into account and won't falsely attribute heals to rolling blooms.
Overall these should be as good as it gets heuristics and work well in most situations. Still there may be bugs and I'm definitely looking for loads of testing on it.
Im running at default settings more or less (no time data collected) removed soem unwanted information and changed colors/textures, thats all.
Been trying everything i can think of to see why it does that, im getting no erros and im running disembedded libs.
Start again and check memory.
If recount is anywhere above 1.5 MiB something is seriously wrong. It should actually be clearly below 1MiB without data. Then just play normal. Data should not explode, in a MgT normal should be 2-3 MiB accumulation. A BT run should be 20MiB or less.
If any of this isn't true, can you make a screenie, and specifically type /script Recount:ShowNrCombatants() in game. That number should be below 100 for a typical raid clear (that's 5 hours of raiding).
-
View User Profile
-
View Posts
-
Send Message
Curse PremiumThe first two players are druids, the last one is a warlock.
ill test6 those during next week then.
Basically, when I try and and click the right click on the title so I can select a different window, the tooltip goes off the left of my screen (due to the position of Recount) and I can't actually see/click on anything. Is there an easy fix to make the tooltip go to the right, or somehow make it so it can't possibly clip off the edge of the screen? Screenshot so it's easier to see what I'm saying:
I'm using version r69336.
Also on a sidenote, I saw you talking about that you added an option to 'restrict recording fights to bosses' or something, is this an option enabled by default, or I have to check it manually? I can't find an option for it on my config. Thanks.