There is sync code in Recount but the current implementation does require others to have Recount for this to function meaningfully (i.e. only people with Recount will both send and receive sync). The previous sync code synced all data which required only very few people to have recount to sync lots of stuff but it lead to massive addon traffic, I try to avoid that problem but it comes at a cost. If there is no syncing between Recount users, this is unintended, let me know.
The sync code isn't really final. I'm still looking into improving it without making it use a lot of bandwidth so hopefully there will be overall improvements (like ways to include non-recount user data in some way).
Another error I forgot to mention... sometimes people sync in a large amount of damage for themselves, but their meter looks normal.
Like... if I delete my data, all the sudden I'll have PlayerA show up after a sync with a ton of damage done... but he doesn't sync the rest of his data, just his large amount of damage. On his screen, his data looks normal.
Doesn't happen all the time... just randomly someone will spike up =p
There appears to be an issue with syncing pets, specifically noticing the issue with totems. When data for totems are synced they are being added to the combatants list with out an owner.
Before a sync I'll see a the proper "Some Random Totem V <Owner>" with .Owner == "Owner". After a sync I'm seeing a "Some Random Totem V" with out "<Owner>" in the name and with .Owner == nil.
This causes issues with the UI in GUI_Main.lua at line 692 (in build 66163)
if v and v.type and Recount.db.profile.Filters.Show[v.type] and not (v.type == "Pet" and not Recount.db.profile.Filters.Show[Recount.db2.char.combatants[v.Owner].type]) then -- Elsia: Added owner inheritance filtering for pets
I changed this to
if v and v.type and Recount.db.profile.Filters.Show[v.type] and not (v.type == "Pet" and v.Owner and not Recount.db.profile.Filters.Show[Recount.db2.char.combatants[v.Owner].type]) then -- Elsia: Added owner inheritance filtering for pets
To fix the error locally until a proper fix is created.
Thanks tons for this. I have actually already committed a change like the one suggested (well only the v.type ~= nil check but that is sufficient), but I hadn't tracked the source of the problem. Thanks for the lead, I'll check into this and restore pet ownership for sync'd totems.
It looks like no one has mentioned this yet, but in battlegrounds Recount appears to be regularly causing a spam of "No player named 'xxx' is currently playing." messages for every player in the battleground.
My hunter is also experiencing the quoted problems below.
My rogue and other rogues in my guild are also seeing largely lower dps numbers from the new recount. I also see rediculously low numbers from mage and warlock players who i know before did about 800dps now doing 400-500. Something goofy is going on with how dps is getting calculated.
Quote from dch48 »
Latest version for 2.4 is seriously bugged for Hunters. It shows things like 600 min damage for arcane shot and a max of 700 with an average of 325. On inspection after fIring a few arcanes, I found that is registering 2 shots for every one done. This is possibly because in the new combat log you get 2 lines. The first one says you have cast arcane shot, the second one says how much damage it did. It does the same thing for my pet's claw attack and Recount registers 2 for each one of them too.
Another thing that's bugged is that on my damage details when I mouse over them, it says my pet did 0% of my damage and one time it even said my pet was a healing Totem. This is when I have my and my pet's damage merged. It also does not calculate dps right any more. It keeps counting time after mobs are dead and the fight is over. The dps I am seeing on recount for my character is less than half what it was before the patch and the new version. I don't think it's accurate for any other class either because everyone in my Guild is now getting much lower dps figures.
Lastly, I really miss being able to look back at the last 5 fights. Please add that feature back in.
I'd love to get some tractable info on this. The data I am personally getting is in the ballpark of before.
Does anybody happen to have a screenie of them doing Dr. Doom damage with the old recount and go ahead and do another run with the current version? That'd be a reliable way to get a comparative measure.
I'll run a damage log vs recount comparison later tonight to see if any actual damage is missing though I find this unlikely.
Some people have reported that combat continues longer than before, I have yet to get reliable information about this. The code that determines combat length is completely untouched since pre-2.3 so I suspect if there really is this effect it has to do with game mechanics and not with Recount per se but I cannot tell for sure until I know what the effect is we are talking about.
What class are you playing? The issues may be class specific? I sadly do not have any saved logs of previous fights to compare against current ones. But the decrease in reported dps is drastically different than pre 2.4 on my hunter. We are talking a 200dps difference in reported dps when farming. I'm not sure blizzard could get away with a stealth nerf that big (though stranger things have happend).
If i can help in any way by parsing logs or any other method, please instruct me on what you'd like me to do.
I was wondering if there's anyway to turn off syncing, either via editing code somewhere or an option in the menu that I missed but pretty sure I didn't see one.
I really hate syncing, in-game dmg meters imo are just for a rough guess and syncing always messes with this. Mainly I hate it just because I have no control over it. Lots of times I'll clear my meters but recount will decide to sync and I have to sit there and clear 3-4 times before it'll stop syncing data.
I read a few posts back you're trying to get testing for it and maybe that's why you removed the feature? Could you just add an option so those wanting to test it can and others can have it turned off so it won't render the addon practically useless and make it frustrating to use?
I have alts of most classes and tested with most. Most tested classes are: hunter, mage, shaman, rogue.
The only class I have not had a chance to test myself is warrior (yes I have a lot of alts).
In any case people report this for all classes as I understand it.
I have tested on my hunter and see no sizable difference. But as said there is no reliable measure. The ballpark is alright.
Also I did a full MT clear with T5/T6 DPSers in a group setting pulling around 800dps. This looks very reasonable to me. This is data for hunter, dps warrior, paladin tank and shadow priest and a resto shaman.
That's why I'm asking for tractable information about this because I do not have a clear indication that the observation is even true on my side.
Anything tangible is very much appreciated.
A way to help is to clear combat log, type /combatlog, DPS Dr. Boom for a significant period of time and send me the combat log after logging out. I'll do this tonight when I come home but maybe this effect only shows at very high gear levels which my hunter certainly doesn't have. Make sure that the combat log is set to self, so that there is no spurious stuff in there for easy offline parsing.
If the combat data is correct and all damage is accounted for that is the DPS you have, in fact on DR Doom one can actually get an independent DPS measure by measuring in-combat time independently and divide by total damage.
I was wondering if there's anyway to turn off syncing, either via editing code somewhere or an option in the menu that I missed but pretty sure I didn't see one.
I really hate syncing, in-game dmg meters imo are just for a rough guess and syncing always messes with this. Mainly I hate it just because I have no control over it. Lots of times I'll clear my meters but recount will decide to sync and I have to sit there and clear 3-4 times before it'll stop syncing data.
I read a few posts back you're trying to get testing for it and maybe that's why you removed the feature? Could you just add an option so those wanting to test it can and others can have it turned off so it won't render the addon practically useless and make it frustrating to use?
Thanks for any help.
There is a way to turn it off via /recount sync off
Recounts new sync code is meant to be very lightweight though. It avoids all syncing (except greater elemental identification, which I hope to get rid off very soon) in combat and does minimal syncing after combat (i.e. only syncing that is known to be needed).
The fact that it resync after deletion is unintended and I'll fix that as soon as I get the opportunity. If everybody turns off sync I'll however never learn about problems and know how to fix them so I hope that at least some are willing to keep sync on and give me constructive feedback on it ;)
[2008/03/27 18:09:41-3673-x134]: Recount-$Revision: 66300 $\GUI_Main.lua:692: attempt to index field '?' (a nil value)
(tail call): ?:
<in C code>: ?
<string>:"safecall Dispatcher[1]":9: in function <[string "safecall Dispatcher[1]"]:5>
(tail call): ?:
AceTimer-3.0\AceTimer-3.0.lua:142: in function <Interface\AddOns\Ace3\AceTimer-3.0\AceTimer-3.0.lua:114>
Not the latest revision but I didn't see commit notes regarding a fix, apologies if it has been fixed already.
I was not asking you to fix RecountFu. (it seems to still have issues with only showing group DPS) and because of this I see that the normal recount bars for DSP and Damagge done do not show merged pets or totems and such, even when you have them set to merged and not shown in the list. thus the DPS or Damage done by me is incomplete...
what I was asking for was a DPS merged bar view and Damage done Merged.
maybe I'm wrong, but recountFu is showing me in solo with all data dumped doing hundreds more DPS than the bar from recount is reporting...
I just switched over to Recount from SWStats, and one big issue in SW was that while it calculated your DPS correctly in the main bar (Mine is about 715 as a Kara Rogue), it showed DPS in a "relative to raid" form in the bars. My DPS would show in bars at about 600.
Now that SWStats got broken past update and I was swayed to Recount, my DPS sank horribly in this addon as well. Last night at Magister's, it was saying my DPS was 380, and I know that's just not possible.
EDIT- Looking at my character screen, my DPS before buffs, poisons, dots etc, is about 376 off the weapons on the character screen. Maybe that has something to do with this fluke?
@Darkclaw: I don't understand what you are saying: Check merge pet in the config to merge pets. This works as best I know. If you ask for merged pet damage in RecountFu you have to contact the maintainer of that addon as I said. Recount contains all this code RecountFu lacks it.
I cannot confirm what the recountfu shows as damage because it's bugged for me unfortunately.
@Skylinee: Thanks that's an interesting screenshot. It does look like it's a hunter issue, or maybe a pet related issue. I'm still confused. Do these mages also usually pull 1000dps in 5mans or is the only thing that's wrong here the hunter dps?
Can you do me a favor and test DPS with and without pet and see if the pet being in combat has any influence?
@Ithorien: Thanks, looks like we look at least at hunters and rogues then but this then talks aaginst a pet issue.
Any magic damage dealer having concrete experiences in this direction?
Rollback Post to RevisionRollBack
To post a comment, please login or register a new account.
The sync code isn't really final. I'm still looking into improving it without making it use a lot of bandwidth so hopefully there will be overall improvements (like ways to include non-recount user data in some way).
-
View User Profile
-
View Posts
-
Send Message
Curse PremiumLike... if I delete my data, all the sudden I'll have PlayerA show up after a sync with a ton of damage done... but he doesn't sync the rest of his data, just his large amount of damage. On his screen, his data looks normal.
Doesn't happen all the time... just randomly someone will spike up =p
Before a sync I'll see a the proper "Some Random Totem V <Owner>" with .Owner == "Owner". After a sync I'm seeing a "Some Random Totem V" with out "<Owner>" in the name and with .Owner == nil.
This causes issues with the UI in GUI_Main.lua at line 692 (in build 66163)
if v and v.type and Recount.db.profile.Filters.Show[v.type] and not (v.type == "Pet" and not Recount.db.profile.Filters.Show[Recount.db2.char.combatants[v.Owner].type]) then -- Elsia: Added owner inheritance filtering for pets
I changed this to
if v and v.type and Recount.db.profile.Filters.Show[v.type] and not (v.type == "Pet" and v.Owner and not Recount.db.profile.Filters.Show[Recount.db2.char.combatants[v.Owner].type]) then -- Elsia: Added owner inheritance filtering for pets
To fix the error locally until a proper fix is created.
How to use add texture??
I'm not able to Codeing.. please help!!!
@cake: Install SharedMedia, it contains a lot of bar textures and Recount will support it automatically.
My rogue and other rogues in my guild are also seeing largely lower dps numbers from the new recount. I also see rediculously low numbers from mage and warlock players who i know before did about 800dps now doing 400-500. Something goofy is going on with how dps is getting calculated.
Does anybody happen to have a screenie of them doing Dr. Doom damage with the old recount and go ahead and do another run with the current version? That'd be a reliable way to get a comparative measure.
I'll run a damage log vs recount comparison later tonight to see if any actual damage is missing though I find this unlikely.
Some people have reported that combat continues longer than before, I have yet to get reliable information about this. The code that determines combat length is completely untouched since pre-2.3 so I suspect if there really is this effect it has to do with game mechanics and not with Recount per se but I cannot tell for sure until I know what the effect is we are talking about.
What class are you playing? The issues may be class specific? I sadly do not have any saved logs of previous fights to compare against current ones. But the decrease in reported dps is drastically different than pre 2.4 on my hunter. We are talking a 200dps difference in reported dps when farming. I'm not sure blizzard could get away with a stealth nerf that big (though stranger things have happend).
If i can help in any way by parsing logs or any other method, please instruct me on what you'd like me to do.
I was wondering if there's anyway to turn off syncing, either via editing code somewhere or an option in the menu that I missed but pretty sure I didn't see one.
I really hate syncing, in-game dmg meters imo are just for a rough guess and syncing always messes with this. Mainly I hate it just because I have no control over it. Lots of times I'll clear my meters but recount will decide to sync and I have to sit there and clear 3-4 times before it'll stop syncing data.
I read a few posts back you're trying to get testing for it and maybe that's why you removed the feature? Could you just add an option so those wanting to test it can and others can have it turned off so it won't render the addon practically useless and make it frustrating to use?
Thanks for any help.
The only class I have not had a chance to test myself is warrior (yes I have a lot of alts).
In any case people report this for all classes as I understand it.
I have tested on my hunter and see no sizable difference. But as said there is no reliable measure. The ballpark is alright.
Also I did a full MT clear with T5/T6 DPSers in a group setting pulling around 800dps. This looks very reasonable to me. This is data for hunter, dps warrior, paladin tank and shadow priest and a resto shaman.
That's why I'm asking for tractable information about this because I do not have a clear indication that the observation is even true on my side.
Anything tangible is very much appreciated.
A way to help is to clear combat log, type /combatlog, DPS Dr. Boom for a significant period of time and send me the combat log after logging out. I'll do this tonight when I come home but maybe this effect only shows at very high gear levels which my hunter certainly doesn't have. Make sure that the combat log is set to self, so that there is no spurious stuff in there for easy offline parsing.
If the combat data is correct and all damage is accounted for that is the DPS you have, in fact on DR Doom one can actually get an independent DPS measure by measuring in-combat time independently and divide by total damage.
There is a way to turn it off via /recount sync off
Recounts new sync code is meant to be very lightweight though. It avoids all syncing (except greater elemental identification, which I hope to get rid off very soon) in combat and does minimal syncing after combat (i.e. only syncing that is known to be needed).
The fact that it resync after deletion is unintended and I'll fix that as soon as I get the opportunity. If everybody turns off sync I'll however never learn about problems and know how to fix them so I hope that at least some are willing to keep sync on and give me constructive feedback on it ;)
Not the latest revision but I didn't see commit notes regarding a fix, apologies if it has been fixed already.
I was not asking you to fix RecountFu. (it seems to still have issues with only showing group DPS) and because of this I see that the normal recount bars for DSP and Damagge done do not show merged pets or totems and such, even when you have them set to merged and not shown in the list. thus the DPS or Damage done by me is incomplete...
what I was asking for was a DPS merged bar view and Damage done Merged.
maybe I'm wrong, but recountFu is showing me in solo with all data dumped doing hundreds more DPS than the bar from recount is reporting...
http://i74.photobucket.com/albums/i267/Skylinee/Recount.jpg
As you can see, the mages under me have higher dps than me even when i've done twice their damage. Pre-2.4 i had over 1000 dps showed on recount.
Now that SWStats got broken past update and I was swayed to Recount, my DPS sank horribly in this addon as well. Last night at Magister's, it was saying my DPS was 380, and I know that's just not possible.
EDIT- Looking at my character screen, my DPS before buffs, poisons, dots etc, is about 376 off the weapons on the character screen. Maybe that has something to do with this fluke?
I cannot confirm what the recountfu shows as damage because it's bugged for me unfortunately.
@Skylinee: Thanks that's an interesting screenshot. It does look like it's a hunter issue, or maybe a pet related issue. I'm still confused. Do these mages also usually pull 1000dps in 5mans or is the only thing that's wrong here the hunter dps?
Can you do me a favor and test DPS with and without pet and see if the pet being in combat has any influence?
@Ithorien: Thanks, looks like we look at least at hunters and rogues then but this then talks aaginst a pet issue.
Any magic damage dealer having concrete experiences in this direction?