Authors CurseForge

I'm brand new to this addon and while I'm really digging it I've noticed one bug. I'm not sure whether the problem is isolated or if its a symptom of greater miscalculation problem.

I have the "Merge Pets w/ Owners" setting checked and it looks like Recount is trying to provide the best of both worlds: the pets damage is rolled up into my own and I can also see how much damage the pet did. I kind of like this, but it does produce an error in terms of the reporting of percentage of total damage done. The pets damage is getting added into the total amount of damage done twice, once in my total and once for the pet.

The easiest way to see this is to have your pet solo a mob. The pet and I were listed as having done the same amount of damage (I did 0 + pet damage) and that each had done 50% of the damage. Obviously if my pet killed the mob by itself it should have done 100% of the damage, not 50%.

Here's a better example though of why this is a problem. I partied up with a friend and the three of us killed a mob and I looked at the data. I'm going to round the numbers here to make it easier, but basically he was listed as doing 3k damage, the pet as 1k and I was listed as 2k (1k by me, and 1k by the pet). So it took 5k damage to kill the mob and my friend did 3k of it - I would expect him to be listed as having done 60% of the damage, but instead he was shown as having done 50%. I was listed as having done 33.3% and the pet as 16.7%.

I think two changes need to be made when pet data is merged with owners:
1) Damage from a pet row should not be included in the total value used for calculating percentage.
2) The percentage shown next to the pet should be their damage divided by the owners merged damage.

That means in the above scenario, my friends would be reported as having done 60%, I would be credited with 40% and my pet would be reported as 50%. Sure, those numbers don't add up to 100% but its actually more useful for the situation where damage is being merged.

EDIT 1: I've never written any lua before, but I thought I'd give it a go and I think I've got number 1 at least partially fixed. You need to change Total=Total+Value to if not Recount.db.char.MergePets or not v.Owner then Total=Total+Value end in GUI_Main.lua in the functions Recount:RefreshMainWindow (line 538) and Recount:ReportData (line 713).

EDIT 2: Did it!! :) Left is without merging pet data, right is with.

I totally hacked this in, not sure if its right or complete, but I think its a good start for Cryect and I hope he includes it.
Recount:RefreshMainWindow from:

local Value,PerSec
...
Value,PerSec=Recount.MainWindow:GetData(v,1)
if Value>0 then
  Total=Total+Value
  if type(lookup[k])=="table" then
    lookup[k][1]=k
    lookup[k][2]=Value
    lookup[k][3]=Recount.db.char.ClassColors[v.enClass]
    lookup[k][4]=v
    lookup[k][5]=PerSec
  else
    lookup[k]={k,Value,Recount.Colors:GetColor("Class",v.enClass),v,PerSec}
    table.insert(dispTable,lookup[k])
  end
...
if v then
  local percent=100*v[2]/Total

to:

local Value,PerSec,OwnerTotal
...
Value,PerSec=Recount.MainWindow:GetData(v,1)
if Value>0 then
  OwnerTotal=0
  if Recount.db.char.MergePets and v.Owner then
    if data[v.Owner].Fights[Recount.CurDataSet] then
      OwnerTotal=Recount.MainWindow:GetData(data[v.Owner],1)
    end
  else
    Total=Total+Value
  end

  if type(lookup[k])=="table" then
    lookup[k][1]=k
    lookup[k][2]=Value
    lookup[k][3]=Recount.db.char.ClassColors[v.enClass]
    lookup[k][4]=v
    lookup[k][5]=PerSec
    lookup[k][6]=OwnerTotal
  else
    lookup[k]={k,Value,Recount.Colors:GetColor("Class",v.enClass),v,PerSec,OwnerTotal}
    table.insert(dispTable,lookup[k])
  end
...
if v then
  local percent=100*v[2]
  if v[6]>0 then
    percent=percent/v[6]
  else				
    percent=percent/Total
  end

Recount:ReportData from:

local Value,PerSec
...
if Value>0 then
  Total=Total+Value

  if type(lookup[k])=="table" then
    lookup[k][1]=k
    lookup[k][2]=Value
    lookup[k][5]=PerSec
  else
    lookup[k]={k,Value,Recount.Colors:GetColor("Class",v.enClass),v,PerSec}
    table.insert(reportTable,lookup[k])
  end
end
...
SendChatMessage(i..". "..reportTable[i][1].." "..reportTable[i][2].." ("..PerSec..(math.floor(1000*reportTable[i][2]/Total)/10).."%)",loc,nil,loc2)

to:

local Value,PerSec,OwnerTotal
...
if Value>0 then
  OwnerTotal=0
  if Recount.db.char.MergePets and v.Owner then
    if data[v.Owner].Fights[Recount.CurDataSet] then
      OwnerTotal=dataMode[2](this,data[v.Owner],1)
    end
  else
    Total=Total+Value
  end

  if type(lookup[k])=="table" then
    lookup[k][1]=k
    lookup[k][2]=Value
    lookup[k][5]=PerSec
    lookup[k][6]=OwnerTotal
  else
    lookup[k]={k,Value,Recount.Colors:GetColor("Class",v.enClass),v,PerSec,OwnerTotal}
    table.insert(reportTable,lookup[k])
  end
end
...
if reportTable[i][6]>0 then
  SendChatMessage(i..". "..reportTable[i][1].." "..reportTable[i][2].." ("..PerSec..(math.floor(1000*reportTable[i][2]/reportTable[i][6])/10).."%)",loc,nil,loc2)
else
  SendChatMessage(i..". "..reportTable[i][1].." "..reportTable[i][2].." ("..PerSec..(math.floor(1000*reportTable[i][2]/Total)/10).."%)",loc,nil,loc2)
end

After patch 2.2 we've started to see massive differences in the recount addon in our raids.. The differences can be enormous. Does this addon really sync data at all or is something just broken after 2.2?