@pompachomp: The numbering doesn't work as you assumes. It round robins through fights as the number of stored fights are limited. There isn't really a good way to number them so I'm not taking the numbering all that seriously... In short I don't intend to change how it's working now.
My guess is that it was a bug in libfail where the library wasnt upgrading its callback registry. I just fixed it end of last week after seeing this discussion - i forgot to come back and say something.
Maybe just touch to get the latest version packaged.
EDIT: This could have been the bug in my original sample as well;
for _, event in ipairs(fail_events) do
for _, event in ipairs(fail_events) do
fail.RegisterCallback("Recount", event, onFail)
Curious, how does wow handle loading libs embedded in multiple addons, IE, i have an ensidiafails that is packaged with latest libfail, but recountfailbot has one that's a month old, will wow load the newer one or the older one?
1# twin shield, i suppose adding the eight spellid of the different shields would show them more or less properly on the guessedabsorb page?
2# druid savage roar, again adding the spellid to the lua should do it, here my question is would it be calculated right? because *often* when multitanking a SINGLE shield absorb it's damage from MULTIPLE sources, IE if i have a savage defense that absors, say, 1500 damage and in a timeframe of 0.1seconds i receive 4 attacks, each of these will be reduced by 1500, whereas "by tooltip" i should have absorbed only 1500 from the very first one.
then watch events SWING_MISSED, RANGE_MISSED, SPELL_MISSED, SPELL_PERIODIC_MISSED in combat log, subtrack damage from known shield HP (based on spellid chart above). should be able to fairly accurately measure shield dps, and even show in recount who did x damage to shield. I think personally recount should put in a little hack that shows the shield as a mob, that way i can spam "shield took damage from who" in raid and see who's not pulling their weight when they fail at shields on heroic 25.
just adding them to guessedabsorbs probably won't work, since the twins shield doesn't use the typical "ABSORB" functions, it uses MISSED.
Edit: As mysticalos said above in my own addon I'm tracking
for the full absorbs, and
where the destination is the boss and the absorb argument > 0 for tracking removal by destroying (and not by expiration) as well as who delivered the killing blow (on the shield).
I'd just like to request that the main frame stays open when zoning (at least outdoors, like Dalaran -> Crystalsong Forest) if you have manually shown it. As far as I understand this is because the zone filters. It's a bit annoying having it disappear while flying around.
Just curious, why not externalize all the modules like fails and absorbs are. That way someone can check off useless stuff like power gains etc on addon screen. I know you modulized it slightly a while back to delete the unwanted lua files without errors but that's counter intuitive plus needs to be done every time you update recount.
Try the latest alpha. It contains an added detail view that shows who did damage to the shield. This solution isn't ideal for a few reasons.
One is that the uses are kind of complementary. It's a different thing if one wants to track absorbs as a defensive stat or as an offensive one (very much comparable to the difference between Damage Done and Damage Taken). So there may be a fairly good argument to be made that this really should be a separate mode.
In any case this version is a proof of concept and I'd be happy to hear if it works as intended.
I'd say damage based absorbs could be moved into normal recount, where as healing etc ones stay in recountabsorbs? you are gonna run into same situation with iCC when you have a boss that uses a mana shield and again recount can't track accurate damage for whole first phase of the encounter. Since dps is something that mod is suppose to measure, it'd be ok there.