Authors CurseForge

Elsia, am I overlooking something or does it look like it's numbering them incorrectly?

i don think its numbering anything , fails get registered via

for _, event in ipairs(fail_events) do
fail:RegisterCallback(event, onFail)
end

, dont they? there are some fails mentioned in the code, but only in a commented section which isnt executed.

is your rc-failbot r21+ `?

Using the latest recountfails, and it does not work. It doesn't reports fails for most encounters, only one here or there. For most part it ignores 3/4 of the fails in libfail.

My guess is that it was a bug in libfail where the library wasnt upgrading its callback registry. I just fixed it end of last week after seeing this discussion - i forgot to come back and say something.

Maybe just touch to get the latest version packaged.

EDIT: This could have been the bug in my original sample as well;

for _, event in ipairs(fail_events) do
    fail:RegisterCallback(event, onFail)
end

should be

for _, event in ipairs(fail_events) do
    fail.RegisterCallback("Recount", event, onFail)
end

Curious, how does wow handle loading libs embedded in multiple addons, IE, i have an ensidiafails that is packaged with latest libfail, but recountfailbot has one that's a month old, will wow load the newer one or the older one?

just makes me wonder though then. if the bug was fixed a week ago, then i shoulda noticed it since i always update it with EF. But i'll pay closer attention to it.

oh wait i see, two bugs, the lib and the sample. guess i'll check it later then. gonna say it coudln't have been lib bug alone, since i tend to keep that up to date.

Shields are relitively easy

[65874] = 175000,
[65858] = 175000,
[67257] = 300000,
[67260] = 300000,
[67256] = 700000,
[67259] = 700000,
[67261] = 1200000,
[67258] = 1200000,

then watch events SWING_MISSED, RANGE_MISSED, SPELL_MISSED, SPELL_PERIODIC_MISSED in combat log, subtrack damage from known shield HP (based on spellid chart above). should be able to fairly accurately measure shield dps, and even show in recount who did x damage to shield. I think personally recount should put in a little hack that shows the shield as a mob, that way i can spam "shield took damage from who" in raid and see who's not pulling their weight when they fail at shields on heroic 25.

just adding them to guessedabsorbs probably won't work, since the twins shield doesn't use the typical "ABSORB" functions, it uses MISSED.

I've created an - unreleased - addon for my guild, this is from the lua file comment section.

    -- base: timestamp, event, srcGUID, srcName, srcFlags, destGUID, destName, destFlags
    -- prefix: spellID|envType, spellName, spellSchool 
    -- suffix: amount|missType, overkill|amountMiss, school, resisted, blocked, absorbed, critflag, glancflag, crushflag
    --[[
    shield apply example
    timestamp     event              srcGUID            srcName          sFlag    destGUID           destName         dFlag    sID   sName                scl  auratype
    23:37:38.953  SPELL_AURA_APPLIED,0xF1300086C0011A57,"Eydis Darkbane",0x400a48,0xF1300086C0011A57,"Eydis Darkbane",0x400a48,65874,"Shield of Darkness",0x20,BUFF
    
    shield remove example
    timestamp     event              srcGUID            srcName          sFlag    destGUID           destName         dFlag    sID   sName                scl  auratype
    23:37:49.078  SPELL_AURA_REMOVED,0xF1300086C0011A57,"Eydis Darkbane",0x400a48,0xF1300086C0011A57,"Eydis Darkbane",0x400a48,65874,"Shield of Darkness",0x20,BUFF
    
    full absorb example
    timestamp     event        srcGUID            srcName  sFlag destGUID           destName         dFlag    sID   sName             scl  missType amountMiss
    23:37:48.703  SPELL_MISSED,0x04000000000374E0,"Meanmage",0x514,0xF1300086C0011A57,"Eydis Darkbane",0x400a48,42845,"Arcane Missiles",0x40,ABSORB,  5089
    
    partial absorb example (killing blow)
    timestamp     event                 srcGUID              srcName  sFlag destGUID           destName         dFlag    sID   sName             scl  tot  o sc res  b abs
    23:37:49.093  SPELL_DAMAGE,0x04000000000374E0,"Meanmage",0x514,0xF1300086C0011A57,"Eydis Darkbane",0x400a48,42845,"Arcane Missiles",0x40,4120,0,64,1001,0,403,nil,nil,nil
    ]]
    -- Shield of Darkness: 65874/175000, 67257/300000, 67256/700000, 67258/1200000
    -- Shield of Light:    65858/175000, 67260/300000, 67259/700000, 67261/1200000

Edit: As mysticalos said above in my own addon I'm tracking
SPELL_MISSED|SPELL_PERIODIC_MISSED|RANGED_MISSED|SWING_MISSED
for the full absorbs, and
SPELL_DAMAGE|SPELL_PERIODIC_DAMAGE|RANGED_DAMAGE|SWING_DAMAGE
where the destination is the boss and the absorb argument > 0 for tracking removal by destroying (and not by expiration) as well as who delivered the killing blow (on the shield).

Just curious, why not externalize all the modules like fails and absorbs are. That way someone can check off useless stuff like power gains etc on addon screen. I know you modulized it slightly a while back to delete the unwanted lua files without errors but that's counter intuitive plus needs to be done every time you update recount.

the shields show up in absorbs but not in a way that's useful at all, it just tells you what you already know, the shield absorbed x damage. But no way to detect damage from who?

I'd say damage based absorbs could be moved into normal recount, where as healing etc ones stay in recountabsorbs? you are gonna run into same situation with iCC when you have a boss that uses a mana shield and again recount can't track accurate damage for whole first phase of the encounter. Since dps is something that mod is suppose to measure, it'd be ok there.