I've disabled all of my other addons aside from Recount and tekErr to avoid any potential cross contamination of resolving this issue. But yea, the error is still cropping up.
Every change has been a complete exit of WoW, delete folder -> install new -> restart WoW. Not even risking a simple /rl in order to keep the data clean for you.
Anyone else but Peoii having that issue? If yes, please let me know. Else it might be a local issue having to do with file permissions and such. Is this Vista?
Anyone else but Peoii having that issue? If yes, please let me know. Else it might be a local issue having to do with file permissions and such. Is this Vista?
The XML change from r1010 -> r1011 completely fixed the issue for me. Looking over my FrameXML log, it wasn't properly detecting the library either.
The optimisations seem to have broken the Current Fight filter mostly, it doesn't clear between trash packs so it continues to add damage to the total. The only time it works properly is for bosses and for the trash pack following a boss, possibly because of the use of Bableboss for those.
I'm interested in these optimizations. Does anyone have any Before/After figures for lets say a full Naxx Raid? I switched to Skada recently, because after the memory usage of Recount started hitting ~20MB's i got a slight freeze after each bossfight or any other long fight. Currently Recount is more accurate though, compared to other meters.
I did single target tests and some core functions I managed to reduce between 20%-50% in call time. This should be noticable under peak load but I haven't had a chance to do peak load tests.
I'm very much looking for feedback. I have no opportunity to raid this week so I am relying on tests of others on this.
Goal is to get all this as efficient as possible. And if that's at all possible to handle the current CL load I'm sure we'll get there eventually. I don't want to make all changes at once though so I first want to get some feedback on this pass before moving on to the next.
[2009/03/08 18:35:10-5008-x5]: Recount-1012\Tracker.lua:1148: attempt to concatenate global 'RecountFightingLevel' (a nil value)
Recount-1012\Tracker.lua:1414: in function `AddDamageData'
Recount-1012\Tracker.lua:309: in function <Interface\AddOns\Recount\Tracker.lua:279>
Recount-1012\Tracker.lua:634: in function `?'
CallbackHandler-1.0-3 (Ace3):146: in function <...Ons\Ace3\CallbackHandler-1.0\CallbackHandler-1.0.lua:146>
<string>:"safecall Dispatcher[21]":4: in function <[string "safecall Dispatcher[21]"]:4>
<in C code>: ?
<string>:"safecall Dispatcher[21]":13: in function `?'
CallbackHandler-1.0-3 (Ace3):91: in function `Fire'
AceEvent-3.0-3 (Ace3):73: in function <Interface\AddOns\Ace3\AceEvent-3.0\AceEvent-3.0.lua:72>
[2009/03/08 18:54:10-361-x1]: Recount-1012\Tracker.lua:1148: attempt to concatenate global 'RecountFightingLevel' (a nil value)
Recount-1012\Tracker.lua:1414: in function `AddDamageData'
Recount-1012\Tracker.lua:309: in function <Interface\AddOns\Recount\Tracker.lua:279>
Recount-1012\Tracker.lua:634: in function `?'
CallbackHandler-1.0-3 (Ace3):146: in function <...Ons\Ace3\CallbackHandler-1.0\CallbackHandler-1.0.lua:146>
<string>:"safecall Dispatcher[21]":4: in function <[string "safecall Dispatcher[21]"]:4>
<in C code>: ?
<string>:"safecall Dispatcher[21]":13: in function `?'
CallbackHandler-1.0-3 (Ace3):91: in function `Fire'
AceEvent-3.0-3 (Ace3):73: in function <Interface\AddOns\Ace3\AceEvent-3.0\AceEvent-3.0.lua:72>
It seems it is. I also had random freezes in other combats. I updated Recount from r999 to r1013 just before the raid, along with Dominos. But given both Dominos and Recount changelogs and the fact that disabling Recount seemed to fixed the issue, I suppose it is related to Recount. I might attach my Recount settings if it could help you.
I found a leak that got introduced by moving locals to upvalues. Can you let me know how this version fairs? Thanks!
Elsia, locals don't use the heap, they use the function call stack. If such a local becomes an upvalue at the end of scope (remains used by a closure), Lua moves it out of the stack into the heap, and future accesses to it cost an extra indirection. Lua thus keeps a list of "open upvalues" for each stack.
Rollback Post to RevisionRollBack
To post a comment, please login or register a new account.
But still same error with r1010.
I've disabled all of my other addons aside from Recount and tekErr to avoid any potential cross contamination of resolving this issue. But yea, the error is still cropping up.
Every change has been a complete exit of WoW, delete folder -> install new -> restart WoW. Not even risking a simple /rl in order to keep the data clean for you.
3/8 10:06:54.890 ** Loading table of contents Interface\AddOns\Recount\Recount.toc
3/8 10:06:54.890 ++ Loading file Interface\AddOns\Recount\embeds.xml
3/8 10:06:54.890 Element 'Include' without file attribute
The XML change from r1010 -> r1011 completely fixed the issue for me. Looking over my FrameXML log, it wasn't properly detecting the library either.
Strangeness...
Edit: Fixed.
I'm very much looking for feedback. I have no opportunity to raid this week so I am relying on tests of others on this.
Goal is to get all this as efficient as possible. And if that's at all possible to handle the current CL load I'm sure we'll get there eventually. I don't want to make all changes at once though so I first want to get some feedback on this pass before moving on to the next.
-
View User Profile
-
View Posts
-
Send Message
Forum Moderator^this on PTR
-
View User Profile
-
View Posts
-
Send Message
Curse PremiumBBEdit.
-
View User Profile
-
View Posts
-
Send Message
Curse Premium-
View User Profile
-
View Posts
-
Send Message
Curse PremiumIt seems it is. I also had random freezes in other combats. I updated Recount from r999 to r1013 just before the raid, along with Dominos. But given both Dominos and Recount changelogs and the fact that disabling Recount seemed to fixed the issue, I suppose it is related to Recount. I might attach my Recount settings if it could help you.
-
View User Profile
-
View Posts
-
Send Message
Curse PremiumElsia, locals don't use the heap, they use the function call stack. If such a local becomes an upvalue at the end of scope (remains used by a closure), Lua moves it out of the stack into the heap, and future accesses to it cost an extra indirection. Lua thus keeps a list of "open upvalues" for each stack.