Ok just dl r41 and will play with it some, I'm raiding again on Monday so that should give it a good run. Noticed a couple of "new" issues tonight whilst raiding, best illustrated by the attached screenshot.
Firstly spell names on the bars weren't being concatenated but were being wrapped, leading to some rather ugly looking text on bars.
Secondly when bars are ticking down and the backdrop is being shown it doesn't look overly neat with rounded textures. It looks like the foreground texture is shrinking and the background texture is expanding to fill the gap. This leads to some gaps between the two textures. Contrast this to how ora3 cd bars are shown depleting to the right of the screenshot. This isn't by far the worst I've seen them but was the only screenshot I had with a different addon generating bars for comparison.
Firstly spell names on the bars weren't being concatenated but were being wrapped, leading to some rather ugly looking text on bars.
Secondly when bars are ticking down and the backdrop is being shown it doesn't look overly neat with rounded textures. It looks like the foreground texture is shrinking and the background texture is expanding to fill the gap. This leads to some gaps between the two textures. Contrast this to how ora3 cd bars are shown depleting to the right of the screenshot. This isn't by far the worst I've seen them but was the only screenshot I had with a different addon generating bars for comparison.
The spell name wrap is fixed in release r42. I'm pretty sure that my fix for rounded textures should also work. I had assumed square corners and cut the length of the underlying background bar, which was obviously a bad assumption. BTW what texture is that you are using that has the round corners so I can test with it myself?
Version r44 adds time format options for bar groups (look under Timer Options) and for cooldown button overlays. There are 24 options and the drop down menu gives you samples that illustrate each variation at selected time values.
I've tried to make the times match as closely as possible those seen on Blizzard's tooltips, when displayed in similar formats.
This version also fixes a bug in the "Show With Uniform Duration" timer option.
Just started using the mod and having a strange issue with r44. r44 is first time i have really used it at all. I am getting bar remnants left behind when a bar disappears. See screenshot.
The left side remnants are my cooldowns, upper left target debuffs, middle noitfication, and above my player frame is short buffs on me. No problem with the icon long buffs. The 2 little ones on the left are 2 righteous fury icons on an autohiding bar using bartender 4.
Just started using the mod and having a strange issue with r44. r44 is first time i have really used it at all. I am getting bar remnants left behind when a bar disappears. See screenshot.
Update: I can see the image now. Those are foreground and background textures for bars. From your message, it sounds like these are in bar-oriented bar groups as opposed to icon-oriented. I also assume they go away if you reload UI [Note: this assumption may be wrong for zombie mini-bars, see below]. Let me know if either assumption is wrong. I'll read the code again for recycling bars and see if I see anything that could result in this.
With regards to the remnants anomaly, another possibility is what I call "zombie mini-bars". If you are using icon configurations, mini-bar width and height default to 0, which results in actual width and height being set by the anchor points. If you haven't disabled mini-bars then strange things could happen when new icons are created from bar objects picked up from the recycle list. I discovered this when I switched "Long Buffs" from bars to icons mid-raid and had a stack of oddly-shaped bars show up. I will commit a fix for this (as well as some additional width-related safety checks) later today.
Update: I am increasingly confident that this scenario will create what I see on the remnants screenshot. The remnant bar colors are class colors which hints at a relationship to the Long Buffs icon group. There are also about the right number of remnant bars in each color. And the Long Buffs icons do not show mini-bars. Reviewing the code, it looks like the zombie mini-bars retain their original anchor points and can show sparks, which matches what I see in the screenshot. And the zombie bars could indeed reappear after a reload UI, since the root cause doesn't go away with a reload. The definitive test is to disable "Bars" in the settings for "Long Buffs" and/or to set non-zero width and height for "Long Buffs" mini-bars. I am testing a fix for all this now.
Thank you for the timer format update, it's great not having to do copy pasta everytime I update now :)
I ended up with the following error in voa25 tonight on my druid, which caused all bar groups to freeze. After running voa10 as well and watching when it happened with a little more care it's linked to when Lunar Eclipse procs, when the eclipse is over everything works fine again. Solar eclipse works fine and error free.
Also on my notifications bar which I have setup in icon only mode, I occasionally get an incorrect spell icon show up. This corrects itself after the spell is cast, so maybe there is a caching issue? Whilst I haven't been reliably able to reproduce it, it does appear to happen more often than not after switching from the spec originally logged in as to a different one. In the screenshot below the icons for innervate and typhoon are correct, but the icon that is showing up as moonkin form should actually be force of nature.
Version r45 has just been checked in. It fixes the "zombie mini-bar" bug and sets new defaults for mini-bars. If you don't want mini-bars with icons then disable them by unchecking "Bars" in the "Layout->Format" settings. I've been testing this fix for a couple hours and it looks solid and I'm hopeful it will fix the "remnant bars" anomaly.
This release also includes a fix reported by my boomkin tester to the same problem Craxziz just reported (line 599 attempt to index bs, a number value) that was introduced in the Eclipse detection code with the buff management changes. I haven't heard back if the fix works so I have my fingers crossed. Let me know Craxziz if you see any more issues with Eclipse.
I'll check out the notification icon issue, Craxziz.
This release also includes a fix reported by my boomkin tester to the same problem Craxziz just reported (line 599 attempt to index bs, a number value) that was introduced in the Eclipse detection code with the buff management changes. I haven't heard back if the fix works so I have my fingers crossed. Let me know Craxziz if you see any more issues with Eclipse.
Just quickly blasted a training dummy to test the fix. The error is gone and lunar eclipse shows up properly, however no cd bar is generated for solar eclipse now, though this is error free.
Also on my notifications bar which I have setup in icon only mode, I occasionally get an incorrect spell icon show up. This corrects itself after the spell is cast, so maybe there is a caching issue? Whilst I haven't been reliably able to reproduce it, it does appear to happen more often than not after switching from the spec originally logged in as to a different one. In the screenshot below the icons for innervate and typhoon are correct, but the icon that is showing up as moonkin form should actually be force of nature.
I think what is happening here is that spell icons get cached when first used. Sometimes this is when an aura is detected, in which case the right icon for the spell is included in the result from UnitAura. Sometimes it is found in the player's spellbook, in which case it is the icon that Blizzard associates in the player's spellbook with the spell. But sometimes it is not available in the player's spellbook (e.g., before you switch spec), in which case Raven attempts to find it with a brute force search of the full internal spellbook (results are cached since we don't like brute force searches). In this last case, the first icon found associated with the spell is used which may not be the same one that is used once the spell is learned into the player's spellbook because there are multiple icons for the same spell name. If you look on Wowhead.com you will see examples of this with at least three different icons associated with Moonkin Form.
I will think more about improving the accuracy of this. For example, I could prefer any icon that has ever been detected in the player spellbook.
Update: I have changed the icon caching strategy to (1) refresh the icon cache when switching specs and (2) prefer looking up textures by spell name over spell id since this usually gives better results. I think the first change will make the biggest difference. I'll commit the changes after a bit of testing and probably after I get a chance to debug the Eclipse code as well.
Yeah that is much better concerning the remnants. Still have 1 remnant though. If I have myself buffed with righteous fury my bartender4 autohide bar shows a highlight around the RF spells on that bar (I have 2 on the bar foir some dumb reason lol) and those highlights always appear even if the bar is hidden. If I remove RF the highlights disappear. And yes my long buffs are set up as icons (with minibars off now) Also Divine Favor cooldown is not being tracked.
For icon only, how about cooldown numbers on the icon, or maybe something can be done to let omnicc use the frames.
You can already achieve this. Select the bar group and switch to the layout tab. Under icon arrangement settings is an option to offset the timer text. Just change the value of the offset so that the timer appears over the icon. Screenshot below shows a rather large version of an icon cd as an example.
Version r46 checked in: Changed icon caching strategy to (1) refresh the icon cache when switching specs and (2) prefer looking up textures by spell name over spell id since this usually gives better results. Fixed Divine Favor cooldown not being tracked. Changed default for unlimited duration bars to "Full Bars". Fixed Eclipse cooldown tracking (pending verification).
Morgalm, glad to hear bar remnants are banished. The "highlights on hidden BT4 bars" has been on my bug list for a while and I'll elevate its priority.
Craxziz, I found a bug in the Eclipse code by inspection that exactly matches the symptoms but the fix hasn't been verified by boomkin testing yet. Also, let me know if the notification icon is working better for you, thanks.
Craxziz, I found a bug in the Eclipse code by inspection that exactly matches the symptoms but the fix hasn't been verified by boomkin testing yet. Also, let me know if the notification icon is working better for you, thanks.
The eclipse cds are working a treat again ty. Run a few spec swaps on different toons to see if I can bug the notification icons, so far they've all been the right icons. Will let you know if I get anymore glitches with the icons, but looking good atm.
If I have myself buffed with righteous fury my bartender4 autohide bar shows a highlight around the RF spells on that bar (I have 2 on the bar foir some dumb reason lol) and those highlights always appear even if the bar is hidden. If I remove RF the highlights disappear.
Version r47 adds a test in the highlights code to make sure the button is visible before displaying highlights or cooldown counts. I actually could not reproduce the problem as you describe it on my paladin so I wonder what your specific settings are for autohide in bartender4. When I enable "hide out of combat" the bar disappears immediately and the highlight disappears about half a second later, and similarly when disabling "hide out of combat" the bar reappears immediately and the highlight reappears a half second later. With the added test in r47 the highlight now disappears immediately when the bar is hidden, so that gives me hope it will work with your autohide setting. Let me know when you have had a chance to test it.
I have the autohide set to show on mouseover if that helps.
That does help and I now have a fix that sets highlight and cooldown text opacity to match that of each button. It works with Bartender4 but I need to test with ButtonFacade, Dominos and Macaroon before releasing it.
Firstly spell names on the bars weren't being concatenated but were being wrapped, leading to some rather ugly looking text on bars.
Secondly when bars are ticking down and the backdrop is being shown it doesn't look overly neat with rounded textures. It looks like the foreground texture is shrinking and the background texture is expanding to fill the gap. This leads to some gaps between the two textures. Contrast this to how ora3 cd bars are shown depleting to the right of the screenshot. This isn't by far the worst I've seen them but was the only screenshot I had with a different addon generating bars for comparison.
-
View User Profile
-
View Posts
-
Send Message
Curse PremiumThe spell name wrap is fixed in release r42. I'm pretty sure that my fix for rounded textures should also work. I had assumed square corners and cut the length of the underlying background bar, which was obviously a bad assumption. BTW what texture is that you are using that has the round corners so I can test with it myself?
Texture is called "round", it's one that can be found in the statusbars that come as part of Sharedmedia.
-
View User Profile
-
View Posts
-
Send Message
Curse PremiumI ran my hunter through VoA just now and everything worked fine so I think the latest version should be solid enough to run with now.
-
View User Profile
-
View Posts
-
Send Message
Curse PremiumI've tried to make the times match as closely as possible those seen on Blizzard's tooltips, when displayed in similar formats.
This version also fixes a bug in the "Show With Uniform Duration" timer option.
-
View User Profile
-
View Posts
-
Send Message
Curse PremiumThe left side remnants are my cooldowns, upper left target debuffs, middle noitfication, and above my player frame is short buffs on me. No problem with the icon long buffs. The 2 little ones on the left are 2 righteous fury icons on an autohiding bar using bartender 4.
-
View User Profile
-
View Posts
-
Send Message
Curse PremiumUpdate: I can see the image now. Those are foreground and background textures for bars. From your message, it sounds like these are in bar-oriented bar groups as opposed to icon-oriented. I also assume they go away if you reload UI [Note: this assumption may be wrong for zombie mini-bars, see below]. Let me know if either assumption is wrong. I'll read the code again for recycling bars and see if I see anything that could result in this.
-
View User Profile
-
View Posts
-
Send Message
Curse PremiumUpdate: I am increasingly confident that this scenario will create what I see on the remnants screenshot. The remnant bar colors are class colors which hints at a relationship to the Long Buffs icon group. There are also about the right number of remnant bars in each color. And the Long Buffs icons do not show mini-bars. Reviewing the code, it looks like the zombie mini-bars retain their original anchor points and can show sparks, which matches what I see in the screenshot. And the zombie bars could indeed reappear after a reload UI, since the root cause doesn't go away with a reload. The definitive test is to disable "Bars" in the settings for "Long Buffs" and/or to set non-zero width and height for "Long Buffs" mini-bars. I am testing a fix for all this now.
Thank you for the timer format update, it's great not having to do copy pasta everytime I update now :)
I ended up with the following error in voa25 tonight on my druid, which caused all bar groups to freeze. After running voa10 as well and watching when it happened with a little more care it's linked to when Lunar Eclipse procs, when the eclipse is over everything works fine again. Solar eclipse works fine and error free.
930x Raven-r44\Main.lua:599: attempt to index global 'bs' (a number value) Raven-r44\Main.lua:738: in function `UpdateCooldowns' Raven-r44\Main.lua:256: in function `Update' Raven-r44\Main.lua:79: in function <Raven\Main.lua:79> Locals: self = <table> { updateActionbar = false testOrder = <table> {} modules = <table> {} CooldownTable = <table> {} lockSpells = <table> {} OptionsTable = <table> {} ReleaseBarGroup = <function> @ Raven\Bars.lua:389: SetDefaultModulePrototype = <function> @ Ace3\AceAddon-3.0\AceAddon-3.0.lua:423: updatePlayer = false IsEnabled = <function> @ Ace3\AceAddon-3.0\AceAddon-3.0.lua:465: IsDuplicateLabel = <function> @ Raven\Options.lua:685: RegisterMessage = <function> @ Ace3\CallbackHandler-1.0\CallbackHandler-1.0.lua:118: UnregisterMessage = <function> @ Ace3\CallbackHandler-1.0\CallbackHandler-1.0.lua:181: Update = <function> @ Raven\Main.lua:247: DefaultProfile = <table> {} ResetOptions = <function> @ Raven\Options.lua:91: db = <table> {} InitializeLayouts = <function> @ Raven\Bars.lua:83: LockBarGroups = <function> @ Raven\Bars.lua:369: TopOptionsTable = <table> {} FinalizeBars = <function> @ Raven\Bars.lua:61: UpdateBarGroup = <function> @ Raven\Bars.lua:305: OnEnable = <function> @ Raven\Main.lua:69: LayoutTemplate = <table> {} UpdateHighlights = <function> @ Raven\Highlights.lua:287: OnInitialize = <function> @ Raven\Main.lua:58: UnregisterAllEvents = <function> @ Ace3\CallbackHandler-1.0\CallbackHandler-1.0.lua:202: InitializeBarGroup = <function> @ Raven\Bars.lua:265: UpdateCooldowns = <function> @ Raven\Main.lua:659: conditionTests = <table> {} UNIT_PET = <function> @ Raven\Main.lua:143: HideBars = <function> @ Raven\Bars.lua:73: InitializeTalents = <function> @ Raven\Main.lua:164: OnProfileChanged = <function> @ Raven\Profile.lua:72: GetName = <function> @ Ace3\AceAddon-3.0\AceAddon-3.0.lua:298: OnProfileShutDown = <function> @ Raven\Profile.lua:78: name = "Raven" ldb = <table> {} Disable = <function> @ Ace3\AceAddon-3.0\AceAddon-3.0.lua:328: SetConditionDefaults = <function> @ Raven\Profile.lua:225: updatePet = false InitializeWeaponBuffs = <function> @ Raven\Main.lua:341: Print = <function> @ Ace3\AceConsole-3.0\AceConsole-3.0.lua:54: updateCooldowns = false eclipseTab = 1 PLAYER_TARGET_CHANGED = <function> @ Raven\Main.lua:148: highlights = true runeTypes = <table> {} PLAYER_TALENT_UPDATE = <function> @ Raven\Main.lua:137: DebuffTable = <table> {} CleanupProfile = <function> @ Raven\Profile.lua:87: UnregisterEvent = <function> @ Ace3\CallbackHandler-1.0\CallbackHandler-1.0.lua:181: UpdateAuras = <function> @ Raven\Main.lua:471: SetDefaultModuleLibraries = <function> @ Ace3\AceAddon-3.0\AceAddon-3.0.lua:381: runeIcons = <table> {} GetIconForBar = <function> @ Raven\Options.lua:665: EnableModule = <function> @ Ace3\AceAddon-3.0\AceAddon-3.0.lua:346: baseName = "Raven" IterateEmbeds = <function> @ Ace3\AceAddon-3.0\AceAddon-3.0.lua:456: SetIconDefaults = <function> @ Raven\Profile.lua:211: Printf = <function> @ Ace3\AceConsole-3.0\AceConsole-3.0.lua:69: myClass = "DRUID" SetDimensionDefaults = <function> @ Raven\Profile.lua:231: InitializeBars = <function> @ Raven\Bars.lua:42: DisableModule = <function> @ Ace3\AceAddon-3.0\AceAddon-3.0.lua:364: SPELLS_CHANGED = <function> define ---Also on my notifications bar which I have setup in icon only mode, I occasionally get an incorrect spell icon show up. This corrects itself after the spell is cast, so maybe there is a caching issue? Whilst I haven't been reliably able to reproduce it, it does appear to happen more often than not after switching from the spec originally logged in as to a different one. In the screenshot below the icons for innervate and typhoon are correct, but the icon that is showing up as moonkin form should actually be force of nature.-
View User Profile
-
View Posts
-
Send Message
Curse PremiumThis release also includes a fix reported by my boomkin tester to the same problem Craxziz just reported (line 599 attempt to index bs, a number value) that was introduced in the Eclipse detection code with the buff management changes. I haven't heard back if the fix works so I have my fingers crossed. Let me know Craxziz if you see any more issues with Eclipse.
I'll check out the notification icon issue, Craxziz.
Just quickly blasted a training dummy to test the fix. The error is gone and lunar eclipse shows up properly, however no cd bar is generated for solar eclipse now, though this is error free.
-
View User Profile
-
View Posts
-
Send Message
Curse PremiumI think what is happening here is that spell icons get cached when first used. Sometimes this is when an aura is detected, in which case the right icon for the spell is included in the result from UnitAura. Sometimes it is found in the player's spellbook, in which case it is the icon that Blizzard associates in the player's spellbook with the spell. But sometimes it is not available in the player's spellbook (e.g., before you switch spec), in which case Raven attempts to find it with a brute force search of the full internal spellbook (results are cached since we don't like brute force searches). In this last case, the first icon found associated with the spell is used which may not be the same one that is used once the spell is learned into the player's spellbook because there are multiple icons for the same spell name. If you look on Wowhead.com you will see examples of this with at least three different icons associated with Moonkin Form.
I will think more about improving the accuracy of this. For example, I could prefer any icon that has ever been detected in the player spellbook.
Update: I have changed the icon caching strategy to (1) refresh the icon cache when switching specs and (2) prefer looking up textures by spell name over spell id since this usually gives better results. I think the first change will make the biggest difference. I'll commit the changes after a bit of testing and probably after I get a chance to debug the Eclipse code as well.
-
View User Profile
-
View Posts
-
Send Message
Curse PremiumYou can already achieve this. Select the bar group and switch to the layout tab. Under icon arrangement settings is an option to offset the timer text. Just change the value of the offset so that the timer appears over the icon. Screenshot below shows a rather large version of an icon cd as an example.
-
View User Profile
-
View Posts
-
Send Message
Curse PremiumMorgalm, glad to hear bar remnants are banished. The "highlights on hidden BT4 bars" has been on my bug list for a while and I'll elevate its priority.
Craxziz, I found a bug in the Eclipse code by inspection that exactly matches the symptoms but the fix hasn't been verified by boomkin testing yet. Also, let me know if the notification icon is working better for you, thanks.
The eclipse cds are working a treat again ty. Run a few spec swaps on different toons to see if I can bug the notification icons, so far they've all been the right icons. Will let you know if I get anymore glitches with the icons, but looking good atm.
-
View User Profile
-
View Posts
-
Send Message
Curse PremiumVersion r47 adds a test in the highlights code to make sure the button is visible before displaying highlights or cooldown counts. I actually could not reproduce the problem as you describe it on my paladin so I wonder what your specific settings are for autohide in bartender4. When I enable "hide out of combat" the bar disappears immediately and the highlight disappears about half a second later, and similarly when disabling "hide out of combat" the bar reappears immediately and the highlight reappears a half second later. With the added test in r47 the highlight now disappears immediately when the bar is hidden, so that gives me hope it will work with your autohide setting. Let me know when you have had a chance to test it.
-
View User Profile
-
View Posts
-
Send Message
Curse Premium-
View User Profile
-
View Posts
-
Send Message
Curse PremiumThat does help and I now have a fix that sets highlight and cooldown text opacity to match that of each button. It works with Bartender4 but I need to test with ButtonFacade, Dominos and Macaroon before releasing it.
Update: Version r48 includes this fix.