Druid: Typhoon, Starfall, Force of Nature
Paladin: Divine Plea, Shield of Righteousness, Hammer of the Righteous
Death Knight: Mind Freeze
Shaman: Wind Shear
I've added these to the preset files in r36. Since r34, cooldowns now have to be identified in the preset files in order to be displayed so I will need to do a class-by-class review to make sure I haven't missed any others. Thank you for catching these.
I've also fixed the bug that didn't allow clicking off bars in the Layout tab.
Just curious, are the presets automatically generated from some source and then modified or are they manually assembled?
They are manually assembled using Wowhead.com as a source for the information. This can be prone to errors but up to r34 that didn't matter so much since I was using the spell book to check for cooldowns. The new approach is better in that it takes less time to run (and detects lockouts) but I do need to do a thorough review of the preset files.
I will get the changes you found into the preset files before the next version is released. I am making good progress on icon-only configurations and should have that ready to go shortly.
I've checked in updated class preset files to fix these.
I tested the icons-only configurations last night in a raid and it is getting close. I also found a couple issues with opacity in the current code (i.e., icon opacity is not adjustable and background opacity is not calculated right) and I'll include fixes for these in the icons-only release.
on my 79 warlock whenever I dismount it always fails to pick up my weapon buff and sometimes fails to pick up my armour buff so I continue getting the missing weapon and armour warnings. this has been happening ever since I started using this awesome addon.
This sounds interesting, I haven't yet tried it out, but it seems like this could be a combination of ClassTimer and Debuff Filter/rFilter with more options? I look forward to it!
on my 79 warlock whenever I dismount it always fails to pick up my weapon buff and sometimes fails to pick up my armour buff so I continue getting the missing weapon and armour warnings. this has been happening ever since I started using this awesome addon.
I haven't been able to replicate this on my 80 warlock. Which weapon buff are you using? Does it pick up the buff when you apply it but loses track when you mount then dismount?
Please try this again after turning off the "Is Resting" test in player status for the condition "Weapon Buff Missing". That will let you test in Dalaran and cut one possible source of delay that could affect picking up the weapon buff.
Also, I wonder if you have either a relatively fast or slow system. Raven uses events to detect buff changes so if it somehow missed seeing the weapon buff then it might not get around to checking it again.
For all you icons-only fans, please download and try version r39. There are four new icon-based configurations on the Layout tab. When you select one, a new set of options appear for Icon Arrangement Settings. Note that the Dimensions settings have moved to the Layout tab too so you can try lots of different arrangements without flipping between tabs too much. Also note that you can now separately change the font-related properties for labels, time text, and icon stack counts on the Appearance tab.
Icon-based settings let you adjust the size and location of a mini-bar. Try making it just four pixels high and setting it either above of below the icon. With class coloring, this can be quite helpful for long buffs. Or make it bigger and use it as a backdrop for the time text. And, of course, you can turn it and any of the other bar components off if you want. Experiment and let me know what works for you and what could be improved.
Here is the release text noting other bug fixes and a caveat:
Adding icon-only configurations plus related changes to the options panel. Fixed opacity issues with icons and background bar textures. Fixed alt-right-click for changing configurations. Fixed issue with rune bars in profile for non-Death Knights. Fixed issue with moving anchors (should not track right key presses). Changed draw layers for components of bar frames to fix issue with relative visibility.
This version has a lot of changes so be sure to back up your existing version (and associated WTF settings) in case there are errors that cause the addon to not work for you.
Not sure if this was doable on earlier versions but started to play around with the icons only mode, but discovered that I can force this error regardless of that. When using custom bar groups, if you set the type to cd, select a class spell (I worked my way thru all the lock ones with an associated cd just to check) and then select the is ready box, the following error pops. Seems to only happen when show unlimited durations is set to on as well.
44x Raven-r39\Bars.lua:846: attempt to call global 'RavenGetLink' (a nil value)
Raven-r39\Main.lua:260: in function `Update'
Raven-r39\Main.lua:77: in function <Raven\Main.lua:77>
Not sure if this was doable on earlier versions but started to play around with the icons only mode, but discovered that I can force this error regardless of that. When using custom bar groups, if you set the type to cd, select a class spell (I worked my way thru all the lock ones with an associated cd just to check) and then select the is ready box, the following error pops. Seems to only happen when show unlimited durations is set to on as well.
I was a bit too ambitious in removing a function I thought was no longer needed. Fixed in version r40 (removed r39 since this is the only change).
Zone wide buffs are no longer showing up on the auto buff group, ie Essence of Wintergrasp, they were showing up previously. Still have target set to player and cast by anyone set.
Zone wide buffs are no longer showing up on the auto buff group, ie Essence of Wintergrasp, they were showing up previously. Still have target set to player and cast by anyone set.
You probably already checked this but please verify that Show If Unlimited Duration is set in the bar group's timer options. I see Essence of Wintergrasp in my Long Buffs bar group at this very moment, so maybe... Oh, and also check your spell filters in the Buffs tab.
BTW, my next major focus is on the Link Settings code to make sure it properly shares the right settings between toons. I mention it because I've found it easy to change a setting on one toon and then find it not as expected on another.
Well, combined with sirlimpy's report about warlock buffs not being picked up on dismount, this makes me want to dig a bit deeper into the buffs code and see if I've missed something. It will be tricky without a repeatable test case though. Let me know if you see another anomaly--especially if you see a buff icon in another addon like Pitbull but not in Raven.
A small request: would it be easy to implement the option to show timers longer than 59" as 1m, 2m, etc?
Thanks again
Have a fiddle around with nest.lua at line 638. This is where the timer formating occurs. t is the time in seconds, so divide by 60 to get minutes. I customise my timers and just copy and paste in the changes as and when it updates.
I have custom time formats on my list of "features to implement when time permits". I can bump it up in priority a bit. Craxziz, please post or private message me the code you copy and paste in so I'm sure to include the one you prefer.
I've spent some time looking at the aura table code in Pitbull4 and I am testing an update based on it. It is much cleaner than what I had and easier for me to be sure that there isn't an anomaly in aura management.
Version r41 includes the new aura management code which considerably simplifies how auras are handled internally. The previous code was convoluted because, for some reason, when I wrote it I was hung up on indexing the aura tables by name and ended up creating linked lists of auras with the same name (which happens quite a lot with target debuffs in raids), all while avoiding garbage collection at all costs. The new code is inspired by the method used in Pitbull4.
I've tested this code to the point that I have enough confidence to use it raiding. However, I will be on the lookout for aura issues and any evidence of a memory leak. Please report any strange behaviour if you decide to update to this version. I am somewhat hopeful that it will fix the buff anomalies previously reported.
Rollback Post to RevisionRollBack
To post a comment, please login or register a new account.
-
View User Profile
-
View Posts
-
Send Message
Curse PremiumI've added these to the preset files in r36. Since r34, cooldowns now have to be identified in the preset files in order to be displayed so I will need to do a class-by-class review to make sure I haven't missed any others. Thank you for catching these.
I've also fixed the bug that didn't allow clicking off bars in the Layout tab.
Druid missing cooldown: Berserk, Feral Charge - Bear, Feral Charge - Cat, Mangle (Bear), Survival Instincts
Mage not a cooldown: Arcane Blast
Priest missing cooldown: Fear Ward
Just curious, are the presets automatically generated from some source and then modified or are they manually assembled?
-
View User Profile
-
View Posts
-
Send Message
Curse PremiumThey are manually assembled using Wowhead.com as a source for the information. This can be prone to errors but up to r34 that didn't matter so much since I was using the spell book to check for cooldowns. The new approach is better in that it takes less time to run (and detects lockouts) but I do need to do a thorough review of the preset files.
I will get the changes you found into the preset files before the next version is released. I am making good progress on icon-only configurations and should have that ready to go shortly.
Also would it be possible to create a merged cd bar for potions, similar to the one for shocks, judgements, etc?
-
View User Profile
-
View Posts
-
Send Message
Curse Premium-
View User Profile
-
View Posts
-
Send Message
Curse PremiumI tested the icons-only configurations last night in a raid and it is getting close. I also found a couple issues with opacity in the current code (i.e., icon opacity is not adjustable and background opacity is not calculated right) and I'll include fixes for these in the icons-only release.
http://www.wowinterface.com/downloads/info17117-ClassTimer.html
http://www.wowinterface.com/downloads/info6530-DebuffFilter.html
http://www.wowinterface.com/downloads/info13006-rFilter2.html
-
View User Profile
-
View Posts
-
Send Message
Curse PremiumI haven't been able to replicate this on my 80 warlock. Which weapon buff are you using? Does it pick up the buff when you apply it but loses track when you mount then dismount?
Please try this again after turning off the "Is Resting" test in player status for the condition "Weapon Buff Missing". That will let you test in Dalaran and cut one possible source of delay that could affect picking up the weapon buff.
Also, I wonder if you have either a relatively fast or slow system. Raven uses events to detect buff changes so if it somehow missed seeing the weapon buff then it might not get around to checking it again.
-
View User Profile
-
View Posts
-
Send Message
Curse PremiumIcon-based settings let you adjust the size and location of a mini-bar. Try making it just four pixels high and setting it either above of below the icon. With class coloring, this can be quite helpful for long buffs. Or make it bigger and use it as a backdrop for the time text. And, of course, you can turn it and any of the other bar components off if you want. Experiment and let me know what works for you and what could be improved.
Here is the release text noting other bug fixes and a caveat:
Adding icon-only configurations plus related changes to the options panel. Fixed opacity issues with icons and background bar textures. Fixed alt-right-click for changing configurations. Fixed issue with rune bars in profile for non-Death Knights. Fixed issue with moving anchors (should not track right key presses). Changed draw layers for components of bar frames to fix issue with relative visibility.
This version has a lot of changes so be sure to back up your existing version (and associated WTF settings) in case there are errors that cause the addon to not work for you.
-
View User Profile
-
View Posts
-
Send Message
Curse PremiumI was a bit too ambitious in removing a function I thought was no longer needed. Fixed in version r40 (removed r39 since this is the only change).
Zone wide buffs are no longer showing up on the auto buff group, ie Essence of Wintergrasp, they were showing up previously. Still have target set to player and cast by anyone set.
-
View User Profile
-
View Posts
-
Send Message
Curse PremiumYou probably already checked this but please verify that Show If Unlimited Duration is set in the bar group's timer options. I see Essence of Wintergrasp in my Long Buffs bar group at this very moment, so maybe... Oh, and also check your spell filters in the Buffs tab.
BTW, my next major focus is on the Link Settings code to make sure it properly shares the right settings between toons. I mention it because I've found it easy to change a setting on one toon and then find it not as expected on another.
-
View User Profile
-
View Posts
-
Send Message
Curse PremiumA small request: would it be easy to implement the option to show timers longer than 59" as 1m, 2m, etc?
Thanks again
Have a fiddle around with nest.lua at line 638. This is where the timer formating occurs. t is the time in seconds, so divide by 60 to get minutes. I customise my timers and just copy and paste in the changes as and when it updates.
-
View User Profile
-
View Posts
-
Send Message
Curse PremiumI've spent some time looking at the aura table code in Pitbull4 and I am testing an update based on it. It is much cleaner than what I had and easier for me to be sure that there isn't an anomaly in aura management.
-
View User Profile
-
View Posts
-
Send Message
Curse PremiumI've tested this code to the point that I have enough confidence to use it raiding. However, I will be on the lookout for aura issues and any evidence of a memory leak. Please report any strange behaviour if you decide to update to this version. I am somewhat hopeful that it will fix the buff anomalies previously reported.