Seems that on the MoP version of this when using Icons (not bars) multiple horn of winters show up... one for each of the DK's casting it.
I am working my way through the classes currently. When I get to DKs then I'll see if anything changed that might explain the behavior of icons versus bars for this spell. It looks like Horn of Winter has not changed so much that it would cause that problem (different effect, different cooldown but same spell id).
I assume the image is showing a Buffs (or Long Buffs) standard bar group in icon format, right? If you turn off Hide Blizzard Buffs on Raven's Setup tab then you can see both sets of buffs at the same time, which is useful for comparing if they are doing the same thing. Thanks for reporting the issue.
I just got this addon for a dedicated proc tracker on Beta, and it's working wonderfully thus far. My sole concern is that I cannot figure out a way to make the addon distinguish between the crit, haste, and mastery Windsong weapon enchant buffs. Each of these buffs has a unique spell ID but the same spell name - Windsong. I cannot seem to add the buffs by spell ID - if I do, Raven automatically recognises the ID I input as Windsong, changes the name as such, and will not let me add different "Windsong" buffs with the other ID's to my custom bar group. It appears that the "Windsong" bar encompasses all three of Windsong's associated spell IDs, as I have seen it show up twice in a list of procs if two Windsong buffs happen to be active at once. However, there is simply no way to determine whether the proc shown is crit, haste, or mastery without mousing over the bar.
Is there any way to force Raven to distinguish between the different Windsong spell ID's ? I don't want to have to find another proc-tracker.
I just got this addon for a dedicated proc tracker on Beta, and it's working wonderfully thus far. My sole concern is that I cannot figure out a way to make the addon distinguish between the crit, haste, and mastery Windsong weapon enchant buffs. Each of these buffs has a unique spell ID but the same spell name - Windsong. I cannot seem to add the buffs by spell ID - if I do, Raven automatically recognises the ID I input as Windsong, changes the name as such, and will not let me add different "Windsong" buffs with the other ID's to my custom bar group. It appears that the "Windsong" bar encompasses all three of Windsong's associated spell IDs, as I have seen it show up twice in a list of procs if two Windsong buffs happen to be active at once. However, there is simply no way to determine whether the proc shown is crit, haste, or mastery without mousing over the bar.
Is there any way to force Raven to distinguish between the different Windsong spell ID's ? I don't want to have to find another proc-tracker.
Thanks.
This should be doable with an option on the Spells tab. I just enchanted Windsong for testing purposes and will check it out myself. This may require a small amount of new code to work the way it should, though. I will try to include a preset for this in the next version.
UPDATE: I have tested the code change (only four lines) and you can now enter a spell ID for setting labels in the Spells tab (format: #104509). I entered different labels for the three flavors of Windsong and it now displays the correct label for each type. I still need to clarify the change in the tooltip text and make it work for colors and sounds (which are defined in the same interface). Also, not sure that this can be made to work as easily in a custom bar group (currently only works in auto bar group) but that is easily addressed by merging bar groups, if desired. Should be in the next release. Thanks for reporting this!
Thanks for the prompt response and info. :D It would be great if this worked with colour so that each Windsong could be coloured differently. Looking forward to the next release.
Hello,
First, I thank you a lot for this fantastic addon that saved my life as a warlock in fireland and dragon soul, letting me track pretting much everything in a very simple and clean way.
I'am using the latest alpha version for mop, but I can't manage to track many cooldowns with custom bars, either using the preset or by adding the spell id.
Example :
- Hand of Gul'dan
- Conflagrate
- All the Dark soul cd's
From what i see, they are recognized (the icon is the good one), but never considered as usable, and always considered as ready.
I have disabled all my other addon just to be sure this wasn't a conflict of some sort.
Hello,
First, I thank you a lot for this fantastic addon that saved my life as a warlock in fireland and dragon soul, letting me track pretting much everything in a very simple and clean way.
I'am using the latest alpha version for mop, but I can't manage to track many cooldowns with custom bars, either using the preset or by adding the spell id.
Example :
- Hand of Gul'dan
- Conflagrate
- All the Dark soul cd's
From what i see, they are recognized (the icon is the good one), but never considered as usable, and always considered as ready.
I have disabled all my other addon just to be sure this wasn't a conflict of some sort.
The way Raven detects cooldowns requires up-to-date class-specific preset files. This method was chosen to minimize CPU overhead and fully support spell school lockouts. However, it does mean that each major expansion requires a bit of work for each class to update everything. Currently, in latest release, the following classes have been updated: druid, priest, rogue, paladin, mage and monk. I am working on warrior at the moment and will prioritize warlock after that. Thank you for testing Raven. Please check the release notes for each new alpha to see when warlock support is updated (it should be in the next couple days).
UPDATE: These changes are included in r244.
Note that Hand of Gul'dan or Conflagrate do not list cooldowns (they list recharge time, which may not be detected in quite the same way). I ran into a warrior spell with a recharge time too, so I will have to test the best way to handle such spells. In any case, I ask your patience on those until I check them out.
Thanks alot for the quick update.
For the recharge time, maybe for icons a simple number should do the trick, like for molten core stacks or sunder armor stacks.
For bars, maybe split the bar in 2 if there is 2 charges ?
I just tested the last release (r245) but Dark soul still isn't tracked properly in custom bars.
I tested all 4 dark soul but none seem to work.
Yes, I am testing it myself on the beta right now and it seems like Dark Soul works differently than similar spells. I'll hold off on the next release until I figure this out.
UPDATE: Dark Soul mechanism works similar to priest Chakra spells. I have tested the changes and all three variants show as cooldowns now. This is included in r246.
Also, not sure that this can be made to work as easily in a custom bar group (currently only works in auto bar group) but that is easily addressed by merging bar groups, if desired.
Hi, I'm trying out the newest release (r246) right now. Which preset bar group are you using to show the buff ? I tried out the "Short buffs" group, with no luck. Raven now supports adding specific spellID's with a hashtag (e.g. #104423), and I can add each flavour of windsong to my custom bar group, and define a colour/label for each. However, none of the bars actually show up when the proc happens. Same problem with the "Short buffs" group.
Hi, I'm trying out the newest release (r246) right now. Which preset bar group are you using to show the buff ? I tried out the "Short buffs" group, with no luck. Raven now supports adding specific spellID's with a hashtag (e.g. #104423), and I can add each flavour of windsong to my custom bar group, and define a colour/label for each. However, none of the bars actually show up when the proc happens. Same problem with the "Short buffs" group.
Just verified this: On the Spells tab, enter each windsong variant's spell id with hashtag in Spell Name and for each one enter the appropriate Label. E.g., Spell Name = #104509, Label = "Windsong (Critical Strike)". When windsong procs in either Short Buffs or Buffs bar group then you will see the correct identifying label.
In beta die by the Sword is not listed under cooldowns for warriors. I tried entering the spell manually, but it still doesn't show its cooldown. It does show the icon though.
I think I fixed it in warrior.lua I found this line
{ "Die by the Sword", BUFF, p.Orange2, id = 118038 },
and changed it to
{ "Die by the Sword", BUFF, p.Orange2, cooldown = true, id = 118038 },
I took a total guess and that fixed it. Now if I pick cooldowns, it shows up in the list.
In beta die by the Sword is not listed under cooldowns for warriors. I tried entering the spell manually, but it still doesn't show its cooldown. It does show the icon though.
I think I fixed it in warrior.lua I found this line
{ "Die by the Sword", BUFF, p.Orange2, id = 118038 },
and changed it to
{ "Die by the Sword", BUFF, p.Orange2, cooldown = true, id = 118038 },
I took a total guess and that fixed it. Now if I pick cooldowns, it shows up in the list.
I just checked in a new alpha with an updated cooldown detection algorithm that should work better (i.e., it no longer depends on the cooldown annotations in the presets being 100% accurate). I tested it and it recognizes Die by the Sword cooldown even without the change to preset file so that is good. However, I'll include the change to the warrior preset in next build so that Die by the Sword shows up on the cooldown list for custom bars.
Right clicking to remove a buff does not work in combat.
You haven't been able to right click to remove an arbitrary buff in combat since the beginning of Cataclysm when Blizzard changed the buff API and made it pretty much impossible to do in a full-featured buff addon.
Different authors found different solutions. One of my favorites is the addon CancelMyBuffs by Phanx, which provides a keybinding for cancelling buffs (which is quicker and easier to use than right-clicking an icon, in my opinion).
Within Raven, I've implemented a special bar called the In-Combat Bar that you set up while out of combat. You define a list of player buffs that you want to be able to cancel in combat (e.g., Ice Block on mage, Dominate Mind on priest). When one of these buffs becomes active in combat, its icon pulses into place on the "in-combat" bar and you can right-click it to cancel the buff.
Slam was missing from cooldowns for warriors so I added this line to warrior.lua
{ "Slam", nil, p.Green, cooldown = true, id = 1464 },
And it shows up. Only thing is with cooldowns of 1.5secs or less I have to manually add the spell and duration, but that's fine. Maybe eventually add an option to show cooldowns that are equal to or less than the GCD.
Slam was missing from cooldowns for warriors so I added this line to warrior.lua
{ "Slam", nil, p.Green, cooldown = true, id = 1464 },
And it shows up. Only thing is with cooldowns of 1.5secs or less I have to manually add the spell and duration, but that's fine. Maybe eventually add an option to show cooldowns that are equal to or less than the GCD.
It really doesn't look like Slam has a cooldown (checked on the beta this morning to verify that wowhead had it right). It does trigger the global cooldown which is what you are seeing.
The problem is when I want to track one of these spells as if the GCD was the cooldown, I do this with heroic strike, cleave, and slam. When I go to otherspells and add slam, it doesn't show a 1.5s cooldown. So I have to add slam under spells and put in a 1.5sec duration.
Its just a messy way of how I have to do it. I'm not sure how I would track wildstrike since it can be 1.5gcd or 1sec.
Rollback Post to RevisionRollBack
To post a comment, please login or register a new account.
-
View User Profile
-
View Posts
-
Send Message
Curse PremiumI am working my way through the classes currently. When I get to DKs then I'll see if anything changed that might explain the behavior of icons versus bars for this spell. It looks like Horn of Winter has not changed so much that it would cause that problem (different effect, different cooldown but same spell id).
I assume the image is showing a Buffs (or Long Buffs) standard bar group in icon format, right? If you turn off Hide Blizzard Buffs on Raven's Setup tab then you can see both sets of buffs at the same time, which is useful for comparing if they are doing the same thing. Thanks for reporting the issue.
The default buff bar is not duplicating the buffs. I asked a raid member not running a buff mod to confirm.
Good work on the mod and keeping it prepped for MoP. Thank you Cheers
I just got this addon for a dedicated proc tracker on Beta, and it's working wonderfully thus far. My sole concern is that I cannot figure out a way to make the addon distinguish between the crit, haste, and mastery Windsong weapon enchant buffs. Each of these buffs has a unique spell ID but the same spell name - Windsong. I cannot seem to add the buffs by spell ID - if I do, Raven automatically recognises the ID I input as Windsong, changes the name as such, and will not let me add different "Windsong" buffs with the other ID's to my custom bar group. It appears that the "Windsong" bar encompasses all three of Windsong's associated spell IDs, as I have seen it show up twice in a list of procs if two Windsong buffs happen to be active at once. However, there is simply no way to determine whether the proc shown is crit, haste, or mastery without mousing over the bar.
Is there any way to force Raven to distinguish between the different Windsong spell ID's ? I don't want to have to find another proc-tracker.
Thanks.
-
View User Profile
-
View Posts
-
Send Message
Curse PremiumThis should be doable with an option on the Spells tab. I just enchanted Windsong for testing purposes and will check it out myself. This may require a small amount of new code to work the way it should, though. I will try to include a preset for this in the next version.
UPDATE: I have tested the code change (only four lines) and you can now enter a spell ID for setting labels in the Spells tab (format: #104509). I entered different labels for the three flavors of Windsong and it now displays the correct label for each type. I still need to clarify the change in the tooltip text and make it work for colors and sounds (which are defined in the same interface). Also, not sure that this can be made to work as easily in a custom bar group (currently only works in auto bar group) but that is easily addressed by merging bar groups, if desired. Should be in the next release. Thanks for reporting this!
First, I thank you a lot for this fantastic addon that saved my life as a warlock in fireland and dragon soul, letting me track pretting much everything in a very simple and clean way.
I'am using the latest alpha version for mop, but I can't manage to track many cooldowns with custom bars, either using the preset or by adding the spell id.
Example :
- Hand of Gul'dan
- Conflagrate
- All the Dark soul cd's
From what i see, they are recognized (the icon is the good one), but never considered as usable, and always considered as ready.
I have disabled all my other addon just to be sure this wasn't a conflict of some sort.
-
View User Profile
-
View Posts
-
Send Message
Curse PremiumThe way Raven detects cooldowns requires up-to-date class-specific preset files. This method was chosen to minimize CPU overhead and fully support spell school lockouts. However, it does mean that each major expansion requires a bit of work for each class to update everything. Currently, in latest release, the following classes have been updated: druid, priest, rogue, paladin, mage and monk. I am working on warrior at the moment and will prioritize warlock after that. Thank you for testing Raven. Please check the release notes for each new alpha to see when warlock support is updated (it should be in the next couple days).
UPDATE: These changes are included in r244.
Note that Hand of Gul'dan or Conflagrate do not list cooldowns (they list recharge time, which may not be detected in quite the same way). I ran into a warrior spell with a recharge time too, so I will have to test the best way to handle such spells. In any case, I ask your patience on those until I check them out.
For the recharge time, maybe for icons a simple number should do the trick, like for molten core stacks or sunder armor stacks.
For bars, maybe split the bar in 2 if there is 2 charges ?
I tested all 4 dark soul but none seem to work.
-
View User Profile
-
View Posts
-
Send Message
Curse PremiumYes, I am testing it myself on the beta right now and it seems like Dark Soul works differently than similar spells. I'll hold off on the next release until I figure this out.
UPDATE: Dark Soul mechanism works similar to priest Chakra spells. I have tested the changes and all three variants show as cooldowns now. This is included in r246.
Hi, I'm trying out the newest release (r246) right now. Which preset bar group are you using to show the buff ? I tried out the "Short buffs" group, with no luck. Raven now supports adding specific spellID's with a hashtag (e.g. #104423), and I can add each flavour of windsong to my custom bar group, and define a colour/label for each. However, none of the bars actually show up when the proc happens. Same problem with the "Short buffs" group.
-
View User Profile
-
View Posts
-
Send Message
Curse PremiumJust verified this: On the Spells tab, enter each windsong variant's spell id with hashtag in Spell Name and for each one enter the appropriate Label. E.g., Spell Name = #104509, Label = "Windsong (Critical Strike)". When windsong procs in either Short Buffs or Buffs bar group then you will see the correct identifying label.
-
View User Profile
-
View Posts
-
Send Message
Curse PremiumI think I fixed it in warrior.lua I found this line
{ "Die by the Sword", BUFF, p.Orange2, id = 118038 },
and changed it to
{ "Die by the Sword", BUFF, p.Orange2, cooldown = true, id = 118038 },
I took a total guess and that fixed it. Now if I pick cooldowns, it shows up in the list.
-
View User Profile
-
View Posts
-
Send Message
Curse PremiumI just checked in a new alpha with an updated cooldown detection algorithm that should work better (i.e., it no longer depends on the cooldown annotations in the presets being 100% accurate). I tested it and it recognizes Die by the Sword cooldown even without the change to preset file so that is good. However, I'll include the change to the warrior preset in next build so that Die by the Sword shows up on the cooldown list for custom bars.
-
View User Profile
-
View Posts
-
Send Message
Curse PremiumYou haven't been able to right click to remove an arbitrary buff in combat since the beginning of Cataclysm when Blizzard changed the buff API and made it pretty much impossible to do in a full-featured buff addon.
Different authors found different solutions. One of my favorites is the addon CancelMyBuffs by Phanx, which provides a keybinding for cancelling buffs (which is quicker and easier to use than right-clicking an icon, in my opinion).
Within Raven, I've implemented a special bar called the In-Combat Bar that you set up while out of combat. You define a list of player buffs that you want to be able to cancel in combat (e.g., Ice Block on mage, Dominate Mind on priest). When one of these buffs becomes active in combat, its icon pulses into place on the "in-combat" bar and you can right-click it to cancel the buff.
-
View User Profile
-
View Posts
-
Send Message
Curse Premium{ "Slam", nil, p.Green, cooldown = true, id = 1464 },
And it shows up. Only thing is with cooldowns of 1.5secs or less I have to manually add the spell and duration, but that's fine. Maybe eventually add an option to show cooldowns that are equal to or less than the GCD.
-
View User Profile
-
View Posts
-
Send Message
Curse PremiumIt really doesn't look like Slam has a cooldown (checked on the beta this morning to verify that wowhead had it right). It does trigger the global cooldown which is what you are seeing.
-
View User Profile
-
View Posts
-
Send Message
Curse PremiumIts just a messy way of how I have to do it. I'm not sure how I would track wildstrike since it can be 1.5gcd or 1sec.