Authors CurseForge

Quote from Galvin

Ok I need help doing this.
I made a custom bar notify. To show when to do heroic strike when rage is > 70 and the spell is ready. This part works fine. But I also want to make it light up when battle trance buff is up. But only if the heroic strike spell is ready.

I tried making two conditionals one for heroic strike (>70 rage, spell ready) and battle trance(buff active, heroic strike spell ready)

Then create a custom bar notify and add both to it, but it doesn't work.

Also for some reason when creating these notify bars I can't change the color of them doesn't let me.

So, the condition/notify bar for heroic strike and rage>70 works fine by itself. Does the battle trance and heroic strike ready one work by itself also?

You should be able to show two different bars for these two in the same custom bar group. Alternatively, you can create a third condition that is true if either of these is true and have a single notify bar for it.

It is a little hard to debug without seeing more of what you are doing. Can you put screenshots up somewhere for the conditions and for the custom bar group?

I'll look at the color issue tonight.

Quote from Tomber

So, the condition/notify bar for heroic strike and rage>70 works fine by itself. Does the battle trance and heroic strike ready one work by itself also?

You should be able to show two different bars for these two in the same custom bar group. Alternatively, you can create a third condition that is true if either of these is true and have a single notify bar for it.

It is a little hard to debug without seeing more of what you are doing. Can you put screenshots up somewhere for the conditions and for the custom bar group?

I'll look at the color issue tonight.

I'll try to explain it better. I do have a bar that shows when the battle trance buff is up. What battle trance does is let you use an ability that costs more than 5 rage to cost no rage. So its best to use with a heroic strike.

For heroic strike + battle trance to work. It firsts needs to check to see if a battle trance buff is active. Then it needs to check to see if heroic strike is not on cooldown. If these two conditions are met then it should show the bar.
And I tried placing this under one condition test thing called battle trance.

Then I created another test condition for heroic strike. The spell cant be on cooldown and rage has to be > 70. It should show the bar.

Then create a notify bar. Add both battle trance test and heroic strike test to it. It just doesn't work the way I want it to. It should show the bar if rage is > 70 or if battle trance is active when heroic strike is not on cooldown.

I'm new to this mod so I'm probably doing it wrong.

I attached my save file, hopefully that helps.

Think I may have found the problem. When I add more than one condition to a bar. After its created it only says it has one condition and not both. So I'm thinking its a bug.

I created a new profile and created everything from scratch.
So it'll say
Type:Condition
Condition: Battle Trance!

But it doesn't list the heroic strike! condition.

So this one only displayed when heroic strike was off cooldown and the battle trance was active.

And the bug I mentioned in the curse forums for your mod. Is spreading, everytime I go to Custom bars and click on one of my bars its throwing that same error. And I cant see any changes. So I think the bug is corrupting my profile more and more.

Quote from Galvin

Think I may have found the problem. When I add more than one condition to a bar. After its created it only says it has one condition and not both. So I'm thinking its a bug.

I am not sure how you are adding more than one condition to a bar. Normally a notification is for a single condition. If you want a more complex combination of conditions, use a third condition and add dependencies. Dependencies can "AND" together conditions or "OR" together conditions.

I wonder if you are using the Condition pulldowns under Special Effects to "add more than one condition to a bar". If so, they are only used to control appearance options as described in the associated check box tooltips.

Quote from Galvin

And the bug I mentioned in the curse forums for your mod. Is spreading, everytime I go to Custom bars and click on one of my bars its throwing that same error. And I cant see any changes. So I think the bug is corrupting my profile more and more.

The bug you mentioned in the curse forums is a problem in the localization code. I'll fix it and get a new release out as soon as possible.

Quote from Tomber

I am not sure how you are adding more than one condition to a bar. Normally a notification is for a single condition. If you want a more complex combination of conditions, use a third condition and add dependencies. Dependencies can "AND" together conditions or "OR" together conditions.

I wonder if you are using the Condition pulldowns under Special Effects to "add more than one condition to a bar". If so, they are only used to control appearance options as described in the associated check box tooltips.


The bug you mentioned in the curse forums is a problem in the localization code. I'll fix it and get a new release out as soon as possible.

I got it working. Were you able to fix the color problem for notify bars?

Quote from Galvin

Oh, well when I create a new bar it had checkboxes with all the conditions that I made.

Under result I tried using that, but it would only let me select one condition so didn't know how to add multiple conditions.

Anyway I try that later today, probably won't be able to until tonight.

When you are in the bar creation mode and check multiple boxes then you get separate bars for each one you checked (not one bar which checks all the conditions). Sorry that is not made more clear--I will see if I can update the tooltips to clarify.

I've been looking at your Raven.lua file and I am still trying to understand one of the settings. Please verify that you are using the latest release of Raven (which at the moment is r120). I'll continue to look for what can be causing it, too.

Quote from Tomber

When you are in the bar creation mode and check multiple boxes then you get separate bars for each one you checked (not one bar which checks all the conditions). Sorry that is not made more clear--I will see if I can update the tooltips to clarify.

I've been looking at your Raven.lua file and I am still trying to understand one of the settings. Please verify that you are using the latest release of Raven (which at the moment is r120). I'll continue to look for what can be causing it, too.

It wasn't obvious to me at first but I got it working. using latest release. For now I have a small work around to the color issue. Under appearance I uncheck use defaults and I can change the notify color. Problem is thats not per bar but for all notify. But since I'm only using one notify it works for now.

Quote from Galvin

Under appearance I uncheck use defaults and I can change the notify color. Problem is thats not per bar but for all notify. But since I'm only using one notify it works for now.

Please check what you have the bar group color scheme set to (it is as the bottom of the Appearance tab for the bar group). In order to change individual bar colors Foreground needs to be set to Spell. This is probably not obvious and could be improved on from a user interface point of view :).

Quote from Tomber

Please check what you have the bar group color scheme set to (it is as the bottom of the Appearance tab for the bar group). In order to change individual bar colors Foreground needs to be set to Spell. This is probably not obvious and could be improved on from a user interface point of view :).

It is set to spell. Under the bar set for notify the color and icon are grayed out except for the pulldown box and the color box next to it, but those dont let me change anything.

Like I said if the bar is for a spell or buff I can change the color. But if a bar is for notify I have no color control.

Quote from Galvin

It is set to spell. Under the bar set for notify the color and icon are grayed out except for the pulldown box and the color box next to it, but those dont let me change anything.

Like I said if the bar is for a spell or buff I can change the color. But if a bar is for notify I have no color control.

Thank you for the clear description. I have reproduced this now. I'll give it some thought and see what is to be done.

Quote from X-buZZ

Tomber, i was able to narrow the coloring issue down. It has something to do with the foreground saturation and brightness. A soon as i set them to 0.0 (or no change) the color is correct.

Hi Tomber,

just wanted to ask if you have noticed my response about the coloring issue.

Quote from X-buZZ

Hi Tomber,

just wanted to ask if you have noticed my response about the coloring issue.

Yes, I have and I've done a couple experiments to try to understand the options better.

It has been busy here around the holidays and I probably won't have a large block of time to work on pending issues for a couple more days, though.

Quote from zoumtag

I updated my warlock spell rotation plugin with affliction conditions.

It's available here: http://noiretendard.free.fr/wow_addons/Raven_plugins/Warlock.html

Testers and feedback most welcome )

I might have to bring my warlock out of retirement to test this :).

Here is a summary of my planned fixes for the next release:

1. Fix for localization-related Lua error reported by Galvin. I have this change made in my working copy.

2. Fix coloring issue reported by X-buZZ. Thank you for narrowing this down to the foreground saturation and brightness controls.

3. Fix not being able to set notify color when there is no associated spell, as reported by Galvin.

Here are the highest priority areas I will be looking at after the bug fix release:

1. Address ButtonFacade support (again). I am looking at supporting four different skins for any Raven profile, selectable on a bar group basis. Selection will be on the Appearance tab as well as separate defaults for bar and icon configurations on the Defaults tab. Also, I am thinking of making the two icon border coloring methods selectable (either, both, neither) to address the differences between how skins respond to border coloring and to make sure that people who want to set colors in BF itself can do so. This should address requests for selecting which bar groups use what kind of icon border coloring (reference: virginc on curse addon thread).

2. Generalize bar group filtering. There have been a number of feature requests related to filtering and I am thinking of consolidating filtering options into a single location. Options to include dispellable by type, stealable, purgeable, in another bar group, etc.

3. Generalize shared auras and cooldowns. Currently several shared cooldowns are supported (e.g., shaman shocks). I'm thinking about allowing users to specify sets of auras or cooldowns that will be reduced to single bars.

4. Clean up cooldowns for feral spells. When 4.0.1 came out, some bear and cat abilities (skull bash, swipe, mangle, feral charge) became harder to distinguish and cooldowns were not generated for both bear and cat versions. This leads to an issue with feral charge in particular because there are different cooldown times for each.

5. Registration for localization. I've held off with all the changes for the options panel but I think I probably should just go ahead and get it started.

Did I miss any major pending bugs? Any feedback on priority for feature requests. Feel free to look at open tickets and suggest others that should be addressed sooner.

The only bug if it is a bug. Is with raging blow. Sometimes the cooldown bar will vanish before it reaches zero.

Quote from Galvin

The only bug if it is a bug. Is with raging blow. Sometimes the cooldown bar will vanish before it reaches zero.

This is a confusing one, all right. As far as I know, no other cooldown timer bar behaves like this--they all count down to 0 unless reset by something (a proc or other spell).

I don't have a high-level warrior and I'd appreciate a bit more info from anyone who does have one.

Can you check what the Raging Blow cooldown bar starts at? Does it say 6 seconds when it first comes up? And does it always go away at the same exact time?

Do you have the Glyph of Raging Blow? It looks like that reduced the cooldown by 1.5 seconds at one point during beta but it was later changed.

What I'm wondering is whether this is a bug at Blizzard's end (reporting the wrong duration but lasting the right amount of time) or something that needs to be handled as a special case.

I have the glyph but all it does is increase the crit chance by 5%

Quote from Tomber

Can you check what the Raging Blow cooldown bar starts at? Does it say 6 seconds when it first comes up? And does it always go away at the same exact time?

Thank you for getting back on the glyph. Can you check the time on the Raging Blow cooldown bar when it first shows up and then just before it goes away?

Quote from Tomber

3. Fix not being able to set notify color when there is no associated spell, as reported by Galvin.

I have fixed this in my working copy. I'm still working on the color issue for X-buZZ--it is a headscratcher.