Authors CurseForge

using r168, i can drill down into the damage/spell details, but then the UI bugs out. You can't pop back up using right click and my error mod is getting spammed with the following errors:

Maybe I need to reset my savedvariables or something?
:(

[22:46:05] ...ib\SpecializedLibBars-1.0\SpecializedLibBars-1.0.lua:857: attempt to compare number with string
[C]: ?
...ib\SpecializedLibBars-1.0\SpecializedLibBars-1.0.lua:857: in function <...ib\SpecializedLibBars-1.0\SpecializedLibBars-1.0.lua:849>
[C]: ?
...ib\SpecializedLibBars-1.0\SpecializedLibBars-1.0.lua:878: in function `SortBars'
...ib\SpecializedLibBars-1.0\SpecializedLibBars-1.0.lua:419: in function <...ib\SpecializedLibBars-1.0\SpecializedLibBars-1.0.lua:410>
(tail call): ?
Interface\AddOns\Skada\Skada.lua:247: in function `CreateBar'
Interface\AddOns\Skada\Skada.lua:133: in function `UpdateDisplay'
Interface\AddOns\Skada\Skada.lua:1841: in function `UpdateBars'
Interface\AddOns\Skada\Skada.lua:323: in function `DisplayMode'
Interface\AddOns\SkadaDamage\Damage.lua:234: in function `click'
Interface\AddOns\Skada\Skada.lua:90: in function <Interface\AddOns\Skada\Skada.lua:86>
Interface\AddOns\Skada\Skada.lua:139: in function <Interface\AddOns\Skada\Skada.lua:139>

[22:50:02] ...ib\SpecializedLibBars-1.0\SpecializedLibBars-1.0.lua:1544: Value cannot be nil!
(tail call): ?
[C]: ?
...ib\SpecializedLibBars-1.0\SpecializedLibBars-1.0.lua:1544: in function `SetValue'
Interface\AddOns\Skada\Skada.lua:131: in function `UpdateDisplay'
Interface\AddOns\Skada\Skada.lua:1841: in function <Interface\AddOns\Skada\Skada.lua:1812>
(tail call): ?
[C]: ?
[string "safecall Dispatcher[2]"]:9: in function <[string "safecall Dispatcher[2]"]:5>
(tail call): ?
...Ons\ag_UnitFrames\libs\AceTimer-3.0\AceTimer-3.0.lua:144: in function <...Ons\ag_UnitFrames\libs\AceTimer-3.0\AceTimer-3.0.lua:118>

edit for more tests:
- I deleted my custom window (called threat) and reloaded the UI. Now the problem doesn't show itself. I also disabled the Threat module, although that probably has nothing to do with the above issue. Anyway, deleting my old window setting seems to have cleared it up for now. I will continue to test by creating a new window.

Edit2: u can reproduce the behavior by creating a new custom window. Once u have two or more windows active, the "drill down/up" navigation functionality breaks.

Edit3: hmm, seems single main window or multiple windows still breaks.... must be something to do with drilling down into the details of dmg. Maybe new stuff u'r adding in r168 is not done?

I've never gotten an actual error, but I have noticed that when using a background panel, right-clicking on the background panel (such as while on a view with fewer bars than the maximum) it skips all the way back to the view list, instead of the previous view.

For example, it should be:

Main <-> Current Fight <-> Damage <-> Kittydruid <-> Shred

...but if the views for Kittydruid or Shred have fewer bars than cover up the whole background panel, right-clicking on the background panel jumps back to Current Fight.

Also, it would be nice to be able to hide the gray backgrounds for the individual bars.

Is there a way to pause skada while in a raid environment? I couldn't find anything. I am hoping there is as I like this much more than recount, but I hate logging out to disable a mod during 25 man raids (dmg meters tend to beat the crap out of my system during them)

Heya, I love Skada as assessment was my favorite damage meter mod of all time.

I was wondering, is there a way to see what each ability hit/crit(s) for?

Using r168 and ''Hide while hidden'', but the window still doesn't show up when joining a raid (reloading UI don't help either), so i'm pretty sure it won't collect any data in the raid. Will report back in a sec.

Nope, nothing recorded while in a raid with ''hide while solo'' and ''disable collect while hidden'' enabled. Seems to be a bug indeed.

Quote from Morgalm

Yes but the window does not come back in a raid group. If you manually open it to wake it up it will start recording again.

No it doesn't. Even if clicking the LDB display to bring up the window, no data is recorded at all.

Quote from Jesamyn

If you click on your bar for either damage or DPS, it'll show you your abilities. You can click on the ability to drill down further to show your totals for hits and crits.

The bolded part actually only works for damage spells, and not for healing spells, unfortunately.

Everyone in our guild using the r168 has the same issues as hellnoBH.
Skada breaks randomly, and by breaking I mean :
- Can't click on the windows anymore.
- Display is messed up, bars not at their places
- Can't report the data
- Can't do anything.

Error message points at a library though...

Don't use that option. Every time you wipe it will reset ;)

There's an issue regarding the threat calculation of Skada:
it does not show faded toons (mages using Mirror Image and priests using Fade).
While using the named abilities, the threatvalue is decreased by 410065408.
When casting Mirror Image, the "real" threatvalue of my toon is displayed (something arout -40000000yx) for a moment, but my toon is wiped off skada's threatlist at the moment the first Mirror Image successfully attacks the mob I'm facing.
Xinxuan did a workaround to fix this within Omen (on line 1299 of Omen.lua; simple addition of the given value when my toon has negative threatvalues) to prevent me from not knowing if I'm about to putt agro when Mirror Image wears off.
I've tried to fix this by myself by adding the given value to threatvalue on line 118 of threat.lua by using the following code:

  if threatvalue then
    if threatvalue < 0 then
       threatvalue = threatvalue + 410065408    
    end
  end

I failed, my toon still went off the Threatlist.

[edit]Add:
There's another issue regarding the "damage done" module.
Some spells have two effects, e.g. Pyroblast and Living Bomb.
Both have a DoT-effect and a direct hit, which should be handled seperately, because the direct hits can crit, the dots can't.
Skada shows the following:
Pyroblast: hits: 32; crits: 2; critrate: 5.9%
This is true for all effects named Pyroblast, but only 6 of the 32 hits are direct hits, the rest are dot ticks.
[/edit]
I really like this mod, but the given issue decreases it's usability quite a bit.

r165 is the latest version that works without bugs atm, so i suggest everyone use that until the latter version gets fixed.

in r168 i get these errors when selecting DPS: (DPS calculation in Damage tab still works.

[2009/04/03 16:22:47-7046-x1]: SkadaDamage-1.0\Damage.lua:361: table index is nil
Skada-1.0\Skada.lua:1838: in function `UpdateBars'
Skada-1.0\Skada.lua:323: in function `DisplayMode'
Skada-1.0\Skada.lua:1855: in function <Interface\AddOns\Skada\Skada.lua:1855>

[2009/04/03 16:22:48-7046-x8]: SkadaDamage-1.0\Damage.lua:361: table index is nil
Skada-1.0\Skada.lua:1838: in function <Interface\AddOns\Skada\Skada.lua:1812>
(tail call): ?:
<in C code>: ?
<string>:"safecall Dispatcher[2]":9: in function <[string "safecall Dispatcher[2]"]:5>
(tail call): ?:
AceTimer-3.0-5 (Ace3):144: in function <Interface\AddOns\Ace3\AceTimer-3.0\AceTimer-3.0.lua:118>

further on when trying to report enemy damage taken on a specific target (like vesperon) the report looks somewhat weird. all other targets get reported too and are sorted via damage taken. in some cases even complete lines were missing (9th. player on thaddius only - happened on r165 i think). as a small enhancement to enemy damage taken I'd like to also see the DPS on that target (useful for investigating dps on a single drake without all this bombing fun on fire elementals or whelps)

r168

The window (I just use one) does not remember its visibility status. Upon logging in, it is always visible, and for reasons unknown displays the Interrupts data view despite the fact that I haven't actually navigated to this view in 2-3 weeks, and navigate away from this view every time.

In views where all bars are "full", there is sometimes one bar which is about 30% longer than the rest, and sticks out of the window.

In all views the spacing between the first and second bars is about 1px greater than the spacing between all other bars, regardless of the spacing setting, as long as it's greater than zero; this is most noticable when spacing is set to a small number such as 1 or 2.

I'll post tickets for these as well.