Yeah, I know, suggestions are quite a lot of work to localize. A Chinese user sent me a full localization of the suggestions in zhCN, you can see how he did it in suggestion_zhCN.lua. That's a lot of work though, and I'll only provide these gradually.
I've already fixed the 6-7 main panel strings (search this realm, etc..) and I'll upload the file soon. I've made good progress on deDE too, based on what I could find in atlasLoot + wowhead, but there will still be around 200 entries to translate, and since I hardly speak German, I'm calling out for help :)
@asciident: better fubar support is planned. I'm working on the addon a little bit everyday based on the time I can find, and the todolist is still long, don't lose hope :)
edit: the latest version is on SVN. We're getting close. deDE still contains a lot of enUS, but at least it's stable.
I know you're busy with the localizations, but if you have time you could look at it :)
The attached file contains the tables with the data I thought about showing.
The gathering part could be used somewhere at the tooltip hook.
(if GetItem returns nil you could search the id in this table and show information about that item)
The crafted item information is a simple id -> ids dictionary.
It could be used both ways for getting crafted item(s) and source item(s).
The reputation turnin part is a bit hacky (added them to the loot tables)
But at least this one already works for me. ;) And you can extract the item ids from it, if you want.
Suggestion.lua direct translate from CN file, since it would be quite a lot of work if starting from scratch. Please refer my thanks the to the CN translator.
Thanks a lot to both of you, I'll have a look at this tonight.
The author of the CN translation is a user of this forum I guess, I saw that he tried to make the update on SVN, his name is wang, but I haven't seen any of his posts here yet :)
Anyway, credits will be in the changelog & readme.
Edit: I've just uploaded the latest version on SVN, localization is still not 100% complete, but worth releasing officially. v.014 will be uploaded in a few minutes on WoWinterface & curse shortly. Translations will be implemented as they come in.
The newest update doesn't have the right TW locale file.
re-attached it here again
Edit: after playing with the new version, I found out that it will freeze WOW client occasionally when displaying suggestion tooltip. Endless loop and only an ALT-CTRL-DEL can get out.
Did you identify where this happens ? There are 3 places where I use suggestions: tradeskills, leveling and reputation. Does this happen everywhere ? I'll have a look at it tonight.
Did you identify where this happens ? There are 3 places where I use suggestions: tradeskills, leveling and reputation. Does this happen everywhere ? I'll have a look at it tonight.
I'm looking into this right now, and I can't see anything that could cause an infinite loop.
Can you reproduce this issue easily ? Does it happen all the time ? Also, since Altoholic is playing a bit with tooltips, maybe another addon is trying to read altoholic's tooltip and causes a problem because of the data it contains.
Extreme test: if you can reproduce the issue easily, does it keep happening if altoholic is the only active addon ?
I'm looking into this right now, and I can't see anything that could cause an infinite loop.
Can you reproduce this issue easily ? Does it happen all the time ? Also, since Altoholic is playing a bit with tooltips, maybe another addon is trying to read altoholic's tooltip and causes a problem because of the data it contains.
Extreme test: if you can reproduce the issue easily, does it keep happening if altoholic is the only active addon ?
Let me know :)
Thanks
Thao
Don't think so, since this doesn't happens when there's no localization. I think that doesn't related to tooltip thingy since it's all fine with just English.
Exactly how to reproduce this, is both skill and reputation, first tooltip is fine, the second reading will cause the lock up.
BTW, I didn't pay much attention to memory usage before until recent, I found that Altoholic used up 2.34-2.88 MB even it's idle, which is quite a large amount I think.
Don't think so, since this doesn't happens when there's no localization. I think that doesn't related to tooltip thingy since it's all fine with just English.
Exactly how to reproduce this, is both skill and reputation, first tooltip is fine, the second reading will cause the lock up.
BTW, I didn't pay much attention to memory usage before until recent, I found that Altoholic used up 2.34-2.88 MB even it's idle, which is quite a large amount I think.
Its not much for a database addon, also do you use embeded or disembeded libs? If you run embeded the first addon to load that use the lib gets blaimed for all the addons that use the lib, and with Altoholic being in the "A" list it is lightly to load first.
For me it uses ~1.8MB with 10 chars and 2 of em banks with lots of stuff.
Its not much for a database addon, also do you use embeded or disembeded libs? If you run embeded the first addon to load that use the lib gets blaimed for all the addons that use the lib, and with Altoholic being in the "A" list it is lightly to load first.
For me it uses ~1.8MB with 10 chars and 2 of em banks with lots of stuff.
English version is fine, I have no problem when things are not localized. BTW, I am using standalone lib. I've never saw Altoholic get ahead of Autobar memory usage.
About the lockup, I suspect that was cause by memory leak. The way how it call suggest.lua or there are no garbage collection routines or so. I am not certain about why it should handle in what method, which I guess those suggestion.lua, suggestion_zhCN.lua and suggestion_zhTW.lua might should be merge in one file for better performance.
i am using altoholic with joy. it's a great addon. however... i have it installed and i got it in my fubar showing. there is also an extra dot around my minimap for altoholic. when i say to altoholic though the fubar to only show at the minimap i get TWO altoholic dots at minimap, since there allready is one. i would like to remove the one sitting at my minimap now... it only needs to show at my fubar. i basically have two altoholics this way. the fubar altoholic is working fine and it's selected not to show itself at the minimap, yet there still is one. so i tried to move to the minimap and move back to fubar. but instead of just switching forth and back i would get two minimap dots. kinda weird. the button at the minimap works without a problem btw (it only does not respect my chinchilla square minimap, while the fubar one does respect it when i tell it to attach to the minimap)
@NightOwl: regarding the lockup, I'll make a test tonight by replacing my english suggestions with yours (since they're normally never loaded for me), and see if I can reproduce this. There should not be any problem since the method that tries to get a suggestion should simply exit if no data is found.. anyway, I don't reject the idea of a bug in my code, but this one would suprise me ^^
About memory consumption, I suggest you have a look at this screenshot:
Explanations are at the end of page 5 in this post, but as Kerecha explained, Altoholic is credited for using all libraries while other addons are not. See the memory consumption on my machine: 958k vs 2.68m with 10 chars, I guess it speaks for itself.. and don't forget that I have the same loot table as the latest atlas loot, except that mine only contains item id's .. so all in all, I'm pretty satisfied with how low I managed to keep memory consumption :)
..when i say to altoholic though the fubar to only show at the minimap i get TWO altoholic dots at minimap, since there allready is one. i would like to remove the one sitting at my minimap now...
By default, it's normal that the two icons are present, but there's an option to hide Altoholic's icon, did you try it ?
@NightOwl: regarding the lockup, I'll make a test tonight by replacing my english suggestions with yours (since they're normally never loaded for me), and see if I can reproduce this. There should not be any problem since the method that tries to get a suggestion should simply exit if no data is found.. anyway, I don't reject the idea of a bug in my code, but this one would suprise me ^^
What I mean is suggestion.lua detect if locale isn't enUS then it will quit and find the other suggestion_XXXX to load, is this a wasted of loading with every tooltip mouseover will request this over and over.
I'll make the same test when I get back home, and if I manage to reproduce the issue, I'll narrow it down to the incriminating data.
I'm surprised that the data are actually causing the lockup.
I'll tell you more after my tests (in a couple of hours).
edit: I just tried to reproduce the issue, but I guess my wow client doesn't react like yours to zhTW text, all I can see is a set of unreadable characters.
I would suggest you to try what I would have tried myself, namely narrowing down the problem to the specific suggestion entry that causes the problem. Try reproducing the issue with a smaller file, you could already get rid of profession and leveling suggestions, as they're not likely to be the cause.
I'm working on a cool feature in the addon, and I'd love to get some input to fine tune it :)
In the equipment pane, it's currently possible to right-click on at item to find a potential upgrade based on item level. This works fine. The only problem is that if you're trying to find an upgrade for the shoulder slot of your warrior, you'll get paladin stuff listed as well.
What I'm currently working on is a second type of search which will analyze the item stats to determine if it should be accounted for in the results. For instance, if the item passes the first filters (ex: item type = "armor", subtype = "plate", slot = "shoulder", iLevel > current item), then I'll filter out items with "mana" or "intellect", as they're typically for a paladin. This already works well in my version.
But if I look at the problem the other way around, trying to find an upgrade for a paladin slot, it will be almost impossible to filter out anything, unless I take talent spec into account and set rules to filter out based on this info as well (ex: a retribution pala won't care about +def).
Does the approach sound natural to you ? Or would you expect something different ?
1: must have / vital (like +heal or int or maybe mp5 on heal pallay gear)
2: ignore (dun really matter) (armor, sta for heal pallys for instance)
3: must not have (like int and mp5 for warrs)
This should make it easier to find a specific upgrade depending on specc aswell as stats on current item.
The approach sounds plenty natural to me. And I love the concept.
Is it possible rather than trying to check for talents (which may or may not be opening a can of worms coding-wise) that you could check for a specific spell in order to set the spec-type for hybrids?
Forex, if the Paladin has Holy Shield, they're almost certainly Protection. Same with Crusader Strike for Ret paladins (and that should be pretty much the same as warrior gear for the most part). For Holy Paladins, Holy Shock would be the spell.
I'd imagine there's similar key spells for druids and shaman. (Enhancement: Dual Wield or Parry, for example.)
I really look forward to it. Is there any way you could include a level limit if the character isn't 70? Either a "usable" option a la the auction house, or current level +5 or something, configurable or not, would be really awesome. I don't really need to see sunwell or BT drops for my Level 50 Warrior.
Rollback Post to RevisionRollBack
To post a comment, please login or register a new account.
I've already fixed the 6-7 main panel strings (search this realm, etc..) and I'll upload the file soon. I've made good progress on deDE too, based on what I could find in atlasLoot + wowhead, but there will still be around 200 entries to translate, and since I hardly speak German, I'm calling out for help :)
@asciident: better fubar support is planned. I'm working on the addon a little bit everyday based on the time I can find, and the todolist is still long, don't lose hope :)
edit: the latest version is on SVN. We're getting close. deDE still contains a lot of enUS, but at least it's stable.
I know you're busy with the localizations, but if you have time you could look at it :)
The attached file contains the tables with the data I thought about showing.
The gathering part could be used somewhere at the tooltip hook.
(if GetItem returns nil you could search the id in this table and show information about that item)
The crafted item information is a simple id -> ids dictionary.
It could be used both ways for getting crafted item(s) and source item(s).
The reputation turnin part is a bit hacky (added them to the loot tables)
But at least this one already works for me. ;) And you can extract the item ids from it, if you want.
updated localization file.
The author of the CN translation is a user of this forum I guess, I saw that he tried to make the update on SVN, his name is wang, but I haven't seen any of his posts here yet :)
Anyway, credits will be in the changelog & readme.
Edit: I've just uploaded the latest version on SVN, localization is still not 100% complete, but worth releasing officially. v.014 will be uploaded in a few minutes on WoWinterface & curse shortly. Translations will be implemented as they come in.
re-attached it here again
Edit: after playing with the new version, I found out that it will freeze WOW client occasionally when displaying suggestion tooltip. Endless loop and only an ALT-CTRL-DEL can get out.
Reputation will trigger this.
Can you reproduce this issue easily ? Does it happen all the time ? Also, since Altoholic is playing a bit with tooltips, maybe another addon is trying to read altoholic's tooltip and causes a problem because of the data it contains.
Extreme test: if you can reproduce the issue easily, does it keep happening if altoholic is the only active addon ?
Let me know :)
Thanks
Thao
Don't think so, since this doesn't happens when there's no localization. I think that doesn't related to tooltip thingy since it's all fine with just English.
Exactly how to reproduce this, is both skill and reputation, first tooltip is fine, the second reading will cause the lock up.
BTW, I didn't pay much attention to memory usage before until recent, I found that Altoholic used up 2.34-2.88 MB even it's idle, which is quite a large amount I think.
Its not much for a database addon, also do you use embeded or disembeded libs? If you run embeded the first addon to load that use the lib gets blaimed for all the addons that use the lib, and with Altoholic being in the "A" list it is lightly to load first.
For me it uses ~1.8MB with 10 chars and 2 of em banks with lots of stuff.
English version is fine, I have no problem when things are not localized. BTW, I am using standalone lib. I've never saw Altoholic get ahead of Autobar memory usage.
About the lockup, I suspect that was cause by memory leak. The way how it call suggest.lua or there are no garbage collection routines or so. I am not certain about why it should handle in what method, which I guess those suggestion.lua, suggestion_zhCN.lua and suggestion_zhTW.lua might should be merge in one file for better performance.
any ideas?
About memory consumption, I suggest you have a look at this screenshot:
Explanations are at the end of page 5 in this post, but as Kerecha explained, Altoholic is credited for using all libraries while other addons are not. See the memory consumption on my machine: 958k vs 2.68m with 10 chars, I guess it speaks for itself.. and don't forget that I have the same loot table as the latest atlas loot, except that mine only contains item id's .. so all in all, I'm pretty satisfied with how low I managed to keep memory consumption :)
By default, it's normal that the two icons are present, but there's an option to hide Altoholic's icon, did you try it ?
What I mean is suggestion.lua detect if locale isn't enUS then it will quit and find the other suggestion_XXXX to load, is this a wasted of loading with every tooltip mouseover will request this over and over.
So, it should be the problem with the locale file. But seems I can't find any trace which cause those lock up.
I'm surprised that the data are actually causing the lockup.
I'll tell you more after my tests (in a couple of hours).
edit: I just tried to reproduce the issue, but I guess my wow client doesn't react like yours to zhTW text, all I can see is a set of unreadable characters.
I would suggest you to try what I would have tried myself, namely narrowing down the problem to the specific suggestion entry that causes the problem. Try reproducing the issue with a smaller file, you could already get rid of profession and leveling suggestions, as they're not likely to be the cause.
I'm working on a cool feature in the addon, and I'd love to get some input to fine tune it :)
In the equipment pane, it's currently possible to right-click on at item to find a potential upgrade based on item level. This works fine. The only problem is that if you're trying to find an upgrade for the shoulder slot of your warrior, you'll get paladin stuff listed as well.
What I'm currently working on is a second type of search which will analyze the item stats to determine if it should be accounted for in the results. For instance, if the item passes the first filters (ex: item type = "armor", subtype = "plate", slot = "shoulder", iLevel > current item), then I'll filter out items with "mana" or "intellect", as they're typically for a paladin. This already works well in my version.
But if I look at the problem the other way around, trying to find an upgrade for a paladin slot, it will be almost impossible to filter out anything, unless I take talent spec into account and set rules to filter out based on this info as well (ex: a retribution pala won't care about +def).
Does the approach sound natural to you ? Or would you expect something different ?
Any input is welcome :)
1: must have / vital (like +heal or int or maybe mp5 on heal pallay gear)
2: ignore (dun really matter) (armor, sta for heal pallys for instance)
3: must not have (like int and mp5 for warrs)
This should make it easier to find a specific upgrade depending on specc aswell as stats on current item.
Is it possible rather than trying to check for talents (which may or may not be opening a can of worms coding-wise) that you could check for a specific spell in order to set the spec-type for hybrids?
Forex, if the Paladin has Holy Shield, they're almost certainly Protection. Same with Crusader Strike for Ret paladins (and that should be pretty much the same as warrior gear for the most part). For Holy Paladins, Holy Shock would be the spell.
I'd imagine there's similar key spells for druids and shaman. (Enhancement: Dual Wield or Parry, for example.)
I really look forward to it. Is there any way you could include a level limit if the character isn't 70? Either a "usable" option a la the auction house, or current level +5 or something, configurable or not, would be really awesome. I don't really need to see sunwell or BT drops for my Level 50 Warrior.