Ok, I have time to make a correct reply now, I was in the middle of KZ yesterday evening, with little time to check my code & wowwiki.
I'm already using GetTradeSkillRecipeLink & GetTradeSkillItemLink, but the thing is that we're not talking about 2 links here, but 3:
ex:
1) The plan: [Plans: Adamantite Breastplate] (id 23596)
2) The recipe: [Blacksmithing: Adamantite Breastplate] (id 29606)
3) The craft: [Adamantite Breastplate] (id 23507)
What you are suggesting me is to make the link between 2 and 3, but what I actually need is to make the link between 1 & 2 or 1 & 3. Whenever I have a plan (formula, pattern, etc..) in my bags (or at the AH), the plan does not give me the id of the item that can be crafted with it, so the only way to make the connection is based on the names included in 1 & 2. I hope this is clear :)
Now, if there's a way to know that plan 23596 teaches me 29606 to craft item 23507, I don't know about it, but I'd be happy to be proven wrong ^^
Regarding the way I store data, I actually save both 2 & 3, as I want to be able to link the 2 information in search results.
okay, i gotcha. right. yeah, i guess a big id database (well, not really THAT big) would be the way to go. prolly could mine it from wowhead. it'd actually be a usefull set of data, really. maybe could go into lib pt.
Just try it out today in TChinese server, errors I've got so far
[2008/05/18 14:12:54-1943-x1]: Altoholic-2.4.014\Altoholic.lua:1572: attempt to index field '?' (a nil value)
Altoholic-2.4.014\Altoholic.lua:565: in function `BuildCharacterInfoTable'
Altoholic-2.4.014\Altoholic.lua:519: in function `OnShow'
<string>:"*:OnShow":1: in function <[string "*:OnShow"]:1>
<in C code>: in function `Show'
Altoholic-2.4.014\Altoholic.lua:486: in function `ToggleUI'
Altoholic-2.4.014\AltoholicFu.lua:28: in function `OnClick'
FuBarPlugin-2.0-63898:947: in function <...\FuBarPlugin-2.0\FuBarPlugin-2.0\FuBarPlugin-2.0.lua:944>
FuBar-3.0.52967\FuBar.lua:1200: in function <Interface\AddOns\FuBar\FuBar.lua:1198>
[2008/05/18 14:13:35-1943-x1]: Altoholic-2.4.014\Frames\Reputations.lua:21: attempt to index field '?' (a nil value)
<string>:"*:OnShow":1: in function <[string "*:OnShow"]:1>
<in C code>: in function `Show'
Altoholic-2.4.014\Altoholic.lua:494: in function `ActivateMenuItem'
Altoholic-2.4.014\Altoholic.lua:69: in function <Interface\AddOns\Altoholic\Altoholic.lua:69>
---
[2008/05/18 14:14:13-1943-x4]: Altoholic-2.4.014\Altoholic.lua:1572: attempt to index field '?' (a nil value)
Altoholic-2.4.014\Altoholic.lua:1781: in function `GetItemCount'
Altoholic-2.4.014\Altoholic.lua:2025: in function `ProcessTooltip'
Altoholic-2.4.014\Altoholic.lua:1968: in function `OnTooltipSetItem'
CowTip-r68121\CowTip.lua:234: in function <Interface\AddOns\CowTip\CowTip.lua:232>
(tail call): ?:
(tail call): ?:
(tail call): ?:
<in C code>: ?
<in C code>: ?
<in C code>: in function `SetHyperlink'
Altoholic-2.4.014\Frames\Containers.lua:127: in function `Item_OnEnter'
<string>:"*:OnEnter":1: in function <[string "*:OnEnter"]:1>
---
[2008/05/18 14:14:33-1943-x1]: Altoholic-2.4.014\Altoholic.lua:1572: attempt to index field '?' (a nil value)
Altoholic-2.4.014\Frames\Search.lua:197: in function `SearchRealm'
Altoholic-2.4.014\Frames\Search.lua:118: in function `SearchItem'
Altoholic-2.4.014\Altoholic.lua:96: in function <Interface\AddOns\Altoholic\Altoholic.lua:96>
---
[2008/05/18 14:14:44-1943-x1]: Altoholic-2.4.014\Frames\Equipment.lua:15: attempt to index field '?' (a nil value)
<string>:"*:OnShow":1: in function <[string "*:OnShow"]:1>
<in C code>: in function `Show'
Altoholic-2.4.014\Altoholic.lua:494: in function `ActivateMenuItem'
Altoholic-2.4.014\Altoholic.lua:1302: in function <Interface\AddOns\Altoholic\Altoholic.lua:1300>
---
The addon does not work on non localized versions. The core of the addon is based on the translations of classes, if someone can provide me with a full translation, I'm ok to integrate it in future versions.
Just like to say that this addon is pure distilled awesomeness, and add in a vote for item searches. I adore BankItems for the item search functionality from the command line, and would love to see it in Altoholic.
The addon does not work on non localized versions. The core of the addon is based on the translations of classes, if someone can provide me with a full translation, I'm ok to integrate it in future versions.
Here's the locale file, although I've try to make it as accurate to the game elements as it can, but there might be some little differences in translation, Since TW always change translations from time to time.
Seems there is many more options needs to translate.
Here's the errors:
[2008/05/19 22:46:22-1970-x1]: Altoholic-2.4.014\localization_zhTW.lua:3: AceLocale(Altoholic): Can only accept true as a value on the base locale. "enUS" is the base locale, "zhTW" is not.
Ace2\AceLibrary\AceLibrary.lua:122: in function `error'
AceLocale-2.2-40629 (Ace2):223: in function `RegisterTranslations'
Altoholic-2.4.014\localization_zhTW.lua:3: in main chunk
---
[2008/05/19 23:06:11-1970-x1]: Altoholic-2.4.014\Altoholic.lua:1106: attempt to concatenate field 'name' (a boolean value)
Altoholic-2.4.014\Altoholic.lua:115: in function <Interface\AddOns\Altoholic\Altoholic.lua:115>
---
[2008/05/19 23:06:15-1970-x1]: Altoholic-2.4.014\Altoholic.lua:1106: attempt to concatenate field 'name' (a boolean value)
Altoholic-2.4.014\Altoholic.lua:130: in function <Interface\AddOns\Altoholic\Altoholic.lua:130>
---
[2008/05/19 23:06:17-1970-x1]: Altoholic-2.4.014\Altoholic.lua:1106: attempt to concatenate field 'name' (a boolean value)
Altoholic-2.4.014\Altoholic.lua:144: in function <Interface\AddOns\Altoholic\Altoholic.lua:144>
---
[2008/05/19 23:06:27-1970-x4]: Altoholic-2.4.014\Altoholic.lua:1106: attempt to concatenate field 'name' (a boolean value)
<string>:"*:OnVerticalScroll":2: in function `updateFunction'
Interface\FrameXML\UIPanelTemplates.lua:237: in function `FauxScrollFrame_OnVerticalScroll':
<string>:"*:OnVerticalScroll":1: in function <[string "*:OnVerticalScroll"]:1>
<in C code>: in function `SetVerticalScroll'
<string>:"*:OnValueChanged":1: in function <[string "*:OnValueChanged"]:1>
---
[2008/05/19 23:06:52-1970-x1]: Altoholic-2.4.014\Altoholic.lua:1106: attempt to concatenate field 'name' (a boolean value)
Altoholic-2.4.014\Altoholic.lua:196: in function <Interface\AddOns\Altoholic\Altoholic.lua:196>
---
I just checked your file, and there's only one mistake which causes all these errors, on line 59, you left:
["Any"] = true,
You have to provide a translation for this, or all translations won't register and cause the subsequent errors you listed. Just provide me with an updated file, and I'll include it in my next svn commit.
Thanks again :)
By the way, command line searches have just been implemented.
The former uploaded file is replaced, please get the latest.
About some request, is there any possibility to implement appearance options?
Like, icon size, font selection, or able to choose separate bags or one big display
BTW, it would be nice if Bags and Bank can have a separator in between so it would be easily to tell with just a glance. Instead of counting 5 bags below is Bank items, lol.
I will see what I can do about icon size & fonts, as well as the disposition of the bags, this is a part of the addon that I intend to update at some point in the future, but there are a still quite a few things I want to implement before reviewing this.
That said, it may always happen earlier than that as my plans often vary based on the free time I have & on the documentation I can get (reading wowwiki, checking other addons, etc..).
So yes, this will happen, but I cannot give you a firm date :)
I will see what I can do about icon size & fonts, as well as the disposition of the bags, this is a part of the addon that I intend to update at some point in the future, but there are a still quite a few things I want to implement before reviewing this.
That said, it may always happen earlier than that as my plans often vary based on the free time I have & on the documentation I can get (reading wowwiki, checking other addons, etc..).
So yes, this will happen, but I cannot give you a firm date :)
Nice to know that it is inside the schedule. No rush actually.
My 2 cents, the addon is now working rather solid and it's a good piece of workmanship. As an informational addon, cosmetic improvements and scaling options will greatly help users with time saving when finding things/information without much scrolling. If things can be arranged to display in one page, why make it to two.
Tested for the first time on my level 2, other-server test alt. Two issues.
r74446, updated standalone libraries, USEng client/server. The character has never been to a bank (has 2 bags on character though). Click on the FuBar icon to open Altoholic and: Altoholic-2.4.014\Altoholic.lua:1567: attempt to index field '?' (a nil value)
Altoholic-2.4.014\Altoholic.lua:564: in function `BuildCharacterInfoTable'
Altoholic-2.4.014\Altoholic.lua:518: in function `OnShow'
<string>:"*:OnShow":1: in function <[string "*:OnShow"]:1>
<in C code>: in function `Show'
Altoholic-2.4.014\Altoholic.lua:485: in function `ToggleUI'
Altoholic-2.4.014\AltoholicFu.lua:28: in function `OnClick'
FuBarPlugin-2.0-63898:947: in function <...\FuBarPlugin-2.0\FuBarPlugin-2.0\FuBarPlugin-2.0.lua:944>
FuBar-3.0.52967\FuBar.lua:1200: in function <Interface\AddOns\FuBar\FuBar.lua:1198>.
Second issue: this eats CPU time constantly when you are either idle or moving/in-combat and don't have the Altoholic window open. It averages 0.050 CPU/sec (tested with OptionHouse).
Not much, but the BankItems & Possessions mods don't use any until you open their windows. It all adds up ;).
The error you get usually happens when the class of a player is unknown to the addon, like when they introduced female class names in frFR & deDE, but since you're playing on an english client (so am I), this is unlikely to fail, unless you're playing a DK on WotLK alpha :D
On a more serious note, which class are you playing ?
For the second issue, I'm surprised the addon is eating cpu time when idle. I'll make some code profiling to see what's going on, but I normally don't do anything when the addon is closed, except searching the DB when mousing over an item, but that's an expected cpu consumption. Maybe an event is triggered more often than expected. Thanks for reporting :)
Zidomo, I've just test it with both option house and performance fu.
I didn't see any problem similar to yours, cpu usage is between 0.022-0.034 with alto window open or not(if no difference with addon window status, the additional usage is not cause by the addon, Dog-Tags eats more that, with or without tooltip active), which is quite normal comparing with other addons.
BTW, no errors are thrown with the recent update :)
Not really playing; the class I tried it on was Paladin (female Blood Elf).
Yes, with or without the window open, it averages 0.050 CPU/sec here. If that was only with the window open, no issue at all.
But with it closed and the character is idle, it becomes an issue. Mods that are in an inactive state (to the user, at least) shouldn't be using CPU when the user is idle, no matter how small the amount ;). Especially when similar mods (BankItems, Possessions) don't duplicate that behavior.
I just got back home and made some tests to find out more about this performance issue.. and the results will most likely surprise you.
I made my tests with PerformanceFu, and after logging on, I saw that Altoholic was indeed eating a constant 1.5% of cpu time. As PerformanceFu hinted me at login that the results it reports may not be accurate when libraries are used, because their memory & cpu consumption is attached to an addon that uses them.
Since I was sure that the addon wasn't doing anything special while being idle, I thought there was a simple test I could make, so I left wow, went to my addons directory and changed 3 things:
1) renamed the addon directory to Zltoholic
2) renamed the .toc to Zltoholic
3) renamed the addon title in the .toc, also to Zltoholic
The result is on this screenshot:
On the left part, the addon is named "Altoholic" and uses 2.68MB & 1.42% cpu time.
On the right part, it's named "Zltoholic". and uses 958Kb & 0.01% cpu time.
Need I say more ?
My conclusion is simple, perfomance addons most likely sort results at some point, and attach libraries' cpu & memory consumption to the first addon they find (in alphabetical order), this is thus a non-issue for me :)
Rollback Post to RevisionRollBack
To post a comment, please login or register a new account.
okay, i gotcha. right. yeah, i guess a big id database (well, not really THAT big) would be the way to go. prolly could mine it from wowhead. it'd actually be a usefull set of data, really. maybe could go into lib pt.
Here's the locale file, although I've try to make it as accurate to the game elements as it can, but there might be some little differences in translation, Since TW always change translations from time to time.
Seems there is many more options needs to translate.
Here's the errors:
I just checked your file, and there's only one mistake which causes all these errors, on line 59, you left:
You have to provide a translation for this, or all translations won't register and cause the subsequent errors you listed. Just provide me with an updated file, and I'll include it in my next svn commit.
Thanks again :)
By the way, command line searches have just been implemented.
EDIT: fix some translate mistake, please get the latest file
For your info, I intend to complete the localization of the addon soon (within 1 or 2 weeks), so I might need your help later on ;)
Thanks again, let me know if you encounter errors.
About some request, is there any possibility to implement appearance options?
Like, icon size, font selection, or able to choose separate bags or one big display
BTW, it would be nice if Bags and Bank can have a separator in between so it would be easily to tell with just a glance. Instead of counting 5 bags below is Bank items, lol.
I will see what I can do about icon size & fonts, as well as the disposition of the bags, this is a part of the addon that I intend to update at some point in the future, but there are a still quite a few things I want to implement before reviewing this.
That said, it may always happen earlier than that as my plans often vary based on the free time I have & on the documentation I can get (reading wowwiki, checking other addons, etc..).
So yes, this will happen, but I cannot give you a firm date :)
Nice to know that it is inside the schedule. No rush actually.
My 2 cents, the addon is now working rather solid and it's a good piece of workmanship. As an informational addon, cosmetic improvements and scaling options will greatly help users with time saving when finding things/information without much scrolling. If things can be arranged to display in one page, why make it to two.
toc file with translated description
r74446, updated standalone libraries, USEng client/server. The character has never been to a bank (has 2 bags on character though). Click on the FuBar icon to open Altoholic and:
Altoholic-2.4.014\Altoholic.lua:1567: attempt to index field '?' (a nil value)
Altoholic-2.4.014\Altoholic.lua:564: in function `BuildCharacterInfoTable'
Altoholic-2.4.014\Altoholic.lua:518: in function `OnShow'
<string>:"*:OnShow":1: in function <[string "*:OnShow"]:1>
<in C code>: in function `Show'
Altoholic-2.4.014\Altoholic.lua:485: in function `ToggleUI'
Altoholic-2.4.014\AltoholicFu.lua:28: in function `OnClick'
FuBarPlugin-2.0-63898:947: in function <...\FuBarPlugin-2.0\FuBarPlugin-2.0\FuBarPlugin-2.0.lua:944>
FuBar-3.0.52967\FuBar.lua:1200: in function <Interface\AddOns\FuBar\FuBar.lua:1198>.
Second issue: this eats CPU time constantly when you are either idle or moving/in-combat and don't have the Altoholic window open. It averages 0.050 CPU/sec (tested with OptionHouse).
Not much, but the BankItems & Possessions mods don't use any until you open their windows. It all adds up ;).
On a more serious note, which class are you playing ?
For the second issue, I'm surprised the addon is eating cpu time when idle. I'll make some code profiling to see what's going on, but I normally don't do anything when the addon is closed, except searching the DB when mousing over an item, but that's an expected cpu consumption. Maybe an event is triggered more often than expected. Thanks for reporting :)
I didn't see any problem similar to yours, cpu usage is between 0.022-0.034 with alto window open or not(if no difference with addon window status, the additional usage is not cause by the addon, Dog-Tags eats more that, with or without tooltip active), which is quite normal comparing with other addons.
BTW, no errors are thrown with the recent update :)
Yes, with or without the window open, it averages 0.050 CPU/sec here. If that was only with the window open, no issue at all.
But with it closed and the character is idle, it becomes an issue. Mods that are in an inactive state (to the user, at least) shouldn't be using CPU when the user is idle, no matter how small the amount ;). Especially when similar mods (BankItems, Possessions) don't duplicate that behavior.
Glad to hear the new update fixes the bug :).
I made my tests with PerformanceFu, and after logging on, I saw that Altoholic was indeed eating a constant 1.5% of cpu time. As PerformanceFu hinted me at login that the results it reports may not be accurate when libraries are used, because their memory & cpu consumption is attached to an addon that uses them.
Since I was sure that the addon wasn't doing anything special while being idle, I thought there was a simple test I could make, so I left wow, went to my addons directory and changed 3 things:
1) renamed the addon directory to Zltoholic
2) renamed the .toc to Zltoholic
3) renamed the addon title in the .toc, also to Zltoholic
The result is on this screenshot:
On the left part, the addon is named "Altoholic" and uses 2.68MB & 1.42% cpu time.
On the right part, it's named "Zltoholic". and uses 958Kb & 0.01% cpu time.
Need I say more ?
My conclusion is simple, perfomance addons most likely sort results at some point, and attach libraries' cpu & memory consumption to the first addon they find (in alphabetical order), this is thus a non-issue for me :)