Authors CurseForge

Quote from gagou

macaroon support is not correctly working for spell having spécial characters in their names, this is mostly for local having special characters like é, è, ?* in frFR

to solve this problem on my local copy of DrDamage I've changed the following:

    if IsAddOnLoaded("Macaroon") then
        local func = function(button)
            if button.macrospell then
                return nil, [COLOR=Red]string_match(button.macrospell,"[%w%s]+"),[/COLOR] button.macrorank
            end
        end
        ABrefresh["MacaroonButton"] = function()
            for _, button in pairs(Macaroon.Buttons) do
                ABtable[button[1]:GetName()] = func
            end
        end
    end    

in

    if IsAddOnLoaded("Macaroon") then
        local func = function(button)
            if button.macrospell then
                return nil, [COLOR=Red]button.macrospell[/COLOR], button.macrorank
            end
        end
        ABrefresh["MacaroonButton"] = function()
            for _, button in pairs(Macaroon.Buttons) do
                ABtable[button[1]:GetName()] = func
            end
        end
    end    

what the use of the string.match here? it's working perfectly on my system without it.

It seems DrDamage is back, so maybe you can consider this problem I had with Macaroon on my frFR client

I saw the note on the project page about Explosive Shot and am curious as to why it's too complicated to calculate. Seems like it's just a short DoT really, unless you're talking about factoring in LnL procs.

Edit: Also, addons like this really need glyph support, as the numbers are all thrown off by glyphs that cause procs or change cooldowns, etc.

Edit 2: I'm pretty sure the hit calculations are off by 1% also, as it's claiming that 9% is the hit cap for Hunters even though it's been reduced to 8% in the game.

The latest version still incorrectly calculates Frostfire Bolt for mages as well. It adds the total of frost spellpower plus fire spellpower to the spellpower affecting the spell; in actuality it uses the higher of the two values. I *wish* I could apply like 5k spellpower to it. ;)

Gagorian, in response to your comment in revision 791 of Hunter.lua, "Is this intentional: Any tracking will give bonus to any type?" - yes, that's how the Improved Tracking mechanic works now.

Quote from HunterZ

Gagorian, in response to your comment in revision 791 of Hunter.lua, "Is this intentional: Any tracking will give bonus to any type?" - yes, that's how the Improved Tracking mechanic works now.

Alright, Thanks. Also, I believe I've fixed the hit rating issue you reported, please verify as I cannot test it.

Quote from Gagorian

Alright, Thanks. Also, I believe I've fixed the hit rating issue you reported, please verify as I cannot test it.

I'm pretty sure I tested that it was working last night, but I'll try to remember to double-check.

First of all, let me thank Gagorian and his new team for the wonderful work they have been doing over the last weeks. I wasn't hoping anymore for Dr. Damage to be still alive, and I was feeling kinda lost, it's one of the addons I've developed a pretty big addiction over the years ;)

Now a little question out of the blue. Will you guys think to include, within the calculation formulae, the modifications coming from special items such as relics? For instance I'm talking mainly about Totems, being a shaman that's the situation I know more.
There are Totems which modify the base amount of some healing spells. Since you can't directly add that number to your spell (the final number it's usually bigger than the one you read on the totem) I was wondering if you intend to include these things sometime in the future.

If I remember right the old Dr. Damage had formulae at least for the most common TBC totems.

Gagorian, are you planning to convert DrDamage to Ace3/Blizzard addon config instead of Ace2/FuBarPlugin?

Not sure at this point if this would tie back to Dr. Damage itself, or Macaroon... When swapping specs and the profile gets switched in Macaroon tied to this event, it doesn't seem that it's updating to reflect the new set of buttons on the bars. For instance, in tank spec, I'll have Flash of Light in one spot, but in a different spot for ret spec. When swapping specs, I'll still show healing numbers on what is now a damaging spell in that button's place. Tried to force an update via slash commands (assuming I was doing it correctly), but it seemed to have no effect.

Quote from akumasama

First of all, let me thank Gagorian and his new team for the wonderful work they have been doing over the last weeks. I wasn't hoping anymore for Dr. Damage to be still alive, and I was feeling kinda lost, it's one of the addons I've developed a pretty big addiction over the years ;)

Now a little question out of the blue. Will you guys think to include, within the calculation formulae, the modifications coming from special items such as relics? For instance I'm talking mainly about Totems, being a shaman that's the situation I know more.
There are Totems which modify the base amount of some healing spells. Since you can't directly add that number to your spell (the final number it's usually bigger than the one you read on the totem) I was wondering if you intend to include these things sometime in the future.

If I remember right the old Dr. Damage had formulae at least for the most common TBC totems.

Will be added as soon as we get to it!

Quote from Ydrisselle

Gagorian, are you planning to convert DrDamage to Ace3/Blizzard addon config instead of Ace2/FuBarPlugin?

I've considered it several times, but I still like the dewdrop style configuration.. and as far as I know Ace3 doesn't have that style of fast/easy configuration (which I think suits DrDamage well). So it's a bit of a tough decision, but not out of the question.

Quote from MegaManJuno

Not sure at this point if this would tie back to Dr. Damage itself, or Macaroon... When swapping specs and the profile gets switched in Macaroon tied to this event, it doesn't seem that it's updating to reflect the new set of buttons on the bars. For instance, in tank spec, I'll have Flash of Light in one spot, but in a different spot for ret spec. When swapping specs, I'll still show healing numbers on what is now a damaging spell in that button's place. Tried to force an update via slash commands (assuming I was doing it correctly), but it seemed to have no effect.

I'm not exactly sure how I'll work around this, I need to look into it. Have you asked from the Macaroon author as well?

Thanks for adding a calculation for the Hunter ability Explosive Shot. Is there a reason though that it isn't counted as a DoT? DrDamage seems to report the average damage of a single tick even though it's really a DoT that ticks 3 times.

Quote from Gagorian

I've considered it several times, but I still like the dewdrop style configuration.. and as far as I know Ace3 doesn't have that style of fast/easy configuration (which I think suits DrDamage well). So it's a bit of a tough decision, but not out of the question.

A Broker plugin (launcher I think) + LibQTip/LibQTipClick clickable tooltip? :)

Quote from HunterZ

Thanks for adding a calculation for the Hunter ability Explosive Shot. Is there a reason though that it isn't counted as a DoT? DrDamage seems to report the average damage of a single tick even though it's really a DoT that ticks 3 times.

I'll look into some better implementation. Can you explain how the dot ticks work after the initial hit. Do they have a fixed damage or the same range as the initial hit?

Quote from Maul

Perhaps refresh the buttons on the event PLAYER_TALENT_UPDATE. I will look into it, however, from my end :)

I'm doing that already :)

But it's possible his version didn't have it yet if he was using an older version. Although if he said he was forcing a manual update then there has to be something else amiss as well.