also.. all the ranks of the spells are hardcoded. (the value for dmg/heal written in the tooptip). maybe there is a way to read it programatically (parse the tooptip). at least for caster spells it would work..
Depending on what action bar and/or tooltip addon(s) someone uses, the spell rank may or may not appear in the tooltip.
well.. from what i can see in the code, there is some major bloat in the code from trying to get right all the ranks of all the spells.
-> this is useless now that down-ranking is gone.
Having lower ranks is useful for lower level characters.
Trying to parse the tooltips for the values is actually way less efficient and more bloat code than just listing the values in a table. That would also make managing different localizations more of a pain in the ass. While lower rank spells may seem useless for level 80 characters, I'm sure anyone leveling a new character appreciates having values.
Why do you think it's a better idea to parse instead?
But, that's not really the issue anyway. If the addon is to be fixed then someone does have to take responsibility over it, I'm not gonna accept a few hacks here and there. If it's not going to be maintained it's not worth fixing.
true
i was just looking at the code and though that for every patch, someone needs to look at all the spells and all the ranks for all the classes... quite a load of work :/
maybe if u could take a couple of hours and write a smallish guide with the basics of maintaing the addon, someone will look into it with more ... pleasure. and in time get to know the code and maybe improve it
If someone is interested in maintaining DrDamage, they'll need to be familiar with its code and internal workings anyway, which will give them a much better idea of what's involved in maintaining the addon than some "guide" you're asking someone who doesn't even play the game anymore to spend time writing...
Yeah well. If I honestly thought writing a guide would help, I wouldn't mind spending a few hours doing it. In fact I wouldn't mind spending time helping someone take DrDamage over, but like I've said the new author has got to have the patience to see it through. Otherwise it's just a waste of time for me.
Looking at Mr. Damage, he's still got months of work to do.. And, no offense meant to the author, the code seems very static, inefficient and harder to maintain than DrDamage. Of course I realize it's still in development, but I've learned during my project that planning ahead saves hundreds of hours on code rewrites.
Yeah well. If I honestly thought writing a guide would help, I wouldn't mind spending a few hours doing it. In fact I wouldn't mind spending time helping someone take DrDamage over, but like I've said the new author has got to have the patience to see it through. Otherwise it's just a waste of time for me.
Looking at Mr. Damage, he's still got months of work to do.. And, no offense meant to the author, the code seems very static, inefficient and harder to maintain than DrDamage. Of course I realize it's still in development, but I've learned during my project that planning ahead saves hundreds of hours on code rewrites.
I've tried doing some updates to the Druid portion, but my knowledge of it is pretty rudimentary. I've pretty much been copy/pasting and changing stuff. It's better then nothing, but havinng something to give me an idea how to do more complicated stuff would be much appreciated.
Yeah well. If I honestly thought writing a guide would help, I wouldn't mind spending a few hours doing it. In fact I wouldn't mind spending time helping someone take DrDamage over, but like I've said the new author has got to have the patience to see it through. Otherwise it's just a waste of time for me.
Looking at Mr. Damage, he's still got months of work to do.. And, no offense meant to the author, the code seems very static, inefficient and harder to maintain than DrDamage. Of course I realize it's still in development, but I've learned during my project that planning ahead saves hundreds of hours on code rewrites.
i suggested a written guide so u don;t have to train one guy. this way ppl can read it, and figure out by themselves if they want to get deeper or not. so u don;t have to waste time on each individual who thinks he can do it only to discover later it;s too much for him (like Dally did)
i suggested a written guide so u don;t have to train one guy. this way ppl can read it, and figure out by themselves if they want to get deeper or not. so u don;t have to waste time on each individual who thinks he can do it only to discover later it;s too much for him (like Dally did)
I just don't see how a "guide" will help this situation. If someone is knowledgable enough that they're able to effectively mantain an addon, simply looking through its code for a few minutes should be sufficient to determine if it's something they're up to or not, and certainly more indicative than reading some "how to maintain this addon" guide. :(
That's true, but then again spark plugs and distributors are generally not labeled with "if make == 'Ford' and model == 'F250' then attachHere(1) end". ;)
I've been working on my DrDamage clone, and it's going really well, soon ready for a release, at least for the caster classes. There is still a lot to do for melee classes.
That's true, but then again spark plugs and distributors are generally not labeled with "if make == 'Ford' and model == 'F250' then attachHere(1) end". ;)
But it would allow programmers to fix their cars really fast :P (Hell, I could pull it off then)
when people say guide it makes me cry a bit inside :(
I usually cry inside when I get a clients email stating "doesn't work" as error description, or when the phone rings, because 90% of the people I get on the phone, I would consider "stupid". So a guide would help them, but none of them bastids reads lol. (If a button says UPDATE and you call tech support to whine on the non-working update but not having clicked the button labelled as update, yeah).
I've been working on my DrDamage clone, and it's going really well, soon ready for a release, at least for the caster classes. There is still a lot to do for melee classes.
Actually.. I've managed to acquire 3 new slaves like someone already noticed. So there might be a tiny bit of light at the end of the tunnel. I'm not going to promise anything but we shall see how it goes!
Depending on what action bar and/or tooltip addon(s) someone uses, the spell rank may or may not appear in the tooltip.
Having lower ranks is useful for lower level characters.
Why do you think it's a better idea to parse instead?
But, that's not really the issue anyway. If the addon is to be fixed then someone does have to take responsibility over it, I'm not gonna accept a few hacks here and there. If it's not going to be maintained it's not worth fixing.
i was just looking at the code and though that for every patch, someone needs to look at all the spells and all the ranks for all the classes... quite a load of work :/
maybe if u could take a couple of hours and write a smallish guide with the basics of maintaing the addon, someone will look into it with more ... pleasure. and in time get to know the code and maybe improve it
just a though :)
Looking at Mr. Damage, he's still got months of work to do.. And, no offense meant to the author, the code seems very static, inefficient and harder to maintain than DrDamage. Of course I realize it's still in development, but I've learned during my project that planning ahead saves hundreds of hours on code rewrites.
I've tried doing some updates to the Druid portion, but my knowledge of it is pretty rudimentary. I've pretty much been copy/pasting and changing stuff. It's better then nothing, but havinng something to give me an idea how to do more complicated stuff would be much appreciated.
i suggested a written guide so u don;t have to train one guy. this way ppl can read it, and figure out by themselves if they want to get deeper or not. so u don;t have to waste time on each individual who thinks he can do it only to discover later it;s too much for him (like Dally did)
I just don't see how a "guide" will help this situation. If someone is knowledgable enough that they're able to effectively mantain an addon, simply looking through its code for a few minutes should be sufficient to determine if it's something they're up to or not, and certainly more indicative than reading some "how to maintain this addon" guide. :(
But it would allow programmers to fix their cars really fast :P (Hell, I could pull it off then)
I usually cry inside when I get a clients email stating "doesn't work" as error description, or when the phone rings, because 90% of the people I get on the phone, I would consider "stupid". So a guide would help them, but none of them bastids reads lol. (If a button says UPDATE and you call tech support to whine on the non-working update but not having clicked the button labelled as update, yeah).
Can I test it?
TheoryCraft09.04.25.zip
I play a Shadow Priest (dual spec is Holy).
If those aren't fully added, I can take a look. Can't promise much though, I work about 12/13hrs a day.