[2008/03/24 16:53:14-404-x2]: Ace3\Ace3.lua:81: attempt to index upvalue 'frame' (a nil value)
CallbackHandler-1.0\CallbackHandler-1.0.lua:146: in function <...Ons\Ace3\CallbackHandler-1.0\CallbackHandler-1.0.lua:146>
<string>:"safecall Dispatcher[2]":4: in function <[string "safecall Dispatcher[2]"]:4>
<in C code>: ?
<string>:"safecall Dispatcher[2]":13: in function `?'
CallbackHandler-1.0\CallbackHandler-1.0.lua:91: in function `Fire'
AceConfigRegistry-3.0\AceConfigRegistry-3.0.lua:260: in function `NotifyChange'
CoolDownButtons\config.lua:1331: in function `InitPositions'
CoolDownButtons\core.lua:818: in function `?'
CallbackHandler-1.0\CallbackHandler-1.0.lua:146: in function <...Ons\Ace3\CallbackHandler-1.0\CallbackHandler-1.0.lua:146>
<string>:"safecall Dispatcher[1]":4: in function <[string "safecall Dispatcher[1]"]:4>
<in C code>: ?
<string>:"safecall Dispatcher[1]":13: in function `?'
CallbackHandler-1.0\CallbackHandler-1.0.lua:91: in function `Fire'
AceEvent-3.0\AceEvent-3.0.lua:70: in function <Interface\AddOns\Ace3\AceEvent-3.0\AceEvent-3.0.lua:69>
---
[2008/03/24 16:53:14-404-x2]: Ace3\Ace3.lua:81: attempt to index upvalue 'frame' (a nil value)
CallbackHandler-1.0\CallbackHandler-1.0.lua:146: in function <...Ons\Ace3\CallbackHandler-1.0\CallbackHandler-1.0.lua:146>
<string>:"safecall Dispatcher[2]":4: in function <[string "safecall Dispatcher[2]"]:4>
<in C code>: ?
<string>:"safecall Dispatcher[2]":13: in function `?'
CallbackHandler-1.0\CallbackHandler-1.0.lua:91: in function `Fire'
AceConfigRegistry-3.0\AceConfigRegistry-3.0.lua:260: in function `NotifyChange'
CoolDownButtons\config.lua:1331: in function `InitPositions'
CoolDownButtons\core.lua:818: in function `?'
CallbackHandler-1.0\CallbackHandler-1.0.lua:146: in function <...Ons\Ace3\CallbackHandler-1.0\CallbackHandler-1.0.lua:146>
<string>:"safecall Dispatcher[1]":4: in function <[string "safecall Dispatcher[1]"]:4>
<in C code>: ?
<string>:"safecall Dispatcher[1]":13: in function `?'
CallbackHandler-1.0\CallbackHandler-1.0.lua:91: in function `Fire'
AceEvent-3.0\AceEvent-3.0.lua:70: in function <Interface\AddOns\Ace3\AceEvent-3.0\AceEvent-3.0.lua:69>
---
It's a Bug in Ace3, it's fixed in branches but not yet in trunk, we have to wait until the current branch moves to trunk.
[2008/03/25 12:46:09-417-x1]: CoolDownButtons\locales\zhCN.lua:5: attempt to index local 'L' (a nil value)
---
fixed
--
i enabled some 2.4 changes in latest version(r65857)
i tested them last time a week ago on ptr, i hope they still work.
cant test for next 13-14 hours since EU is still 2.3 :)
Dodge, you've made a wonderful job with this addon! I love it! (I hope it will work fine after the patch, it's still on maintenance here in France :P )
As I love this addon and wouldn't want to go back to bars, I was wondering if you know if the same system exists for timers, or if you plan to create a TimerButtons addon? (I like Sorren's Timers, but a TimerButtons would be great! :D )
Dodge, you've made a wonderful job with this addon! I love it! (I hope it will work fine after the patch, it's still on maintenance here in France :P )
As I love this addon and wouldn't want to go back to bars, I was wondering if you know if the same system exists for timers, or if you plan to create a TimerButtons addon? (I like Sorren's Timers, but a TimerButtons would be great! :D )
Thanks again for your work!
i'm currently working on a modularized rewrite, and i'm planing to add dot timers. but i cant pormise that i'll realy do it since i dont know yet how hard it will be. but it should be easy since there are now the GUIDs :)
I have my cooldowns split so when they are close to expiring, they show up separately. If a cooldown is so short it will only display among the expiring, it is working fine. However, when a cooldown is long, it does not make the transition to the expiring.
I have my cooldowns split so when they are close to expiring, they show up separately. If a cooldown is so short it will only display among the expiring, it is working fine. However, when a cooldown is long, it does not make the transition to the expiring.
There are a few minor issues with the school lockout. When I as I priest get locked out on my spells, four icons appear. One for Discipline, Holy, Shadow and something else I cannot figure out. The last uses the Gift of the Naaru icon. What is that?
As we all know, there are in fact not any Discipline school. They are all a part of Holy. There are, however, Discipline spells. Since they are part of the same school, it would probably be more correct to group them both under Holy and only show one icon for both of them.
Also, some of the icons (shadow and discipline if I recall correctly) are flickering, as if there are two icons on the same layer both fighting to be on top.
There are a few minor issues with the school lockout. When I as I priest get locked out on my spells, four icons appear. One for Discipline, Holy, Shadow and something else I cannot figure out. The last uses the Gift of the Naaru icon. What is that?
enable chatpost, get a lockout click on it, then you know what it is ^^ (or see last qoute^^)
As we all know, there are in fact not any Discipline school. They are all a part of Holy. There are, however, Discipline spells. Since they are part of the same school, it would probably be more correct to group them both under Holy and only show one icon for both of them.
if a spell is in your spellbook under Discipline then they are grouped as Discipline (i group by spellbook tabs ^^)
Also, some of the icons (shadow and discipline if I recall correctly) are flickering, as if there are two icons on the same layer both fighting to be on top.
hmm, if you can reproduce it, create a 3rd chatframe if you dont have one already (mainchat = chatframe1, combatlog = chatframe2) and then if the flickering appears type "/run cdb()" and copy/paste me the output from Chatframe3.
well... :/
the Gift of the Naaru icon, is the Gift of the Naaru cooldown :P
its shown becouse Gift of the Naaru is in the General Tab of a spellbook and i'm grouping the spells per spellbook tab
and to the flickering problem, can you make the frame bigger and type "/run cdb()" while the cooldowns are active?that i can see all messages AND the cooldowns at the same time.
and some other questions, is the flickering just on a lockout from Counterspell or always if you have x or more cooldowns active?
CDB seems to be using a lot of cpu power compared to other addons (70% of Ace2 itself with a myriad of addons), the highest of all my addons with the exception of ace2, performancefu and tabletlib (which is understandable) when cpu profiling is enabled.
About the announcements using LibSink, you could add the icon, change the announce template to something shorter like "SKILL ready !" (or let the user choose) and let the user choose the text color. That's just suggestions though.
For the CPU thing, I suggest Dodge to :
1) move the pulse effect code of in their own onUpdate handler and use it on pulse frames,
2) throttle down processing of the main onUpdate handler, either by using a "delayToNextUpdate" pattern or by using AceTimer-3.0.
1) is necessary to keep the pulse effect smooth while 2) decreases the CPU load.
About the announcements using LibSink, you could add the icon, change the announce template to something shorter like "SKILL ready !" (or let the user choose) and let the user choose the text color. That's just suggestions though.
it's on my todo list for the rewrite i'm worikn on :)
Quote from Adirelle »
For the CPU thing, I suggest Dodge to :
1) move the pulse effect code of in their own onUpdate handler and use it on pulse frames,
2) throttle down processing of the main onUpdate handler, either by using a "delayToNextUpdate" pattern or by using AceTimer-3.0.
1) is necessary to keep the pulse effect smooth while 2) decreases the CPU load.
a fix for current CDB is in work, in the rewrite i'll use AceTimer instead of teh onupdate event :)
-
View User Profile
-
View Posts
-
Send Message
Curse PremiumIt's a Bug in Ace3, it's fixed in branches but not yet in trunk, we have to wait until the current branch moves to trunk.
-
View User Profile
-
View Posts
-
Send Message
Curse Premiumfixed
--
i enabled some 2.4 changes in latest version(r65857)
i tested them last time a week ago on ptr, i hope they still work.
cant test for next 13-14 hours since EU is still 2.3 :)
As I love this addon and wouldn't want to go back to bars, I was wondering if you know if the same system exists for timers, or if you plan to create a TimerButtons addon? (I like Sorren's Timers, but a TimerButtons would be great! :D )
Thanks again for your work!
-
View User Profile
-
View Posts
-
Send Message
Curse Premiumi'm currently working on a modularized rewrite, and i'm planing to add dot timers. but i cant pormise that i'll realy do it since i dont know yet how hard it will be. but it should be easy since there are now the GUIDs :)
I have my cooldowns split so when they are close to expiring, they show up separately. If a cooldown is so short it will only display among the expiring, it is working fine. However, when a cooldown is long, it does not make the transition to the expiring.
-
View User Profile
-
View Posts
-
Send Message
Curse Premiumfixed!
Scaling and distance between buttons was a bit funny (scaling down made buttons overlap), but was easy to tweak after I had scaled to my liking.
There are a few minor issues with the school lockout. When I as I priest get locked out on my spells, four icons appear. One for Discipline, Holy, Shadow and something else I cannot figure out. The last uses the Gift of the Naaru icon. What is that?
As we all know, there are in fact not any Discipline school. They are all a part of Holy. There are, however, Discipline spells. Since they are part of the same school, it would probably be more correct to group them both under Holy and only show one icon for both of them.
Also, some of the icons (shadow and discipline if I recall correctly) are flickering, as if there are two icons on the same layer both fighting to be on top.
Again, thanks a lot for this great mod <3
-
View User Profile
-
View Posts
-
Send Message
Curse Premiumenable chatpost, get a lockout click on it, then you know what it is ^^ (or see last qoute^^)
if a spell is in your spellbook under Discipline then they are grouped as Discipline (i group by spellbook tabs ^^)
hmm, if you can reproduce it, create a 3rd chatframe if you dont have one already (mainchat = chatframe1, combatlog = chatframe2) and then if the flickering appears type "/run cdb()" and copy/paste me the output from Chatframe3.
thank you for the report :)
The flickering seems to always be on icon one and four.
Output:
http://img260.imageshack.us/my.php?image=wowscrnshot032908235451ug5.jpg
http://img260.imageshack.us/my.php?image=wowscrnshot032908235502rx6.jpg
http://img260.imageshack.us/my.php?image=wowscrnshot032908235507pd9.jpg
-
View User Profile
-
View Posts
-
Send Message
Curse Premiumwell... :/
the Gift of the Naaru icon, is the Gift of the Naaru cooldown :P
its shown becouse Gift of the Naaru is in the General Tab of a spellbook and i'm grouping the spells per spellbook tab
and to the flickering problem, can you make the frame bigger and type "/run cdb()" while the cooldowns are active?that i can see all messages AND the cooldowns at the same time.
and some other questions, is the flickering just on a lockout from Counterspell or always if you have x or more cooldowns active?
-
View User Profile
-
View Posts
-
Send Message
Curse Premium-
View User Profile
-
View Posts
-
Send Message
Curse Premium1) move the pulse effect code of in their own onUpdate handler and use it on pulse frames,
2) throttle down processing of the main onUpdate handler, either by using a "delayToNextUpdate" pattern or by using AceTimer-3.0.
1) is necessary to keep the pulse effect smooth while 2) decreases the CPU load.
-
View User Profile
-
View Posts
-
Send Message
Curse Premiumit's on my todo list for the rewrite i'm worikn on :)
a fix for current CDB is in work, in the rewrite i'll use AceTimer instead of teh onupdate event :)
[edit]
cpu usage fix comitted
I do have OmniCC installed for general cdc, dunno if it can be a problem.
when i use a spell the button glow as long it is active.
example:
i use drums of war, my button in bongos glow green as long it is active.
it good because i don't have to move my eyes at top right to my buff buttons