Authors CurseForge

I still can't get Hearthstone to hide, am I doing something wrong?

I have "Move items to spell cooldowns" turned on, and I have Hearthstone added to the special list of items in the "Cooldowns" tab. In the options there, for Hearthstone, I have "Hide" checked...but the icon still shows.

Of course it's not game-breaking, just somewhat irritating, especially with potions. :P

Quote from goat_song »

I still can't get Hearthstone to hide, am I doing something wrong?

I have "Move items to spell cooldowns" turned on, and I have Hearthstone added to the special list of items in the "Cooldowns" tab. In the options there, for Hearthstone, I have "Hide" checked...but the icon still shows.

Under Time Limit you need to set a value (in seconds). Cooldowns that are longer than the set time will not show.

get this error at login with my hunter and warlock

[2008/06/12 14:44:34-693-x1]: CoolDownButtons-v2.1\Modules\Cooldown_Manager.lua:81: attempt to call method 'RegisterEvent' (a nil value)
(tail call): ?:
<in C code>: ?
<string>:"safecall Dispatcher[1]":9: in function <[string "safecall Dispatcher[1]"]:5>
(tail call): ?:
AceAddon-3.0\AceAddon-3.0.lua:365: in function `EnableAddon'
AceAddon-3.0\AceAddon-3.0.lua:377: in function `EnableAddon'
AceAddon-3.0\AceAddon-3.0.lua:435: in function <Interface\AddOns\Ace3\AceAddon-3.0\AceAddon-3.0.lua:421>
<in C code>: in function `LoadAddOn'
Interface\FrameXML\UIParent.lua:908: in function `UIParentLoadAddOn':
Interface\FrameXML\UIParent.lua:234: in function `CombatLog_LoadUI':
Interface\FrameXML\UIParent.lua:327: in function `UIParent_OnEvent':
<string>:"*:OnEvent":1: in function <[string "*:OnEvent"]:1>

There is an issue with the time limit option that is still broken after being fixed in one of the recent revisions. Although now it will finally hide CDs longer than x seconds, those CDs do not show up when they go under x seconds even with the option checked to make them show up when below x seconds. Thanks for a great addon.

Come to think of it, I had the same issue with time limits and spells never showing. My max is 5 minutes, Innervate never did show up (6 minute CD).

Anyway, problem. The global cooldown is screwing with the end of any other cooldown. If the GCD is active when a cooldown ends, the remaining time on that cooldown becomes the remaining time on the GCD. If you spam the GCD constantly, it's possible to keep a 6-second cooldown appearing to still be down for a good 30 seconds without touching it.

To illustrate:

4----3----2----1--1----01----01----0
GCD---GCD---GCD---GCD---GCD---GCD---

Where the numbers are the displayed duration of the cooldown and the 'G' of GCD is the beginning of a new GCD.

To reproduce, take a Priest, just about any level, and cast Mind Blast. A split second before MB cools down, start spamming Inner Fire as fast as lag will let you.

Definitely not a big deal, but it could use fixing. Not sure exactly how though. =\

I'm getting this error whenever I try to mess with my timer settings:

[2008/06/13 15:26:50-193-x142]: CoolDownButtons-v2.1\Modules\Button_Manager.lua:245: attempt to perform arithmetic on field 'buttonSpacing' (a nil value)
CoolDownButtons-v2.1\Modules\Button_Manager.lua:185: in function `DrawButton'
CoolDownButtons-v2.1\Modules\Bar_Manager.lua:102: in function <...rface\AddOns\CoolDownButtons\Modules\Bar_Manager.lua:68>
(tail call): ?:
<in C code>: ?
<string>:"safecall Dispatcher[2]":9: in function <[string "safecall Dispatcher[2]"]:5>
(tail call): ?:
AceTimer-3.0\AceTimer-3.0.lua:140: in function <Interface\AddOns\Ace3\AceTimer-3.0\AceTimer-3.0.lua:114>

Also, timers aren't showing up at all on any of my buttons. Am I setting some timer command wrong here?

Quote from Spif »

Under Time Limit you need to set a value (in seconds). Cooldowns that are longer than the set time will not show.

Yes, but that just means the Hearthstone icon will show up when its CD is under the time limit. I don't want that - I want to hide the Hearthstone icon altogether, no matter what its CD is.

Dodge - many thanks for fixing the aforementioned problem. Setting time limits seems to have been fully implemented, great work!

Quote from Saryai »

Anyway, problem. The global cooldown is screwing with the end of any other cooldown. If the GCD is active when a cooldown ends, the remaining time on that cooldown becomes the remaining time on the GCD. If you spam the GCD constantly, it's possible to keep a 6-second cooldown appearing to still be down for a good 30 seconds without touching it.

This seems to be very similar to the problem I'm having. When I'm tanking, I will start spamming my shield slam key before it comes off cool down so it gets used as soon as the cooldown is up. When I do this, the icon stays up, but the cooldown time goes away. Not sure if this is a CDB or an OmniCC problem.

Love the addon btw! When this is resolved, I'm planning on redoing my whole UI to hide a ton of buttons.

Quote from casimireffect »

This seems to be very similar to the problem I'm having. When I'm tanking, I will start spamming my shield slam key before it comes off cool down so it gets used as soon as the cooldown is up. When I do this, the icon stays up, but the cooldown time goes away. Not sure if this is a CDB or an OmniCC problem.

Love the addon btw! When this is resolved, I'm planning on redoing my whole UI to hide a ton of buttons.

I looked into the problem some and I think narrowed it down to one section of the code.

When I change:

  if ((button.cooldown.noCooldownCount == nil and db.showOmniCC == false) or (button.cooldown.noCooldownCount == 1 and db.showOmniCC == true)) then
    if not db.showOmniCC then
      button.cooldown.noCooldownCount = 1
    else
      button.cooldown.noCooldownCount = nil
    end
    button.cooldown:SetCooldown(_G["Get"..data.kind.."Cooldown"](data.id, BOOKTYPE_SPELL))
  end

to

  if ((button.cooldown.noCooldownCount == nil and db.showOmniCC == false) or (button.cooldown.noCooldownCount == 1 and db.showOmniCC == true)) then
   if not db.showOmniCC then
     button.cooldown.noCooldownCount = 1
   else
      button.cooldown.noCooldownCount = nil
   end
    button.cooldown:SetCooldown(_G["Get"..data.kind.."Cooldown"](data.id, BOOKTYPE_SPELL))
  end

  --force the cooldown to get set:
  button.cooldown:SetCooldown(_G["Get"..data.kind.."Cooldown"](data.id, BOOKTYPE_SPELL))

the problem goes away. I don't totally understand the if statements and I know that I'm short circuiting some of the options, but this fixed my problem. Hopefully it will give you a headstart on doing an official fix. Thanks.

hi,

I would like the cooldown time style to have the option to show the remaining seconds

see you Xara

Hmmm seems that Divine Shield is not coming up when used and it's missing from the dropdown menu in the Cooldown Settings tab.

Any ideas?

@dodge

yes something like "120" would be best, preferable without "s" for seconds
(fast counting, it's obvious seconds are meant).
For short cooldowns "2m" is not very accurate as this can be 1:01 oder 1:59

I'm still having the same issue of cooldowns above the set time limit not showing up when they fall below the threshold even though the option for them to show up at that threshold is checked. I am using the latest revision.

CooldownButtons didn't save my settings for OmniCC. I have to enable it every time I log in

Awesome! This last revision fixed all my problems. Great job :D