I really like your addon. I've been using it since the author of Dominos pointed me to it. Recently, I started to play a shaman. This class has several abilities that give a temporary weapon enchant. Would it be possible for you to add the functionality to Inline Aura to also highlight buttons if a certain weapon enchant is currently in effect?
If needed I could possibly provide a function that returns whether a given name is found in the tooltip of a given weapon (since temporary weapon buffs all start in a new line it would suffice to match the beginning of each tooltip line against the enchant name).
As Frontier said, the temporary weapon enchant for shamans is an extra line in the tooltip, formatted like this: "[Enchant Name] [Enchant Level] ([duration])".
The same is true for rogues and their poisons. I don't know about the old weapon oils and I don't by heart if there are more classes with temporary weapon buffs.
Ok, so I tried this weapon buff thing again and this is still the same crap.
Visually, it looks quite simple to catch. Programmatically, the enchant line is a simple string like any other, without anything that could help to identify it. In French, the enchant name isn't even the same as the spell name, and there is no locale-insensitive data that could help. Let alone the fact it should be checked periodically (instead of checking in response to events).
Given how InlineAura is designed, there is no way I could integrate weapon buffs into it.
Beside this, I worked a bit the internals so I could add shaman totem support (even if I doubt many shamans only use action bars to handle totems).
Let alone the fact it should be checked periodically (instead of checking in response to events).
You can catch weapon enchant change by registering to event UNIT_INVENTORY_CHANGED, this is working but time until expiration is not yet available at this time so if you need it you have to add a small delay between UNIT_INVENTORY_CHANGED fire and call to GetWeaponEnchantInfo()
i play a priest twink and i want to ask you, if you could improve inline aura by checking a hostile target buffs, whether i can dispel magic from the target. If i can dispel magic , the number of magic buffs, should be shown on the dispel magic button. is this possible with inline aura?
Latest alpha version allows to recognize buff by spell id (use #12354 instead of spell name) since Blizzard introduced this possibility in 3.3. So you should be able to distinguish the talent and the weapon proc.
Well the actual problem is that the skill is called Berserk, too, so either by adding #50344 (talent/skill) or by adding #59620 (enchant proc) and disabling it, the proc buff still is shown on the Berserk action button.
I tried to hack GetSpellName in ClassDefaults.lua to ignore the proc/give it a different name, but that didn't work:
By default, InlineAura shows only your own (de)buffs so it should not be confusing for new users. BTW, others' (de)buffs are shown in a different color: yellow instead of red for debuffs and cyan instead of green for buffs. (This may be not that helpful for color-blind people. If someone has a good idea to fix this, I would like to hear it.)