holy shit, indeed, i didn't see the "spell specific settings" tab, awesome !.
well the idea was for me to highlight my Dancing Rune Weapon when my Greatness Trinket Procs, not sure it's something that should go by default :).
ah yeah, i changed my buttonfacade skin to Phish, still black border and all, but inline aura gives me neon red and neon green border highlight, which is truely awesome :)
ah yeah, i changed my buttonfacade skin to Phish, still black border and all, but inline aura gives me neon red and neon green border highlight, which is truely awesome :)
Just keep in mind that the colors are typically blended, so you can't always expect the exact result you're looking for. :)
Yeah it still seems to be doing some kind of weird blend. Example:
I wanted to have my IA buffs be green {0,1,0}, debuffs red {1,0,0}, and my pet's behavior (passive/defensive/aggressive) and follow status (follow/stay) selections yellow {1,1,0} (which use the Checked border in BF). However, by setting Blue to zero for Checked, blue was added to the IA colors, giving white {1,1,1} for IA buffs and magenta {1,0,1} for IA debuffs.
I compromised for now by setting Checked's blue to 0.5, giving everything a pastel hue ({0,1,0.5} for buffs, {1,0,0.5} for debuffs, and {1,1,0.5} for Checked).
Still using this. Been working great. I've almost entirely given up my dot timer addons in favor of inline aura.
How many class defaults were you thinking about adding? Would you like lists for some of the other classes? It looks like Hunters and Druids have a decent set of defaults already.
I'm playing an hunter and a feral druid myself, that's why they have good defaults. As adding new defaults is quite cheap I might add more if anyone provided good ones.
This add-on is great! Its pretty much eliminated the need for me to use dot timers on my shadowpriest, something that before I could not live without. Now all my cool downs and dot times are on my action bars, making it very easy to just have one place to focus when I'm raiding.
I'm playing an hunter and a feral druid myself, that's why they have good defaults. As adding new defaults is quite cheap I might add more if anyone provided good ones.
Ok, here's a start with some priest ones. The spell ids are for the rank 1 of spells like what's in the ClassDefaults.lua file.
(On Spell Reflection - the talent Improved Spell Reflection does allow you to 'put' this buff on others when you cast it on yourself, but I think it is still a candidate for a self only buff)
Ok these next ones are maybes. I tried it out and found that they really helped me watch for the procs, but I would completely understand if you'd rather leave them as things people have to add on their own if they wanted them. I added them to the ClassDefaults in this manner, which might be entirely wrong :)
elseif class == 'WARRIOR' then
DeclareSelfBuffs({
1464, -- Slam
5308, -- Execute
7384, -- Overpower
23922, -- Shield Slam
})
SetSpellDefaults('buff', 1464, 46916) -- lights up Slam when Bloodsurge talent procs
SetSpellDefaults('buff', 23922, 46951) -- lights up Shield Slam when Sword and Board talent procs
SetSpellDefaults('buff', 7384, 60503) -- lights up Overpower when Taste for Blood talent procs
SetSpellDefaults('buff', 5308, 52437) -- lights up Execute when Sudden Death talent procs
Looks like there's lots of Paladin defaults already, here's some more though.
Paladin
SelfBuffs
498, -- Divine Protection
642, -- Divine Shield
20216, -- Divine Favor
31842, -- Divine Illumination
53651, -- Beacon of Light buff name on player is Light's Beacon
SelfTalentProc(19750, 53489) -- Flash of Light => Art of War
Judgements of the Pure is another SelfTalentProc, but I don't know what would be a good way to add that one. Perhaps leave it up to the player if they'd rather track the debuff time on the Judgement or the buff time from talent. Probably depends on the group/raid make up.
edit: some more
Priest
SelfTalentProc(2061, 33151) -- Flash Heal => Surge of Light
SelfTalentProc(585, 33151) -- Smite => Surge of Light
Holy Concentration is being completely changed in 3.1, probably not worth adding it.
For PTR/3.1 only, the talent is different on live and spell id 63731 doesn't exist there:
SelfTalentProc(2060, 63731) -- Greater Heal => Serendipity
SelfTalentProc(596, 63731) -- Prayer of Healing => Serendipity
Shaman
SelfBuffs
324, -- Lightning Shield
2645, -- Ghost Wolf
16188, -- Nature's Swiftness
30823, -- Shamanistic Rage
52127, -- Water Shield
55198, -- Tidal Force
Maelstrom Weapon, spell id 53817, is another self talent proc that effects five different spells. Maybe leave it up to player to decide which spell(s) to light up?
I noticed while putting this together that you can't track weapon buffs like Windfury Weapon, etc. I'll stick in a ticket about it, not sure if you want to scan that buff category.
Druid
Here's a couple additions for the Druid defaults that already exist
I don't have a Druid that's high enough to test it, but it should be possible to do a SelfTalentProc for Eclipse. I think this is correct, but it needs to be tested.
What would also be nice is a way to specify where on the action button to show times, stacks, etc.
Actually that part is very dynamic ATM and I am not sure how I could let the user configure this. There is basically 4 cases :
1) aura countdown,
2) aura countdown + aura stack count,
3) OmniCC (or the like) + aura countdown,
4) OmniCC (or the like) + aura countdown + aura stack counts.
They are solved this way ATM:
1) large, centered countdown,
2) large, centered countdown + small stack count at bottom,
3) small countdown at bottom,
4) small countdown at bottom left + small aura stack at bottom right.
I'm considering letting the user choose between top and bottom for cases 2, 3 and 4 and maybe switch countdown and stack sides for case 4 (or maybe simply unconditionally switch stack and countdown).
I am considering enabling "show only mine" by default and then setting IA to show others' auras only for a few spells. Any thought on this idea ?
I would personally prefer this setting. Would make all the self only buffs I posted moot. Should also eliminate the issues like the one HunterZ mentioned.
I'm considering letting the user choose between top and bottom for cases 2, 3 and 4 and maybe switch countdown and stack sides for case 4 (or maybe simply unconditionally switch stack and countdown).
With build r44 and the new option to set application count on a per spell basis, I've been fine with the defaults. For me it's case 3 and 4 as I use OmniCC. The only issue I've run in to is that the reagent count gets in the way on certain abilities.
You could consider an option to allow users with OmniCC (or the like) to use case 1 and 2 on abilities without a cooldown. Example with a Druid: Mark of the Wild has no cooldown, so that could optionally show as case 1 for OmniCC users. Which should still allow the reagent count to be visible.
I noticed while putting this together that you can't track weapon buffs like Windfury Weapon, etc. I'll stick in a ticket about it, not sure if you want to scan that buff category.
Actually properly detecting these buffs is quite hard IIRC. It involves some tooltip scanning.
I don't have a Druid that's high enough to test it, but it should be possible to do a SelfTalentProc for Eclipse. I think this is correct, but it needs to be tested.
You could consider an option to allow users with OmniCC (or the like) to use case 1 and 2 on abilities without a cooldown. Example with a Druid: Mark of the Wild has no cooldown, so that could optionally show as case 1 for OmniCC users. Which should still allow the reagent count to be visible.
This is the exact case I was about to bring up as the main issue that prompted my previous post. IA's buff time display on my Druid's MotW button (bottom middle, since I run OmniCC) covers up the reagent count number (bottom-right I think).
Actually, I could not get cooldown data about abilities before you use them but I could try what you propose.
But in the first place I noticed that my timer onupdate handlers (used to update the displayed time) seem to be a bit heavy so I will try to optimize its code.
Rollback Post to RevisionRollBack
To post a comment, please login or register a new account.
Moreover, if you have some idea of generic settings like this, I may add them to the class defaults.
well the idea was for me to highlight my Dancing Rune Weapon when my Greatness Trinket Procs, not sure it's something that should go by default :).
ah yeah, i changed my buttonfacade skin to Phish, still black border and all, but inline aura gives me neon red and neon green border highlight, which is truely awesome :)
It works with Phish now? I gotta try that...
Paladin, buff "The Art of War", spell "Flash of Light"
Yeah it still seems to be doing some kind of weird blend. Example:
I wanted to have my IA buffs be green {0,1,0}, debuffs red {1,0,0}, and my pet's behavior (passive/defensive/aggressive) and follow status (follow/stay) selections yellow {1,1,0} (which use the Checked border in BF). However, by setting Blue to zero for Checked, blue was added to the IA colors, giving white {1,1,1} for IA buffs and magenta {1,0,1} for IA debuffs.
I compromised for now by setting Checked's blue to 0.5, giving everything a pastel hue ({0,1,0.5} for buffs, {1,0,0.5} for debuffs, and {1,1,0.5} for Checked).
Mage, Spell "Arcane Missile" Buff "Missile Barrage"
Mage, Spell "Fireball" Buff "Brain Freeze"
Paladin, Spell "Holy Light" Buff "Infusion of Light"
Paladin, Spell "Flash of Light" Buff "Infusion of Light"
Paladin, Spell "Holy Light" Buff "Light's Grace"
How many class defaults were you thinking about adding? Would you like lists for some of the other classes? It looks like Hunters and Druids have a decent set of defaults already.
Ok, here's a start with some priest ones. The spell ids are for the rank 1 of spells like what's in the ClassDefaults.lua file.
Priest
Self Buffs:
588, -- Inner Fire
15473, -- Shadowform
47585, -- Dispersion
Spell Defaults:
buff, 1243, 21562 -- Power Word: Fortitude => Prayer of Fortitude
buff, 21562, 1243 -- Prayer of Fortitude => Power Word: Fortitude
buff, 976, 27683 -- Shadow Protection => Prayer of Shadow Protection
buff, 27683, 976 -- Prayer of Shadow Protection => Shadow Protection
buff, 14752, 27681 -- Divine Spirit => Prayer of Spirit
buff, 27681, 14752 -- Prayer of Spirit => Divine Spirit
Warrior
Self Buffs:
871, -- Shield Wall
1719, -- Recklessness
2565, -- Shield Block
12292, -- Death Wish
12975, -- Last Stand
18499, -- Berserker Rage
20230, -- Retaliation
23920, -- Spell Reflection
46924, -- Bladestorm
55694, -- Enraged Regeneration
(On Spell Reflection - the talent Improved Spell Reflection does allow you to 'put' this buff on others when you cast it on yourself, but I think it is still a candidate for a self only buff)
Ok these next ones are maybes. I tried it out and found that they really helped me watch for the procs, but I would completely understand if you'd rather leave them as things people have to add on their own if they wanted them. I added them to the ClassDefaults in this manner, which might be entirely wrong :)
Paladin
SelfBuffs
498, -- Divine Protection
642, -- Divine Shield
20216, -- Divine Favor
31842, -- Divine Illumination
53651, -- Beacon of Light buff name on player is Light's Beacon
SelfTalentProc(19750, 53489) -- Flash of Light => Art of War
Judgements of the Pure is another SelfTalentProc, but I don't know what would be a good way to add that one. Perhaps leave it up to the player if they'd rather track the debuff time on the Judgement or the buff time from talent. Probably depends on the group/raid make up.
edit: some more
Priest
SelfTalentProc(2061, 33151) -- Flash Heal => Surge of Light
SelfTalentProc(585, 33151) -- Smite => Surge of Light
Holy Concentration is being completely changed in 3.1, probably not worth adding it.
For PTR/3.1 only, the talent is different on live and spell id 63731 doesn't exist there:
SelfTalentProc(2060, 63731) -- Greater Heal => Serendipity
SelfTalentProc(596, 63731) -- Prayer of Healing => Serendipity
Shaman
SelfBuffs
324, -- Lightning Shield
2645, -- Ghost Wolf
16188, -- Nature's Swiftness
30823, -- Shamanistic Rage
52127, -- Water Shield
55198, -- Tidal Force
SelfTalentProc(331, 53390) -- Healing Wave => Tidal Waves
SelfTalentProc(8004, 53390) -- Lesser Healing Wave => Tidal Waves
Maelstrom Weapon, spell id 53817, is another self talent proc that effects five different spells. Maybe leave it up to player to decide which spell(s) to light up?
I noticed while putting this together that you can't track weapon buffs like Windfury Weapon, etc. I'll stick in a ticket about it, not sure if you want to scan that buff category.
Druid
Here's a couple additions for the Druid defaults that already exist
SelfBuffs
1850, -- Dash
5217, -- Tiger's Fury
5225, -- Track Humanoids
5229, -- Enrage
16689, -- Nature's Grasp
17116, -- Nature's Swiftness
22812, -- Barkskin
22842, -- Frenzied Regeneration
50334, -- Berserk
61336, -- Survival Instincts
I don't have a Druid that's high enough to test it, but it should be possible to do a SelfTalentProc for Eclipse. I think this is correct, but it needs to be tested.
SelfTalentProc(5176, 48517) -- Wrath => Eclipse
SelfTalentProc(2912, 48518) -- Starfire => Eclipse
What would also be nice is a way to specify where on the action button to show times, stacks, etc.
Actually that part is very dynamic ATM and I am not sure how I could let the user configure this. There is basically 4 cases :
1) aura countdown,
2) aura countdown + aura stack count,
3) OmniCC (or the like) + aura countdown,
4) OmniCC (or the like) + aura countdown + aura stack counts.
They are solved this way ATM:
1) large, centered countdown,
2) large, centered countdown + small stack count at bottom,
3) small countdown at bottom,
4) small countdown at bottom left + small aura stack at bottom right.
I'm considering letting the user choose between top and bottom for cases 2, 3 and 4 and maybe switch countdown and stack sides for case 4 (or maybe simply unconditionally switch stack and countdown).
I would personally prefer this setting. Would make all the self only buffs I posted moot. Should also eliminate the issues like the one HunterZ mentioned.
With build r44 and the new option to set application count on a per spell basis, I've been fine with the defaults. For me it's case 3 and 4 as I use OmniCC. The only issue I've run in to is that the reagent count gets in the way on certain abilities.
You could consider an option to allow users with OmniCC (or the like) to use case 1 and 2 on abilities without a cooldown. Example with a Druid: Mark of the Wild has no cooldown, so that could optionally show as case 1 for OmniCC users. Which should still allow the reagent count to be visible.
Actually properly detecting these buffs is quite hard IIRC. It involves some tooltip scanning.
Since both buff have the same name, both spells would be highlighted whichever one appear.
This is the exact case I was about to bring up as the main issue that prompted my previous post. IA's buff time display on my Druid's MotW button (bottom middle, since I run OmniCC) covers up the reagent count number (bottom-right I think).
But in the first place I noticed that my timer onupdate handlers (used to update the displayed time) seem to be a bit heavy so I will try to optimize its code.