My druid's Rake seems to get refreshed by someone else. No other druid in raid, so I guess some pet is to blame. Anyway, Rake is a DoT and not a debuff, so I think it doesn't make sense to show the duration of some pet's Rake to a druid.
Also, "Mangle - Bear" and "Mangle - Cat" are basically the same debuff. If I saw correctly during our raid, they are not treated as such. (interesting, because if a bear applies the debuff, the cats can skip mangling, which leads to more kitty DPS)
Edit: Just saw that there are spell specific options. So most of my complaints may be moot. :)
Hmmm... I am not sure that I understand the spell specific settings. It won't let me add "Faerie Fire (Feral)". Also, how does this "aura to lookup"-thingie work? Is that a way to add aliases for spells?
Also, how does this "aura to lookup"-thingie work? Is that a way to add aliases for spells?
Yes. Enter one aura per line.
About Rake, hunters' cat have an attack named Rake, that is similar to the druids' Rake. Was it shown as yours or others (red or yellow, provided you did not changed the default colors) ?
Inline Aura can only differentiate debuffs that are "yours" or "others". Given the Blizzard API, it can not tell if it was applied by a druid, a hunter pet or whatever. If the debuff have the same name that your spell, it will be taken into account. And BTW, any DoT is a debuff that deals damages.
It may have been shown as other. I configured it now to only show my own Rake, which is the only thing that makes sense for a DoT IMO.
Couldn't test it yet. I do not team with hunters that often. :)
How do I enter Mangle correctly? Both ways? "Mangle - Cat" for "Mangle - Bear" and the other way round as well? Or is one way enough? I can apply both debuffs myself, and they do overwrite each other.
"Faerie Fire (Feral)" still seems to be a problem, tho. I can hack it into the saved config file, but I cannot enter it ingame. Dunno why, just that nothing happens when I click the okay-button.
Edit: in case it was not clear: I totally love Inline Aura. Configuration could need some more help texts, and I guess the border colors of my BF-skin are a bit too similar to differenciate between own debuffs and others. Will play around with some other skins. Other than that, IA is a huge help!
I did not have time to test the druid issues yet but I will do.
From the point of view of Inline Aura (and Blizzard API), DoTs are just debuffs, one of the two type of auras (the other one being buffs). Stock Inline Aura handles all auras the same way. This is why you see others' DoT when "only mine" is unchecked and why there are spell specific options (though they are a bit buggy ATM). If you have meaningful spell settings for druids, I will be happy to include them.
Okay, lemme see... Since it did not let me insert Fearie Fire in the settings, I edited ClassDefaults.lua by hand:
elseif class == 'DRUID' then
SetSpellDefaults('debuff', 48564, 48566) -- Mangle - Bear => Mangle - Cat
SetSpellDefaults('debuff', 48566, 48564) -- Mangle - Cat => Mangle - Bear
SetSpellDefaults('debuff', 48475, 48476) -- Faerie Fire (Feral) => Faerie Fire
That seems to work for me so far. I also set my DoTs so that I do not see those of other druids or pets. All looking good, so far. :)
Not sure about listing Mangle twice, tho. But it didn't want to work for me with just one of those lines.
Using r25 on live with Dominos+OmniCC+ButtonFacade since Dominos dumped it's buff module. It shows the timers fine, but it doesn't seem to color debuff borders for some reason (except somewhat randomly in raids - perhaps showing other people's buffs/debuffs?).
It colors buff borders just fine, although it doesn't color Mend Pet when it's up unless I'm targeting my pet.
Using r25 on live with Dominos+OmniCC+ButtonFacade since Dominos dumped it's buff module. It shows the timers fine, but it doesn't seem to color debuff borders for some reason (except somewhat randomly in raids - perhaps showing other people's buffs/debuffs?)
It colors buff borders just fine, although it doesn't color Mend Pet when it's up unless I'm targeting my pet.
Yep. "You" is "you", not "you or your pet". I have considered adding some spell-specific option to check the pet but there was not enough demand for it.
Hrm... It works fine here using Dominos and OmniCC. I do not use ButtonFacade myself, though I installed it for testing purpose. I guess we are going to find out what could cause this bug to happen. Here a first batch of questions : Which BF skin are you using ? Does disabling BF fix it ? In which group setup is it happening (party/raid/solo/other) ? Are you using any other addon that might mess with the action buttons ?
Hrm... It works fine here using Dominos and OmniCC. I do not use ButtonFacade myself, though I installed it for testing purpose. I guess we are going to find out what could cause this bug to happen. Here a first batch of questions :
I'm at work right now, so I'll have to get to some of the questions later, but:
In which group setup is it happening (party/raid/solo/other) ? First noticed in raid, and then tested more extensively while solo.
Are you using any other addon that might mess with the action buttons ? DrDamage, but I put it on standby/suspended because its numbers were overlapping InlineAura's, making them hard to read. I'll try with DrDamage fully disabled.
I should also mention that the Dominos buff module worked fine with this setup until it was removed in the latest update in the last couple of days. Also, Inline Aura works fine for highlighting self and target buffs, and for displaying the time counters for both buffs and debuffs.
I should probably roll back to 1.0 before launching the game as well, as I only did a rollback and reloadui while playing because it didn't look like there were any non-code changes (although I didn't look too deeply).
Actually r25 should work exactly like 1.0 on live servers. It just includes a small piece of code that is only loaded on the PTR to handle the UnitAura changes.
Okay so it seems to be specific to the Caith skin, as it works with all the other skins I have (Dream Layout, Zoomed, Blizzard). Time to find another skin I like I guess.
Edit: It seems that the "Checked" border color setting in ButtonFacade must be set to a color and alpha value that will bitwise-AND or something with InlineAura's red debuff border, or else it won't show.
Let me do a bit of testing. I'm guessing it's the same issue we had with SBF.
Edit: Ok, it seems it's the same issue that arose with Satrina Buff Frames. Apparently, there's an issue with applying colors to a specific layer that already has colors set (even if set to 0, in this case).
Due to the nature of how colors are applied in ButtonFacade, that system is not going to change. If the addon in question is using LBF correctly, then that addon *should* be able to use LBF's built-in functions to set/change the color.
However, if this is still causing a problem, the buff/debuff colors should be applied to the "Border" layer only, as all of my skins have the color left open for this exact reason. The other layers are more dynamic and should not be influenced by anything other than the skin itself.
IA does not detect nor interact with LBF. If there is a way to detect if a button is skinned with LBF and to set the border color that does not completely mess LBF, I will use it. However, my first tests let me think there was no need for this.
I updated my post above. For debuff/buff border colors, use the "Border" layer, not the "Checked" layer. Please. :) The reason being is that the "Border" layer is slightly more static than the others and is also the layer that most other similar mods use. For the record, by "Border" I mean the "Equipped" overlay.
Edit: If someone can come up with a viable solution, I'd be welcome to take a look at it, but I'm pretty sure that how LBF colors layers isn't going to change.
I did notice that this problem arises when an addon uses native (IE Blizzard) methods to apply such changes. When this is done, it interferes with BF's skinning (It usually tries to blend the two color settings). The only thing I can think of is to detect if LBF is loaded and use its built-in functions to change the color. Remember, BF is a GUI only. LibButtonFacade is a library. ;)
My primary objective is to highlight the standard action buttons. Ideally I would like to find a solution that works both with and without LBF. If I cannot, I will probably write a code that handles both situation differently.
After a closer look to LBF, I think there are 4 solutions:
1) use Border instead of Checked texture. That will fix the issue with the Caith skin but any texture that defines a Border color (or even if the user plays with the border color setting of BF) will break IA coloring again.
2) add my own texture, that will not be skinned. This will work with or without LBF but may look ugly depending on the LBF skin. (And I could add an option to have a "plain" highlight.)
3) add my own texture, that tries to use the same texture than the Border. Maybe tricky to set up but would fix the ugliness factor of point 2).
I'm also thinking that load order plays a factor here, too. For example, if BF is loaded first (alphabetical), then the problem we're discussing happens. If the mod loads first, BF will probably overwrite those colors.
As I said, I know of no other solution outside of the mod first detecting LBF and using its built-in functions to apply the color if it (LBF) exists. If someone can come up with a viable solution, I'd love to hear it.
Rollback Post to RevisionRollBack
To post a comment, please login or register a new account.
-
View User Profile
-
View Posts
-
Send Message
Curse PremiumActually I prefer tickets for explanation and such, though a link to the ticket here won't harm.
Also, "Mangle - Bear" and "Mangle - Cat" are basically the same debuff. If I saw correctly during our raid, they are not treated as such. (interesting, because if a bear applies the debuff, the cats can skip mangling, which leads to more kitty DPS)
Edit: Just saw that there are spell specific options. So most of my complaints may be moot. :)
-
View User Profile
-
View Posts
-
Send Message
Curse PremiumYes. Enter one aura per line.
About Rake, hunters' cat have an attack named Rake, that is similar to the druids' Rake. Was it shown as yours or others (red or yellow, provided you did not changed the default colors) ?
Inline Aura can only differentiate debuffs that are "yours" or "others". Given the Blizzard API, it can not tell if it was applied by a druid, a hunter pet or whatever. If the debuff have the same name that your spell, it will be taken into account. And BTW, any DoT is a debuff that deals damages.
Couldn't test it yet. I do not team with hunters that often. :)
How do I enter Mangle correctly? Both ways? "Mangle - Cat" for "Mangle - Bear" and the other way round as well? Or is one way enough? I can apply both debuffs myself, and they do overwrite each other.
"Faerie Fire (Feral)" still seems to be a problem, tho. I can hack it into the saved config file, but I cannot enter it ingame. Dunno why, just that nothing happens when I click the okay-button.
Edit: in case it was not clear: I totally love Inline Aura. Configuration could need some more help texts, and I guess the border colors of my BF-skin are a bit too similar to differenciate between own debuffs and others. Will play around with some other skins. Other than that, IA is a huge help!
-
View User Profile
-
View Posts
-
Send Message
Curse PremiumFrom the point of view of Inline Aura (and Blizzard API), DoTs are just debuffs, one of the two type of auras (the other one being buffs). Stock Inline Aura handles all auras the same way. This is why you see others' DoT when "only mine" is unchecked and why there are spell specific options (though they are a bit buggy ATM). If you have meaningful spell settings for druids, I will be happy to include them.
elseif class == 'DRUID' then SetSpellDefaults('debuff', 48564, 48566) -- Mangle - Bear => Mangle - Cat SetSpellDefaults('debuff', 48566, 48564) -- Mangle - Cat => Mangle - Bear SetSpellDefaults('debuff', 48475, 48476) -- Faerie Fire (Feral) => Faerie FireThat seems to work for me so far. I also set my DoTs so that I do not see those of other druids or pets. All looking good, so far. :)Not sure about listing Mangle twice, tho. But it didn't want to work for me with just one of those lines.
It colors buff borders just fine, although it doesn't color Mend Pet when it's up unless I'm targeting my pet.
-
View User Profile
-
View Posts
-
Send Message
Curse PremiumDoes 1.0 work properly ?
Yep. "You" is "you", not "you or your pet". I have considered adding some spell-specific option to check the pet but there was not enough demand for it.
-
View User Profile
-
View Posts
-
Send Message
Curse PremiumI'm at work right now, so I'll have to get to some of the questions later, but:
Which BF skin are you using ? I'm using the Caith BF skin: http://www.wowace.com/projects/buttonfacade_caith/
Does disabling BF fix it ? Will test tonight.
In which group setup is it happening (party/raid/solo/other) ? First noticed in raid, and then tested more extensively while solo.
Are you using any other addon that might mess with the action buttons ? DrDamage, but I put it on standby/suspended because its numbers were overlapping InlineAura's, making them hard to read. I'll try with DrDamage fully disabled.
I should also mention that the Dominos buff module worked fine with this setup until it was removed in the latest update in the last couple of days. Also, Inline Aura works fine for highlighting self and target buffs, and for displaying the time counters for both buffs and debuffs.
I should probably roll back to 1.0 before launching the game as well, as I only did a rollback and reloadui while playing because it didn't look like there were any non-code changes (although I didn't look too deeply).
-
View User Profile
-
View Posts
-
Send Message
Curse PremiumEdit: It seems that the "Checked" border color setting in ButtonFacade must be set to a color and alpha value that will bitwise-AND or something with InlineAura's red debuff border, or else it won't show.
Edit 2: ButtonFacade ticket posted here: http://www.wowace.com/projects/buttonfacade/tickets/9-compatibility-issue-with-inline-aura
I posted a couple tickets to the IA WowAce project for other things too :p
-
View User Profile
-
View Posts
-
Send Message
Curse PremiumEdit: Ok, it seems it's the same issue that arose with Satrina Buff Frames. Apparently, there's an issue with applying colors to a specific layer that already has colors set (even if set to 0, in this case).
Due to the nature of how colors are applied in ButtonFacade, that system is not going to change. If the addon in question is using LBF correctly, then that addon *should* be able to use LBF's built-in functions to set/change the color.
However, if this is still causing a problem, the buff/debuff colors should be applied to the "Border" layer only, as all of my skins have the color left open for this exact reason. The other layers are more dynamic and should not be influenced by anything other than the skin itself.
-
View User Profile
-
View Posts
-
Send Message
Curse Premium-
View User Profile
-
View Posts
-
Send Message
Curse PremiumEdit: If someone can come up with a viable solution, I'd be welcome to take a look at it, but I'm pretty sure that how LBF colors layers isn't going to change.
I did notice that this problem arises when an addon uses native (IE Blizzard) methods to apply such changes. When this is done, it interferes with BF's skinning (It usually tries to blend the two color settings). The only thing I can think of is to detect if LBF is loaded and use its built-in functions to change the color. Remember, BF is a GUI only. LibButtonFacade is a library. ;)
-
View User Profile
-
View Posts
-
Send Message
Curse Premium-
View User Profile
-
View Posts
-
Send Message
Curse Premium1) use Border instead of Checked texture. That will fix the issue with the Caith skin but any texture that defines a Border color (or even if the user plays with the border color setting of BF) will break IA coloring again.
2) add my own texture, that will not be skinned. This will work with or without LBF but may look ugly depending on the LBF skin. (And I could add an option to have a "plain" highlight.)
3) add my own texture, that tries to use the same texture than the Border. Maybe tricky to set up but would fix the ugliness factor of point 2).
4) not care.
-
View User Profile
-
View Posts
-
Send Message
Curse PremiumAs I said, I know of no other solution outside of the mod first detecting LBF and using its built-in functions to apply the color if it (LBF) exists. If someone can come up with a viable solution, I'd love to hear it.