SmartRes2 Official Forum

#121 Jun 2, 2010
Myrroddin
Myrroddin

View User Profile

View Posts

Send Message
Forum Moderator
Forum Moderator
- Location: Edmonton
- Join Date: 5/8/2006
- Posts: 1,400
- Member Details
Zidomo, yes, I know r121 spits out that error... again. *sigh* ... Of course, the svn version has no error, but it is replicated with a direct install. It is weird, because if you look at the translation, the phrase is there.

And yes, r117 works fine, because the code that uses that bugged translation isn't there.

Rollback Post to Revision RollBack
#122 Jun 2, 2010
Myrroddin
Myrroddin

View User Profile

View Posts

Send Message
Forum Moderator
Forum Moderator
- Location: Edmonton
- Join Date: 5/8/2006
- Posts: 1,400
- Member Details
All figured out, plus some other tweaks and improvements. Beta 2.0 is game tested, but not raid tested.

It is on Curse now, and I will put it on WowInterface later tonight after sleep and work.

Rollback Post to Revision RollBack

#123 Jun 9, 2010

StormFX

Curse Premium

Location: Over Yonder
Join Date: 2/10/2008
Posts: 1,465
Member Details

Getting the "Print" error. I know Ace3 is installed, so something must be killing it or something.

1x SmartRes2-Beta 2.0\SmartRes2.lua:810: attempt to call global 'Print' (a nil value)
CallbackHandler-1.0-5 (Ace3):147: in function <...Ons\Ace3\CallbackHandler-1.0\CallbackHandler-1.0.lua:147>
<string>:"safecall Dispatcher[4]":4: in function <[string "safecall Dispatcher[4]"]:4>
<in C code>: ?
<string>:"safecall Dispatcher[4]":13: in function `?'
CallbackHandler-1.0-5 (Ace3):92: in function `Fire'
LibResComm-1.0-90048:143: in function `?'
LibResComm-1.0-90048:48: in function <...ibs\LibResComm-1.0\LibResComm-1.0\LibResComm-1.0.lua:47>

Last edited by StormFX: Jun 9, 2010

#124 Jun 9, 2010
Rayvene
Rayvene

View User Profile

View Posts

Send Message
Curse Premium
- Location: Chicago
- Join Date: 6/24/2006
- Posts: 654
- Member Details
print probably exists, but Print does not. Likely just a capitalization error somewhere

Rollback Post to Revision RollBack
#125 Jun 9, 2010
StormFX
StormFX

View User Profile

View Posts

Send Message
Curse Premium
- Location: Over Yonder
- Join Date: 2/10/2008
- Posts: 1,465
- Member Details
Well, I think there's supposed to be a global "Print" function somewhere, but it's not showing up ><

Edit: Also, resetting the profile doesn't work. Actually, I think the :OnProfileChanged method is borked altogether. ><

Last edited by StormFX: Jun 9, 2010

Rollback Post to Revision RollBack
#126 Jun 9, 2010
Myrroddin
Myrroddin

View User Profile

View Posts

Send Message
Forum Moderator
Forum Moderator
- Location: Edmonton
- Join Date: 5/8/2006
- Posts: 1,400
- Member Details
I know what the issue is, but I can't get to fixing it for a couple of days due to work. Should be a quickie, and I hope to have Beta 2.01 up shortly.

And if OnProfileChanged() is borked, it hasn't affected me. The error you are seeing is unrelated to profile management. That said, anyone upgrading from Beta 1.x probably will need to reset their profile, and I have indicated as such both on the main addon page and the changelog.

Last edited by Myrroddin: Jun 9, 2010

Rollback Post to Revision RollBack
#127 Jun 9, 2010
Torhal
Torhal

View User Profile

View Posts

Send Message
Project Author
CurseForge
- Location: Meridianville
- Join Date: 2/13/2008
- Posts: 2,860
- Member Details
Quote from StormFX
Getting the "Print" error. I know Ace3 is installed, so something must be killing it or something.

1x SmartRes2-Beta 2.0\SmartRes2.lua:810: attempt to call global 'Print' (a nil value) <snip>

I've fixed this in the latest alpha - somehow, a call to SendChatMessage() was changed to a call to (the non-existent) Print() function.
Rollback Post to Revision RollBack
#128 Jun 9, 2010
StormFX
StormFX

View User Profile

View Posts

Send Message
Curse Premium
- Location: Over Yonder
- Join Date: 2/10/2008
- Posts: 1,465
- Member Details
There's another call to the non-existant "Print" function on line 1110 in the latest alpha (There were two calls in the beta).

The profile issue is that the OnProfileReset event calls the :OnProfileChanged method rather than the :OnNewProfile method. If you delete the random message table and try to reset the profile, the table's still empty. That event should be calling the :OnNewProfile method since just refreshing the profile doesn't actually reset any of the saved variables.

Last edited by StormFX: Jun 9, 2010

Rollback Post to Revision RollBack
#129 Jun 9, 2010
Torhal
Torhal

View User Profile

View Posts

Send Message
Project Author
CurseForge
- Location: Meridianville
- Join Date: 2/13/2008
- Posts: 2,860
- Member Details
Quote from StormFX
There's another call to the non-existant "Print" function on line 1110 in the latest alpha (There were two calls in the beta).
<snip>

Fixed - changed to self:Print()

Rollback Post to Revision RollBack
#130 Jun 10, 2010
StormFX
StormFX

View User Profile

View Posts

Send Message
Curse Premium
- Location: Over Yonder
- Join Date: 2/10/2008
- Posts: 1,465
- Member Details
Sweet, thanks! I manually changed the OnProfileChanged to OnNewProfile for the OnProfileReset event and fixes the other issue.

Rollback Post to Revision RollBack
#131 Jun 10, 2010
Myrroddin
Myrroddin

View User Profile

View Posts

Send Message
Forum Moderator
Forum Moderator
- Location: Edmonton
- Join Date: 5/8/2006
- Posts: 1,400
- Member Details
StormFX, good catch, and I missed it when I made Beta 2.01 .... Looks like Beta 2.02 coming up :-(

Rollback Post to Revision RollBack
#132 Jun 10, 2010
StormFX
StormFX

View User Profile

View Posts

Send Message
Curse Premium
- Location: Over Yonder
- Join Date: 2/10/2008
- Posts: 1,465
- Member Details
Some of LIKE seeing bold add-ons at the top of CC. :)

Rollback Post to Revision RollBack
#133 Jun 20, 2010
Sarbian
Sarbian

View User Profile

View Posts

Send Message
Curse Premium
- Location: Paris
- Join Date: 3/7/2005
- Posts: 51
- Member Details
I tried your addon a few times and I had the same problem each time : "Everybody is alive. Congratulations!" when half my group was dead.

This time I tried to fix it and found that the raidUpdated variable is not reset in a group, so the SortedResList table is empty in a 5 man group ( at last for mine ).

I regitered the PARTY_MEMBERS_CHANGED event and added the function to reset raidUpdated

function SmartRes2:PARTY_MEMBERS_CHANGED() raidUpdated = true end

Now it works for my 5 man groups.
Rollback Post to Revision RollBack
#134 Jun 21, 2010
Myrroddin
Myrroddin

View User Profile

View Posts

Send Message
Forum Moderator
Forum Moderator
- Location: Edmonton
- Join Date: 5/8/2006
- Posts: 1,400
- Member Details
Sarbian, I know in Beta 2.02, in fact going back to to the first versions, that cross realm players are not properly detected by the smart ressing feature, and you get the "Everybody is alive..." message. Does your suggestion fix that? Or is there some other bug your code fixes?

Rollback Post to Revision RollBack
#135 Jun 21, 2010
Sarbian
Sarbian

View User Profile

View Posts

Send Message
Curse Premium
- Location: Paris
- Join Date: 3/7/2005
- Posts: 51
- Member Details
I had the "Everybody is alive" with 5 characters from the same server ( I mutlibox 5 char ) . My patch fix it for me but I didn't test it with a cross realm group.

In SmartRes2:OnEnable() and SmartRes2:OnEnable() I added the line

self:RegisterEvent("PARTY_MEMBERS_CHANGED")

And I added the function from my previous post.
Rollback Post to Revision RollBack
#136 Jun 26, 2010
Myrroddin
Myrroddin

View User Profile

View Posts

Send Message
Forum Moderator
Forum Moderator
- Location: Edmonton
- Join Date: 5/8/2006
- Posts: 1,400
- Member Details
I'm about to commit your adjustment, Sarbian.

I got told that /sr cast and /smartres cast did not res people, even when they were dead. This was in a raid, so it isn't the cross-realm player issue. Could someone verify this, please?

Rollback Post to Revision RollBack
#137 Jun 28, 2010
Myrroddin
Myrroddin

View User Profile

View Posts

Send Message
Forum Moderator
Forum Moderator
- Location: Edmonton
- Join Date: 5/8/2006
- Posts: 1,400
- Member Details
Added some code (dry coded) that hopefully will allow the auto res key and /sr cast command to work on cross-realm players. Could not previously find them because of

pName - pRealm

Was not returning properly. I don't currently have an active subscription, so looking for alpha testers. Of course, this only works in 5 person instances because you cannot have cross realm players in raids. If you get errors, please post them to the tracker as usual.

Also, I added a check for players being AFK. It will now skip those players, hopefully until they are the only players left.

Rollback Post to Revision RollBack

#138 Jun 28, 2010

morgalm

Curse Premium

Location: Campbell River
Join Date: 9/19/2005
Posts: 802
Member Details

Why in the world are you duplicating the same code twice?

function SmartRes2:OnEnable()
    -- called when SmartRes2 is enabled
    self:RegisterEvent("PLAYER_REGEN_DISABLED")
    self:RegisterEvent("PLAYER_REGEN_ENABLED")
    self:RegisterEvent("RAID_ROSTER_UPDATE")
    self:RegisterEvent("PARTY_MEMBERS_CHANGED")
    Media.RegisterCallback(self, "OnValueChanged", "UpdateMedia")
    ResComm.RegisterCallback(self, "ResComm_ResStart")
    ResComm.RegisterCallback(self, "ResComm_ResEnd")
    ResComm.RegisterCallback(self, "ResComm_Ressed")
    ResComm.RegisterCallback(self, "ResComm_ResExpired")
    self.res_bars.RegisterCallback(self, "FadeFinished")
    self.res_bars.RegisterCallback(self, "AnchorMoved", "ResAnchorMoved")
    self:BindKeys()
end

function SmartRes2:OnDisable()
    -- called when SmartRes2 is disabled    
end

-- enable SmartRes2 ----------------------------------------------------------
function SmartRes2:Enable()
    self:RegisterEvent("PLAYER_REGEN_DISABLED")
    self:RegisterEvent("PLAYER_REGEN_ENABLED")
    self:RegisterEvent("RAID_ROSTER_UPDATE")
    self:RegisterEvent("PARTY_MEMBERS_CHANGED")
    Media.RegisterCallback(self, "OnValueChanged", "UpdateMedia")
    ResComm.RegisterCallback(self, "ResComm_ResStart")
    ResComm.RegisterCallback(self, "ResComm_ResEnd")
    ResComm.RegisterCallback(self, "ResComm_Ressed")
    ResComm.RegisterCallback(self, "ResComm_ResExpired")
    self.res_bars.RegisterCallback(self, "FadeFinished")
    self.res_bars.RegisterCallback(self, "AnchorMoved", "ResAnchorMoved")
    self:BindKeys()
end

And it's broken atm won't even res anyone but havent investigated why yet.

#139 Jun 28, 2010
StormFX
StormFX

View User Profile

View Posts

Send Message
Curse Premium
- Location: Over Yonder
- Join Date: 2/10/2008
- Posts: 1,465
- Member Details
Technically, the code's only duplicated once. :P Duplicated twice would be three copies. :P

Rollback Post to Revision RollBack
#140 Jun 28, 2010
Myrroddin
Myrroddin

View User Profile

View Posts

Send Message
Forum Moderator
Forum Moderator
- Location: Edmonton
- Join Date: 5/8/2006
- Posts: 1,400
- Member Details
If it isn't working, it probably has to do with line 1000 and lines 1014-1023. I always wondered about that duplicate code. Where should I put what in the OnEnable() and Enable() functions? I was never clear about how to code that.

Rollback Post to Revision RollBack
To post a comment, please login or register a new account.

Previous Thread

Next Thread