Zidomo, yes, I know r121 spits out that error... again. *sigh* ... Of course, the svn version has no error, but it is replicated with a direct install. It is weird, because if you look at the translation, the phrase is there.
And yes, r117 works fine, because the code that uses that bugged translation isn't there.
Getting the "Print" error. I know Ace3 is installed, so something must be killing it or something.
1x SmartRes2-Beta 2.0\SmartRes2.lua:810: attempt to call global 'Print' (a nil value)
CallbackHandler-1.0-5 (Ace3):147: in function <...Ons\Ace3\CallbackHandler-1.0\CallbackHandler-1.0.lua:147>
<string>:"safecall Dispatcher[4]":4: in function <[string "safecall Dispatcher[4]"]:4>
<in C code>: ?
<string>:"safecall Dispatcher[4]":13: in function `?'
CallbackHandler-1.0-5 (Ace3):92: in function `Fire'
LibResComm-1.0-90048:143: in function `?'
LibResComm-1.0-90048:48: in function <...ibs\LibResComm-1.0\LibResComm-1.0\LibResComm-1.0.lua:47>
I know what the issue is, but I can't get to fixing it for a couple of days due to work. Should be a quickie, and I hope to have Beta 2.01 up shortly.
And if OnProfileChanged() is borked, it hasn't affected me. The error you are seeing is unrelated to profile management. That said, anyone upgrading from Beta 1.x probably will need to reset their profile, and I have indicated as such both on the main addon page and the changelog.
There's another call to the non-existant "Print" function on line 1110 in the latest alpha (There were two calls in the beta).
The profile issue is that the OnProfileReset event calls the :OnProfileChanged method rather than the :OnNewProfile method. If you delete the random message table and try to reset the profile, the table's still empty. That event should be calling the :OnNewProfile method since just refreshing the profile doesn't actually reset any of the saved variables.
I tried your addon a few times and I had the same problem each time : "Everybody is alive. Congratulations!" when half my group was dead.
This time I tried to fix it and found that the raidUpdated variable is not reset in a group, so the SortedResList table is empty in a 5 man group ( at last for mine ).
I regitered the PARTY_MEMBERS_CHANGED event and added the function to reset raidUpdated
function SmartRes2:PARTY_MEMBERS_CHANGED()
raidUpdated = true
end
Sarbian, I know in Beta 2.02, in fact going back to to the first versions, that cross realm players are not properly detected by the smart ressing feature, and you get the "Everybody is alive..." message. Does your suggestion fix that? Or is there some other bug your code fixes?
I had the "Everybody is alive" with 5 characters from the same server ( I mutlibox 5 char ) . My patch fix it for me but I didn't test it with a cross realm group.
In SmartRes2:OnEnable() and SmartRes2:OnEnable() I added the line
I got told that /sr cast and /smartres cast did not res people, even when they were dead. This was in a raid, so it isn't the cross-realm player issue. Could someone verify this, please?
Added some code (dry coded) that hopefully will allow the auto res key and /sr cast command to work on cross-realm players. Could not previously find them because of
pName - pRealm
Was not returning properly. I don't currently have an active subscription, so looking for alpha testers. Of course, this only works in 5 person instances because you cannot have cross realm players in raids. If you get errors, please post them to the tracker as usual.
Also, I added a check for players being AFK. It will now skip those players, hopefully until they are the only players left.
If it isn't working, it probably has to do with line 1000 and lines 1014-1023. I always wondered about that duplicate code. Where should I put what in the OnEnable() and Enable() functions? I was never clear about how to code that.
Rollback Post to RevisionRollBack
To post a comment, please login or register a new account.
And yes, r117 works fine, because the code that uses that bugged translation isn't there.
It is on Curse now, and I will put it on WowInterface later tonight after sleep and work.
Edit: Also, resetting the profile doesn't work. Actually, I think the :OnProfileChanged method is borked altogether. ><
And if OnProfileChanged() is borked, it hasn't affected me. The error you are seeing is unrelated to profile management. That said, anyone upgrading from Beta 1.x probably will need to reset their profile, and I have indicated as such both on the main addon page and the changelog.
I've fixed this in the latest alpha - somehow, a call to SendChatMessage() was changed to a call to (the non-existent) Print() function.
The profile issue is that the OnProfileReset event calls the :OnProfileChanged method rather than the :OnNewProfile method. If you delete the random message table and try to reset the profile, the table's still empty. That event should be calling the :OnNewProfile method since just refreshing the profile doesn't actually reset any of the saved variables.
Fixed - changed to self:Print()
This time I tried to fix it and found that the raidUpdated variable is not reset in a group, so the SortedResList table is empty in a 5 man group ( at last for mine ).
I regitered the PARTY_MEMBERS_CHANGED event and added the function to reset raidUpdated
Now it works for my 5 man groups.
In SmartRes2:OnEnable() and SmartRes2:OnEnable() I added the line
And I added the function from my previous post.
I got told that /sr cast and /smartres cast did not res people, even when they were dead. This was in a raid, so it isn't the cross-realm player issue. Could someone verify this, please?
pName - pRealm
Was not returning properly. I don't currently have an active subscription, so looking for alpha testers. Of course, this only works in 5 person instances because you cannot have cross realm players in raids. If you get errors, please post them to the tracker as usual.
Also, I added a check for players being AFK. It will now skip those players, hopefully until they are the only players left.
And it's broken atm won't even res anyone but havent investigated why yet.